rtc: snvs: Use __maybe_unused instead of #if CONFIG_PM_SLEEP
PATCH v2 1/1 rtc: snvs: Use __maybe_unused instead of #if CONFIG_PM_SLEEP
Use __maybe_unused for power management related functions instead of #if CONFIG_PM_SLEEP to simply the code.
Signed-off-by Anson Huang <[email protected]>
Reviewed-by Dong Aisheng <[email protected]>
---
Changes since V1:
- use SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() to make sure snvs_rtc_pm_ops is empty when PM is off.
--- drivers/rtc/rtc-snvs.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-)
drivers/rtc/rtc-snvs.c +4 -15
@@ -360,9 +360,7 @@ static int snvs_rtc_probe(struct platform_device *pdev)return ret; } -#ifdef CONFIG_PM_SLEEP - -static int snvs_rtc_suspend_noirq (struct device *dev) +static int __maybe_unused snvs_rtc_suspend_noirq (struct device *dev) {struct snvs_rtc_data *data =dev_get_drvdata (dev);
@@ -372,7 +370,7 @@ static int snvs_rtc_suspend_noirq(struct device *dev)return 0 ; } -static int snvs_rtc_resume_noirq (struct device *dev) +static int __maybe_unused snvs_rtc_resume_noirq (struct device *dev) {struct snvs_rtc_data *data =dev_get_drvdata (dev);
@@ -383,18 +381,9 @@ static int snvs_rtc_resume_noirq(struct device *dev) }static const struct dev_pm_ops snvs_rtc_pm_ops = { - .suspend_noirq = snvs_rtc_suspend_noirq, - .resume_noirq = snvs_rtc_resume_noirq, +SET_NOIRQ_SYSTEM_SLEEP_PM_OPS (snvs_rtc_suspend_noirq, snvs_rtc_resume_noirq) }; -#define SNVS_RTC_PM_OPS (&snvs_rtc_pm_ops) - -#else - -#define SNVS_RTC_PM_OPS NULL - -#endif -static const struct of_device_id snvs_dt_ids[] = { { .compatible ="fsl,sec-v4.0-mon-rtc-lp" , }, {/* sentinel */ }
@@ -404,7 +393,7 @@ MODULE_DEVICE_TABLE(of, snvs_dt_ids);static struct platform_driver snvs_rtc_driver = { .driver = { .name ="snvs_rtc" , - .pm =SNVS_RTC_PM_OPS , + .pm = &snvs_rtc_pm_ops, .of_match_table = snvs_dt_ids, }, .probe = snvs_rtc_probe,
Signature · 1 line
2.7.4
Quoted 12 lines · Anson Huang
Use
__maybe_unusedfor power management related functions instead of #ifCONFIG_PM_SLEEPto simply the code.Signed-off-by Anson Huang <[email protected]>Reviewed-by Dong Aisheng <[email protected]>---
Changes since V1:
- useSET_NOIRQ_SYSTEM_SLEEP_PM_OPS()to make suresnvs_rtc_pm_opsis empty when PM is off.--- drivers/rtc/rtc-snvs.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-)
Applied, thanks.
Signature · 3 lines
Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com