clk: imx: pllv3: Fix fall through build warning
Subsystems (3)
PATCH 1/1 clk: imx: pllv3: Fix fall through build warning
Fix below fall through build warning:
drivers/clk/imx/clk-pllv3.c:453:21: warning:
this statement may fall through [-Wimplicit-fallthrough=]
pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
^drivers/clk/imx/clk-pllv3.c:454:2: note: here
case IMX_PLLV3_AV:
^~~~
--- drivers/clk/imx/clk-pllv3.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/imx/clk-pllv3.c +1 -0
@@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name,case IMX_PLLV3_AV_IMX7 : pll->num_offset =PLL_IMX7_NUM_OFFSET ; pll->denom_offset =PLL_IMX7_DENOM_OFFSET ; +/* fall through */ case IMX_PLLV3_AV : ops = &clk_pllv3_av_ops;break ;
Signature · 6 lines
2.7.4 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 9 lines
From: Anson Huang
Sent: Tuesday, April 30, 2019 9:55 AM
Subject: [PATCH] clk: imx: pllv3: Fix fall through build warningFix below fall through build warning:
drivers/clk/imx/clk-pllv3.c:453:21: warning:
this statement may fall through [-Wimplicit-fallthrough=]
Quoted 7 lines
pll->denom_offset = PLL_IMX7_DENOM_OFFSET; ^
drivers/clk/imx/clk-pllv3.c:454:2: note: here
caseIMX_PLLV3_AV:
^~~~Signed-off-by Anson Huang <[email protected]>
Regards
Dong Aisheng
Stephen Boyd
maintainerQuoting Anson Huang (2019-04-29 18:55:18)
Quoted 5 lines
Fix below fall through build warning:
drivers/clk/imx/clk-pllv3.c:453:21: warning:
this statement may fall through [-Wimplicit-fallthrough=]
Quoted 8 lines
pll->denom_offset = PLL_IMX7_DENOM_OFFSET; ^
drivers/clk/imx/clk-pllv3.c:454:2: note: here
caseIMX_PLLV3_AV:
^~~~Signed-off-by Anson Huang <[email protected]>---
Gustavo says there are two warnings. Please compile test with the right options, add Reported-by tags when you get bug reports from someone, and add a Fixes tag and then resend.
Quoted 15 lines
drivers/clk/imx/clk-pllv3.c | 1 + 1 file changed, 1 insertion(+)drivers/clk/imx/clk-pllv3.c +1
-0@@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name,case IMX_PLLV3_AV_IMX7 : pll->num_offset =PLL_IMX7_NUM_OFFSET ; pll->denom_offset =PLL_IMX7_DENOM_OFFSET ; +/* fall through */ case IMX_PLLV3_AV : ops = &clk_pllv3_av_ops;break ;
Hi, Stephen
I saw Gustavo already sent out a patch to fix these two warnings, so I will NOT sent the patch again, thanks.
Quoted 46 lines
-----Original Message-----
From: Stephen Boyd [mailto:[email protected]]
Sent: Wednesday, May 1, 2019 2:17 AM
To: [email protected]; [email protected]; linux-arm- [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]; Anson Huang <[email protected]>; Gustavo A. R. Silva <[email protected]>
Cc: dl-linux-imx <[email protected]>
Subject: Re: [PATCH] clk: imx: pllv3: Fix fall through build warningQuoting Anson Huang (2019-04-29 18:55:18)
Quoted 5 lines
Fix below fall through build warning:
drivers/clk/imx/clk-pllv3.c:453:21: warning:
this statement may fall through [-Wimplicit-fallthrough=]Quoted 8 lines
pll->denom_offset = PLL_IMX7_DENOM_OFFSET; ^
drivers/clk/imx/clk-pllv3.c:454:2: note: here
caseIMX_PLLV3_AV:
^~~~Signed-off-by Anson Huang <[email protected]>---
Gustavo says there are two warnings. Please compile test with the right options, add Reported-by tags when you get bug reports from someone, and add a Fixes tag and then resend.
drivers/clk/imx/clk-pllv3.c struct clk *imx_clk_pllv3(enum imx_pllv3_type type,
Quoted 8 lines
drivers/clk/imx/clk-pllv3.c | 1 + 1 file changed, 1 insertion(+)drivers/clk/imx/clk-pllv3.c +0
-0@@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type,const char *name,
Quoted 7 lines
drivers/clk/imx/clk-pllv3.c +1
-0case IMX_PLLV3_AV_IMX7 : pll->num_offset =PLL_IMX7_NUM_OFFSET ; pll->denom_offset =PLL_IMX7_DENOM_OFFSET ; +/* fall through */ case IMX_PLLV3_AV : ops = &clk_pllv3_av_ops;break ;
Stephen Boyd
maintainerQuoting Anson Huang (2019-05-01 02:33:46)
Quoted 2 lines
Hi, Stephen
I saw Gustavo already sent out a patch to fix these two warnings, so I will NOT sent the patch again, thanks.
So I will apply that patch instead? Can you send your reviewed-by tag then?