ARM: dts: aspeed: Add s7106 BMC Machine
Subsystems (3)
PATCH v2 1/1 ARM: dts: aspeed: Add s7106 BMC Machine
s7106 is a Tyan platform family with an ASPEED AST2500 BMC.
--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts | 175 ++++++++++++++++++++++++++++ 2 files changed, 177 insertions(+), 1 deletion(-) create mode 100755 arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
arch/arm/boot/dts/Makefile +2 -1
@@ -1247,4 +1247,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-opp-witherspoon.dtb \ aspeed-bmc-opp-zaius.dtb \ aspeed-bmc-portwell-neptune.dtb \ - aspeed-bmc-quanta-q71l.dtb + aspeed-bmc-quanta-q71l.dtb \ + aspeed-bmc-tyan-s7106.dtb
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +175 -0
175 lines not on this page · raw message
Signature · 1 line
2.7.4
Hi Ray,
Thanks for the patch, it would be good to send this upstream!
However, some comments below:
Quoted 82 lines · Ray Lue
s7106 is a Tyan platform family with an ASPEED AST2500 BMC.
Signed-off-by Ray Lue <[email protected]>--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts | 175 ++++++++++++++++++++++++++++ 2 files changed, 177 insertions(+), 1 deletion(-) create mode 100755 arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtsarch/arm/boot/dts/Makefile +2
-1@@ -1247,4 +1247,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-opp-witherspoon.dtb \ aspeed-bmc-opp-zaius.dtb \ aspeed-bmc-portwell-neptune.dtb \ - aspeed-bmc-quanta-q71l.dtb + aspeed-bmc-quanta-q71l.dtb \ + aspeed-bmc-tyan-s7106.dtbarch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +54
-0@@ -0,0 +1,175 @@ +// SPDX-License-Identifier: GPL-2.0 +/dts-v1/; + +#include "aspeed-g5.dtsi" + +/ { + model = "Tyan S7106 BMC"; + compatible = "tyan,s7106-bmc", "aspeed,ast2500"; + + chosen { + stdout-path = &uart5; + bootargs = "console=ttyS4,115200 earlyprintk"; + }; + + memory { + reg = <0x80000000 0x20000000>; + }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + vga_memory: framebuffer@98000000 { + no-map; + reg = <0x98000000 0x00800000>; /* 8MB */ + }; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, + <&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>, + <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>, + <&adc 12>, <&adc 13>, <&adc 14>; + }; + + iio-hwmon-battery { + compatible = "iio-hwmon"; + io-channels = <&adc 15>; + }; +}; + +&fmc { + status = "okay"; + flash@0 { + label = "bmc"; + status = "okay"; + m25p,fast-read; +#include "openbmc-flash-layout.dtsi" + }; +}; + +// UART1 is used only by the host. While the BMC does not need toaccess it,
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 57
Quoted 3 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +3
-0+// enable it here to make sure the UART's clock gets enabled. +&uart1 { + status = "okay";
Needs a pinctrl node as well to ensure the UART IO is routed out of the BMC.
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 61
Quoted 4 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +4
-0+}; + +&uart3 { + status = "okay";
As above.
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 65
Quoted 4 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +4
-0+}; + +&uart5 { + status = "okay";
Note that pinctrl isn't necessary here, uart5 functionality isn't behind a mux.
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 69
Quoted 4 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +4
-0+}; + +&lpc_ctrl { + status = "okay";
Have you run into issues with not assigning reserved memory? As far as I'm aware we still need Vijay's patch to be applied.
Are you setting it to "okay" this just to enable the LPC clock?
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 78
Quoted 9 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +9
-0+}; + +&lpc_snoop { + status = "okay"; + snoop-ports = <0x80>; +}; + +&adc { + status = "okay";
Should have explicit pinctrl property here requesting the necessary ADC lines. Looks like all the other platform DTS files need this fixed too.
Quoted 33 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +33
-0+}; + +&pwm_tacho { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm3_default &pinctrl_pwm4_default>; + + fan@0 { + reg = <0x03>; + aspeed,fan-tach-ch = /bits/ 8 <0x02>; + }; + + fan@1 { + reg = <0x04>; + aspeed,fan-tach-ch = /bits/ 8 <0x03>; + }; + + fan@2 { + reg = <0x03>; + aspeed,fan-tach-ch = /bits/ 8 <0x04>; + }; + + fan@3 { + reg = <0x04>; + aspeed,fan-tach-ch = /bits/ 8 <0x05>; + }; + + fan@4 { + reg = <0x03>; + aspeed,fan-tach-ch = /bits/ 8 <0x06>; + }; + + fan@5 {
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 121
Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +10
-0+ reg = <0x04>; + aspeed,fan-tach-ch = /bits/ 8 <0x07>; + }; +}; + +&i2c0 { + status = "okay"; + + nct7802@28 { + compatible = "nuvoton,nct7802";
This compatible isn't documented anywhere. Do you have out-of-tree bindings? A driver?
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 134
Quoted 13 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +13
-0+ reg = <0x28>; + }; +}; + +&i2c1 { + status = "okay"; +}; + +&i2c2 { + status = "okay"; + + eeprom@50 { + compatible = "at,24c256";
Compatible also isn't documented anywhere. Same queries as above.
Quoted 45 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +41
-0+ reg = <0x50>; + }; +}; + +&i2c3 { + status = "okay"; +}; + +&i2c4 { + status = "okay"; +}; + +&i2c5 { + status = "okay"; +}; + +&i2c6 { + status = "okay"; +}; + +&i2c7 { + status = "okay"; +}; + +&i2c8 { + status = "okay"; +}; + +&mac0 { + status = "okay"; + + use-ncsi; + no-hw-checksum; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii1_default>; +}; + +&ibt { + status = "okay"; +};Signature · 1 line
2.7.4
Cheers,
Andrew
Hi Andrew,
Thanks for your review, I will update the patch accordingly. Detailed response below.
Quoted 96 lines
-----Original Message-----
From: Andrew Jeffery [mailto:[email protected]]
Sent: Wednesday, May 1, 2019 1:43 PM
To: Ray Lue <[email protected]>; [email protected]; Joel Stanley <[email protected]>; Vijay Khemka <[email protected]>
Cc: ray.lue (呂郁銳 - MCT) <[email protected]>
Subject: Re: [PATCH linux dev-5.0 v2 1/1] ARM: dts: aspeed: Add s7106 BMC MachineHi Ray,
Thanks for the patch, it would be good to send this upstream!
However, some comments below:
Quoted 80 lines · Ray Lue
s7106 is a Tyan platform family with an ASPEED AST2500 BMC.
Signed-off-by Ray Lue <[email protected]>--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts | 175 ++++++++++++++++++++++++++++ 2 files changed, 177 insertions(+), 1 deletion(-) create mode 100755
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtsarch/arm/boot/dts/Makefile +2
-1@@ -1247,4 +1247,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-opp-witherspoon.dtb \ aspeed-bmc-opp-zaius.dtb \ aspeed-bmc-portwell-neptune.dtb \ - aspeed-bmc-quanta-q71l.dtb + aspeed-bmc-quanta-q71l.dtb \ + aspeed-bmc-tyan-s7106.dtbarch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +52
-0@@ -0,0 +1,175 @@ +// SPDX-License-Identifier: GPL-2.0 +/dts-v1/; + +#include "aspeed-g5.dtsi" + +/ { + model = "Tyan S7106 BMC"; + compatible = "tyan,s7106-bmc", "aspeed,ast2500"; + + chosen { + stdout-path = &uart5; + bootargs = "console=ttyS4,115200 earlyprintk"; + }; + + memory { + reg = <0x80000000 0x20000000>; + }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + vga_memory: framebuffer@98000000 { + no-map; + reg = <0x98000000 0x00800000>; /* 8MB */ + }; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, + <&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>, + <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>, + <&adc 12>, <&adc 13>, <&adc 14>; + }; + + iio-hwmon-battery { + compatible = "iio-hwmon"; + io-channels = <&adc 15>; + }; +}; + +&fmc { + status = "okay"; + flash@0 { + label = "bmc"; + status = "okay"; + m25p,fast-read; +#include "openbmc-flash-layout.dtsi" + }; +};
Quoted 8 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 57
Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +2
-0+ +// UART1 is used only by the host. While the BMC does not need toaccess it,
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +3
-0+// enable it here to make sure the UART's clock gets enabled. +&uart1 { + status = "okay";Needs a pinctrl node as well to ensure the UART IO is routed out of the BMC.
Will add in V3 patch
Quoted 7 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 61
Quoted 5 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +4
-0+}; + +&uart3 { + status = "okay";As above.
Will add in V3 patch
Quoted 8 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 65
Quoted 5 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +4
-0+}; + +&uart5 { + status = "okay";Note that pinctrl isn't necessary here, uart5 functionality isn't behind a mux.
Quoted 7 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 69
Quoted 4 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +4
-0+}; + +&lpc_ctrl { + status = "okay";Have you run into issues with not assigning reserved memory? As far as I'm aware we still need Vijay's patch to be applied.
Yes, I need to add below description or the LCLK will be disabled.
memory-region = <&flash_memory>; flash = <&spi1>;
We can't relate this description to LCLK, so we think it's a bug and created an another patch to add these two lines to update s7016 device tree. Sorry for the confusion made, I will add this into V3 patch directly.
Quoted 16 lines
Are you setting it to "okay" this just to enable the LPC clock?
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 78
Quoted 9 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +9
-0+}; + +&lpc_snoop { + status = "okay"; + snoop-ports = <0x80>; +}; + +&adc { + status = "okay";Should have explicit pinctrl property here requesting the necessary ADC lines. Looks like all the other platform DTS files need this fixed too.
Got it, will update the device pinctrl for all ADC lines.
Quoted 38 lines
Quoted 38 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +38
-0+}; + +&pwm_tacho { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm3_default &pinctrl_pwm4_default>; + + fan@0 { + reg = <0x03>; + aspeed,fan-tach-ch = /bits/ 8 <0x02>; + }; + + fan@1 { + reg = <0x04>; + aspeed,fan-tach-ch = /bits/ 8 <0x03>; + }; + + fan@2 { + reg = <0x03>; + aspeed,fan-tach-ch = /bits/ 8 <0x04>; + }; + + fan@3 { + reg = <0x04>; + aspeed,fan-tach-ch = /bits/ 8 <0x05>; + }; + + fan@4 { + reg = <0x03>; + aspeed,fan-tach-ch = /bits/ 8 <0x06>; + }; + + fan@5 { + reg = <0x04>; + aspeed,fan-tach-ch = /bits/ 8 <0x07>; + }; +}; +
Quoted 9 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 121
Quoted 5 lines
+&i2c0 {
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +4
-0+ status = "okay"; + + nct7802@28 { + compatible = "nuvoton,nct7802";This compatible isn't documented anywhere. Do you have out-of-tree bindings? A driver?
The driver is in /drivers/hwmon/nct7802.c, I don't know why it's not documented in /devicetree/bindings/hwmon.
Quoted 7 lines
Quoted 7 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +7
-0+ reg = <0x28>; + }; +}; + +&i2c1 { + status = "okay"; +};
Quoted 9 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts line 134
Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +6
-0+ +&i2c2 { + status = "okay"; + + eeprom@50 { + compatible = "at,24c256";Compatible also isn't documented anywhere. Same queries as above.
Sorry for using the deprecated term, will update to "atmel".
Quoted 48 lines
Quoted 41 lines
arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts new file +40
-1+ reg = <0x50>; + }; +}; + +&i2c3 { + status = "okay"; +}; + +&i2c4 { + status = "okay"; +}; + +&i2c5 { + status = "okay"; +}; + +&i2c6 { + status = "okay"; +}; + +&i2c7 { + status = "okay"; +}; + +&i2c8 { + status = "okay"; +}; + +&mac0 { + status = "okay"; + + use-ncsi; + no-hw-checksum; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii1_default>; }; + +&ibt { + status = "okay"; +}; --Quoted 3 lines
2.7.4
Cheers,
Andrew