ath10k: Check tx_stats before use it
PATCH 1/1 ath10k: Check tx_stats before use it
tx_stats will be freed and set to NULL before debugfs_sta node is removed in station disconnetion process. So if read the debugfs_sta node there may be NULL pointer error. Add check for tx_stats before use it to resove this issue.
--- drivers/net/wireless/ath/ath10k/debugfs_sta.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/net/wireless/ath/ath10k/debugfs_sta.c +7 -0
@@ -674,6 +674,13 @@ static ssize_t ath10k_dbg_sta_dump_tx_stats(struct file *file,mutex_lock (&ar->conf_mutex); +if (!arsta->tx_stats) { +ath10k_warn (ar,"failed to get tx stats" ); +mutex_unlock (&ar->conf_mutex); +kfree (buf); +return 0 ; + } +spin_lock_bh (&ar->data_lock);for (k =0 ; k <ATH10K_STATS_TYPE_MAX ; k++) {for (j =0 ; j <ATH10K_COUNTER_TYPE_MAX ; j++) {
Signature · 7 lines
1.9.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 7 lines · Yingying Tang
tx_statswill be freed and set to NULL beforedebugfs_stanode is removed in station disconnetion process. So if read thedebugfs_stanode there may be NULL pointer error. Add check fortx_statsbefore use it to resove this issue.Signed-off-by Yingying Tang <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
9e7251fa3897 ath10k: Check tx_stats before use it
Signature · 3 lines
https://patchwork.kernel.org/patch/10926861/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 7 lines · Yingying Tang
tx_statswill be freed and set to NULL beforedebugfs_stanode is removed in station disconnetion process. So if read thedebugfs_stanode there may be NULL pointer error. Add check fortx_statsbefore use it to resove this issue.Signed-off-by Yingying Tang <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
9e7251fa3897 ath10k: Check tx_stats before use it
Signature · 9 lines
https://patchwork.kernel.org/patch/10926861/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k