Skip to contentSkip to conversation

gpu/drm: Remove duplicate headers

PATCH In review [email protected] 3 participants 4 messages May 3, 2019 – May 7, 2019

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu/drm: Remove duplicate headers

From: Jagadeesh Pagadala <[email protected]>

Remove duplicate headers which are included twice.

---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c             | 1 -
 drivers/gpu/drm/nouveau/nvkm/subdev/bus/nv04.c        | 2 --
 drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 -
 3 files changed, 4 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c +0 -1
index 018df2c..45a5bc6 100644
@@ -15,7 +15,6 @@
 #include "dpu_hwio.h"
 #include "dpu_hw_lm.h"
 #include "dpu_hw_mdss.h"
-#include "dpu_kms.h"
 
 #define LM_OP_MODE                        0x00
 #define LM_OUT_SIZE                       0x04
drivers/gpu/drm/nouveau/nvkm/subdev/bus/nv04.c +0 -2
index c80b967..2b44ba5 100644
@@ -26,8 +26,6 @@
 
 #include <subdev/gpio.h>
 
-#include <subdev/gpio.h>
-
 static void
 nv04_bus_intr(struct nvkm_bus *bus)
 {
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c +0 -1
index 2c9c972..cacf2e0 100644
@@ -53,7 +53,6 @@
 #include <linux/of_graph.h>
 #include <linux/pm.h>
 
-#include <drm/drm_panel.h>
 #include <drm/drmP.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_mipi_dsi.h>
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 5 lines · On Fri, May 03, 2019 at 11:28:13PM +0530, [email protected] wrote:

From: Jagadeesh Pagadala <[email protected]>

Remove duplicate headers which are included twice.

I collected some acks for the msm and nouveau parts and pushed this. For next time around would be great if you split these up along driver/module boundaries, so that each maintainer can pick this up directly.

Thanks for your patch.
-Daniel

Quoted 46 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c             | 1 -
 drivers/gpu/drm/nouveau/nvkm/subdev/bus/nv04.c        | 2 --
 drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 -
 3 files changed, 4 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c +0 -1
index 018df2c..45a5bc6 100644
@@ -15,7 +15,6 @@
 #include "dpu_hwio.h"
 #include "dpu_hw_lm.h"
 #include "dpu_hw_mdss.h"
-#include "dpu_kms.h"
 
 #define LM_OP_MODE                        0x00
 #define LM_OUT_SIZE                       0x04
drivers/gpu/drm/nouveau/nvkm/subdev/bus/nv04.c +0 -2
index c80b967..2b44ba5 100644
@@ -26,8 +26,6 @@
 
 #include <subdev/gpio.h>
 
-#include <subdev/gpio.h>
-
 static void
 nv04_bus_intr(struct nvkm_bus *bus)
 {
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c +0 -1
index 2c9c972..cacf2e0 100644
@@ -53,7 +53,6 @@
 #include <linux/of_graph.h>
 #include <linux/pm.h>
 
-#include <drm/drm_panel.h>
 #include <drm/drmP.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_mipi_dsi.h>
Signature · 1 line
1.8.3.1
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
#2 lore raw
Quoted 5 lines · Daniel Vetter
Quoted 4 lines · On Fri, May 03, 2019 at 11:28:13PM +0530, [email protected] wrote:

From: Jagadeesh Pagadala <[email protected]>

Remove duplicate headers which are included twice.

Quoted 13 lines
Quoted 1 line

I collected some acks for the msm and nouveau parts and pushed this. For next time around would be great if you split these up along driver/module boundaries, so that each maintainer can pick this up directly.

Thanks for your patch.
-Daniel

Quoted 4 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c             | 1 -
 drivers/gpu/drm/nouveau/nvkm/subdev/bus/nv04.c        | 2 --
 drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 -

Correction, this didn't compile, so I dropped the changes to panel-rpi. Another reason to split patches more for next time around. Also, needs more compile testing (you need cross compilers for at least arm to test this stuff).
-Daniel

Quoted 47 lines
Quoted 42 lines
 3 files changed, 4 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c +0 -1
index 018df2c..45a5bc6 100644
@@ -15,7 +15,6 @@
 #include "dpu_hwio.h"
 #include "dpu_hw_lm.h"
 #include "dpu_hw_mdss.h"
-#include "dpu_kms.h"
 
 #define LM_OP_MODE                        0x00
 #define LM_OUT_SIZE                       0x04
drivers/gpu/drm/nouveau/nvkm/subdev/bus/nv04.c +0 -2
index c80b967..2b44ba5 100644
@@ -26,8 +26,6 @@
 
 #include <subdev/gpio.h>
 
-#include <subdev/gpio.h>
-
 static void
 nv04_bus_intr(struct nvkm_bus *bus)
 {
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c +0 -1
index 2c9c972..cacf2e0 100644
@@ -53,7 +53,6 @@
 #include <linux/of_graph.h>
 #include <linux/pm.h>
 
-#include <drm/drm_panel.h>
 #include <drm/drmP.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_mipi_dsi.h>
Signature · 1 line
1.8.3.1
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
#3 lore raw
Quoted 20 lines · Daniel Vetter
Quoted 5 lines · Daniel Vetter
Quoted 4 lines · On Fri, May 03, 2019 at 11:28:13PM +0530, [email protected] wrote:

From: Jagadeesh Pagadala <[email protected]>

Remove duplicate headers which are included twice.

Quoted 13 lines
Quoted 1 line

I collected some acks for the msm and nouveau parts and pushed this. For next time around would be great if you split these up along driver/module boundaries, so that each maintainer can pick this up directly.

Thanks for your patch.
-Daniel

Quoted 4 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c             | 1 -
 drivers/gpu/drm/nouveau/nvkm/subdev/bus/nv04.c        | 2 --
 drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 -
Quoted 4 lines

Correction, this didn't compile, so I dropped the changes to panel-rpi. Another reason to split patches more for next time around. Also, needs more compile testing (you need cross compilers for at least arm to test this stuff).

I will try to resurrect my patch series for drm/panel/ that addresses:
- removal of drmP.h
- removal of duplicated include files
- sort all include files

In other words - panel-raspberrypi-touchscreen.c will be dealt with. I expect to look at it in two weeks time (on vacation starting friday).

Sam
_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau