Skip to contentSkip to conversation

ath11k: fix target assert when unload driver

PATCH In review Venkateswara Naralasetty 2 participants 2 messages May 8, 2019 – May 13, 2019 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: fix target assert when unload driver

Currently ath11k_ahb_ext_irq_disable() called before ath11k_mac_unregister which will disable napi before mac_unregister and still we might receive packets on all active devices which results reo_dest_ring full.

Fix this issue by moving ath11k_ahb_ext_irq_disable() after ath11k_mac_unregister().

---
 drivers/net/wireless/ath/ath11k/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/core.c +1 -1
index dc56df5..e3e6b64 100644
@@ -486,6 +486,7 @@ static int ath11k_core_pdev_create(struct ath11k_base *sc)
 static void ath11k_core_pdev_destroy(struct ath11k_base *sc)
 {
 	ath11k_mac_unregister(sc);
+	ath11k_ahb_ext_irq_disable(sc);
 	ath11k_dp_pdev_free(sc);
 }
 
@@ -781,7 +782,6 @@ void ath11k_core_deinit(struct ath11k_base *sc)
 {
 	mutex_lock(&sc->core_lock);
 
-	ath11k_ahb_ext_irq_disable(sc);
 	ath11k_core_pdev_destroy(sc);
 	ath11k_core_stop(sc);
 
Signature · 7 lines
2.7.4


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 8 lines · Venkateswara Naralasetty

Currently ath11k_ahb_ext_irq_disable() called before ath11k_mac_unregister which will disable napi before mac_unregister and still we might receive packets on all active devices which results reo_dest_ring full.

Fix this issue by moving ath11k_ahb_ext_irq_disable() after ath11k_mac_unregister().

Patch applied to ath.git, thanks.

25c08e7a8442 ath11k: fix target assert when unload driver

Signature · 9 lines
https://patchwork.kernel.org/patch/10935837/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k