kdb: Fix bound check compiler warning
PATCH v2 1/1 kdb: Fix bound check compiler warning
The strncpy() function may leave the destination string buffer unterminated, better use strscpy() instead.
This fixes the following warning with gcc 8.2:
kernel/debug/kdb/kdb_io.c: In function 'kdb_getstr':kernel/debug/kdb/kdb_io.c:449:3: warning: 'strncpy' specified bound 256 equals destination size [-Wstringop-truncation]
strncpy(kdb_prompt_str, prompt, CMD_BUFLEN);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by Wenlin Kang <[email protected]>
--- kernel/debug/kdb/kdb_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/debug/kdb/kdb_io.c +1 -1
@@ -446,7 +446,7 @@ static char *kdb_read(char *buffer, size_t bufsize)char *kdb_getstr (char *buffer,size_t bufsize,const char *prompt) {if (prompt && kdb_prompt_str != prompt) -strncpy (kdb_prompt_str, prompt,CMD_BUFLEN ); +strscpy (kdb_prompt_str, prompt,CMD_BUFLEN );kdb_printf (kdb_prompt_str); kdb_nextline =1 ;/* Prompt and input resets line number */ return kdb_read (buffer, bufsize);
Signature · 1 line
1.9.1