Skip to contentSkip to conversation

ath11k: fix sparse symbol should be static warnings

PATCH In review Kalle Valo 1 participant 4 messages May 14, 2019 – May 20, 2019 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore

Kalle Valo

author
#0 lore raw

PATCH 1/3 ath11k: fix sparse symbol should be static warnings

Fixes warnings like:

drivers/net/wireless/ath/ath11k/wmi.c:203:5: warning: symbol 'ath11k_wmi_cmd_send_nowait' was not declared. Should it be static?

Also ath11k_dp_htt_rx_filter_setup() was declared in the wrong header file, fix that as well.

---
 drivers/net/wireless/ath/ath11k/debug.c |   2 +-
 drivers/net/wireless/ath/ath11k/dp_rx.c |  31 +++---
 drivers/net/wireless/ath/ath11k/dp_rx.h |   4 -
 drivers/net/wireless/ath/ath11k/dp_tx.h |   6 ++
 drivers/net/wireless/ath/ath11k/wmi.c   | 170 ++++++++++++++++----------------
 5 files changed, 107 insertions(+), 106 deletions(-)
drivers/net/wireless/ath/ath11k/debug.c +1 -1
index b6e18938ba5e..441229ddd358 100644
@@ -8,7 +8,7 @@
 #include "debug.h"
 #include "wmi.h"
 #include "hal_rx.h"
-#include "dp_rx.h"
+#include "dp_tx.h"
 
 void ath11k_info(struct ath11k_base *sc, const char *fmt, ...)
 {
drivers/net/wireless/ath/ath11k/dp_rx.c +15 -16
index c7582ce08899..f67b52bd40a7 100644
@@ -2150,10 +2150,9 @@ static void ath11k_dp_rx_update_peer_stats(struct ath11k_sta *arsta,
 	rx_stats->num_mpdu_fcs_err += ppdu_info->num_mpdu_fcs_err;
 }
 
-struct sk_buff *
-ath11k_dp_rx_alloc_mon_status_buf(struct ath11k_base *ab,
-				  struct dp_rxdma_ring *rx_ring,
-				  int *buf_id, gfp_t gfp)
+static struct sk_buff *ath11k_dp_rx_alloc_mon_status_buf(struct ath11k_base *ab,
+							 struct dp_rxdma_ring *rx_ring,
+							 int *buf_id, gfp_t gfp)
 {
 	struct sk_buff *skb;
 	dma_addr_t paddr;
@@ -2261,8 +2260,8 @@ int ath11k_dp_rx_mon_status_bufs_replenish(struct ath11k_base *ab, int mac_id,
 	return req_entries - num_remain;
 }
 
-int ath11k_dp_rx_reap_mon_status_ring(struct ath11k_base *ab, int mac_id,
-				      int *budget, struct sk_buff_head *skb_list)
+static int ath11k_dp_rx_reap_mon_status_ring(struct ath11k_base *ab, int mac_id,
+					     int *budget, struct sk_buff_head *skb_list)
 {
 	struct ath11k *ar = ab->pdevs[mac_id].ar;
 	struct ath11k_pdev_dp *dp = &ar->dp;
@@ -3680,10 +3679,10 @@ ath11k_dp_rx_mon_merg_msdus(struct ath11k *ar,
 	return NULL;
 }
 
-int ath11k_dp_rx_mon_deliver(struct ath11k *ar, u32 mac_id,
-			     struct sk_buff *head_msdu,
-			     struct sk_buff *tail_msdu,
-			     struct napi_struct *napi)
+static int ath11k_dp_rx_mon_deliver(struct ath11k *ar, u32 mac_id,
+				    struct sk_buff *head_msdu,
+				    struct sk_buff *tail_msdu,
+				    struct napi_struct *napi)
 {
 	struct ath11k_pdev_dp *dp = &ar->dp;
 	struct sk_buff *mon_skb, *skb_next, *header;
@@ -3731,8 +3730,8 @@ int ath11k_dp_rx_mon_deliver(struct ath11k *ar, u32 mac_id,
 	return -EINVAL;
 }
 
-void ath11k_dp_rx_mon_dest_process(struct ath11k *ar, u32 quota,
-				   struct napi_struct *napi)
+static void ath11k_dp_rx_mon_dest_process(struct ath11k *ar, u32 quota,
+					  struct napi_struct *napi)
 {
 	struct ath11k_pdev_dp *dp = &ar->dp;
 	struct ath11k_mon_data *pmon = (struct ath11k_mon_data *)&dp->mon_data;
@@ -3837,8 +3836,8 @@ static inline void ath11k_dp_rx_mon_status_process_tlv(struct ath11k *ar,
 	}
 }
 
-int ath11k_dp_mon_process_rx(struct ath11k_base *ab, int mac_id,
-			     struct napi_struct *napi, int budget)
+static int ath11k_dp_mon_process_rx(struct ath11k_base *ab, int mac_id,
+				    struct napi_struct *napi, int budget)
 {
 	struct ath11k *ar = ab->pdevs[mac_id].ar;
 	struct ath11k_pdev_dp *dp = &ar->dp;
@@ -3866,7 +3865,7 @@ int ath11k_dp_rx_process_mon_rings(struct ath11k_base *ab, int mac_id,
 	return ret;
 }
 
-int ath11k_dp_rx_pdev_mon_status_attach(struct ath11k *ar)
+static int ath11k_dp_rx_pdev_mon_status_attach(struct ath11k *ar)
 {
 	struct ath11k_pdev_dp *dp = &ar->dp;
 	struct ath11k_mon_data *pmon = (struct ath11k_mon_data *)&dp->mon_data;
@@ -3914,7 +3913,7 @@ int ath11k_dp_rx_pdev_mon_attach(struct ath11k *ar)
 	return 0;
 }
 
-int ath11k_dp_mon_link_free(struct ath11k *ar)
+static int ath11k_dp_mon_link_free(struct ath11k *ar)
 {
 	struct ath11k_pdev_dp *dp = &ar->dp;
 	struct ath11k_mon_data *pmon = &dp->mon_data;
drivers/net/wireless/ath/ath11k/dp_rx.h +0 -4
index cc66bc96b3db..5fe6e6d0431c 100644
@@ -374,10 +374,6 @@ int ath11k_dp_htt_tlv_iter(struct ath11k_base *ab, const void *ptr, size_t len,
 			   int (*iter)(struct ath11k_base *ar, u16 tag, u16 len,
 				       const void *ptr, void *data),
 			   void *data);
-int ath11k_dp_htt_rx_filter_setup(struct ath11k_base *ab, u32 ring_id,
-				  int mac_id, enum hal_ring_type ring_type,
-				  int rx_buf_size,
-				  struct htt_rx_ring_tlv_filter *tlv_filter);
 int ath11k_dp_rx_process_mon_rings(struct ath11k_base *ab, int mac_id,
 				   struct napi_struct *napi, int budget);
 int ath11k_dp_rx_process_mon_status(struct ath11k_base *ab, int mac_id,
drivers/net/wireless/ath/ath11k/dp_tx.h +6 -0
index b2f33327ae30..751a0cec4997 100644
@@ -30,4 +30,10 @@ int ath11k_dp_htt_h2t_ext_stats_req(struct ath11k *ar, u8 type,
 				    struct htt_ext_stats_cfg_params *cfg_params,
 				    u64 cookie);
 int ath11k_dp_htt_monitor_mode_ring_config(struct ath11k *ar, bool reset);
+
+int ath11k_dp_htt_rx_filter_setup(struct ath11k_base *ab, u32 ring_id,
+				  int mac_id, enum hal_ring_type ring_type,
+				  int rx_buf_size,
+				  struct htt_rx_ring_tlv_filter *tlv_filter);
+
 #endif
drivers/net/wireless/ath/ath11k/wmi.c +85 -85

452 lines not on this page · raw message

Signature · 7 lines
2.7.4


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
author
#1 lore raw

PATCH 2/3 ath11k: remove unused functions

GCC warns:

drivers/net/wireless/ath/ath11k/wmi.c:2559:12: warning: 'ath11k_send_bcn_buf_ll_cmd' defined but not used [-Wunused-function] drivers/net/wireless/ath/ath11k/wmi.c:2453:12: warning: 'ath11k_send_set_smps_params_cmd' defined but not used [-Wunused-function] drivers/net/wireless/ath/ath11k/wmi.c:2396:12: warning: 'ath11k_send_set_mimops_cmd' defined but not used [-Wunused-function] drivers/net/wireless/ath/ath11k/wmi.c:2362:12: warning: 'ath11k_send_set_sta_ps_mode_cmd' defined but not used [-Wunused-function] drivers/net/wireless/ath/ath11k/wmi.c:1042:12: warning: 'ath11k_send_vdev_set_fwtest_param_cmd' defined but not used [-Wunused-function] drivers/net/wireless/ath/ath11k/wmi.c:1012:12: warning: 'ath11k_send_gpio_output_cmd' defined but not used [-Wunused-function] drivers/net/wireless/ath/ath11k/wmi.c:974:12: warning: 'ath11k_send_gpio_config_cmd' defined but not used [-Wunused-function] drivers/net/wireless/ath/ath11k/wmi.c:943:12: warning: 'ath11k_send_green_ap_ps_enable_cmd' defined but not used [-Wunused-function]

So remove those. They can be can easily added back if they are ever needed.

---
 drivers/net/wireless/ath/ath11k/wmi.c | 292 ----------------------------------
 1 file changed, 292 deletions(-)
drivers/net/wireless/ath/ath11k/wmi.c +0 -292
index a8ef1be6e7de..7ca0a64befb4 100644
@@ -940,136 +940,6 @@ int ath11k_wmi_send_peer_delete_cmd(struct ath11k *ar,
 	return ret;
 }
 
-static int ath11k_send_green_ap_ps_enable_cmd(struct ath11k_pdev_wmi *wmi_handle,
-					      u32 value, u8 mac_id)
-{
-	struct ath11k_base *ab = wmi_handle->wmi_sc->sc;
-	struct wmi_pdev_green_ap_ps_enable_cmd_param *cmd;
-	struct sk_buff *skb;
-	int ret, len;
-
-	len = sizeof(*cmd);
-	skb = ath11k_wmi_alloc_skb(wmi_handle->wmi_sc, len);
-	if (!skb)
-		return -ENOMEM;
-
-	cmd = (void *)skb->data;
-	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG,
-				     WMI_TAG_PDEV_GREEN_AP_PS_ENABLE_CMD) |
-			  FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE);
-
-	cmd->pdev_id = mac_id;
-	cmd->enable = value;
-
-	ret = ath11k_wmi_cmd_send(wmi_handle, skb,
-				  WMI_PDEV_GREEN_AP_PS_ENABLE_CMDID);
-
-	if (ret) {
-		ath11k_warn(ab, "Failed to send WMI_PDEV_GREEN_AP_PS_ENABLE_CMDID");
-		dev_kfree_skb(skb);
-	}
-	return ret;
-}
-
-static int ath11k_send_gpio_config_cmd(struct ath11k_pdev_wmi *wmi_handle,
-				       struct gpio_config_params *param)
-{
-	struct ath11k_base *ab = wmi_handle->wmi_sc->sc;
-	struct wmi_gpio_config_cmd_param *cmd;
-	struct sk_buff *skb;
-	int ret, len;
-
-	len = sizeof(*cmd);
-
-	/* Sanity Checks */
-	if (param->pull_type > WMI_GPIO_PULL_DOWN ||
-	    param->intr_mode > WMI_GPIO_INTTYPE_LEVEL_HIGH) {
-		return -EINVAL;
-	}
-	skb = ath11k_wmi_alloc_skb(wmi_handle->wmi_sc, len);
-	if (!skb)
-		return -ENOMEM;
-
-	cmd = (void *)skb->data;
-	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_GPIO_CONFIG_CMD) |
-			  FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE);
-
-	cmd->gpio_num = param->gpio_num;
-	cmd->input = param->input;
-	cmd->pull_type = param->pull_type;
-	cmd->intr_mode = param->intr_mode;
-
-	ret = ath11k_wmi_cmd_send(wmi_handle, skb,
-				  WMI_GPIO_CONFIG_CMDID);
-
-	if (ret) {
-		ath11k_warn(ab, "Failed to send WMI_GPIO_CONFIG_CMDID");
-		dev_kfree_skb(skb);
-	}
-	return ret;
-}
-
-static int ath11k_send_gpio_output_cmd(struct ath11k_pdev_wmi *wmi_handle,
-				       struct gpio_output_params *param)
-{
-	struct ath11k_base *ab = wmi_handle->wmi_sc->sc;
-	struct wmi_gpio_output_cmd_param *cmd;
-	struct sk_buff *skb;
-	int ret, len;
-
-	len = sizeof(*cmd);
-	skb = ath11k_wmi_alloc_skb(wmi_handle->wmi_sc, len);
-	if (!skb)
-		return -ENOMEM;
-
-	cmd = (void *)skb->data;
-	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_GPIO_OUTPUT_CMD) |
-			  FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE);
-
-	cmd->gpio_num = param->gpio_num;
-	cmd->set = param->set;
-
-	ret = ath11k_wmi_cmd_send(wmi_handle, skb,
-				  WMI_GPIO_OUTPUT_CMDID);
-
-	if (ret) {
-		ath11k_warn(ab, "Failed to send WMI_GPIO_OUTPUT_CMDID");
-		dev_kfree_skb(skb);
-	}
-	return ret;
-}
-
-static int ath11k_send_vdev_set_fwtest_param_cmd(struct ath11k_pdev_wmi *wmi_handle,
-						 struct set_fwtest_params *param)
-{
-	struct ath11k_base *ab = wmi_handle->wmi_sc->sc;
-	struct wmi_fwtest_set_param_cmd_param *cmd;
-	struct sk_buff *skb;
-	int ret, len;
-
-	len = sizeof(*cmd);
-	skb = ath11k_wmi_alloc_skb(wmi_handle->wmi_sc, len);
-	if (!skb)
-		return -ENOMEM;
-
-	cmd = (void *)skb->data;
-	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG,
-				     WMI_TAG_FWTEST_SET_PARAM_CMD) |
-			  FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE);
-
-	cmd->param_id = param->arg;
-	cmd->param_value = param->value;
-
-	ret = ath11k_wmi_cmd_send(wmi_handle, skb,
-				  WMI_FWTEST_CMDID);
-
-	if (ret) {
-		ath11k_warn(ab, "Failed to send WMI_FWTEST_CMDID");
-		dev_kfree_skb(skb);
-	}
-	return ret;
-}
-
 int ath11k_wmi_send_pdev_set_regdomain(struct ath11k *ar,
 				       struct pdev_set_regdomain_params *param)
 {
@@ -2359,134 +2229,6 @@ int ath11k_wmi_send_scan_chan_list_cmd(struct ath11k *ar,
 	return ret;
 }
 
-static int ath11k_send_set_sta_ps_mode_cmd(struct ath11k_pdev_wmi *wmi_handle,
-					   u32 vdev_id, u8 val)
-{
-	struct ath11k_base *ab = wmi_handle->wmi_sc->sc;
-	struct wmi_sta_powersave_mode_cmd *cmd;
-	struct sk_buff *skb;
-	int ret, len;
-
-	len = sizeof(*cmd);
-
-	skb = ath11k_wmi_alloc_skb(wmi_handle->wmi_sc, len);
-	if (!skb)
-		return -ENOMEM;
-
-	cmd = (void *)skb->data;
-	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG,
-				     WMI_TAG_STA_POWERSAVE_MODE_CMD) |
-			  FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE);
-	cmd->vdev_id =  vdev_id;
-	if (val)
-		cmd->sta_ps_mode =  WMI_STA_PS_MODE_ENABLED;
-	else
-		cmd->sta_ps_mode =  WMI_STA_PS_MODE_DISABLED;
-
-	ret = ath11k_wmi_cmd_send(wmi_handle, skb,
-				  WMI_STA_POWERSAVE_MODE_CMDID);
-
-	if (ret) {
-		ath11k_warn(ab, "Failed to send WMI_STA_POWERSAVE_MODE_CMDID");
-		dev_kfree_skb(skb);
-	}
-	return ret;
-}
-
-static int ath11k_send_set_mimops_cmd(struct ath11k_pdev_wmi *wmi_handle,
-				      u8 vdev_id, int value)
-{
-	struct ath11k_base *ab = wmi_handle->wmi_sc->sc;
-	struct wmi_sta_smps_force_mode_cmd *cmd;
-	struct sk_buff *skb;
-	int ret, len;
-
-	len = sizeof(*cmd);
-
-	skb = ath11k_wmi_alloc_skb(wmi_handle->wmi_sc, len);
-	if (!skb)
-		return -ENOMEM;
-
-	cmd = (void *)skb->data;
-	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG,
-				     WMI_TAG_STA_SMPS_FORCE_MODE_CMD) |
-			  FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE);
-
-	cmd->vdev_id = vdev_id;
-
-	/* WMI_SMPS_FORCED_MODE values do not directly map
-	 * to SM power save values defined in the specification.
-	 * Make sure to send the right mapping.
-	 */
-	switch (value) {
-	case 0:
-		cmd->forced_mode =  WMI_SMPS_FORCED_MODE_NONE;
-		break;
-	case 1:
-		cmd->forced_mode =  WMI_SMPS_FORCED_MODE_DISABLED;
-		break;
-	case 2:
-		cmd->forced_mode =  WMI_SMPS_FORCED_MODE_STATIC;
-		break;
-	case 3:
-		cmd->forced_mode =  (WMI_SMPS_FORCED_MODE_DYNAMIC);
-		break;
-	default:
-		ath11k_warn(ab, "INVALID Mimo PS CONFIG %d", value);
-		return -EINVAL;
-	}
-
-	ath11k_dbg(ab, ATH11K_DBG_WMI,
-		   "Setting SMPS Force Mode. vdev %d, mode %d\n",
-		   cmd->vdev_id, cmd->forced_mode);
-
-	ret = ath11k_wmi_cmd_send(wmi_handle, skb,
-				  WMI_STA_SMPS_FORCE_MODE_CMDID);
-
-	if (ret) {
-		ath11k_warn(ab, "Failed to send WMI_STA_SMPS_FORCE_MODE_CMDID");
-		dev_kfree_skb(skb);
-	}
-	return ret;
-}
-
-static int ath11k_send_set_smps_params_cmd(struct ath11k_pdev_wmi *wmi_handle,
-					   u8 vdev_id, int value)
-{
-	struct ath11k_base *ab = wmi_handle->wmi_sc->sc;
-	struct wmi_sta_smps_param_cmd *cmd;
-	struct sk_buff *skb;
-	int ret, len;
-
-	len = sizeof(*cmd);
-
-	skb = ath11k_wmi_alloc_skb(wmi_handle->wmi_sc, len);
-	if (!skb)
-		return -ENOMEM;
-
-	cmd = (void *)skb->data;
-	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_STA_SMPS_PARAM_CMD) |
-			  FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE);
-
-	cmd->vdev_id = vdev_id;
-	cmd->value = value & WMI_SMPS_MASK_LOWER_16BITS;
-	cmd->param = (value >> WMI_SMPS_PARAM_VALUE_SHIFT) &
-		     WMI_SMPS_MASK_UPPER_3BITS;
-
-	ath11k_dbg(ab, ATH11K_DBG_WMI,
-		   "Setting SMPS Param. vdev %d, param %d, value %d\n",
-		   cmd->vdev_id, cmd->param, cmd->value);
-
-	ret = ath11k_wmi_cmd_send(wmi_handle, skb,
-				  WMI_STA_SMPS_PARAM_CMDID);
-
-	if (ret) {
-		ath11k_warn(ab, "Failed to send WMI_STA_SMPS_PARAM_CMDID");
-		dev_kfree_skb(skb);
-	}
-	return ret;
-}
-
 int ath11k_wmi_send_wmm_update_cmd_tlv(struct ath11k *ar, u32 vdev_id,
 				       struct wmi_wmm_params_all_arg *param)
 {
@@ -2556,40 +2298,6 @@ int ath11k_wmi_send_wmm_update_cmd_tlv(struct ath11k *ar, u32 vdev_id,
 	return ret;
 }
 
-static int ath11k_send_bcn_buf_ll_cmd(struct ath11k_pdev_wmi *wmi_handle,
-				      struct wmi_bcn_send_from_host_cmd *param)
-{
-	struct ath11k_base *ab = wmi_handle->wmi_sc->sc;
-	struct wmi_bcn_send_from_host_cmd *cmd;
-	struct sk_buff *skb;
-	int ret, len;
-
-	len = sizeof(*cmd);
-
-	skb = ath11k_wmi_alloc_skb(wmi_handle->wmi_sc, len);
-	if (!skb)
-		return -ENOMEM;
-
-	cmd = (void *)skb->data;
-	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG,
-				     WMI_TAG_BCN_SEND_FROM_HOST_CMD) |
-			  FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE);
-
-	cmd->vdev_id = param->vdev_id;
-	cmd->data_len = param->data_len;
-	cmd->frame_ctrl = param->frame_ctrl;
-	cmd->frag_ptr = param->frag_ptr;
-	cmd->dtim_flag = param->dtim_flag;
-
-	ret = ath11k_wmi_cmd_send(wmi_handle, skb,
-				  WMI_PDEV_SEND_BCN_CMDID);
-	if (ret) {
-		ath11k_warn(ab, "Failed to send WMI_PDEV_SEND_BCN_CMDID");
-		dev_kfree_skb(skb);
-	}
-	return ret;
-}
-
 int ath11k_wmi_send_dfs_phyerr_offload_enable_cmd(struct ath11k *ar,
 						  u32 pdev_id)
 {
Signature · 7 lines
2.7.4


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
author
#2 lore raw

PATCH 3/3 ath11k: workaround GCC unitialised warnings

In reply to Kalle Valo

After making some WMI functions static GCC started to warn quite a lot about uninitalised variables:

ath11k/wmi.c:5303:3: warning: 'install_key_compl.status' may be used uninitialized in this function [-Wmaybe-uninitialized]

From a quick look they look like false warnings but let's initialise the variables anyway to make the warning go away.

---
 drivers/net/wireless/ath/ath11k/wmi.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/net/wireless/ath/ath11k/wmi.c +9 -9
index 7ca0a64befb4..9a0b904a16ff 100644
@@ -4805,7 +4805,7 @@ static void ath11k_bcn_tx_status_event(struct ath11k_base *ab, u8 *evt_buf, u32
 static void ath11k_vdev_stopped_event(struct ath11k_base *ab, u8 *evt_buf, u32 len)
 {
 	struct ath11k *ar;
-	u32 vdev_id;
+	u32 vdev_id = 0;
 
 	if (ath11k_pull_vdev_stopped_param_tlv(ab, evt_buf, len,
 					       &vdev_id) != 0) {
@@ -4831,7 +4831,7 @@ static void ath11k_vdev_stopped_event(struct ath11k_base *ab, u8 *evt_buf, u32 l
 
 static void ath11k_mgmt_rx_event(struct ath11k_base *ab, struct sk_buff *skb)
 {
-	struct mgmt_rx_event_params rx_ev;
+	struct mgmt_rx_event_params rx_ev = {0};
 	struct ath11k *ar;
 	struct ieee80211_rx_status *status = IEEE80211_SKB_RXCB(skb);
 	struct ieee80211_hdr *hdr;
@@ -4940,7 +4940,7 @@ static void ath11k_mgmt_rx_event(struct ath11k_base *ab, struct sk_buff *skb)
 
 static void ath11k_mgmt_tx_compl_event(struct ath11k_base *ab, struct sk_buff *skb)
 {
-	struct wmi_mgmt_tx_compl_event tx_compl_param;
+	struct wmi_mgmt_tx_compl_event tx_compl_param = {0};
 	struct ath11k *ar;
 
 	if (ath11k_pull_mgmt_tx_compl_param_tlv(ab, skb->data, skb->len,
@@ -4972,7 +4972,7 @@ static void ath11k_mgmt_tx_compl_event(struct ath11k_base *ab, struct sk_buff *s
 static void ath11k_scan_event(struct ath11k_base *ab, u8 *evt_buf, u32 len)
 {
 	struct ath11k *ar;
-	struct wmi_scan_event scan_ev;
+	struct wmi_scan_event scan_ev = {0};
 
 	if (ath11k_pull_scan_ev(ab, evt_buf, len,
 				&scan_ev) != 0) {
@@ -5079,7 +5079,7 @@ static void ath11k_peer_sta_kickout_event(struct ath11k_base *ab, u8 *evt_buf, u
 
 static void ath11k_roam_event(struct ath11k_base *ab, u8 *evt_buf, u32 len)
 {
-	struct wmi_roam_event roam_ev;
+	struct wmi_roam_event roam_ev = {};
 	struct ath11k *ar;
 
 	if (ath11k_pull_roam_ev(ab, evt_buf, len, &roam_ev) != 0) {
@@ -5125,7 +5125,7 @@ static void ath11k_roam_event(struct ath11k_base *ab, u8 *evt_buf, u32 len)
 
 static void ath11k_chan_info_event(struct ath11k_base *ab, u8 *evt_buf, u32 len)
 {
-	struct wmi_chan_info_event ch_info_ev;
+	struct wmi_chan_info_event ch_info_ev = {0};
 	struct ath11k *ar;
 	struct survey_info *survey;
 	int idx;
@@ -5199,7 +5199,7 @@ static void ath11k_chan_info_event(struct ath11k_base *ab, u8 *evt_buf, u32 len)
 static void ath11k_pdev_bss_chan_info_event(struct ath11k_base *ab, u8 *evt_buf,
 				     u32 len)
 {
-	struct wmi_pdev_bss_chan_info_event bss_ch_info_ev;
+	struct wmi_pdev_bss_chan_info_event bss_ch_info_ev = {};
 	struct survey_info *survey;
 	struct ath11k *ar;
 	u32 cc_freq_hz = ab->cc_freq_hz;
@@ -5273,7 +5273,7 @@ static void ath11k_pdev_bss_chan_info_event(struct ath11k_base *ab, u8 *evt_buf,
 static void ath11k_vdev_install_key_compl_event(struct ath11k_base *ab, u8 *evt_buf,
 						u32 len)
 {
-	struct wmi_vdev_install_key_complete_arg install_key_compl;
+	struct wmi_vdev_install_key_complete_arg install_key_compl = {0};
 	struct ath11k *ar;
 
 	if (ath11k_pull_vdev_install_key_compl_ev(ab, evt_buf, len,
@@ -5347,7 +5347,7 @@ static void ath11k_service_available_event(struct ath11k_base *ab, u8 *evt_buf,
 
 static void ath11k_peer_assoc_conf_event(struct ath11k_base *ab, u8 *evt_buf, u32 len)
 {
-	struct wmi_peer_assoc_conf_arg peer_assoc_conf;
+	struct wmi_peer_assoc_conf_arg peer_assoc_conf = {0};
 	struct ath11k *ar;
 
 	if (ath11k_pull_peer_assoc_conf_ev(ab, evt_buf, len,
Signature · 7 lines
2.7.4


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
author
#3 lore raw
In reply to Kalle Valo
Quoted 7 lines · Kalle Valo

Fixes warnings like:

drivers/net/wireless/ath/ath11k/wmi.c:203:5: warning: symbol 'ath11k_wmi_cmd_send_nowait' was not declared. Should it be static?

Also ath11k_dp_htt_rx_filter_setup() was declared in the wrong header file, fix that as well.

3 patches applied to ath.git, thanks.

08c6d676f96b ath11k: fix sparse symbol should be static warnings ef5f0fc6d73f ath11k: remove unused functions e8cb49bd3900 ath11k: workaround GCC unitialised warnings

Signature · 9 lines
https://patchwork.kernel.org/patch/10942033/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k