nvme-cli: remove unused NVME_AER_NOTICE_*
PATCH 1/1 nvme-cli: remove unused NVME_AER_NOTICE_*
NVME_AER_NOTICE_* are unused and these values conflict with the values defined in the kernel nvme.h.
Cc Keith Busch <keith.busch at intel.com>
Signed-off-by Akinobu Mita <akinobu.mita at gmail.com>
--- linux/nvme.h | 3 --- 1 file changed, 3 deletions(-)
linux/nvme.h +0 -3
@@ -589,9 +589,6 @@ enum {NVME_AER_SMART =1 ,NVME_AER_CSS =6 , NVME_AER_VS = 7, -NVME_AER_NOTICE_NS_CHANGED =0x0002 , -NVME_AER_NOTICE_ANA =0x0003 , - NVME_AER_NOTICE_FW_ACT_STARTING = 0x0102, }; struct nvme_lba_range_type {
Signature · 1 line
2.7.4
PATCH 1/1 nvme-cli: remove unused NVME_AER_NOTICE_*
linux/nvme.h enum { · line 592
Quoted 12 lines
linux/nvme.h +0
-3@@ -589,9 +589,6 @@ enum {NVME_AER_SMART =1 ,NVME_AER_CSS =6 , NVME_AER_VS = 7, -NVME_AER_NOTICE_NS_CHANGED =0x0002 , -NVME_AER_NOTICE_ANA =0x0003 , - NVME_AER_NOTICE_FW_ACT_STARTING = 0x0102, };
It looks like we can sync-up the header files sooner or later from the kernel code to avoid kind of conflicts you mentioned.
Anyway,
Reviewed-by Minwoo Im <minwoo.im.dev at gmail.com>
PATCH 1/1 nvme-cli: remove unused NVME_AER_NOTICE_*
In reply to Akinobu MitaLooks good.
Reviewed-by Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
Quoted 23 lines · Akinobu Mita
NVME_AER_NOTICE_* are unused and these values conflict with the values defined in the kernel
nvme.h.Cc Keith Busch <keith.busch at intel.com>Signed-off-by Akinobu Mita <akinobu.mita at gmail.com>--- linux/nvme.h | 3 --- 1 file changed, 3 deletions(-)linux/nvme.h +0
-3@@ -589,9 +589,6 @@ enum {NVME_AER_SMART =1 ,NVME_AER_CSS =6 , NVME_AER_VS = 7, -NVME_AER_NOTICE_NS_CHANGED =0x0002 , -NVME_AER_NOTICE_ANA =0x0003 , - NVME_AER_NOTICE_FW_ACT_STARTING = 0x0102, }; struct nvme_lba_range_type {