FAILED: patch "[PATCH] power: supply: axp288_charger: Fix unchecked return value" failed to apply to 4.4-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From c3422ad5f84a66739ec6a37251ca27638c85b6be Mon Sep 17 00:00:00 2001
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 18 Mar 2019 11:14:39 -0500
Subject: [PATCH] power: supply: axp288_charger: Fix unchecked return value
Currently there is no check on platform_get_irq() return value in case it fails, hence never actually reporting any errors and causing unexpected behavior when using such value as argument for function regmap_irq_get_virq().
Fix this by adding a proper check, a message reporting any errors and returning *pirq*
Addresses-Coverity-ID: 1443940 ("Improper use of negative value")
drivers/power/supply/axp288_charger.c +4 -0
@@ -833,6 +833,10 @@ static int axp288_charger_probe(struct platform_device *pdev)/* Register charger interrupts */ for (i =0 ; i <CHRG_INTR_END ; i++) { pirq =platform_get_irq (info->pdev, i); +if (pirq <0 ) { +dev_err (&pdev->dev,"Failed to get IRQ: %d\n" , pirq); +return pirq; + } info->irq[i] =regmap_irq_get_virq (info->regmap_irqc, pirq);if (info->irq[i] <0 ) { dev_warn(&info->pdev->dev,