Skip to contentSkip to conversation

ARC: [plat-hsdk]: GMAC DT Bindings Improvements

PATCH In review Jose Abreu 3 participants 5 messages May 20, 2019 – May 21, 2019

Subsystems (2)
Device tree bindings Synopsys ARC architecture
lore
Share & tools
lore

Jose Abreu

author
#0 lore raw

cover ARC: [plat-hsdk]: GMAC DT Bindings Improvements

Add two missing bindings.

Cc Joao Pinto <[email protected]>
Cc Rob Herring <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Eugeniy Paltsev <[email protected]>
Cc Alexey Brodkin <[email protected]>

Jose Abreu (2):
ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC
node
ARC: [plat-hsdk]: Add missing FIFO size entry in GMAC node

 arch/arc/boot/dts/hsdk.dts | 4 ++++
 1 file changed, 4 insertions(+)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/2 ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node

GMAC controller on HSDK boards supports 256 Hash Table size so we need to add the multicast filter bins property. This allows for the Hash filter to work properly using stmmac driver.

Signed-off-by Jose Abreu <[email protected]>
Cc Joao Pinto <[email protected]>
Cc Rob Herring <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Eugeniy Paltsev <[email protected]>
Cc Alexey Brodkin <[email protected]>
---
 arch/arc/boot/dts/hsdk.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arc/boot/dts/hsdk.dts +1 -0
index 69bc1c9e8e50..b0f059377ab0 100644
@@ -187,6 +187,7 @@
 			interrupt-names = "macirq";
 			phy-mode = "rgmii";
 			snps,pbl = <32>;
+			snps,multicast-filter-bins = <256>;
 			clocks = <&gmacclk>;
 			clock-names = "stmmaceth";
 			phy-handle = <&phy0>;
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH 2/2 ARC: [plat-hsdk]: Add missing FIFO size entry in GMAC node

In reply to Jose Abreu

Add the binding for RX/TX fifo size of GMAC node.

Signed-off-by Jose Abreu <[email protected]>
Cc Joao Pinto <[email protected]>
Cc Rob Herring <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Eugeniy Paltsev <[email protected]>
Cc Alexey Brodkin <[email protected]>
---
 arch/arc/boot/dts/hsdk.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/arc/boot/dts/hsdk.dts +3 -0
index b0f059377ab0..3bcd1edc4dcc 100644
@@ -196,6 +196,9 @@
 			mac-address = [00 00 00 00 00 00]; /* Filled in by U-Boot */
 			dma-coherent;
 
+			tx-fifo-depth = <4096>;
+			rx-fifo-depth = <4096>;
+
 			mdio {
 				#address-cells = <1>;
 				#size-cells = <0>;
Signature · 1 line
2.7.4
Tested-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] ARC: [plat-hsdk]: Add missing FIFO size entry in GMAC node

Hi Jose,

Tested-by Eugeniy Paltsev <[email protected]>
Quoted 27 lines · Jose Abreu

Add the binding for RX/TX fifo size of GMAC node.

Signed-off-by Jose Abreu <[email protected]>
Cc Joao Pinto <[email protected]>
Cc Rob Herring <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Eugeniy Paltsev <[email protected]>
Cc Alexey Brodkin <[email protected]>
---
 arch/arc/boot/dts/hsdk.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/arc/boot/dts/hsdk.dts +3 -0
index b0f059377ab0..3bcd1edc4dcc 100644
@@ -196,6 +196,9 @@
 			mac-address = [00 00 00 00 00 00]; /* Filled in by U-Boot */
 			dma-coherent;
 
+			tx-fifo-depth = <4096>;
+			rx-fifo-depth = <4096>;
+
 			mdio {
 				#address-cells = <1>;
 				#size-cells = <0>;
Signature · 1 line
 Eugeniy Paltsev
Acked-by on the v1 series
#4 lore raw
In reply to Jose Abreu

Hi Jose, all,

Quoted 11 lines

-----Original Message-----
From: Jose Abreu <[email protected]>
Sent: Monday, May 20, 2019 4:43 PM
To: [email protected]; [email protected]; [email protected]
Cc: Jose Abreu <[email protected]>; Joao Pinto <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Vineet Gupta <[email protected]>; Eugeniy Paltsev <[email protected]>; Alexey Brodkin <[email protected]>
Subject: [PATCH 0/2] ARC: [plat-hsdk]: GMAC DT Bindings Improvements

Add two missing bindings.

For entire series:

Acked-by Alexey Brodkin <[email protected]>

@Vineet Gupta could you please pick this on up?

-Alexey