drm/nouveau/svm: Convert to use hmm_range_fault()
Subsystems (3)
PATCH 1/1 drm/nouveau/svm: Convert to use hmm_range_fault()
Convert to use hmm_range_fault().
Signed-off-by Souptick Joarder <[email protected]>
--- drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_svm.c +1 -1
@@ -649,7 +649,7 @@ struct nouveau_svmm { range.values = nouveau_svm_pfn_values; range.pfn_shift =NVIF_VMM_PFNMAP_V0_ADDR_SHIFT ; again: - ret =hmm_vma_fault (&range, true); + ret =hmm_range_fault (&range, true);if (ret ==0 ) {mutex_lock (&svmm->mutex);if (!hmm_vma_range_done (&range)) {
Signature · 1 line
1.9.1
Quoted 2 lines · Souptick Joarder
Convert to use
hmm_range_fault().
Any comment on this patch ?
Quoted 22 lines
Signed-off-by Souptick Joarder <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nouveau_svm.c +1
-2@@ -649,7 +649,7 @@ struct nouveau_svmm { range.values = nouveau_svm_pfn_values; range.pfn_shift =NVIF_VMM_PFNMAP_V0_ADDR_SHIFT ; again: - ret =hmm_vma_fault (&range, true); + ret =hmm_range_fault (&range, true);if (ret ==0 ) {mutex_lock (&svmm->mutex);if (!hmm_vma_range_done (&range)) { --1.9.1
Hi Jason,
Quoted 4 lines · Souptick Joarder
Convert to use
hmm_range_fault().Signed-off-by Souptick Joarder <[email protected]>
Would you like to take it through your new hmm tree or do I need to resend it ?
Quoted 20 lines
--- drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nouveau_svm.c +1
-2@@ -649,7 +649,7 @@ struct nouveau_svmm { range.values = nouveau_svm_pfn_values; range.pfn_shift =NVIF_VMM_PFNMAP_V0_ADDR_SHIFT ; again: - ret =hmm_vma_fault (&range, true); + ret =hmm_range_fault (&range, true);if (ret ==0 ) {mutex_lock (&svmm->mutex);if (!hmm_vma_range_done (&range)) { --1.9.1
Quoted 10 lines · Souptick Joarder
Hi Jason,
Quoted 4 lines · Souptick Joarder
Convert to use
hmm_range_fault().Signed-off-by Souptick Joarder <[email protected]>Would you like to take it through your new hmm tree or do I need to resend it ?
This patch is wrong as the API is different between the two see what is in hmm.h to see the differences between hmm_vma_fault() hmm_range_fault() a simple rename break things.
Quoted 21 lines
Quoted 21 lines
--- drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nouveau_svm.c +1
-2@@ -649,7 +649,7 @@ struct nouveau_svmm { range.values = nouveau_svm_pfn_values; range.pfn_shift =NVIF_VMM_PFNMAP_V0_ADDR_SHIFT ; again: - ret =hmm_vma_fault (&range, true); + ret =hmm_range_fault (&range, true);if (ret ==0 ) {mutex_lock (&svmm->mutex);if (!hmm_vma_range_done (&range)) { --1.9.1