patch "USB: rio500: fix memory leak in close after disconnect" added to usb-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
USB: rio500: fix memory leak in close after disconnect
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From e0feb73428b69322dd5caae90b0207de369b5575 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <[email protected]>
Date: Thu, 9 May 2019 11:30:59 +0200
Subject: USB: rio500: fix memory leak in close after disconnect
If a disconnected device is closed, rio_close() must free the buffers.
--- drivers/usb/misc/rio500.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
drivers/usb/misc/rio500.c +15 -2
@@ -86,9 +86,22 @@ static int close_rio(struct inode *inode, struct file *file) {struct rio_usb_data *rio = &rio_instance; - rio->isopen =0 ; +/* against disconnect() */ +mutex_lock (&rio500_mutex); +mutex_lock (&(rio->lock)); -dev_info (&rio->rio_dev->dev,"Rio closed.\n" ); + rio->isopen =0 ; +if (!rio->present) { +/* cleanup has been delayed */ +kfree (rio->ibuf); +kfree (rio->obuf); + rio->ibuf =NULL ; + rio->obuf =NULL ; + }else { +dev_info (&rio->rio_dev->dev,"Rio closed.\n" ); + } +mutex_unlock (&(rio->lock)); +mutex_unlock (&rio500_mutex);return 0 ; }
Signature · 1 line
2.21.0