Skip to contentSkip to conversation

raw/ifpga: fix unintentional integer overflow

PATCH In review Andy Pei 2 participants 5 messages May 22, 2019 – Jul 4, 2019

lore
Share & tools
lore

Andy Pei

author
#0 lore raw

PATCH 1/1 raw/ifpga: fix unintentional integer overflow

cast unsigned int ports_per_retimer, unsigned int nums_retimer, unsigned int nums_fvl and unsigned int ports_per_fvl to uint64_t before multiply operation, to avoid Unintentional integer overflow.

Coverity issue: 337924, 337926

Fixes d1cd4eb2d48e ("raw/ifpga: support ipn3ke")
---
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +4 -4
index 41be1a2..9c68666 100644
@@ -494,8 +494,8 @@
 	if (!strcmp(attr_name, "LineSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.ports_per_retimer *
-			opae_rtm_info.nums_retimer;
+		uint64_t tmp = (uint64_t)opae_rtm_info.ports_per_retimer *
+					(uint64_t)opae_rtm_info.nums_retimer;
 		*attr_value = tmp;
 		return 0;
 	}
@@ -547,8 +547,8 @@
 	if (!strcmp(attr_name, "NICSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.nums_fvl *
-					opae_rtm_info.ports_per_fvl;
+		uint64_t tmp = (uint64_t)opae_rtm_info.nums_fvl *
+					(uint64_t)opae_rtm_info.ports_per_fvl;
 		*attr_value = tmp;
 		return 0;
 	}
Signature · 1 line
1.8.3.1
#1 lore raw

Hi Andy,

Why you sent this patch two times?

Quoted 53 lines

-----Original Message-----
From: Pei, Andy
Sent: Wednesday, May 22, 2019 14:43
To: [email protected]
Cc: Pei, Andy <[email protected]>; Xu, Rosen <[email protected]>; [email protected]
Subject: [PATCH] raw/ifpga: fix unintentional integer overflow

cast unsigned int ports_per_retimer, unsigned int nums_retimer, unsigned int nums_fvl and unsigned int ports_per_fvl to uint64_t before multiply operation, to avoid Unintentional integer overflow.

Coverity issue: 337924, 337926

Fixes d1cd4eb2d48e ("raw/ifpga: support ipn3ke")
---
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -2
index 41be1a2..9c68666 100644
@@ -494,8 +494,8 @@
 	if (!strcmp(attr_name, "LineSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.ports_per_retimer *
-			opae_rtm_info.nums_retimer;
+		uint64_t tmp = (uint64_t)opae_rtm_info.ports_per_retimer *
+
 	(uint64_t)opae_rtm_info.nums_retimer;
 		*attr_value = tmp;
 		return 0;
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -2
 	}
@@ -547,8 +547,8 @@
 	if (!strcmp(attr_name, "NICSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.nums_fvl *
-					opae_rtm_info.ports_per_fvl;
+		uint64_t tmp = (uint64_t)opae_rtm_info.nums_fvl *
+
 	(uint64_t)opae_rtm_info.ports_per_fvl;
 		*attr_value = tmp;
 		return 0;

}
--
1.8.3.1

author
#2 lore raw

Hi Rosen,

I use git send-email for internal check, I seems I should not cc you and stable@dpdk.

-----Original Message-----
From: Xu, Rosen
Sent: Thursday, May 23, 2019 10:11 AM
To: Pei, Andy <[email protected]>; [email protected]
Cc: [email protected]
Subject: RE: [PATCH] raw/ifpga: fix unintentional integer overflow

Hi Andy,

Why you sent this patch two times?

Quoted 53 lines

-----Original Message-----
From: Pei, Andy
Sent: Wednesday, May 22, 2019 14:43
To: [email protected]
Cc: Pei, Andy <[email protected]>; Xu, Rosen <[email protected]>; [email protected]
Subject: [PATCH] raw/ifpga: fix unintentional integer overflow

cast unsigned int ports_per_retimer, unsigned int nums_retimer, unsigned int nums_fvl and unsigned int ports_per_fvl to uint64_t before multiply operation, to avoid Unintentional integer overflow.

Coverity issue: 337924, 337926

Fixes d1cd4eb2d48e ("raw/ifpga: support ipn3ke")
---
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -2
index 41be1a2..9c68666 100644
@@ -494,8 +494,8 @@
 	if (!strcmp(attr_name, "LineSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.ports_per_retimer *
-			opae_rtm_info.nums_retimer;
+		uint64_t tmp = (uint64_t)opae_rtm_info.ports_per_retimer *
+
 	(uint64_t)opae_rtm_info.nums_retimer;
 		*attr_value = tmp;
 		return 0;
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -2
 	}
@@ -547,8 +547,8 @@
 	if (!strcmp(attr_name, "NICSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.nums_fvl *
-					opae_rtm_info.ports_per_fvl;
+		uint64_t tmp = (uint64_t)opae_rtm_info.nums_fvl *
+
 	(uint64_t)opae_rtm_info.ports_per_fvl;
 		*attr_value = tmp;
 		return 0;

}
--
1.8.3.1

Acked-by on v1 1/1
#3 lore raw
In reply to Andy Pei

Hi,

Quoted 50 lines

-----Original Message-----
From: Pei, Andy
Sent: Wednesday, May 22, 2019 14:43
To: [email protected]
Cc: Pei, Andy <[email protected]>; Xu, Rosen <[email protected]>; [email protected]
Subject: [PATCH] raw/ifpga: fix unintentional integer overflow

cast unsigned int ports_per_retimer, unsigned int nums_retimer, unsigned int nums_fvl and unsigned int ports_per_fvl to uint64_t before multiply operation, to avoid Unintentional integer overflow.

Coverity issue: 337924, 337926

Fixes d1cd4eb2d48e ("raw/ifpga: support ipn3ke")
---
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -2
index 41be1a2..9c68666 100644
@@ -494,8 +494,8 @@
 	if (!strcmp(attr_name, "LineSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.ports_per_retimer *
-			opae_rtm_info.nums_retimer;
+		uint64_t tmp = (uint64_t)opae_rtm_info.ports_per_retimer *
+
 	(uint64_t)opae_rtm_info.nums_retimer;
 		*attr_value = tmp;
 		return 0;
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -2
 	}
@@ -547,8 +547,8 @@
 	if (!strcmp(attr_name, "NICSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.nums_fvl *
-					opae_rtm_info.ports_per_fvl;
+		uint64_t tmp = (uint64_t)opae_rtm_info.nums_fvl *
+
 	(uint64_t)opae_rtm_info.ports_per_fvl;
 		*attr_value = tmp;
 		return 0;
Quoted 3 lines

}
--
1.8.3.1

author
#4 lore raw
In reply to Andy Pei

+Qi

-----Original Message-----
From: Pei, Andy
Sent: Wednesday, May 22, 2019 2:43 PM
To: [email protected]
Cc: Pei, Andy <[email protected]>; Xu, Rosen <[email protected]>; [email protected]
Subject: [PATCH] raw/ifpga: fix unintentional integer overflow

cast unsigned int ports_per_retimer, unsigned int nums_retimer, unsigned int nums_fvl and unsigned int ports_per_fvl to uint64_t before multiply operation, to avoid Unintentional integer overflow.

Coverity issue: 337924, 337926

Fixes d1cd4eb2d48e ("raw/ifpga: support ipn3ke")
---
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +4 -4
index 41be1a2..9c68666 100644
@@ -494,8 +494,8 @@
 	if (!strcmp(attr_name, "LineSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.ports_per_retimer *
-			opae_rtm_info.nums_retimer;
+		uint64_t tmp = (uint64_t)opae_rtm_info.ports_per_retimer *
+					(uint64_t)opae_rtm_info.nums_retimer;
 		*attr_value = tmp;
 		return 0;
 	}
@@ -547,8 +547,8 @@
 	if (!strcmp(attr_name, "NICSideLinkPortNum")) {
 		if (opae_manager_get_retimer_info(mgr, &opae_rtm_info))
 			return -1;
-		uint64_t tmp = opae_rtm_info.nums_fvl *
-					opae_rtm_info.ports_per_fvl;
+		uint64_t tmp = (uint64_t)opae_rtm_info.nums_fvl *
+					(uint64_t)opae_rtm_info.ports_per_fvl;
 		*attr_value = tmp;
 		return 0;
 	}

--
1.8.3.1