net/ipn3ke: delete identical branch
PATCH 1/1 net/ipn3ke: delete identical branch
Whether the if statement is ture or not, the operation is identical.
It is unnecessary to check the if statement, so just delete the if statement.
Coverity issue: 337928
--- drivers/net/ipn3ke/ipn3ke_tm.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
drivers/net/ipn3ke/ipn3ke_tm.c +2 -13
@@ -1541,23 +1541,12 @@ struct ipn3ke_tm_shaper_params_range_type ipn3ke_tm_shaper_params_rang[] = {NULL , rte_strerror(EINVAL)); } - }else if (n->node_state == -IPN3KE_TM_NODE_STATE_CONFIGURED_DEL ) { -if (n->level !=IPN3KE_TM_NODE_LEVEL_VT || - n->n_children !=0 ) { -return -rte_tm_error_set (error, -EINVAL , -RTE_TM_ERROR_TYPE_UNSPECIFIED , -NULL , -rte_strerror (EINVAL )); - }else { -return -rte_tm_error_set (error, + }else if (n->node_state ==IPN3KE_TM_NODE_STATE_CONFIGURED_DEL ) +return -rte_tm_error_set (error,EINVAL ,RTE_TM_ERROR_TYPE_UNSPECIFIED ,NULL ,rte_strerror (EINVAL )); - } - } } n = tm->h.port_commit_node;
Signature · 1 line
1.8.3.1
Hi,
Quoted 56 lines
-----Original Message-----
From: Pei, Andy
Sent: Wednesday, May 22, 2019 14:45
To: [email protected]
Cc: Pei, Andy <[email protected]>; Xu, Rosen <[email protected]>; [email protected]
Subject: [PATCH] net/ipn3ke: delete identical branchWhether the if statement is ture or not, the operation is identical. It is unnecessary to check the if statement, so just delete the if statement.
Coverity issue: 337928
Signed-off-by Andy Pei <[email protected]>--- drivers/net/ipn3ke/ipn3ke_tm.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)(quoted diff) +0
-0
b/drivers/net/ipn3ke/ipn3ke_tm.cindex 4bcf3aa..39c49bc 100644drivers/net/ipn3ke/ipn3ke_tm.c +2
-14@@ -1541,23 +1541,12 @@ struct ipn3ke_tm_shaper_params_range_type ipn3ke_tm_shaper_params_rang[] = {NULL , rte_strerror(EINVAL)); } - }else if (n->node_state == -IPN3KE_TM_NODE_STATE_CONFIGURED_DEL ) { -if (n->level !=IPN3KE_TM_NODE_LEVEL_VT || - n->n_children !=0 ) { -return -rte_tm_error_set (error, -EINVAL , - RTE_TM_ERROR_TYPE_UNSPECIFIED, -NULL , -rte_strerror (EINVAL )); - }else { -return -rte_tm_error_set (error, + }else if (n->node_state ==IPN3KE_TM_NODE_STATE_CONFIGURED_DEL ) +return -rte_tm_error_set (error,EINVAL ,RTE_TM_ERROR_TYPE_UNSPECIFIED ,NULL ,rte_strerror (EINVAL )); - } - } } n = tm->h.port_commit_node; --
Quoted 1 line
1.8.3.1
Zhang, Qi Z
AppliedQuoted 22 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Xu, Rosen
Sent: Thursday, May 23, 2019 10:27 AM
To: Pei, Andy <[email protected]>; [email protected]
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH] net/ipn3ke: delete identical branchHi,
Quoted 11 lines
-----Original Message-----
From: Pei, Andy
Sent: Wednesday, May 22, 2019 14:45
To: [email protected]
Cc: Pei, Andy <[email protected]>; Xu, Rosen <[email protected]>; [email protected]
Subject: [PATCH] net/ipn3ke: delete identical branchWhether the if statement is ture or not, the operation is identical. It is unnecessary to check the if statement, so just delete the if statement.
Quoted 8 lines
Quoted 7 lines
Coverity issue: 337928
Signed-off-by Andy Pei <[email protected]>---
Acked-by Rosen Xu <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi