Skip to contentSkip to conversation

net/ipn3ke: delete unnecessary code

PATCH In review Andy Pei 2 participants 2 messages May 22, 2019 – May 23, 2019 Network drivers

lore
Share & tools
lore

Andy Pei

author
#0 lore raw

PATCH 1/1 net/ipn3ke: delete unnecessary code

Whether the value of ret is true or false, the end target is always run.
It is unnecessary to check the value of ret, so just delete it.

Coverity issue: 337930

Fixes c01c748e4ae6 ("net/ipn3ke: add new driver")
---
 drivers/net/ipn3ke/ipn3ke_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ipn3ke/ipn3ke_ethdev.c +1 -2
index 9079b57..d88afa6 100644
@@ -581,8 +581,7 @@ static int ipn3ke_vswitch_remove(struct rte_afu_device *afu_dev)
 	}
 
 	ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name);
-	if (ret)
-		goto end;
+
 end:
 	if (kvlist)
 		rte_kvargs_free(kvlist);
Signature · 1 line
1.8.3.1
Acked-by on v1 1/1
#1 lore raw
Quoted 38 lines

-----Original Message-----
From: Pei, Andy
Sent: Wednesday, May 22, 2019 14:45
To: [email protected]
Cc: Pei, Andy <[email protected]>; Xu, Rosen <[email protected]>; [email protected]
Subject: [PATCH] net/ipn3ke: delete unnecessary code

Whether the value of ret is true or false, the end target is always run. It is unnecessary to check the value of ret, so just delete it.

Coverity issue: 337930

Fixes c01c748e4ae6 ("net/ipn3ke: add new driver")
---
 drivers/net/ipn3ke/ipn3ke_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ipn3ke/ipn3ke_ethdev.c +1 -2
index 9079b57..d88afa6 100644
@@ -581,8 +581,7 @@ static int ipn3ke_vswitch_remove(struct
 rte_afu_device *afu_dev)
 	}
 
 	ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name);
-	if (ret)
-		goto end;
+
 end:
 	if (kvlist)
Quoted 3 lines

rte_kvargs_free(kvlist);
--
1.8.3.1