PCI: altera: Fix no return warning for altera_pcie_irq_teardown()
PATCH 1/1 PCI: altera: Fix no return warning for altera_pcie_irq_teardown()
Fix compilation warning caused by patch "PCI: altera: Allow building as module".
drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
}
--- drivers/pci/controller/pcie-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pcie-altera.c +1 -1
@@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)return 0 ; } -static int altera_pcie_irq_teardown (struct altera_pcie *pcie) +static void altera_pcie_irq_teardown (struct altera_pcie *pcie) {irq_set_chained_handler_and_data (pcie->irq,NULL ,NULL );irq_domain_remove (pcie->irq_domain);
Signature · 1 line
2.19.0
Quoted 26 lines · Ley Foon Tan
Fix compilation warning caused by patch "PCI: altera: Allow building as module".
drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
}Signed-off-by Ley Foon Tan <[email protected]>--- drivers/pci/controller/pcie-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/controller/pcie-altera.c +1
-2@@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)return 0 ; } -static int altera_pcie_irq_teardown (struct altera_pcie *pcie) +static void altera_pcie_irq_teardown (struct altera_pcie *pcie) {irq_set_chained_handler_and_data (pcie->irq,NULL ,NULL );irq_domain_remove (pcie->irq_domain); --
Quoted 2 lines
2.19.0
Hi
You can squash this patch to this https://lkml.org/lkml/2019/4/24/18
"PCI: altera: Allow building as module" if want.
Thanks.
Regards
Ley Foon
Quoted 31 lines · Ley Foon Tan
Quoted 26 lines · Ley Foon Tan
Fix compilation warning caused by patch "PCI: altera: Allow building as module".
drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
}Signed-off-by Ley Foon Tan <[email protected]>--- drivers/pci/controller/pcie-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/controller/pcie-altera.c +1
-2@@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)return 0 ; } -static int altera_pcie_irq_teardown (struct altera_pcie *pcie) +static void altera_pcie_irq_teardown (struct altera_pcie *pcie) {irq_set_chained_handler_and_data (pcie->irq,NULL ,NULL );irq_domain_remove (pcie->irq_domain); --Quoted 2 lines
2.19.0
Hi
Quoted 2 lines
You can squash this patch to this https://lkml.org/lkml/2019/4/24/18
"PCI: altera: Allow building as module" if want.
Done, thanks.
Lorenzo