Skip to contentSkip to conversation

PCI: altera: Fix no return warning for altera_pcie_irq_teardown()

PATCH In review Ley Foon Tan 3 participants 3 messages May 24, 2019 – May 30, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: altera: Fix no return warning for altera_pcie_irq_teardown()

Fix compilation warning caused by patch "PCI: altera: Allow building as module".

drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:
drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
}

---
 drivers/pci/controller/pcie-altera.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pcie-altera.c +1 -1
index 6c86bc69ace8..27222071ace7 100644
@@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
 	return 0;
 }
 
-static int altera_pcie_irq_teardown(struct altera_pcie *pcie)
+static void altera_pcie_irq_teardown(struct altera_pcie *pcie)
 {
 	irq_set_chained_handler_and_data(pcie->irq, NULL, NULL);
 	irq_domain_remove(pcie->irq_domain);
Signature · 1 line
2.19.0
#1 lore raw
Quoted 26 lines · Ley Foon Tan

Fix compilation warning caused by patch "PCI: altera: Allow building as module".

drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:
drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
}

---
 drivers/pci/controller/pcie-altera.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pcie-altera.c +1 -2
index 6c86bc69ace8..27222071ace7 100644
@@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
        return 0;
 }
 
-static int altera_pcie_irq_teardown(struct altera_pcie *pcie)
+static void altera_pcie_irq_teardown(struct altera_pcie *pcie)
 {
        irq_set_chained_handler_and_data(pcie->irq, NULL, NULL);
        irq_domain_remove(pcie->irq_domain);
--
Quoted 2 lines

2.19.0

Hi

You can squash this patch to this https://lkml.org/lkml/2019/4/24/18
"PCI: altera: Allow building as module" if want.

Thanks.

Regards
Ley Foon

#2 lore raw
Quoted 31 lines · Ley Foon Tan
Quoted 26 lines · Ley Foon Tan

Fix compilation warning caused by patch "PCI: altera: Allow building as module".

drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:
drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
}

---
 drivers/pci/controller/pcie-altera.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pcie-altera.c +1 -2
index 6c86bc69ace8..27222071ace7 100644
@@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
        return 0;
 }
 
-static int altera_pcie_irq_teardown(struct altera_pcie *pcie)
+static void altera_pcie_irq_teardown(struct altera_pcie *pcie)
 {
        irq_set_chained_handler_and_data(pcie->irq, NULL, NULL);
        irq_domain_remove(pcie->irq_domain);
--
Quoted 2 lines

2.19.0

Hi

Quoted 2 lines

You can squash this patch to this https://lkml.org/lkml/2019/4/24/18
"PCI: altera: Allow building as module" if want.

Done, thanks.

Lorenzo