Skip to contentSkip to conversation

sparc: perf: fix updated event period in response to PERF_EVENT_IOC_PERIOD

PATCH Applied Young Xiao 2 participants 2 messages May 29, 2019 – Jun 3, 2019

Subsystems (2)
lore
Share & tools
lore

Young Xiao

author
#0 lore raw

PATCH 1/1 sparc: perf: fix updated event period in response to PERF_EVENT_IOC_PERIOD

The PERF_EVENT_IOC_PERIOD ioctl command can be used to change the sample period of a running perf_event. Consequently, when calculating the next event period, the new period will only be considered after the previous one has overflowed.

This patch changes the calculation of the remaining event ticks so that they are offset if the period has changed.

See commit 3581fe0ef37c ("ARM: 7556/1: perf: fix updated event period in response to PERF_EVENT_IOC_PERIOD") for details.

---
 arch/sparc/kernel/perf_event.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/sparc/kernel/perf_event.c +4 -0
index 6de7c68..a58ae9c 100644
@@ -891,6 +891,10 @@ static int sparc_perf_event_set_period(struct perf_event *event,
 	s64 period = hwc->sample_period;
 	int ret = 0;
 
+	/* The period may have been changed by PERF_EVENT_IOC_PERIOD */
+	if (unlikely(period != hwc->last_period))
+		left = period - (hwc->last_period - left);
+
 	if (unlikely(left <= -period)) {
 		left = period;
 		local64_set(&hwc->period_left, left);
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

From: Young Xiao <[email protected]>
Date: Wed, 29 May 2019 10:21:48 +0800

Quoted 5 lines

The PERF_EVENT_IOC_PERIOD ioctl command can be used to change the sample period of a running perf_event. Consequently, when calculating the next event period, the new period will only be considered after the previous one has overflowed.

Quoted 7 lines

This patch changes the calculation of the remaining event ticks so that they are offset if the period has changed.

See commit 3581fe0ef37c ("ARM: 7556/1: perf: fix updated event period in response to PERF_EVENT_IOC_PERIOD") for details.

Applied, thanks.