drm/amd/powerplay: avoid possible buffer overflow
Subsystems (2)
PATCH 1/1 drm/amd/powerplay: avoid possible buffer overflow
Make sure the clock level enforced is within the allowed ranges in case PP_SCLK and PP_MCLK.
Signed-off-by Young Xiao <[email protected]>
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +12 -0
@@ -1836,6 +1836,12 @@ static int vega12_force_clock_level(struct pp_hwmgr *hwmgr,case PP_SCLK : soft_min_level = mask ? (ffs (mask) -1 ) :0 ; soft_max_level = mask ? (fls (mask) -1 ) :0 ; +if (soft_max_level >= data->dpm_table.gfx_table.count) { +pr_err ("Clock level specified %d is over max allowed %d\n" , + soft_max_level, + data->dpm_table.gfx_table.count -1 ); +return -EINVAL ; + } data->dpm_table.gfx_table.dpm_state.soft_min_level = data->dpm_table.gfx_table.dpm_levels[soft_min_level].value;
@@ -1856,6 +1862,12 @@ static int vega12_force_clock_level(struct pp_hwmgr *hwmgr,case PP_MCLK : soft_min_level = mask ? (ffs (mask) -1 ) :0 ; soft_max_level = mask ? (fls (mask) -1 ) :0 ; +if (soft_max_level >= data->dpm_table.gfx_table.count) { +pr_err ("Clock level specified %d is over max allowed %d\n" , + soft_max_level, + data->dpm_table.gfx_table.count -1 ); +return -EINVAL ; + } data->dpm_table.mem_table.dpm_state.soft_min_level = data->dpm_table.mem_table.dpm_levels[soft_min_level].value;
Signature · 1 line
2.7.4