Skip to contentSkip to conversation

crypto/octeontx: sync mbox changes done in kernel drv

PATCH Superseded Anoob Joseph 2 participants 4 messages May 29, 2019 – Jun 19, 2019 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto/octeontx: sync mbox changes done in kernel drv

From: Lukasz Bartosik <[email protected]>

Synchronize mbox with latest changes in kernel driver

Change-Id I2123bf5a0784eab2604cc2c82eead0af16e745ff
---
 drivers/crypto/octeontx/otx_cryptodev_mbox.c |  3 +++
 drivers/crypto/octeontx/otx_cryptodev_mbox.h | 12 +++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)
drivers/crypto/octeontx/otx_cryptodev_mbox.c +3 -0
index a8e51a8..daba776 100644
@@ -24,6 +24,9 @@ otx_cpt_handle_mbox_intr(struct cpt_vf *cptvf)
 	CPT_LOG_DP_DEBUG("%s: Mailbox msg 0x%lx from PF",
 		    cptvf->dev_name, (unsigned int long)mbx.msg);
 	switch (mbx.msg) {
+	case OTX_CPT_MSG_VF_UP:
+		cptvf->pf_acked = true;
+		break;
 	case OTX_CPT_MSG_READY:
 		{
 			otx_cpt_chipid_vfid_t cid;
drivers/crypto/octeontx/otx_cryptodev_mbox.h +5 -7
index b05d1c5..2d2e0e6 100644
@@ -15,11 +15,6 @@
 
 #define OTX_CPT_MBOX_MSG_TIMEOUT    2000 /* In Milli Seconds */
 
-#define OTX_CPT_MBOX_MSG_TYPE_REQ	0
-#define OTX_CPT_MBOX_MSG_TYPE_ACK	1
-#define OTX_CPT_MBOX_MSG_TYPE_NACK	2
-#define OTX_CPT_MBOX_MSG_TYPE_NOP	3
-
 /* CPT mailbox structure */
 struct cpt_mbox {
 	/** Message type MBOX[0] */
@@ -28,7 +23,8 @@ struct cpt_mbox {
 	uint64_t data;
 };
 
-typedef enum {
+/* PF-VF message opcodes */
+enum otx_cpt_mbox_opcode {
 	OTX_CPT_MSG_VF_UP = 1,
 	OTX_CPT_MSG_VF_DOWN,
 	OTX_CPT_MSG_READY,
@@ -36,7 +32,9 @@ typedef enum {
 	OTX_CPT_MSG_QBIND_GRP,
 	OTX_CPT_MSG_VQ_PRIORITY,
 	OTX_CPT_MSG_PF_TYPE,
-} otx_cpt_mbox_opcode_t;
+	OTX_CPT_MBOX_MSG_TYPE_ACK,
+	OTX_CPT_MBOX_MSG_TYPE_NACK
+};
 
 typedef union {
 	uint64_t u64;
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 crypto/octeontx: sync mbox changes done in kernel driver

From: Lukasz Bartosik <[email protected]>

Synchronize mbox with latest changes in kernel driver

---
 drivers/crypto/octeontx/otx_cryptodev_mbox.c |  3 +++
 drivers/crypto/octeontx/otx_cryptodev_mbox.h | 12 +++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)
drivers/crypto/octeontx/otx_cryptodev_mbox.c +3 -0
index a8e51a8..daba776 100644
@@ -24,6 +24,9 @@ otx_cpt_handle_mbox_intr(struct cpt_vf *cptvf)
 	CPT_LOG_DP_DEBUG("%s: Mailbox msg 0x%lx from PF",
 		    cptvf->dev_name, (unsigned int long)mbx.msg);
 	switch (mbx.msg) {
+	case OTX_CPT_MSG_VF_UP:
+		cptvf->pf_acked = true;
+		break;
 	case OTX_CPT_MSG_READY:
 		{
 			otx_cpt_chipid_vfid_t cid;
drivers/crypto/octeontx/otx_cryptodev_mbox.h +5 -7
index b05d1c5..2d2e0e6 100644
@@ -15,11 +15,6 @@
 
 #define OTX_CPT_MBOX_MSG_TIMEOUT    2000 /* In Milli Seconds */
 
-#define OTX_CPT_MBOX_MSG_TYPE_REQ	0
-#define OTX_CPT_MBOX_MSG_TYPE_ACK	1
-#define OTX_CPT_MBOX_MSG_TYPE_NACK	2
-#define OTX_CPT_MBOX_MSG_TYPE_NOP	3
-
 /* CPT mailbox structure */
 struct cpt_mbox {
 	/** Message type MBOX[0] */
@@ -28,7 +23,8 @@ struct cpt_mbox {
 	uint64_t data;
 };
 
-typedef enum {
+/* PF-VF message opcodes */
+enum otx_cpt_mbox_opcode {
 	OTX_CPT_MSG_VF_UP = 1,
 	OTX_CPT_MSG_VF_DOWN,
 	OTX_CPT_MSG_READY,
@@ -36,7 +32,9 @@ typedef enum {
 	OTX_CPT_MSG_QBIND_GRP,
 	OTX_CPT_MSG_VQ_PRIORITY,
 	OTX_CPT_MSG_PF_TYPE,
-} otx_cpt_mbox_opcode_t;
+	OTX_CPT_MBOX_MSG_TYPE_ACK,
+	OTX_CPT_MBOX_MSG_TYPE_NACK
+};
 
 typedef union {
 	uint64_t u64;
Signature · 1 line
2.7.4
#2 lore raw

Re: [dpdk-dev] [PATCH v2] crypto/octeontx: sync mbox changes done in kernel driver

Hi Akhil, Pablo,

This patch is ready for merge.

Thanks,
Anoob

Quoted 78 lines

-----Original Message-----
From: Anoob Joseph <[email protected]>
Sent: Wednesday, May 29, 2019 4:14 PM
To: Akhil Goyal <[email protected]>; Pablo de Lara <[email protected]>
Cc: Lukas Bartosik <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; [email protected]; Anoob Joseph <[email protected]>
Subject: [PATCH v2] crypto/octeontx: sync mbox changes done in kernel driver

From: Lukasz Bartosik <[email protected]>

Synchronize mbox with latest changes in kernel driver

---
 drivers/crypto/octeontx/otx_cryptodev_mbox.c |  3 +++
drivers/crypto/octeontx/otx_cryptodev_mbox.h | 12 +++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)
drivers/crypto/octeontx/otx_cryptodev_mbox.c +3 -0
index a8e51a8..daba776 100644
@@ -24,6 +24,9 @@ otx_cpt_handle_mbox_intr(struct cpt_vf *cptvf)
 	CPT_LOG_DP_DEBUG("%s: Mailbox msg 0x%lx from PF",
 		    cptvf->dev_name, (unsigned int long)mbx.msg);
 	switch (mbx.msg) {
+	case OTX_CPT_MSG_VF_UP:
+		cptvf->pf_acked = true;
+		break;
 	case OTX_CPT_MSG_READY:
 		{
 			otx_cpt_chipid_vfid_t cid;
drivers/crypto/octeontx/otx_cryptodev_mbox.h +5 -8
index b05d1c5..2d2e0e6 100644
@@ -15,11 +15,6 @@
 
 #define OTX_CPT_MBOX_MSG_TIMEOUT    2000 /* In Milli Seconds */
 
-#define OTX_CPT_MBOX_MSG_TYPE_REQ	0
-#define OTX_CPT_MBOX_MSG_TYPE_ACK	1
-#define OTX_CPT_MBOX_MSG_TYPE_NACK	2
-#define OTX_CPT_MBOX_MSG_TYPE_NOP	3
-
 /* CPT mailbox structure */
 struct cpt_mbox {
 	/** Message type MBOX[0] */
@@ -28,7 +23,8 @@ struct cpt_mbox {
 	uint64_t data;
 };
 
-typedef enum {
+/* PF-VF message opcodes */
+enum otx_cpt_mbox_opcode {
 	OTX_CPT_MSG_VF_UP = 1,
 	OTX_CPT_MSG_VF_DOWN,
 	OTX_CPT_MSG_READY,
@@ -36,7 +32,9 @@ typedef enum {
 	OTX_CPT_MSG_QBIND_GRP,
 	OTX_CPT_MSG_VQ_PRIORITY,
 	OTX_CPT_MSG_PF_TYPE,
-} otx_cpt_mbox_opcode_t;
+	OTX_CPT_MBOX_MSG_TYPE_ACK,
+	OTX_CPT_MBOX_MSG_TYPE_NACK
+};
 
 typedef union {
 	uint64_t u64;
--

2.7.4

Applied
#3 lore raw

Re: [dpdk-dev] [PATCH v2] crypto/octeontx: sync mbox changes done in kernel driver

In reply to Anoob Joseph
Quoted 4 lines

From: Lukasz Bartosik <[email protected]>

Quoted 9 lines

Synchronize mbox with latest changes in kernel driver

---
 drivers/crypto/octeontx/otx_cryptodev_mbox.c |  3 +++
 drivers/crypto/octeontx/otx_cryptodev_mbox.h | 12 +++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)

Applied to dpdk-next-crypto

Thanks.