Skip to contentSkip to conversation

staging: kpc2000: Fix build failure caused by wrong include file

PATCH In review Guenter Roeck 2 participants 2 messages May 30, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: kpc2000: Fix build failure caused by wrong include file

xtensa:allmodconfig fails to build.

arch/xtensa/include/asm/uaccess.h: In function 'clear_user':
arch/xtensa/include/asm/uaccess.h:40:22: error:
implicit declaration of function 'uaccess_kernel'

uaccess_kernel() is declared in linux/uaccess.h, not asm/uaccess.h.

Fixes 7df95299b94a ("staging: kpc2000: Add DMA driver")
Cc Matt Sickler <[email protected]>
---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
index 5741d2b49a7d..e741fa753ca1 100644
@@ -8,7 +8,7 @@
 #include <linux/errno.h>    /* error codes */
 #include <linux/types.h>    /* size_t */
 #include <linux/cdev.h>
-#include <asm/uaccess.h>    /* copy_*_user */
+#include <linux/uaccess.h>    /* copy_*_user */
 #include <linux/aio.h>      /* aio stuff */
 #include <linux/highmem.h>
 #include <linux/pagemap.h>
Signature · 1 line
2.7.4
#1 lore raw
Quoted 20 lines · Guenter Roeck

xtensa:allmodconfig fails to build.

arch/xtensa/include/asm/uaccess.h: In function 'clear_user':
arch/xtensa/include/asm/uaccess.h:40:22: error:
implicit declaration of function 'uaccess_kernel'

uaccess_kernel() is declared in linux/uaccess.h, not asm/uaccess.h.

Fixes 7df95299b94a ("staging: kpc2000: Add DMA driver")
Cc Matt Sickler <[email protected]>
---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +0 -0
index 5741d2b49a7d..e741fa753ca1 100644

drivers/staging/kpc2000/kpc_dma/fileops.c line 14

Quoted 8 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
@@ -8,7 +8,7 @@
 #include <linux/errno.h>    /* error codes */
 #include <linux/types.h>    /* size_t */
 #include <linux/cdev.h>
-#include <asm/uaccess.h>    /* copy_*_user */
+#include <linux/uaccess.h>    /* copy_*_user */
 #include <linux/aio.h>      /* aio stuff */
 #include <linux/highmem.h>
 #include <linux/pagemap.h>

Already fixed by e00839f38823 ("staging: kpc2000: fix build error on xtensa") in my staging-linus branch.

thanks,

greg k-h