Skip to contentSkip to conversation

IB/mlx5: Limit to 64-bit builds

PATCH In review Guenter Roeck 2 participants 3 messages May 30, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/mlx5: Limit to 64-bit builds

32-bit builds fail with errors such as

ERROR: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!

Fixes 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
Cc Ariel Levkovich <[email protected]>
---
 drivers/infiniband/hw/mlx5/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/Kconfig +1 -1
index ea248def4556..574b97da7a43 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config MLX5_INFINIBAND
 	tristate "Mellanox 5th generation network adapters (ConnectX series) support"
-	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
+	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE && 64BIT
 	---help---
 	  This driver provides low-level InfiniBand support for
 	  Mellanox Connect-IB PCI Express host channel adapters (HCAs).
Signature · 1 line
2.7.4
#1 lore raw
Quoted 3 lines · Guenter Roeck

32-bit builds fail with errors such as

ERROR: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!

It is fixed in rdma-rc.
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=wip/jgg-for-rc&id=37eb86c4507abcb14fc346863e83aa8751aa4675

Thanks

Quoted 24 lines
Fixes 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
Cc Ariel Levkovich <[email protected]>
---
 drivers/infiniband/hw/mlx5/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/Kconfig +1 -2
index ea248def4556..574b97da7a43 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config MLX5_INFINIBAND
 	tristate "Mellanox 5th generation network adapters (ConnectX series) support"
-	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
+	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE && 64BIT
 	---help---
 	  This driver provides low-level InfiniBand support for
 	  Mellanox Connect-IB PCI Express host channel adapters (HCAs).
--

2.7.4

#2 lore raw
Quoted 8 lines · Leon Romanovsky
Quoted 3 lines · Guenter Roeck

32-bit builds fail with errors such as

ERROR: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!

It is fixed in rdma-rc.
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=wip/jgg-for-rc&id=37eb86c4507abcb14fc346863e83aa8751aa4675

Excellent, and sorry for the noise.

Guenter

Quoted 27 lines

Thanks

Quoted 24 lines
Fixes 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
Cc Ariel Levkovich <[email protected]>
---
  drivers/infiniband/hw/mlx5/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/Kconfig +1 -2
index ea248def4556..574b97da7a43 100644
@@ -1,7 +1,7 @@
  # SPDX-License-Identifier: GPL-2.0-only
  config MLX5_INFINIBAND
  	tristate "Mellanox 5th generation network adapters (ConnectX series) support"
-	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
+	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE && 64BIT
  	---help---
  	  This driver provides low-level InfiniBand support for
  	  Mellanox Connect-IB PCI Express host channel adapters (HCAs).
--

2.7.4