tracing/probe: Add multi-probes per event support
Subsystems (3)
Masami Hiramatsu
maintainercover tracing/probe: Add multi-probes per event support
Hello,
This is a series to add multi-probes per event support to probe-event.
For trace-event, we can insert same trace-event on several places on the code, and those can record similar information as a same event with same format.
This series implements similar feature on probe-event. Since the probe event is based on the compiled binary, sometimes we find that the target source line is complied into several different addresses, e.g. inlined function, unrolled loop, etc. In those cases, it is useful to put a same probe-event on different addresses.
With this series, we can append multi probes on one event as below
# echo p:testevent _do_fork r1=%ax r2=%dx > kprobe_events # echo p:testevent fork_idle r1=%ax r2=%cx >> kprobe_events # kprobe_events p:kprobes/testevent _do_fork r1=%ax r2=%dx p:kprobes/testevent fork_idle r1=%ax r2=%cx
This means testevent is hit on both of _do_fork and fork_idle. As you can see, the appended event must have same number of arguments and those must have same 'type' and 'name' as original one. This is like a function signature, it checks whether the appending event has the same type and name of event arguments and same probe type, but doesn't care about the assignment.
So, below appending commands will be rejected.
# echo p:testevent _do_fork r1=%ax r2=%dx > kprobe_events # echo p:testevent fork_idle r1=%ax >> kprobe_events (No 2nd argument) # echo p:testevent fork_idle r1=%ax r2=%ax:x8 >> kprobe_events (The type of 2nd argument is different)
If one inlined code has an argument on a register, but another inlined code has fixed value (as a result of optimization), you can also specify the fixed immediate value, e.g.
# echo p:testevent _do_fork r1=%ax r2=%dx > kprobe_events # echo p:testevent fork_idle r1=%ax r2=\1 >> kprobe_events
Of course, it is hard to find those assignment changes by manual. I'm preparing another series of patches for perf-probe, which will automatically find such "cloned" targets and fold those into one event.
(Should I merge that series into this series?)
Thank you,
---
Masami Hiramatsu (21):
tracing/kprobe: Set print format right after parsed command tracing/uprobe: Set print format when parsing command tracing/probe: Add trace_probe init and free functions tracing/probe: Add trace_event_call register API for trace_probe tracing/probe: Add trace_event_file access APIs for trace_probe tracing/probe: Add trace flag access APIs for trace_probe tracing/probe: Add probe event name and group name accesses APIs tracing/probe: Add trace_event_call accesses APIs tracing/kprobe: Check registered state using kprobe tracing/probe: Split trace_event related data from trace_probe tracing/dynevent: Delete all matched events tracing/dynevent: Pass extra arguments to match operation tracing/kprobe: Add multi-probe per event support tracing/uprobe: Add multi-probe per uprobe event support tracing/kprobe: Add per-probe delete from event tracing/uprobe: Add per-probe delete from event tracing/probe: Add immediate parameter support tracing/probe: Add immediate string parameter support selftests/ftrace: Add a testcase for kprobe multiprobe event selftests/ftrace: Add syntax error test for immediates selftests/ftrace: Add syntax error test for multiprobe
Documentation/trace/kprobetrace.rst | 1 Documentation/trace/uprobetracer.rst | 1 kernel/trace/trace.c | 8 kernel/trace/trace_dynevent.c | 10 kernel/trace/trace_dynevent.h | 7 kernel/trace/trace_events_hist.c | 4 kernel/trace/trace_kprobe.c | 408 +++++++++++--------- kernel/trace/trace_probe.c | 247 ++++++++++++ kernel/trace/trace_probe.h | 121 +++++- kernel/trace/trace_uprobe.c | 358 ++++++++++-------- tools/testing/selftests/ftrace/test.d/functions | 2 .../ftrace/test.d/kprobe/kprobe_multiprobe.tc | 35 ++ .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 15 + 13 files changed, 830 insertions(+), 387 deletions(-) create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_multiprobe.tc
--
Masami Hiramatsu (Linaro) <[email protected]>
Masami Hiramatsu
maintainerPATCH 1/21 tracing/kprobe: Set print format right after parsed command
Set event call's print format right after parsed command for simplifying (un)register_kprobe_event().
--- kernel/trace/trace_kprobe.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-)
kernel/trace/trace_kprobe.c +9 -16
@@ -272,6 +272,7 @@ static void free_trace_kprobe(struct trace_kprobe *tk)kfree (tk->tp.call.class->system);kfree (tk->tp.call.name); +kfree (tk->tp.call.print_fmt);kfree (tk->symbol);free_percpu (tk->nhit);kfree (tk);
@@ -730,6 +731,10 @@ static int trace_kprobe_create(int argc, const char *argv[]) goto error;/* This can be -ENOMEM */ } + ret =traceprobe_set_print_fmt (&tk->tp, is_return); +if (ret <0 ) + goto error; + ret =register_trace_kprobe (tk);if (ret) {trace_probe_log_set_index (1 );
@@ -1416,18 +1421,14 @@ static int register_kprobe_event(struct trace_kprobe *tk)init_trace_event_call (tk, call); -if (traceprobe_set_print_fmt (&tk->tp,trace_kprobe_is_return (tk)) <0 ) -return -ENOMEM ; ret =register_trace_event (&call->event); -if (!ret) { -kfree (call->print_fmt); +if (!ret)return -ENODEV ; - } + ret =trace_add_event_call (call);if (ret) {pr_info ("Failed to register kprobe event: %s\n" ,trace_event_name (call)); -kfree (call->print_fmt);unregister_trace_event (&call->event); }return ret;
@@ -1435,13 +1436,8 @@ static int register_kprobe_event(struct trace_kprobe *tk)static int unregister_kprobe_event (struct trace_kprobe *tk) { -int ret; -/* tp->event is unregistered in trace_remove_event_call() */ - ret =trace_remove_event_call (&tk->tp.call); -if (!ret) -kfree (tk->tp.call.print_fmt); -return ret; +return trace_remove_event_call (&tk->tp.call); }#ifdef CONFIG_PERF_EVENTS
@@ -1479,10 +1475,8 @@ create_local_trace_kprobe(char *func, void *addr, unsigned long offs, } ret =__register_trace_kprobe (tk); -if (ret <0 ) { -kfree (tk->tp.call.print_fmt); +if (ret <0 ) goto error; - }return &tk->tp.call; error:
@@ -1503,7 +1497,6 @@ void destroy_local_trace_kprobe(struct trace_event_call *event_call)__unregister_trace_kprobe (tk); -kfree (tk->tp.call.print_fmt); free_trace_kprobe(tk); }#endif /* CONFIG_PERF_EVENTS */
Masami Hiramatsu
maintainerPATCH 2/21 tracing/uprobe: Set print format when parsing command
In reply to Masami HiramatsuSet event call's print format right after parsed command for simplifying (un)register_uprobe_event().
--- kernel/trace/trace_uprobe.c | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-)
kernel/trace/trace_uprobe.c +7 -18
@@ -345,6 +345,7 @@ static void free_trace_uprobe(struct trace_uprobe *tu)path_put (&tu->path);kfree (tu->tp.call.class->system);kfree (tu->tp.call.name); +kfree (tu->tp.call.print_fmt);kfree (tu->filename);kfree (tu); }
@@ -592,6 +593,10 @@ static int trace_uprobe_create(int argc, const char **argv) goto error; } + ret =traceprobe_set_print_fmt (&tu->tp,is_ret_probe (tu)); +if (ret <0 ) + goto error; + ret =register_trace_uprobe (tu);if (!ret) goto out;
@@ -1362,21 +1367,15 @@ static int register_uprobe_event(struct trace_uprobe *tu)init_trace_event_call (tu, call); -if (traceprobe_set_print_fmt (&tu->tp,is_ret_probe (tu)) <0 ) -return -ENOMEM ; - ret =register_trace_event (&call->event); -if (!ret) { -kfree (call->print_fmt); +if (!ret)return -ENODEV ; - } ret =trace_add_event_call (call);if (ret) {pr_info ("Failed to register uprobe event: %s\n" ,trace_event_name (call)); -kfree (call->print_fmt);unregister_trace_event (&call->event); }
@@ -1385,15 +1384,8 @@ static int register_uprobe_event(struct trace_uprobe *tu)static int unregister_uprobe_event (struct trace_uprobe *tu) { -int ret; -/* tu->event is unregistered in trace_remove_event_call() */ - ret =trace_remove_event_call (&tu->tp.call); -if (ret) -return ret; -kfree (tu->tp.call.print_fmt); - tu->tp.call.print_fmt =NULL ; -return 0 ; +return trace_remove_event_call (&tu->tp.call); }#ifdef CONFIG_PERF_EVENTS
@@ -1452,9 +1444,6 @@ void destroy_local_trace_uprobe(struct trace_event_call *event_call) tu = container_of(event_call, struct trace_uprobe, tp.call); -kfree (tu->tp.call.print_fmt); - tu->tp.call.print_fmt =NULL ; - free_trace_uprobe(tu); }#endif /* CONFIG_PERF_EVENTS */
Masami Hiramatsu
maintainerPATCH 3/21 tracing/probe: Add trace_probe init and free functions
In reply to Masami HiramatsuAdd common trace_probe init and cleanup function in trace_probe.c, and use it from trace_kprobe.c and trace_uprobe.c
--- kernel/trace/trace_kprobe.c | 49 +++++++++++-------------------------------- kernel/trace/trace_probe.c | 36 ++++++++++++++++++++++++++++++++ kernel/trace/trace_probe.h | 4 ++++ kernel/trace/trace_uprobe.c | 27 ++++-------------------- 4 files changed, 58 insertions(+), 58 deletions(-)
kernel/trace/trace_kprobe.c +13 -36
@@ -197,6 +197,16 @@ static int kprobe_dispatcher(struct kprobe *kp, struct pt_regs *regs);static int kretprobe_dispatcher (struct kretprobe_instance *ri,struct pt_regs *regs); +static void free_trace_kprobe (struct trace_kprobe *tk) +{ +if (tk) { +trace_probe_cleanup (&tk->tp); +kfree (tk->symbol); +free_percpu (tk->nhit); +kfree (tk); + } +} +/* * Allocate new trace_probe and initialize it (including kprobes). */
@@ -235,49 +245,17 @@ static struct trace_kprobe *alloc_trace_kprobe(const char *group, tk->rp.maxactive = maxactive; -if (!event || !group) { - ret = -EINVAL ; - goto error; - } - - tk->tp.call.class = &tk->tp.class; - tk->tp.call.name =kstrdup (event,GFP_KERNEL ); -if (!tk->tp.call.name) - goto error; - - tk->tp.class.system =kstrdup (group,GFP_KERNEL ); -if (!tk->tp.class.system) + ret =trace_probe_init (&tk->tp, event, group); +if (ret <0 ) goto error;dyn_event_init (&tk->devent, &trace_kprobe_ops); -INIT_LIST_HEAD (&tk->tp.files);return tk; error: -kfree (tk->tp.call.name); -kfree (tk->symbol); -free_percpu (tk->nhit); -kfree (tk); +free_trace_kprobe (tk);return ERR_PTR (ret); } -static void free_trace_kprobe (struct trace_kprobe *tk) -{ -int i; - -if (!tk) -return ; - -for (i =0 ; i < tk->tp.nr_args; i++) -traceprobe_free_probe_arg (&tk->tp.args[i]); - -kfree (tk->tp.call.class->system); -kfree (tk->tp.call.name); -kfree (tk->tp.call.print_fmt); -kfree (tk->symbol); -free_percpu (tk->nhit); -kfree (tk); -} -static struct trace_kprobe *find_trace_kprobe (const char *event,const char *group) {
@@ -1400,7 +1378,6 @@ static struct trace_event_functions kprobe_funcs = {static inline void init_trace_event_call (struct trace_kprobe *tk,struct trace_event_call *call) { -INIT_LIST_HEAD (&call->class->fields);if (trace_kprobe_is_return (tk)) { call->event.funcs = &kretprobe_funcs; call->class->define_fields = kretprobe_event_define_fields;
kernel/trace/trace_probe.c +36 -0
@@ -884,3 +884,39 @@ int traceprobe_define_arg_fields(struct trace_event_call *event_call, }return 0 ; } + + +void trace_probe_cleanup (struct trace_probe *tp) +{ +int i; + +for (i =0 ; i < tp->nr_args; i++) +traceprobe_free_probe_arg (&tp->args[i]); + +kfree (tp->call.class->system); +kfree (tp->call.name); +kfree (tp->call.print_fmt); +} + +int trace_probe_init (struct trace_probe *tp,const char *event, +const char *group) +{ +if (!event || !group) +return -EINVAL ; + + tp->call.class = &tp->class; + tp->call.name =kstrdup (event,GFP_KERNEL ); +if (!tp->call.name) +return -ENOMEM ; + + tp->class.system =kstrdup (group,GFP_KERNEL ); +if (!tp->class.system) { +kfree (tp->call.name); + tp->call.name =NULL ; +return -ENOMEM ; + } +INIT_LIST_HEAD (&tp->files); +INIT_LIST_HEAD (&tp->class.fields); + +return 0 ; +}
kernel/trace/trace_probe.h +4 -0
@@ -248,6 +248,10 @@ static inline bool trace_probe_is_registered(struct trace_probe *tp)return !!(tp->flags &TP_FLAG_REGISTERED ); } +int trace_probe_init (struct trace_probe *tp,const char *event, +const char *group); +void trace_probe_cleanup (struct trace_probe *tp); +/* Check the name is good for event/group/fields */ static inline bool is_good_name (const char *name) {
kernel/trace/trace_uprobe.c +5 -22
@@ -300,25 +300,17 @@ static struct trace_uprobe * alloc_trace_uprobe(const char *group, const char *event, int nargs, bool is_ret) { struct trace_uprobe *tu; - -if (!event || !group) -return ERR_PTR (-EINVAL ); +int ret; tu =kzalloc (SIZEOF_TRACE_UPROBE (nargs),GFP_KERNEL );if (!tu)return ERR_PTR (-ENOMEM ); - tu->tp.call.class = &tu->tp.class; - tu->tp.call.name =kstrdup (event,GFP_KERNEL ); -if (!tu->tp.call.name) - goto error; - - tu->tp.class.system =kstrdup (group,GFP_KERNEL ); -if (!tu->tp.class.system) + ret =trace_probe_init (&tu->tp, event, group); +if (ret <0 ) goto error;dyn_event_init (&tu->devent, &trace_uprobe_ops); -INIT_LIST_HEAD (&tu->tp.files); tu->consumer.handler = uprobe_dispatcher;if (is_ret) tu->consumer.ret_handler = uretprobe_dispatcher;
@@ -326,26 +318,18 @@ alloc_trace_uprobe(const char *group, const char *event, int nargs, bool is_ret)return tu; error: -kfree (tu->tp.call.name);kfree (tu); -return ERR_PTR (-ENOMEM ); +return ERR_PTR (ret); }static void free_trace_uprobe (struct trace_uprobe *tu) { -int i; -if (!tu)return ; -for (i =0 ; i < tu->tp.nr_args; i++) -traceprobe_free_probe_arg (&tu->tp.args[i]); -path_put (&tu->path); -kfree (tu->tp.call.class->system); -kfree (tu->tp.call.name); -kfree (tu->tp.call.print_fmt); +trace_probe_cleanup (&tu->tp);kfree (tu->filename);kfree (tu); }
@@ -1351,7 +1335,6 @@ static struct trace_event_functions uprobe_funcs = {static inline void init_trace_event_call (struct trace_uprobe *tu,struct trace_event_call *call) { -INIT_LIST_HEAD (&call->class->fields); call->event.funcs = &uprobe_funcs; call->class->define_fields = uprobe_event_define_fields;
Masami Hiramatsu
maintainerPATCH 4/21 tracing/probe: Add trace_event_call register API for trace_probe
In reply to Masami HiramatsuSince trace_event_call is a field of trace_probe, these operations should be done in trace_probe.c. trace_kprobe and trace_uprobe use new functions to register/unregister trace_event_call.
--- kernel/trace/trace_kprobe.c | 20 +++----------------- kernel/trace/trace_probe.c | 16 ++++++++++++++++ kernel/trace/trace_probe.h | 6 ++++++ kernel/trace/trace_uprobe.c | 22 +++------------------- 4 files changed, 28 insertions(+), 36 deletions(-)
kernel/trace/trace_kprobe.c +3 -17
@@ -1393,28 +1393,14 @@ static inline void init_trace_event_call(struct trace_kprobe *tk,static int register_kprobe_event (struct trace_kprobe *tk) { -struct trace_event_call *call = &tk->tp.call; -int ret =0 ; - -init_trace_event_call (tk, call); - - ret =register_trace_event (&call->event); -if (!ret) -return -ENODEV ; +init_trace_event_call (tk, &tk->tp.call); - ret =trace_add_event_call (call); -if (ret) { -pr_info ("Failed to register kprobe event: %s\n" , -trace_event_name (call)); -unregister_trace_event (&call->event); - } -return ret; +return trace_probe_register_event_call (&tk->tp); }static int unregister_kprobe_event (struct trace_kprobe *tk) { -/* tp->event is unregistered in trace_remove_event_call() */ -return trace_remove_event_call (&tk->tp.call); +return trace_probe_unregister_event_call (&tk->tp); }#ifdef CONFIG_PERF_EVENTS
kernel/trace/trace_probe.c +16 -0
@@ -920,3 +920,19 @@ int trace_probe_init(struct trace_probe *tp, const char *event,return 0 ; } + +int trace_probe_register_event_call (struct trace_probe *tp) +{ +struct trace_event_call *call = &tp->call; +int ret; + + ret =register_trace_event (&call->event); +if (!ret) +return -ENODEV ; + + ret =trace_add_event_call (call); +if (ret) +unregister_trace_event (&call->event); + +return ret; +}
kernel/trace/trace_probe.h +6 -0
@@ -251,6 +251,12 @@ static inline bool trace_probe_is_registered(struct trace_probe *tp)int trace_probe_init (struct trace_probe *tp,const char *event,const char *group);void trace_probe_cleanup (struct trace_probe *tp); +int trace_probe_register_event_call (struct trace_probe *tp); +static inline int trace_probe_unregister_event_call (struct trace_probe *tp) +{ +/* tp->event is unregistered in trace_remove_event_call() */ +return trace_remove_event_call (&tp->call); +}/* Check the name is good for event/group/fields */ static inline bool is_good_name (const char *name)
kernel/trace/trace_uprobe.c +3 -19
@@ -1345,30 +1345,14 @@ static inline void init_trace_event_call(struct trace_uprobe *tu,static int register_uprobe_event (struct trace_uprobe *tu) { -struct trace_event_call *call = &tu->tp.call; -int ret =0 ; - -init_trace_event_call (tu, call); - - ret =register_trace_event (&call->event); -if (!ret) -return -ENODEV ; - - ret =trace_add_event_call (call); - -if (ret) { -pr_info ("Failed to register uprobe event: %s\n" , -trace_event_name (call)); -unregister_trace_event (&call->event); - } +init_trace_event_call (tu, &tu->tp.call); -return ret; +return trace_probe_register_event_call (&tu->tp); }static int unregister_uprobe_event (struct trace_uprobe *tu) { -/* tu->event is unregistered in trace_remove_event_call() */ -return trace_remove_event_call (&tu->tp.call); +return trace_probe_unregister_event_call (&tu->tp); }#ifdef CONFIG_PERF_EVENTS
Masami Hiramatsu
maintainerPATCH 5/21 tracing/probe: Add trace_event_file access APIs for trace_probe
In reply to Masami HiramatsuAdd trace_event_file access APIs for trace_probe data structure. This simplifies enabling/disabling operations in uprobe and kprobe events so that those don't touch deep inside the trace_probe.
This also removing a redundant synchronization when the kprobe event is used from perf, since the perf itself uses tracepoint_synchronize_unregister() after disabling (ftrace- defined) event, thus we don't have to synchronize in that path. Also we don't need to identify local trace_kprobe too anymore.
--- kernel/trace/trace_kprobe.c | 85 +++++++++++++++---------------------------- kernel/trace/trace_probe.c | 47 ++++++++++++++++++++++++ kernel/trace/trace_probe.h | 36 ++++++++++-------- kernel/trace/trace_uprobe.c | 42 +++++++-------------- 4 files changed, 109 insertions(+), 101 deletions(-)
kernel/trace/trace_kprobe.c +29 -56
@@ -290,34 +290,27 @@ static inline int __enable_trace_kprobe(struct trace_kprobe *tk)static int enable_trace_kprobe (struct trace_kprobe *tk,struct trace_event_file *file) { -struct event_file_link *link; +bool enabled =trace_probe_is_enabled (&tk->tp);int ret =0 ;if (file) { - link =kmalloc (sizeof (*link),GFP_KERNEL ); -if (!link) { - ret = -ENOMEM ; - goto out; - } - - link->file = file; -list_add_tail_rcu (&link->list, &tk->tp.files); + ret =trace_probe_add_file (&tk->tp, file); +if (ret) +return ret; + }else + tk->tp.flags |=TP_FLAG_PROFILE ; - tk->tp.flags |=TP_FLAG_TRACE ; - ret =__enable_trace_kprobe (tk); -if (ret) { -list_del_rcu (&link->list); -kfree (link); - tk->tp.flags &= ~TP_FLAG_TRACE ; - } +if (enabled) +return 0 ; - }else { - tk->tp.flags |=TP_FLAG_PROFILE ; - ret =__enable_trace_kprobe (tk); -if (ret) + ret =__enable_trace_kprobe (tk); +if (ret) { +if (file) +trace_probe_remove_file (&tk->tp, file); +else tk->tp.flags &= ~TP_FLAG_PROFILE ; } - out: +return ret; }
@@ -328,54 +321,34 @@ enable_trace_kprobe(struct trace_kprobe *tk, struct trace_event_file *file)static int disable_trace_kprobe (struct trace_kprobe *tk,struct trace_event_file *file) { -struct event_file_link *link =NULL ; -int wait =0 ; +struct trace_probe *tp = &tk->tp;int ret =0 ;if (file) { - link =find_event_file_link (&tk->tp, file); -if (!link) { - ret = -EINVAL ; - goto out; - } - -list_del_rcu (&link->list); - wait =1 ; -if (!list_empty (&tk->tp.files)) +if (!trace_probe_get_file_link (tp, file)) +return -ENOENT ; +if (!trace_probe_has_single_file (tp)) goto out; - - tk->tp.flags &= ~TP_FLAG_TRACE ; + tp->flags &= ~TP_FLAG_TRACE ; }else - tk->tp.flags &= ~TP_FLAG_PROFILE ; + tp->flags &= ~TP_FLAG_PROFILE ; -if (!trace_probe_is_enabled (&tk->tp) &&trace_probe_is_registered (&tk->tp)) { +if (!trace_probe_is_enabled (tp) &&trace_probe_is_registered (tp)) {if (trace_kprobe_is_return (tk))disable_kretprobe (&tk->rp);else disable_kprobe (&tk->rp.kp); - wait =1 ; } -/* -* if tk is not added to any list, it must be a local trace_kprobe -* created with perf_event_open. We don't need to wait for these -* trace_kprobes -*/ -if (list_empty (&tk->devent.list)) - wait =0 ; out: -if (wait) { +if (file)/* -* Synchronize with kprobe_trace_func/kretprobe_trace_func -* to ensure disabled (all running handlers are finished). -* This is not only for kfree(), but also the caller, -* trace_remove_event_call() supposes it for releasing -* event_call related objects, which will be accessed in -* the kprobe_trace_func/kretprobe_trace_func. +* Synchronization is done in below function. For perf event, +* file == NULL and perf_trace_event_unreg() calls +* tracepoint_synchronize_unregister() to ensure synchronize +* event. We don't need to care about it. */ -synchronize_rcu (); -kfree (link);/* Ignored if link == NULL */ - } +trace_probe_remove_file (tp, file);return ret; }
@@ -1044,7 +1017,7 @@ kprobe_trace_func(struct trace_kprobe *tk, struct pt_regs *regs) {struct event_file_link *link; -list_for_each_entry_rcu (link, &tk->tp.files, list) +trace_probe_for_each_link_rcu (link, &tk->tp)__kprobe_trace_func (tk, regs, link->file); }NOKPROBE_SYMBOL (kprobe_trace_func);
@@ -1094,7 +1067,7 @@ kretprobe_trace_func(struct trace_kprobe *tk, struct kretprobe_instance *ri, {struct event_file_link *link; -list_for_each_entry_rcu (link, &tk->tp.files, list) +trace_probe_for_each_link_rcu (link, &tk->tp)__kretprobe_trace_func (tk, ri, regs, link->file); }NOKPROBE_SYMBOL (kretprobe_trace_func);
kernel/trace/trace_probe.c +47 -0
50 lines not on this page · raw message
kernel/trace/trace_probe.h +20 -16
@@ -248,16 +248,32 @@ static inline bool trace_probe_is_registered(struct trace_probe *tp)return !!(tp->flags &TP_FLAG_REGISTERED ); } -int trace_probe_init (struct trace_probe *tp,const char *event, -const char *group); -void trace_probe_cleanup (struct trace_probe *tp); -int trace_probe_register_event_call (struct trace_probe *tp);static inline int trace_probe_unregister_event_call (struct trace_probe *tp) {/* tp->event is unregistered in trace_remove_event_call() */ return trace_remove_event_call (&tp->call); } +static inline bool trace_probe_has_single_file (struct trace_probe *tp) +{ +return !!list_is_singular (&tp->files); +} + +int trace_probe_init (struct trace_probe *tp,const char *event, +const char *group); +void trace_probe_cleanup (struct trace_probe *tp); +int trace_probe_register_event_call (struct trace_probe *tp); +int trace_probe_add_file (struct trace_probe *tp,struct trace_event_file *file); +int trace_probe_remove_file (struct trace_probe *tp, +struct trace_event_file *file); +struct event_file_link *trace_probe_get_file_link (struct trace_probe *tp, +struct trace_event_file *file); + +#define trace_probe_for_each_link (pos, tp) \ + list_for_each_entry(pos, &(tp)->files, list) +#define trace_probe_for_each_link_rcu (pos, tp) \ + list_for_each_entry_rcu(pos, &(tp)->files, list) +/* Check the name is good for event/group/fields */ static inline bool is_good_name (const char *name) {
@@ -270,18 +286,6 @@ static inline bool is_good_name(const char *name)return true; } -static inline struct event_file_link * -find_event_file_link (struct trace_probe *tp,struct trace_event_file *file) -{ -struct event_file_link *link; - -list_for_each_entry (link, &tp->files, list) -if (link->file == file) -return link; - -return NULL ; -} -#define TPARG_FL_RETURN BIT(0)#define TPARG_FL_KERNEL BIT(1)#define TPARG_FL_FENTRY BIT(2)
kernel/trace/trace_uprobe.c +13 -29
87 lines not on this page · raw message
Masami Hiramatsu
maintainerPATCH 6/21 tracing/probe: Add trace flag access APIs for trace_probe
In reply to Masami HiramatsuAdd trace_probe_test/set/clear_flag() functions for accessing trace_probe.flag field.
This flags field should not be accessed directly.
--- kernel/trace/trace_kprobe.c | 20 ++++++++++---------- kernel/trace/trace_probe.c | 4 ++-- kernel/trace/trace_probe.h | 22 ++++++++++++++++++++-- kernel/trace/trace_uprobe.c | 18 +++++++++--------- 4 files changed, 41 insertions(+), 23 deletions(-)
kernel/trace/trace_kprobe.c +10 -10
@@ -298,7 +298,7 @@ enable_trace_kprobe(struct trace_kprobe *tk, struct trace_event_file *file)if (ret)return ret; }else - tk->tp.flags |=TP_FLAG_PROFILE ; +trace_probe_set_flag (&tk->tp,TP_FLAG_PROFILE );if (enabled)return 0 ;
@@ -308,7 +308,7 @@ enable_trace_kprobe(struct trace_kprobe *tk, struct trace_event_file *file)if (file)trace_probe_remove_file (&tk->tp, file);else - tk->tp.flags &= ~TP_FLAG_PROFILE ; +trace_probe_clear_flag (&tk->tp,TP_FLAG_PROFILE ); }return ret;
@@ -329,9 +329,9 @@ disable_trace_kprobe(struct trace_kprobe *tk, struct trace_event_file *file)return -ENOENT ;if (!trace_probe_has_single_file (tp)) goto out; - tp->flags &= ~TP_FLAG_TRACE ; +trace_probe_clear_flag (tp,TP_FLAG_TRACE ); }else - tp->flags &= ~TP_FLAG_PROFILE ; +trace_probe_clear_flag (tp,TP_FLAG_PROFILE );if (!trace_probe_is_enabled (tp) &&trace_probe_is_registered (tp)) {if (trace_kprobe_is_return (tk))
@@ -408,7 +408,7 @@ static int __register_trace_kprobe(struct trace_kprobe *tk) ret =register_kprobe (&tk->rp.kp);if (ret ==0 ) - tk->tp.flags |=TP_FLAG_REGISTERED ; +trace_probe_set_flag (&tk->tp,TP_FLAG_REGISTERED );return ret; }
@@ -420,7 +420,7 @@ static void __unregister_trace_kprobe(struct trace_kprobe *tk)unregister_kretprobe (&tk->rp); else unregister_kprobe(&tk->rp.kp); - tk->tp.flags &= ~TP_FLAG_REGISTERED ; +trace_probe_clear_flag (&tk->tp,TP_FLAG_REGISTERED );/* Cleanup kprobe for reuse */ if (tk->rp.kp.symbol_name) tk->rp.kp.addr =NULL ;
@@ -1313,10 +1313,10 @@ static int kprobe_dispatcher(struct kprobe *kp, struct pt_regs *regs)raw_cpu_inc (*tk->nhit); -if (tk->tp.flags &TP_FLAG_TRACE ) +if (trace_probe_test_flag (&tk->tp,TP_FLAG_TRACE ))kprobe_trace_func (tk, regs);#ifdef CONFIG_PERF_EVENTS -if (tk->tp.flags &TP_FLAG_PROFILE ) +if (trace_probe_test_flag (&tk->tp,TP_FLAG_PROFILE )) ret =kprobe_perf_func (tk, regs);#endif return ret;
@@ -1330,10 +1330,10 @@ kretprobe_dispatcher(struct kretprobe_instance *ri, struct pt_regs *regs)raw_cpu_inc (*tk->nhit); -if (tk->tp.flags &TP_FLAG_TRACE ) +if (trace_probe_test_flag (&tk->tp,TP_FLAG_TRACE ))kretprobe_trace_func (tk, ri, regs);#ifdef CONFIG_PERF_EVENTS -if (tk->tp.flags &TP_FLAG_PROFILE ) +if (trace_probe_test_flag (&tk->tp,TP_FLAG_PROFILE ))kretprobe_perf_func (tk, ri, regs);#endif return 0 ;/* We don't tweek kernel, so just return 0 */
kernel/trace/trace_probe.c +2 -2
@@ -948,7 +948,7 @@ int trace_probe_add_file(struct trace_probe *tp, struct trace_event_file *file) link->file = file;INIT_LIST_HEAD (&link->list);list_add_tail_rcu (&link->list, &tp->files); - tp->flags |=TP_FLAG_TRACE ; +trace_probe_set_flag (tp,TP_FLAG_TRACE );return 0 ; }
@@ -979,7 +979,7 @@ int trace_probe_remove_file(struct trace_probe *tp,kfree (link);if (list_empty (&tp->files)) - tp->flags &= ~TP_FLAG_TRACE ; +trace_probe_clear_flag (tp,TP_FLAG_TRACE );return 0 ; }
kernel/trace/trace_probe.h +20 -2
@@ -238,14 +238,32 @@ struct event_file_link {struct list_head list; }; +static inline bool trace_probe_test_flag (struct trace_probe *tp, +unsigned int flag) +{ +return !!(tp->flags & flag); +} + +static inline void trace_probe_set_flag (struct trace_probe *tp, +unsigned int flag) +{ + tp->flags |= flag; +} + +static inline void trace_probe_clear_flag (struct trace_probe *tp, +unsigned int flag) +{ + tp->flags &= ~flag; +} +static inline bool trace_probe_is_enabled (struct trace_probe *tp) { -return !!(tp->flags & (TP_FLAG_TRACE |TP_FLAG_PROFILE )); +return trace_probe_test_flag (tp,TP_FLAG_TRACE |TP_FLAG_PROFILE ); }static inline bool trace_probe_is_registered (struct trace_probe *tp) { -return !!(tp->flags &TP_FLAG_REGISTERED ); +return trace_probe_test_flag (tp,TP_FLAG_REGISTERED ); }static inline int trace_probe_unregister_event_call (struct trace_probe *tp)
kernel/trace/trace_uprobe.c +9 -9
@@ -927,17 +927,17 @@ probe_event_enable(struct trace_uprobe *tu, struct trace_event_file *file,int ret;if (file) { -if (tu->tp.flags &TP_FLAG_PROFILE ) +if (trace_probe_test_flag (&tu->tp,TP_FLAG_PROFILE ))return -EINTR ; ret =trace_probe_add_file (&tu->tp, file);if (ret <0 )return ret; }else { -if (tu->tp.flags &TP_FLAG_TRACE ) +if (trace_probe_test_flag (&tu->tp,TP_FLAG_TRACE ))return -EINTR ; - tu->tp.flags |=TP_FLAG_PROFILE ; +trace_probe_set_flag (&tu->tp,TP_FLAG_PROFILE ); }WARN_ON (!uprobe_filter_is_empty (&tu->filter));
@@ -970,7 +970,7 @@ probe_event_enable(struct trace_uprobe *tu, struct trace_event_file *file,if (file)trace_probe_remove_file (&tu->tp, file);else - tu->tp.flags &= ~TP_FLAG_PROFILE ; +trace_probe_clear_flag (&tu->tp,TP_FLAG_PROFILE );return ret; }
@@ -988,7 +988,7 @@ probe_event_disable(struct trace_uprobe *tu, struct trace_event_file *file)if (trace_probe_is_enabled (&tu->tp))return ; }else - tu->tp.flags &= ~TP_FLAG_PROFILE ; +trace_probe_clear_flag (&tu->tp,TP_FLAG_PROFILE );WARN_ON (!uprobe_filter_is_empty (&tu->filter));
@@ -1266,11 +1266,11 @@ static int uprobe_dispatcher(struct uprobe_consumer *con, struct pt_regs *regs) ucb =uprobe_buffer_get ();store_trace_args (ucb->buf, &tu->tp, regs, esize, dsize); -if (tu->tp.flags &TP_FLAG_TRACE ) +if (trace_probe_test_flag (&tu->tp,TP_FLAG_TRACE )) ret |=uprobe_trace_func (tu, regs, ucb, dsize);#ifdef CONFIG_PERF_EVENTS -if (tu->tp.flags &TP_FLAG_PROFILE ) +if (trace_probe_test_flag (&tu->tp,TP_FLAG_PROFILE )) ret |=uprobe_perf_func (tu, regs, ucb, dsize);#endif uprobe_buffer_put (ucb);
@@ -1301,11 +1301,11 @@ static int uretprobe_dispatcher(struct uprobe_consumer *con, ucb =uprobe_buffer_get ();store_trace_args (ucb->buf, &tu->tp, regs, esize, dsize); -if (tu->tp.flags &TP_FLAG_TRACE ) +if (trace_probe_test_flag (&tu->tp,TP_FLAG_TRACE ))uretprobe_trace_func (tu, func, regs, ucb, dsize);#ifdef CONFIG_PERF_EVENTS -if (tu->tp.flags &TP_FLAG_PROFILE ) +if (trace_probe_test_flag (&tu->tp,TP_FLAG_PROFILE ))uretprobe_perf_func (tu, func, regs, ucb, dsize);#endif uprobe_buffer_put (ucb);
Masami Hiramatsu
maintainerPATCH 7/21 tracing/probe: Add probe event name and group name accesses APIs
In reply to Masami HiramatsuAdd trace_probe_name() and trace_probe_group_name() functions for accessing probe name and group name of trace_probe.
--- kernel/trace/trace_kprobe.c | 24 ++++++++++++------------ kernel/trace/trace_probe.h | 10 ++++++++++ kernel/trace/trace_uprobe.c | 22 +++++++++++----------- 3 files changed, 33 insertions(+), 23 deletions(-)
kernel/trace/trace_kprobe.c +12 -12
@@ -142,8 +142,8 @@ static bool trace_kprobe_match(const char *system, const char *event, {struct trace_kprobe *tk =to_trace_kprobe (ev); -return strcmp (trace_event_name (&tk->tp.call), event) ==0 && - (!system ||strcmp (tk->tp.call.class->system, system) ==0 ); +return strcmp (trace_probe_name (&tk->tp), event) ==0 && + (!system ||strcmp (trace_probe_group_name (&tk->tp), system) ==0 ); }static nokprobe_inline unsigned long trace_kprobe_nhit (struct trace_kprobe *tk)
@@ -263,8 +263,8 @@ static struct trace_kprobe *find_trace_kprobe(const char *event,struct trace_kprobe *tk;for_each_trace_kprobe (tk, pos) -if (strcmp (trace_event_name (&tk->tp.call), event) ==0 && -strcmp (tk->tp.call.class->system, group) ==0 ) +if (strcmp (trace_probe_name (&tk->tp), event) ==0 && +strcmp (trace_probe_group_name (&tk->tp), group) ==0 )return tk;return NULL ; }
@@ -453,8 +453,8 @@ static int register_trace_kprobe(struct trace_kprobe *tk)mutex_lock (&event_mutex);/* Delete old (same name) event if exist */ - old_tk =find_trace_kprobe (trace_event_name (&tk->tp.call), - tk->tp.call.class->system); + old_tk =find_trace_kprobe (trace_probe_name (&tk->tp), +trace_probe_group_name (&tk->tp));if (old_tk) { ret =unregister_trace_kprobe (old_tk);if (ret <0 )
@@ -507,7 +507,7 @@ static int trace_kprobe_module_callback(struct notifier_block *nb, ret =__register_trace_kprobe (tk);if (ret)pr_warn ("Failed to re-register probe %s on %s: %d\n" , -trace_event_name (&tk->tp.call), +trace_probe_name (&tk->tp), mod->name, ret); } }
@@ -737,8 +737,8 @@ static int trace_kprobe_show(struct seq_file *m, struct dyn_event *ev)int i;seq_putc (m,trace_kprobe_is_return (tk) ?'r' :'p' ); -seq_printf (m,":%s/%s" , tk->tp.call.class->system, -trace_event_name (&tk->tp.call)); +seq_printf (m,":%s/%s" ,trace_probe_group_name (&tk->tp), +trace_probe_name (&tk->tp));if (!tk->symbol)seq_printf (m," 0x%p" , tk->rp.kp.addr);
@@ -812,7 +812,7 @@ static int probes_profile_seq_show(struct seq_file *m, void *v) tk =to_trace_kprobe (ev);seq_printf (m," %-44s %15lu %15lu\n" , -trace_event_name (&tk->tp.call), +trace_probe_name (&tk->tp),trace_kprobe_nhit (tk), tk->rp.kp.nmissed);
@@ -1084,7 +1084,7 @@ print_kprobe_event(struct trace_iterator *iter, int flags, field = (struct kprobe_trace_entry_head *)iter->ent; tp = container_of(event, struct trace_probe, call.event); -trace_seq_printf (s,"%s: (" ,trace_event_name (&tp->call)); +trace_seq_printf (s,"%s: (" ,trace_probe_name (tp));if (!seq_print_ip_sym (s, field->ip, flags |TRACE_ITER_SYM_OFFSET )) goto out;
@@ -1111,7 +1111,7 @@ print_kretprobe_event(struct trace_iterator *iter, int flags, field = (struct kretprobe_trace_entry_head *)iter->ent; tp = container_of(event, struct trace_probe, call.event); -trace_seq_printf (s,"%s: (" ,trace_event_name (&tp->call)); +trace_seq_printf (s,"%s: (" ,trace_probe_name (tp));if (!seq_print_ip_sym (s, field->ret_ip, flags |TRACE_ITER_SYM_OFFSET )) goto out;
kernel/trace/trace_probe.h +10 -0
@@ -266,6 +266,16 @@ static inline bool trace_probe_is_registered(struct trace_probe *tp)return trace_probe_test_flag (tp,TP_FLAG_REGISTERED ); } +static inline const char *trace_probe_name (struct trace_probe *tp) +{ +return trace_event_name (&tp->call); +} + +static inline const char *trace_probe_group_name (struct trace_probe *tp) +{ +return tp->call.class->system; +} +static inline int trace_probe_unregister_event_call (struct trace_probe *tp) {/* tp->event is unregistered in trace_remove_event_call() */
kernel/trace/trace_uprobe.c +11 -11
@@ -289,8 +289,8 @@ static bool trace_uprobe_match(const char *system, const char *event, {struct trace_uprobe *tu =to_trace_uprobe (ev); -return strcmp (trace_event_name (&tu->tp.call), event) ==0 && - (!system ||strcmp (tu->tp.call.class->system, system) ==0 ); +return strcmp (trace_probe_name (&tu->tp), event) ==0 && + (!system ||strcmp (trace_probe_group_name (&tu->tp), system) ==0 ); }/*
@@ -340,8 +340,8 @@ static struct trace_uprobe *find_probe_event(const char *event, const char *groustruct trace_uprobe *tu;for_each_trace_uprobe (tu, pos) -if (strcmp (trace_event_name (&tu->tp.call), event) ==0 && -strcmp (tu->tp.call.class->system, group) ==0 ) +if (strcmp (trace_probe_name (&tu->tp), event) ==0 && +strcmp (trace_probe_group_name (&tu->tp), group) ==0 )return tu;return NULL ;
@@ -376,8 +376,8 @@ static struct trace_uprobe *find_old_trace_uprobe(struct trace_uprobe *new)struct trace_uprobe *tmp, *old =NULL ;struct inode *new_inode =d_real_inode (new->path.dentry); - old =find_probe_event (trace_event_name (&new->tp.call), - new->tp.call.class->system); + old =find_probe_event (trace_probe_name (&new->tp), +trace_probe_group_name (&new->tp));for_each_trace_uprobe (tmp, pos) { if ((old ? old != tmp : true) &&
@@ -624,8 +624,8 @@ static int trace_uprobe_show(struct seq_file *m, struct dyn_event *ev)char c =is_ret_probe (tu) ?'r' :'p' ;int i; -seq_printf (m,"%c:%s/%s %s:0x%0*lx" , c, tu->tp.call.class->system, -trace_event_name (&tu->tp.call), tu->filename, +seq_printf (m,"%c:%s/%s %s:0x%0*lx" , c,trace_probe_group_name (&tu->tp), +trace_probe_name (&tu->tp), tu->filename, (int )(sizeof (void *) *2 ), tu->offset);if (tu->ref_ctr_offset)
@@ -695,7 +695,7 @@ static int probes_profile_seq_show(struct seq_file *m, void *v) tu =to_trace_uprobe (ev);seq_printf (m," %s %-44s %15lu\n" , tu->filename, -trace_event_name (&tu->tp.call), tu->nhit); +trace_probe_name (&tu->tp), tu->nhit);return 0 ; }
@@ -896,12 +896,12 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *eif (is_ret_probe (tu)) {trace_seq_printf (s,"%s: (0x%lx <- 0x%lx)" , -trace_event_name (&tu->tp.call), +trace_probe_name (&tu->tp), entry->vaddr[1 ], entry->vaddr[0 ]); data =DATAOF_TRACE_ENTRY (entry, true); }else {trace_seq_printf (s,"%s: (0x%lx)" , -trace_event_name (&tu->tp.call), +trace_probe_name (&tu->tp), entry->vaddr[0 ]); data =DATAOF_TRACE_ENTRY (entry, false); }
Masami Hiramatsu
maintainerPATCH 8/21 tracing/probe: Add trace_event_call accesses APIs
In reply to Masami HiramatsuAdd trace_event_call access APIs for trace_probe. Instead of accessing trace_probe.call directly, use those accesses by trace_probe_event_call() method. This hides the relationship of trace_event_call and trace_probe from trace_kprobe and trace_uprobe.
--- kernel/trace/trace_kprobe.c | 23 ++++++++++++----------- kernel/trace/trace_probe.c | 24 ++++++++++++++---------- kernel/trace/trace_probe.h | 6 ++++++ kernel/trace/trace_uprobe.c | 15 ++++++++------- 4 files changed, 40 insertions(+), 28 deletions(-)
kernel/trace/trace_kprobe.c +12 -11
@@ -985,7 +985,7 @@ __kprobe_trace_func(struct trace_kprobe *tk, struct pt_regs *regs,struct ring_buffer *buffer;int size, dsize, pc;unsigned long irq_flags; -struct trace_event_call *call = &tk->tp.call; +struct trace_event_call *call =trace_probe_event_call (&tk->tp);WARN_ON (call != trace_file->event_call);
@@ -1033,7 +1033,7 @@ __kretprobe_trace_func(struct trace_kprobe *tk, struct kretprobe_instance *ri,struct ring_buffer *buffer;int size, pc, dsize;unsigned long irq_flags; -struct trace_event_call *call = &tk->tp.call; +struct trace_event_call *call =trace_probe_event_call (&tk->tp);WARN_ON (call != trace_file->event_call);
@@ -1163,7 +1163,7 @@ static int kretprobe_event_define_fields(struct trace_event_call *event_call)static int kprobe_perf_func (struct trace_kprobe *tk,struct pt_regs *regs) { -struct trace_event_call *call = &tk->tp.call; +struct trace_event_call *call =trace_probe_event_call (&tk->tp);struct kprobe_trace_entry_head *entry;struct hlist_head *head;int size, __size, dsize;
@@ -1213,7 +1213,7 @@ static void kretprobe_perf_func(struct trace_kprobe *tk, struct kretprobe_instance *ri, struct pt_regs *regs) { - struct trace_event_call *call = &tk->tp.call; + struct trace_event_call *call = trace_probe_event_call(&tk->tp);struct kretprobe_trace_entry_head *entry;struct hlist_head *head;int size, __size, dsize;
@@ -1348,9 +1348,10 @@ static struct trace_event_functions kprobe_funcs = { .trace = print_kprobe_event }; -static inline void init_trace_event_call (struct trace_kprobe *tk, -struct trace_event_call *call) +static inline void init_trace_event_call (struct trace_kprobe *tk) { +struct trace_event_call *call =trace_probe_event_call (&tk->tp); +if (trace_kprobe_is_return (tk)) { call->event.funcs = &kretprobe_funcs; call->class->define_fields = kretprobe_event_define_fields;
@@ -1366,7 +1367,7 @@ static inline void init_trace_event_call(struct trace_kprobe *tk,static int register_kprobe_event (struct trace_kprobe *tk) { -init_trace_event_call (tk, &tk->tp.call); +init_trace_event_call (tk);return trace_probe_register_event_call (&tk->tp); }
@@ -1403,7 +1404,7 @@ create_local_trace_kprobe(char *func, void *addr, unsigned long offs,return ERR_CAST (tk); } -init_trace_event_call (tk, &tk->tp.call); +init_trace_event_call (tk);if (traceprobe_set_print_fmt (&tk->tp,trace_kprobe_is_return (tk)) <0 ) { ret = -ENOMEM ;
@@ -1414,7 +1415,7 @@ create_local_trace_kprobe(char *func, void *addr, unsigned long offs,if (ret <0 ) goto error; -return &tk->tp.call; +return trace_probe_event_call (&tk->tp); error:free_trace_kprobe (tk);return ERR_PTR (ret);
@@ -1447,7 +1448,7 @@ static __init void enable_boot_kprobe_events(void)mutex_lock (&event_mutex);for_each_trace_kprobe (tk, pos) {list_for_each_entry (file, &tr->events, list) -if (file->event_call == &tk->tp.call) +if (file->event_call ==trace_probe_event_call (&tk->tp))trace_event_enable_disable (file,1 ,0 ); }mutex_unlock (&event_mutex);
@@ -1523,7 +1524,7 @@ find_trace_probe_file(struct trace_kprobe *tk, struct trace_array *tr)struct trace_event_file *file;list_for_each_entry (file, &tr->events, list) -if (file->event_call == &tk->tp.call) +if (file->event_call ==trace_probe_event_call (&tk->tp))return file;return NULL ;
kernel/trace/trace_probe.c +14 -10
@@ -844,6 +844,7 @@ static int __set_print_fmt(struct trace_probe *tp, char *buf, int len,int traceprobe_set_print_fmt (struct trace_probe *tp,bool is_return) { +struct trace_event_call *call =trace_probe_event_call (tp);int len;char *print_fmt;
@@ -855,7 +856,7 @@ int traceprobe_set_print_fmt(struct trace_probe *tp, bool is_return)/* Second: actually write the @print_fmt */ __set_print_fmt (tp, print_fmt, len +1 , is_return); - tp->call.print_fmt = print_fmt; + call->print_fmt = print_fmt;return 0 ; }
@@ -888,31 +889,34 @@ int traceprobe_define_arg_fields(struct trace_event_call *event_call,void trace_probe_cleanup (struct trace_probe *tp) { +struct trace_event_call *call =trace_probe_event_call (tp);int i;for (i =0 ; i < tp->nr_args; i++)traceprobe_free_probe_arg (&tp->args[i]); -kfree (tp->call.class->system); -kfree (tp->call.name); -kfree (tp->call.print_fmt); +kfree (call->class->system); +kfree (call->name); +kfree (call->print_fmt); }int trace_probe_init (struct trace_probe *tp,const char *event,const char *group) { +struct trace_event_call *call =trace_probe_event_call (tp); +if (!event || !group)return -EINVAL ; - tp->call.class = &tp->class; - tp->call.name =kstrdup (event,GFP_KERNEL ); -if (!tp->call.name) + call->class = &tp->class; + call->name =kstrdup (event,GFP_KERNEL ); +if (!call->name)return -ENOMEM ; tp->class.system =kstrdup (group,GFP_KERNEL );if (!tp->class.system) { -kfree (tp->call.name); - tp->call.name =NULL ; +kfree (call->name); + call->name =NULL ;return -ENOMEM ; }INIT_LIST_HEAD (&tp->files);
@@ -923,7 +927,7 @@ int trace_probe_init(struct trace_probe *tp, const char *event,int trace_probe_register_event_call (struct trace_probe *tp) { -struct trace_event_call *call = &tp->call; +struct trace_event_call *call =trace_probe_event_call (tp);int ret; ret =register_trace_event (&call->event);
kernel/trace/trace_probe.h +6 -0
@@ -276,6 +276,12 @@ static inline const char *trace_probe_group_name(struct trace_probe *tp)return tp->call.class->system; } +static inline struct trace_event_call * +trace_probe_event_call (struct trace_probe *tp) +{ +return &tp->call; +} +static inline int trace_probe_unregister_event_call (struct trace_probe *tp) {/* tp->event is unregistered in trace_remove_event_call() */
kernel/trace/trace_uprobe.c +8 -7
@@ -821,7 +821,7 @@ static void __uprobe_trace_func(struct trace_uprobe *tu,struct ring_buffer *buffer;void *data;int size, esize; -struct trace_event_call *call = &tu->tp.call; +struct trace_event_call *call =trace_probe_event_call (&tu->tp);WARN_ON (call != trace_file->event_call);
@@ -1113,7 +1113,7 @@ static void __uprobe_perf_func(struct trace_uprobe *tu, unsigned long func, struct pt_regs *regs, struct uprobe_cpu_buffer *ucb, int dsize) { - struct trace_event_call *call = &tu->tp.call; + struct trace_event_call *call = trace_probe_event_call(&tu->tp);struct uprobe_trace_entry_head *entry;struct hlist_head *head;void *data;
@@ -1316,9 +1316,10 @@ static struct trace_event_functions uprobe_funcs = { .trace = print_uprobe_event }; -static inline void init_trace_event_call (struct trace_uprobe *tu, -struct trace_event_call *call) +static inline void init_trace_event_call (struct trace_uprobe *tu) { +struct trace_event_call *call =trace_probe_event_call (&tu->tp); + call->event.funcs = &uprobe_funcs; call->class->define_fields = uprobe_event_define_fields;
@@ -1329,7 +1330,7 @@ static inline void init_trace_event_call(struct trace_uprobe *tu,static int register_uprobe_event (struct trace_uprobe *tu) { -init_trace_event_call (tu, &tu->tp.call); +init_trace_event_call (tu);return trace_probe_register_event_call (&tu->tp); }
@@ -1376,14 +1377,14 @@ create_local_trace_uprobe(char *name, unsigned long offs, tu->path = path; tu->ref_ctr_offset = ref_ctr_offset; tu->filename =kstrdup (name,GFP_KERNEL ); -init_trace_event_call (tu, &tu->tp.call); +init_trace_event_call (tu);if (traceprobe_set_print_fmt (&tu->tp,is_ret_probe (tu)) <0 ) { ret = -ENOMEM ; goto error; } -return &tu->tp.call; +return trace_probe_event_call (&tu->tp); error:free_trace_uprobe (tu);return ERR_PTR (ret);
Masami Hiramatsu
maintainerPATCH 9/21 tracing/kprobe: Check registered state using kprobe
In reply to Masami HiramatsuChange registered check only by trace_kprobe and remove TP_FLAG_REGISTERED from trace_probe, since this feature is only used for trace_kprobe.
--- kernel/trace/trace_kprobe.c | 23 +++++++++++++++-------- kernel/trace/trace_probe.h | 6 ------ 2 files changed, 15 insertions(+), 14 deletions(-)
kernel/trace/trace_kprobe.c +15 -8
@@ -157,6 +157,12 @@ static nokprobe_inline unsigned long trace_kprobe_nhit(struct trace_kprobe *tk)return nhit; } +static nokprobe_inline bool trace_kprobe_is_registered(struct trace_kprobe *tk) +{ +return !(list_empty (&tk->rp.kp.list) && +hlist_unhashed (&tk->rp.kp.hlist)); +} +/* Return 0 if it fails to find the symbol address */ static nokprobe_inline unsigned long trace_kprobe_address (struct trace_kprobe *tk)
@@ -244,6 +250,8 @@ static struct trace_kprobe *alloc_trace_kprobe(const char *group, tk->rp.kp.pre_handler = kprobe_dispatcher; tk->rp.maxactive = maxactive; +INIT_HLIST_NODE (&tk->rp.kp.hlist); +INIT_LIST_HEAD (&tk->rp.kp.list); ret =trace_probe_init (&tk->tp, event, group);if (ret <0 )
@@ -273,7 +281,7 @@ static inline int __enable_trace_kprobe(struct trace_kprobe *tk) {int ret =0 ; -if (trace_probe_is_registered (&tk->tp) && !trace_kprobe_has_gone (tk)) { +if (trace_kprobe_is_registered (tk) && !trace_kprobe_has_gone (tk)) {if (trace_kprobe_is_return (tk)) ret =enable_kretprobe (&tk->rp);else
@@ -333,7 +341,7 @@ disable_trace_kprobe(struct trace_kprobe *tk, struct trace_event_file *file) }else trace_probe_clear_flag (tp,TP_FLAG_PROFILE ); -if (!trace_probe_is_enabled (tp) &&trace_probe_is_registered (tp)) { +if (!trace_probe_is_enabled (tp) &&trace_kprobe_is_registered (tk)) {if (trace_kprobe_is_return (tk))disable_kretprobe (&tk->rp);else
@@ -381,7 +389,7 @@ static int __register_trace_kprobe(struct trace_kprobe *tk) {int i, ret; -if (trace_probe_is_registered (&tk->tp)) +if (trace_kprobe_is_registered (tk))return -EINVAL ;if (within_notrace_func (tk)) {
@@ -407,21 +415,20 @@ static int __register_trace_kprobe(struct trace_kprobe *tk)else ret =register_kprobe (&tk->rp.kp); -if (ret ==0 ) -trace_probe_set_flag (&tk->tp,TP_FLAG_REGISTERED );return ret; }/* Internal unregister function - just handle k*probes and flags */ static void __unregister_trace_kprobe (struct trace_kprobe *tk) { -if (trace_probe_is_registered (&tk->tp)) { +if (trace_kprobe_is_registered (tk)) {if (trace_kprobe_is_return (tk))unregister_kretprobe (&tk->rp);else unregister_kprobe (&tk->rp.kp); -trace_probe_clear_flag (&tk->tp,TP_FLAG_REGISTERED ); -/* Cleanup kprobe for reuse */ +/* Cleanup kprobe for reuse and mark it unregistered */ +INIT_HLIST_NODE (&tk->rp.kp.hlist); +INIT_LIST_HEAD (&tk->rp.kp.list);if (tk->rp.kp.symbol_name) tk->rp.kp.addr =NULL ; }
kernel/trace/trace_probe.h +0 -6
@@ -55,7 +55,6 @@/* Flags for trace_probe */ #define TP_FLAG_TRACE 1#define TP_FLAG_PROFILE 2 -#define TP_FLAG_REGISTERED 4/* data_loc: data location, compatible with u32 */ #define make_data_loc (len, offs) \
@@ -261,11 +260,6 @@ static inline bool trace_probe_is_enabled(struct trace_probe *tp)return trace_probe_test_flag (tp,TP_FLAG_TRACE |TP_FLAG_PROFILE ); } -static inline bool trace_probe_is_registered (struct trace_probe *tp) -{ -return trace_probe_test_flag (tp,TP_FLAG_REGISTERED ); -} -static inline const char *trace_probe_name (struct trace_probe *tp) {return trace_event_name (&tp->call);
Masami Hiramatsu
maintainerPATCH 10/21 tracing/probe: Split trace_event related data from trace_probe
In reply to Masami HiramatsuSplit the trace_event related data from trace_probe data structure and introduce trace_probe_event data structure for its folder. This trace_probe_event data structure can have multiple trace_probe.
--- kernel/trace/trace_kprobe.c | 99 ++++++++++++++++++++++------------- kernel/trace/trace_probe.c | 53 +++++++++++++------ kernel/trace/trace_probe.h | 48 +++++++++++++---- kernel/trace/trace_uprobe.c | 123 +++++++++++++++++++++++++++++-------------- 4 files changed, 221 insertions(+), 102 deletions(-)
kernel/trace/trace_kprobe.c +64 -35
@@ -180,9 +180,17 @@ unsigned long trace_kprobe_address(struct trace_kprobe *tk)return addr; } +static nokprobe_inline struct trace_kprobe * +trace_kprobe_primary_from_call (struct trace_event_call *call) +{ +struct trace_probe *tp =trace_probe_primary_from_call (call); + + return container_of(tp, struct trace_kprobe, tp); +} +bool trace_kprobe_on_func_entry (struct trace_event_call *call) { -struct trace_kprobe *tk = (struct trace_kprobe *)call->data; +struct trace_kprobe *tk =trace_kprobe_primary_from_call (call); return kprobe_on_func_entry(tk->rp.kp.addr, tk->rp.kp.addr ? NULL : tk->rp.kp.symbol_name,
@@ -191,7 +199,7 @@ bool trace_kprobe_on_func_entry(struct trace_event_call *call)bool trace_kprobe_error_injectable (struct trace_event_call *call) { -struct trace_kprobe *tk = (struct trace_kprobe *)call->data; +struct trace_kprobe *tk =trace_kprobe_primary_from_call (call);return within_error_injection_list (trace_kprobe_address (tk)); }
@@ -295,28 +303,40 @@ static inline int __enable_trace_kprobe(struct trace_kprobe *tk)* Enable trace_probe * if the file is NULL, enable "perf" handler, or enable "trace" handler. */ -static int -enable_trace_kprobe (struct trace_kprobe *tk,struct trace_event_file *file) +static int enable_trace_kprobe (struct trace_event_call *call, +struct trace_event_file *file) { -bool enabled =trace_probe_is_enabled (&tk->tp); -int ret =0 ; +struct trace_probe *pos, *tp =trace_probe_primary_from_call (call); +struct trace_kprobe *tk; +bool enabled =trace_probe_is_enabled (tp); +int ret =0 , ecode;if (file) { - ret =trace_probe_add_file (&tk->tp, file); + ret =trace_probe_add_file (tp, file);if (ret)return ret; }else -trace_probe_set_flag (&tk->tp,TP_FLAG_PROFILE ); +trace_probe_set_flag (tp,TP_FLAG_PROFILE );if (enabled)return 0 ; - ret =__enable_trace_kprobe (tk); -if (ret) { + enabled = false; +list_for_each_entry (pos,trace_probe_probe_list (tp), list) { + tk = container_of(pos, struct trace_kprobe, tp); + ecode =__enable_trace_kprobe (tk); +if (ecode) + ret = ecode;/* Save the last error code */ +else + enabled = true; + } + +if (!enabled) { +/* No probe is enabled. Roll back */ if (file) -trace_probe_remove_file (&tk->tp, file); +trace_probe_remove_file (tp, file);else -trace_probe_clear_flag (&tk->tp,TP_FLAG_PROFILE ); +trace_probe_clear_flag (tp,TP_FLAG_PROFILE ); }return ret;
@@ -326,10 +346,11 @@ enable_trace_kprobe(struct trace_kprobe *tk, struct trace_event_file *file)* Disable trace_probe * if the file is NULL, disable "perf" handler, or disable "trace" handler. */ -static int -disable_trace_kprobe (struct trace_kprobe *tk,struct trace_event_file *file) +static int disable_trace_kprobe (struct trace_event_call *call, +struct trace_event_file *file) { -struct trace_probe *tp = &tk->tp; +struct trace_probe *pos, *tp =trace_probe_primary_from_call (call); +struct trace_kprobe *tk;int ret =0 ;if (file) {
@@ -341,7 +362,13 @@ disable_trace_kprobe(struct trace_kprobe *tk, struct trace_event_file *file) }else trace_probe_clear_flag (tp,TP_FLAG_PROFILE ); -if (!trace_probe_is_enabled (tp) &&trace_kprobe_is_registered (tk)) { +if (trace_probe_is_enabled (tp)) + goto out; + +list_for_each_entry (pos,trace_probe_probe_list (tp), list) { + tk = container_of(pos, struct trace_kprobe, tp); +if (!trace_kprobe_is_registered (tk)) +continue ;if (trace_kprobe_is_return (tk))disable_kretprobe (&tk->rp);else
@@ -1089,7 +1116,8 @@ print_kprobe_event(struct trace_iterator *iter, int flags,struct trace_probe *tp; field = (struct kprobe_trace_entry_head *)iter->ent; - tp = container_of(event, struct trace_probe, call.event); + tp =trace_probe_primary_from_call ( + container_of(event, struct trace_event_call, event));trace_seq_printf (s,"%s: (" ,trace_probe_name (tp));
@@ -1116,7 +1144,8 @@ print_kretprobe_event(struct trace_iterator *iter, int flags,struct trace_probe *tp; field = (struct kretprobe_trace_entry_head *)iter->ent; - tp = container_of(event, struct trace_probe, call.event); + tp =trace_probe_primary_from_call ( + container_of(event, struct trace_event_call, event));trace_seq_printf (s,"%s: (" ,trace_probe_name (tp));
@@ -1145,23 +1174,23 @@ static int kprobe_event_define_fields(struct trace_event_call *event_call) {int ret;struct kprobe_trace_entry_head field; -struct trace_kprobe *tk = (struct trace_kprobe *)event_call->data; +struct trace_probe *tp =trace_probe_primary_from_call (event_call); DEFINE_FIELD(unsigned long, ip, FIELD_STRING_IP, 0); -return traceprobe_define_arg_fields (event_call,sizeof (field), &tk->tp); +return traceprobe_define_arg_fields (event_call,sizeof (field), tp); }static int kretprobe_event_define_fields (struct trace_event_call *event_call) {int ret;struct kretprobe_trace_entry_head field; -struct trace_kprobe *tk = (struct trace_kprobe *)event_call->data; +struct trace_probe *tp =trace_probe_primary_from_call (event_call); DEFINE_FIELD(unsigned long, func, FIELD_STRING_FUNC, 0); DEFINE_FIELD(unsigned long, ret_ip, FIELD_STRING_RETIP, 0); -return traceprobe_define_arg_fields (event_call,sizeof (field), &tk->tp); +return traceprobe_define_arg_fields (event_call,sizeof (field), tp); }#ifdef CONFIG_PERF_EVENTS
@@ -1289,20 +1318,19 @@ int bpf_get_kprobe_info(const struct perf_event *event, u32 *fd_type,static int kprobe_register (struct trace_event_call *event,enum trace_reg type,void *data) { -struct trace_kprobe *tk = (struct trace_kprobe *)event->data;struct trace_event_file *file = data;switch (type) {case TRACE_REG_REGISTER : -return enable_trace_kprobe (tk, file); +return enable_trace_kprobe (event, file);case TRACE_REG_UNREGISTER : -return disable_trace_kprobe (tk, file); +return disable_trace_kprobe (event, file);#ifdef CONFIG_PERF_EVENTS case TRACE_REG_PERF_REGISTER : -return enable_trace_kprobe (tk,NULL ); +return enable_trace_kprobe (event,NULL );case TRACE_REG_PERF_UNREGISTER : -return disable_trace_kprobe (tk,NULL ); +return disable_trace_kprobe (event,NULL );case TRACE_REG_PERF_OPEN :case TRACE_REG_PERF_CLOSE :case TRACE_REG_PERF_ADD :
@@ -1369,7 +1397,6 @@ static inline void init_trace_event_call(struct trace_kprobe *tk) call->flags =TRACE_EVENT_FL_KPROBE ; call->class->reg = kprobe_register; - call->data = tk; }static int register_kprobe_event (struct trace_kprobe *tk)
@@ -1430,9 +1457,7 @@ create_local_trace_kprobe(char *func, void *addr, unsigned long offs,void destroy_local_trace_kprobe (struct trace_event_call *event_call) { -struct trace_kprobe *tk; - - tk = container_of(event_call, struct trace_kprobe, tp.call); +struct trace_kprobe *tk =trace_kprobe_primary_from_call (event_call);if (trace_probe_is_enabled (&tk->tp)) {WARN_ON (1 );
@@ -1577,7 +1602,8 @@ static __init int kprobe_trace_self_tests_init(void)pr_warn ("error on getting probe file.\n" ); warn++; }else -enable_trace_kprobe (tk, file); +enable_trace_kprobe ( +trace_probe_event_call (&tk->tp), file); } }
@@ -1598,7 +1624,8 @@ static __init int kprobe_trace_self_tests_init(void)pr_warn ("error on getting probe file.\n" ); warn++; }else -enable_trace_kprobe (tk, file); +enable_trace_kprobe ( +trace_probe_event_call (&tk->tp), file); } }
@@ -1631,7 +1658,8 @@ static __init int kprobe_trace_self_tests_init(void)pr_warn ("error on getting probe file.\n" ); warn++; }else -disable_trace_kprobe (tk, file); +disable_trace_kprobe ( +trace_probe_event_call (&tk->tp), file); } tk =find_trace_kprobe ("testprobe2" ,KPROBE_EVENT_SYSTEM );
@@ -1649,7 +1677,8 @@ static __init int kprobe_trace_self_tests_init(void)pr_warn ("error on getting probe file.\n" ); warn++; }else -disable_trace_kprobe (tk, file); +disable_trace_kprobe ( +trace_probe_event_call (&tk->tp), file); } ret =trace_run_command ("-:testprobe" , create_or_delete_trace_kprobe);
kernel/trace/trace_probe.c +36 -17
90 lines not on this page · raw message
kernel/trace/trace_probe.h +37 -11
105 lines not on this page · raw message
kernel/trace/trace_uprobe.c +84 -39
229 lines not on this page · raw message
Steven Rostedt
maintainerRe: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe
Quoted 17 lines · On Sat, 1 Jun 2019 00:18:16 +0900 Masami Hiramatsu <[email protected]> wrote:
Split the
trace_eventrelated data fromtrace_probedata structure and introducetrace_probe_eventdata structure for its folder. Thistrace_probe_eventdata structure can have multipletrace_probe.Signed-off-by Masami Hiramatsu <[email protected]>--- kernel/trace/trace_kprobe.c | 99 ++++++++++++++++++++++------------- kernel/trace/trace_probe.c | 53 +++++++++++++------ kernel/trace/trace_probe.h | 48 +++++++++++++---- kernel/trace/trace_uprobe.c | 123 +++++++++++++++++++++++++++++-------------- 4 files changed, 221 insertions(+), 102 deletions(-)kernel/trace/trace_kprobe.c +0
-0
kernel/trace/trace_kprobe.c unsigned long trace_kprobe_address(struct trace_kprobe *tk) · line 188
Quoted 9 lines
kernel/trace/trace_kprobe.c +6
-0@@ -180,9 +180,17 @@ unsigned long trace_kprobe_address(struct trace_kprobe *tk)return addr; } +static nokprobe_inline struct trace_kprobe * +trace_kprobe_primary_from_call (struct trace_event_call *call) +{ +struct trace_probe *tp =trace_probe_primary_from_call (call); + + return container_of(tp, struct trace_kprobe, tp);
Hmm, is there a possibility that trace_probe_primary_from_call() may not have a primary?
Quoted 46 lines
kernel/trace/trace_kprobe.c +12
-8+} +bool trace_kprobe_on_func_entry (struct trace_event_call *call) { -struct trace_kprobe *tk = (struct trace_kprobe *)call->data; +struct trace_kprobe *tk =trace_kprobe_primary_from_call (call); return kprobe_on_func_entry(tk->rp.kp.addr, tk->rp.kp.addr ? NULL : tk->rp.kp.symbol_name,@@ -191,7 +199,7 @@ bool trace_kprobe_on_func_entry(struct trace_event_call *call)bool trace_kprobe_error_injectable (struct trace_event_call *call) { -struct trace_kprobe *tk = (struct trace_kprobe *)call->data; +struct trace_kprobe *tk =trace_kprobe_primary_from_call (call);return within_error_injection_list (trace_kprobe_address (tk)); }@@ -295,28 +303,40 @@ static inline int __enable_trace_kprobe(struct trace_kprobe *tk)* Enable trace_probe * if the file is NULL, enable "perf" handler, or enable "trace" handler. */ -static int -enable_trace_kprobe (struct trace_kprobe *tk,struct trace_event_file *file) +static int enable_trace_kprobe (struct trace_event_call *call, +struct trace_event_file *file) { -bool enabled =trace_probe_is_enabled (&tk->tp); -int ret =0 ; +struct trace_probe *pos, *tp =trace_probe_primary_from_call (call); +struct trace_kprobe *tk; +bool enabled =trace_probe_is_enabled (tp); +int ret =0 , ecode;if (file) { - ret =trace_probe_add_file (&tk->tp, file); + ret =trace_probe_add_file (tp, file);if (ret)return ret; }else -trace_probe_set_flag (&tk->tp,TP_FLAG_PROFILE ); +trace_probe_set_flag (tp,TP_FLAG_PROFILE );if (enabled)return 0 ;
kernel/trace/trace_kprobe.c static inline int __enable_trace_kprobe(struct trace_kprobe *tk) · line 331
Quoted 10 lines
kernel/trace/trace_kprobe.c +8
-2- ret =__enable_trace_kprobe (tk); -if (ret) { + enabled = false; +list_for_each_entry (pos,trace_probe_probe_list (tp), list) { + tk = container_of(pos, struct trace_kprobe, tp); + ecode =__enable_trace_kprobe (tk); +if (ecode) + ret = ecode;/* Save the last error code */ +else + enabled = true;
So, if we have some enabled but return an error code, what should a caller think of that? Wouldn't it be an inconsistent state?
-- Steve
Quoted 34 lines
kernel/trace/trace_kprobe.c +23
-2+ } + +if (!enabled) { +/* No probe is enabled. Roll back */ if (file) -trace_probe_remove_file (&tk->tp, file); +trace_probe_remove_file (tp, file);else -trace_probe_clear_flag (&tk->tp,TP_FLAG_PROFILE ); +trace_probe_clear_flag (tp,TP_FLAG_PROFILE ); } +static inline struct trace_probe_event * +trace_probe_event_from_call (struct trace_event_call *event_call) +{ + return container_of(event_call, struct trace_probe_event, call); +} + +static inline struct trace_probe * +trace_probe_primary_from_call (struct trace_event_call *call) +{ +struct trace_probe_event *tpe =trace_probe_event_from_call (call); + + return list_first_entry(&tpe->probes, struct trace_probe, list); +} + +static inline struct list_head *trace_probe_probe_list (struct trace_probe *tp) +{ +return &tp->event->probes; }
Masami Hiramatsu
maintainerRe: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe
Quoted 23 lines · On Mon, 17 Jun 2019 21:56:43 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 20 lines · On Sat, 1 Jun 2019 00:18:16 +0900 Masami Hiramatsu <[email protected]> wrote:
Split the
trace_eventrelated data fromtrace_probedata structure and introducetrace_probe_eventdata structure for its folder. Thistrace_probe_eventdata structure can have multipletrace_probe.Signed-off-by Masami Hiramatsu <[email protected]>--- kernel/trace/trace_kprobe.c | 99 ++++++++++++++++++++++------------- kernel/trace/trace_probe.c | 53 +++++++++++++------ kernel/trace/trace_probe.h | 48 +++++++++++++---- kernel/trace/trace_uprobe.c | 123 +++++++++++++++++++++++++++++-------------- 4 files changed, 221 insertions(+), 102 deletions(-)kernel/trace/trace_kprobe.c +0
-0@@ -180,9 +180,17 @@ unsigned long trace_kprobe_address(struct trace_kprobe *tk)return addr; }
Quoted 10 lines
kernel/trace/trace_kprobe.c unsigned long trace_kprobe_address(struct trace_kprobe *tk) · line 188
Quoted 6 lines
kernel/trace/trace_kprobe.c +6
-0+static nokprobe_inline struct trace_kprobe * +trace_kprobe_primary_from_call (struct trace_event_call *call) +{ +struct trace_probe *tp =trace_probe_primary_from_call (call); + + return container_of(tp, struct trace_kprobe, tp);Hmm, is there a possibility that
trace_probe_primary_from_call()may not have a primary?
Good question! Of course if given event_call is not a kprobe event, it doesn't have primary (or any) trace_probe. But that must not happen unless user misuses it.
And that list never be the empty, when the last trace probe is released, the event_call also unregistered and released. See unregister_trace_kprobe() for details. If there is no siblings on the list, the event_call is also unregistered before unregistering kprobes, and after unregistering kprobes the list is unlinked.
(Note that unregister_kprobe() will wait a quiescence period
before return. This means all probe handlers are done before that.)
Quoted 46 lines
Quoted 46 lines
kernel/trace/trace_kprobe.c +12
-8+} +bool trace_kprobe_on_func_entry (struct trace_event_call *call) { -struct trace_kprobe *tk = (struct trace_kprobe *)call->data; +struct trace_kprobe *tk =trace_kprobe_primary_from_call (call); return kprobe_on_func_entry(tk->rp.kp.addr, tk->rp.kp.addr ? NULL : tk->rp.kp.symbol_name,@@ -191,7 +199,7 @@ bool trace_kprobe_on_func_entry(struct trace_event_call *call)bool trace_kprobe_error_injectable (struct trace_event_call *call) { -struct trace_kprobe *tk = (struct trace_kprobe *)call->data; +struct trace_kprobe *tk =trace_kprobe_primary_from_call (call);return within_error_injection_list (trace_kprobe_address (tk)); }@@ -295,28 +303,40 @@ static inline int __enable_trace_kprobe(struct trace_kprobe *tk)* Enable trace_probe * if the file is NULL, enable "perf" handler, or enable "trace" handler. */ -static int -enable_trace_kprobe (struct trace_kprobe *tk,struct trace_event_file *file) +static int enable_trace_kprobe (struct trace_event_call *call, +struct trace_event_file *file) { -bool enabled =trace_probe_is_enabled (&tk->tp); -int ret =0 ; +struct trace_probe *pos, *tp =trace_probe_primary_from_call (call); +struct trace_kprobe *tk; +bool enabled =trace_probe_is_enabled (tp); +int ret =0 , ecode;if (file) { - ret =trace_probe_add_file (&tk->tp, file); + ret =trace_probe_add_file (tp, file);if (ret)return ret; }else -trace_probe_set_flag (&tk->tp,TP_FLAG_PROFILE ); +trace_probe_set_flag (tp,TP_FLAG_PROFILE );if (enabled)return 0 ;
Quoted 13 lines
kernel/trace/trace_kprobe.c static inline int __enable_trace_kprobe(struct trace_kprobe *tk) · line 331
Quoted 10 lines
kernel/trace/trace_kprobe.c +8
-2- ret =__enable_trace_kprobe (tk); -if (ret) { + enabled = false; +list_for_each_entry (pos,trace_probe_probe_list (tp), list) { + tk = container_of(pos, struct trace_kprobe, tp); + ecode =__enable_trace_kprobe (tk); +if (ecode) + ret = ecode;/* Save the last error code */ +else + enabled = true;So, if we have some enabled but return an error code, what should a caller think of that? Wouldn't it be an inconsistent state?
Oops, good catch!
This part is related to caller (ftrace/perf) so should be more careful. Usually, kprobe enablement should not fail. If one of them has gone (like a probe on unloaded module), it can be fail but that should be ignored. I would like to add some additional check so that
- If all kprobes are on the module which is unloaded, enablement must be failed and return error.
- If any kprobe is enabled, and others are on non-exist modules, it should succeeded and return OK.
- If any kprobe caused an error not because of unloaded module, all other enablement should be canceled and return error.
Is that OK for you?
Thank you,
Quoted 38 lines
-- Steve
Quoted 34 lines
kernel/trace/trace_kprobe.c +23
-2+ } + +if (!enabled) { +/* No probe is enabled. Roll back */ if (file) -trace_probe_remove_file (&tk->tp, file); +trace_probe_remove_file (tp, file);else -trace_probe_clear_flag (&tk->tp,TP_FLAG_PROFILE ); +trace_probe_clear_flag (tp,TP_FLAG_PROFILE ); } +static inline struct trace_probe_event * +trace_probe_event_from_call (struct trace_event_call *event_call) +{ + return container_of(event_call, struct trace_probe_event, call); +} + +static inline struct trace_probe * +trace_probe_primary_from_call (struct trace_event_call *call) +{ +struct trace_probe_event *tpe =trace_probe_event_from_call (call); + + return list_first_entry(&tpe->probes, struct trace_probe, list); +} + +static inline struct list_head *trace_probe_probe_list (struct trace_probe *tp) +{ +return &tp->event->probes; }
Signature · 1 line
Masami Hiramatsu <[email protected]>
Steven Rostedt
maintainerRe: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe
Quoted 15 lines · On Wed, 19 Jun 2019 01:14:09 +0900 Masami Hiramatsu <[email protected]> wrote:
Quoted 10 lines · On Mon, 17 Jun 2019 21:56:43 -0400 Steven Rostedt <[email protected]> wrote:
kernel/trace/trace_kprobe.c unsigned long trace_kprobe_address(struct trace_kprobe *tk) · line 188
Quoted 6 lines
kernel/trace/trace_kprobe.c +6
-0+static nokprobe_inline struct trace_kprobe * +trace_kprobe_primary_from_call (struct trace_event_call *call) +{ +struct trace_probe *tp =trace_probe_primary_from_call (call); + + return container_of(tp, struct trace_kprobe, tp);Hmm, is there a possibility that
trace_probe_primary_from_call()may not have a primary?
Quoted 10 lines
Good question! Of course if given
event_callis not a kprobe event, it doesn't have primary (or any)trace_probe. But that must not happen unless user misuses it.
And that list never be the empty, when the last trace probe is released, theevent_callalso unregistered and released. Seeunregister_trace_kprobe()for details. If there is no siblings on the list, theevent_callis also unregistered before unregistering kprobes, and after unregistering kprobes the list is unlinked.
(Note thatunregister_kprobe()will wait a quiescence period
before return. This means all probe handlers are done before that.)
Yeah, I thought something like that. But perhaps the trace_probe_primary_from_call() code should add a WARN_ON() is the list is empty.
Quoted 30 lines
Quoted 4 lines
Quoted 4 lines
Quoted 13 lines
kernel/trace/trace_kprobe.c static inline int __enable_trace_kprobe(struct trace_kprobe *tk) · line 331
Quoted 10 lines
kernel/trace/trace_kprobe.c +8
-2- ret =__enable_trace_kprobe (tk); -if (ret) { + enabled = false; +list_for_each_entry (pos,trace_probe_probe_list (tp), list) { + tk = container_of(pos, struct trace_kprobe, tp); + ecode =__enable_trace_kprobe (tk); +if (ecode) + ret = ecode;/* Save the last error code */ +else + enabled = true;So, if we have some enabled but return an error code, what should a caller think of that? Wouldn't it be an inconsistent state?
Oops, good catch!
This part is related to caller (ftrace/perf) so should be more careful. Usually, kprobe enablement should not fail. If one of them has gone (like a probe on unloaded module), it can be fail but that should be ignored. I would like to add some additional check so that
- If all kprobes are on the module which is unloaded, enablement must be failed and return error.
- If any kprobe is enabled, and others are on non-exist modules, it should succeeded and return OK.
- If any kprobe caused an error not because of unloaded module, all other enablement should be canceled and return error.
Quoted 2 lines
Is that OK for you?
Sounds good to me.
-- Steve
Steven Rostedt
maintainerRe: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe
Quoted 12 lines · On Tue, 18 Jun 2019 12:23:22 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 12 lines
Oops, good catch!
This part is related to caller (ftrace/perf) so should be more careful. Usually, kprobe enablement should not fail. If one of them has gone (like a probe on unloaded module), it can be fail but that should be ignored. I would like to add some additional check so that
- If all kprobes are on the module which is unloaded, enablement must be failed and return error.
- If any kprobe is enabled, and others are on non-exist modules, it should succeeded and return OK.
- If any kprobe caused an error not because of unloaded module, all other enablement should be canceled and return error.
Quoted 4 lines
Quoted 2 lines
Is that OK for you?
Sounds good to me.
BTW,
I pulled in patches 1-9 and I'm starting to test them now.
-- Steve
Masami Hiramatsu
maintainerRe: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe
Quoted 15 lines · On Tue, 18 Jun 2019 17:11:15 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 12 lines · On Tue, 18 Jun 2019 12:23:22 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 12 lines
Oops, good catch!
This part is related to caller (ftrace/perf) so should be more careful. Usually, kprobe enablement should not fail. If one of them has gone (like a probe on unloaded module), it can be fail but that should be ignored. I would like to add some additional check so that
- If all kprobes are on the module which is unloaded, enablement must be failed and return error.
- If any kprobe is enabled, and others are on non-exist modules, it should succeeded and return OK.
- If any kprobe caused an error not because of unloaded module, all other enablement should be canceled and return error.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Is that OK for you?
Sounds good to me.
BTW,
I pulled in patches 1-9 and I'm starting to test them now.
Thanks! Should I send 10-21 patches in v2?
Thank you,
Signature · 1 line
Masami Hiramatsu <[email protected]>
Steven Rostedt
maintainerRe: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe
Quoted 5 lines · On Wed, 19 Jun 2019 11:28:22 +0900 Masami Hiramatsu <[email protected]> wrote:
Quoted 3 lines
BTW,
I pulled in patches 1-9 and I'm starting to test them now.
Thanks! Should I send 10-21 patches in v2?
Yes please.
The tests have passed, and I will be pushing them to linux-next soon. But as I'm currently traveling, I can't give an exact time I will do that.
-- Steve
Masami Hiramatsu
maintainerRe: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe
In reply to Steven RostedtQuoted 29 lines · On Tue, 18 Jun 2019 12:23:22 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 15 lines · On Wed, 19 Jun 2019 01:14:09 +0900 Masami Hiramatsu <[email protected]> wrote:
Quoted 10 lines · On Mon, 17 Jun 2019 21:56:43 -0400 Steven Rostedt <[email protected]> wrote:
kernel/trace/trace_kprobe.c unsigned long trace_kprobe_address(struct trace_kprobe *tk) · line 188
Quoted 6 lines
kernel/trace/trace_kprobe.c +6
-0+static nokprobe_inline struct trace_kprobe * +trace_kprobe_primary_from_call (struct trace_event_call *call) +{ +struct trace_probe *tp =trace_probe_primary_from_call (call); + + return container_of(tp, struct trace_kprobe, tp);Hmm, is there a possibility that
trace_probe_primary_from_call()may not have a primary?Quoted 10 lines
Good question! Of course if given
event_callis not a kprobe event, it doesn't have primary (or any)trace_probe. But that must not happen unless user misuses it.
And that list never be the empty, when the last trace probe is released, theevent_callalso unregistered and released. Seeunregister_trace_kprobe()for details. If there is no siblings on the list, theevent_callis also unregistered before unregistering kprobes, and after unregistering kprobes the list is unlinked.
(Note thatunregister_kprobe()will wait a quiescence period
before return. This means all probe handlers are done before that.)
Quoted 3 lines
Yeah, I thought something like that. But perhaps the
trace_probe_primary_from_call()code should add aWARN_ON()is the list is empty.
OK, I'll add that, and check in all callers.
Quoted 27 lines
Quoted 27 lines
Quoted 14 lines
kernel/trace/trace_kprobe.c static inline int __enable_trace_kprobe(struct trace_kprobe *tk) · line 331
Quoted 11 lines
kernel/trace/trace_kprobe.c +8
-2- ret =__enable_trace_kprobe (tk); -if (ret) { + enabled = false; +list_for_each_entry (pos,trace_probe_probe_list (tp), list) { + tk = container_of(pos, struct trace_kprobe, tp); + ecode =__enable_trace_kprobe (tk); +if (ecode) + ret = ecode;/* Save the last error code */ +else + enabled = true;So, if we have some enabled but return an error code, what should a caller think of that? Wouldn't it be an inconsistent state?
Oops, good catch!
This part is related to caller (ftrace/perf) so should be more careful. Usually, kprobe enablement should not fail. If one of them has gone (like a probe on unloaded module), it can be fail but that should be ignored. I would like to add some additional check so that
- If all kprobes are on the module which is unloaded, enablement must be failed and return error.
- If any kprobe is enabled, and others are on non-exist modules, it should succeeded and return OK.
- If any kprobe caused an error not because of unloaded module, all other enablement should be canceled and return error.
Quoted 4 lines
Quoted 2 lines
Is that OK for you?
Sounds good to me.
Thank you!
Signature · 1 line
Masami Hiramatsu <[email protected]>
Masami Hiramatsu
maintainerPATCH 11/21 tracing/dynevent: Delete all matched events
In reply to Masami HiramatsuWhen user gives an event name to delete, delete all matched events instead of the first one.
This means if there are several events which have same name but different group (subsystem) name, those are removed if user passed only the event name, e.g.
# cat kprobe_events p:group1/testevent _do_fork p:group2/testevent fork_idle # echo -:testevent >> kprobe_events # cat kprobe_events #
--- kernel/trace/trace_dynevent.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
kernel/trace/trace_dynevent.c +5 -3
@@ -61,10 +61,12 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)for_each_dyn_event_safe (pos, n) {if (type && type != pos->ops)continue ; -if (pos->ops->match (system, event, pos)) { - ret = pos->ops->free (pos); +if (!pos->ops->match (system, event, pos)) +continue ; + + ret = pos->ops->free (pos); +if (ret)break ; - } }mutex_unlock (&event_mutex);
Masami Hiramatsu
maintainerPATCH 12/21 tracing/dynevent: Pass extra arguments to match operation
In reply to Masami HiramatsuPass extra arguments to match operation for checking exact match. If the event doesn't support exact match, it will be ignored.
--- kernel/trace/trace_dynevent.c | 4 +++- kernel/trace/trace_dynevent.h | 7 ++++--- kernel/trace/trace_events_hist.c | 4 ++-- kernel/trace/trace_kprobe.c | 4 ++-- kernel/trace/trace_uprobe.c | 4 ++-- 5 files changed, 13 insertions(+), 10 deletions(-)
kernel/trace/trace_dynevent.c +3 -1
@@ -47,6 +47,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)return -EINVAL ; event++; } + argc--; argv++; p =strchr (event,'/' );if (p) {
@@ -61,7 +62,8 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)for_each_dyn_event_safe (pos, n) {if (type && type != pos->ops)continue ; -if (!pos->ops->match (system, event, pos)) +if (!pos->ops->match (system, event, + argc, (const char **)argv, pos))continue ; ret = pos->ops->free (pos);
kernel/trace/trace_dynevent.h +4 -3
@@ -31,8 +31,9 @@ struct dyn_event;* @is_busy: Check whether given event is busy so that it can not be deleted. * Return true if it is busy, otherwides false. * @free: Delete the given event. Return 0 if success, otherwides error. -* @match: Check whether given event and system name match this event. -* Return true if it matches, otherwides false. +* @match: Check whether given event and system name match this event. The argc +* and argv is used for exact match. Return true if it matches, otherwides +* false. * * Except for @create, these methods are called under holding event_mutex. */
@@ -43,7 +44,7 @@ struct dyn_event_operations {bool (*is_busy)(struct dyn_event *ev);int (*free)(struct dyn_event *ev);bool (*match)(const char *system,const char *event, -struct dyn_event *ev); +int argc,const char **argv,struct dyn_event *ev); };/* Register new dyn_event type -- must be called at first */
kernel/trace/trace_events_hist.c +2 -2
@@ -374,7 +374,7 @@ static int synth_event_show(struct seq_file *m, struct dyn_event *ev);static int synth_event_release (struct dyn_event *ev);static bool synth_event_is_busy (struct dyn_event *ev);static bool synth_event_match (const char *system,const char *event, -struct dyn_event *ev); +int argc,const char **argv,struct dyn_event *ev);static struct dyn_event_operations synth_event_ops = { .create = synth_event_create,
@@ -422,7 +422,7 @@ static bool synth_event_is_busy(struct dyn_event *ev) }static bool synth_event_match (const char *system,const char *event, -struct dyn_event *ev) +int argc,const char **argv,struct dyn_event *ev) {struct synth_event *sev =to_synth_event (ev);
kernel/trace/trace_kprobe.c +2 -2
@@ -39,7 +39,7 @@ static int trace_kprobe_show(struct seq_file *m, struct dyn_event *ev);static int trace_kprobe_release (struct dyn_event *ev);static bool trace_kprobe_is_busy (struct dyn_event *ev);static bool trace_kprobe_match (const char *system,const char *event, -struct dyn_event *ev); +int argc,const char **argv,struct dyn_event *ev);static struct dyn_event_operations trace_kprobe_ops = { .create = trace_kprobe_create,
@@ -138,7 +138,7 @@ static bool trace_kprobe_is_busy(struct dyn_event *ev) }static bool trace_kprobe_match (const char *system,const char *event, -struct dyn_event *ev) +int argc,const char **argv,struct dyn_event *ev) {struct trace_kprobe *tk =to_trace_kprobe (ev);
kernel/trace/trace_uprobe.c +2 -2
@@ -44,7 +44,7 @@ static int trace_uprobe_show(struct seq_file *m, struct dyn_event *ev);static int trace_uprobe_release (struct dyn_event *ev);static bool trace_uprobe_is_busy (struct dyn_event *ev);static bool trace_uprobe_match (const char *system,const char *event, -struct dyn_event *ev); +int argc,const char **argv,struct dyn_event *ev);static struct dyn_event_operations trace_uprobe_ops = { .create = trace_uprobe_create,
@@ -285,7 +285,7 @@ static bool trace_uprobe_is_busy(struct dyn_event *ev) }static bool trace_uprobe_match (const char *system,const char *event, -struct dyn_event *ev) +int argc,const char **argv,struct dyn_event *ev) {struct trace_uprobe *tu =to_trace_uprobe (ev);
Masami Hiramatsu
maintainerPATCH 13/21 tracing/kprobe: Add multi-probe per event support
In reply to Masami HiramatsuAdd multi-probe per one event support to kprobe events. User can define several different probes on one trace event if those events have same "event signature",
e.g.
# echo p:testevent _do_fork > kprobe_events # echo p:testevent fork_idle >> kprobe_events # kprobe_events p:kprobes/testevent _do_fork p:kprobes/testevent fork_idle
The event signature is defined by kprobe type (retprobe or not), the number of args, argument names, and argument types.
Note that this only support appending method. Delete event operation will delete all probes on the event.
--- kernel/trace/trace.c | 4 +-- kernel/trace/trace_kprobe.c | 52 ++++++++++++++++++++++++++++++++++---- kernel/trace/trace_probe.c | 59 ++++++++++++++++++++++++++++++++++++------- kernel/trace/trace_probe.h | 14 +++++++++- 4 files changed, 111 insertions(+), 18 deletions(-)
kernel/trace/trace.c +2 -2
@@ -4813,11 +4813,11 @@ static const char readme_msg[] =#endif #endif /* CONFIG_STACK_TRACER */ #ifdef CONFIG_DYNAMIC_EVENTS -" dynamic_events\t\t- Add/remove/show the generic dynamic events\n" +" dynamic_events\t\t- Create/append/remove/show the generic dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n"#endif #ifdef CONFIG_KPROBE_EVENTS -" kprobe_events\t\t- Add/remove/show the kernel dynamic events\n" +" kprobe_events\t\t- Create/append/remove/show the kernel dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n"#endif #ifdef CONFIG_UPROBE_EVENTS
kernel/trace/trace_kprobe.c +46 -6
85 lines not on this page · raw message
kernel/trace/trace_probe.c +50 -9
74 lines not on this page · raw message
kernel/trace/trace_probe.h +13 -1
@@ -302,6 +302,13 @@ static inline struct list_head *trace_probe_probe_list(struct trace_probe *tp)return &tp->event->probes; } +static inline bool trace_probe_has_sibling (struct trace_probe *tp) +{ +struct list_head *list =trace_probe_probe_list (tp); + +return !list_empty (list) && !list_is_singular (list); +} +static inline int trace_probe_unregister_event_call (struct trace_probe *tp) {/* tp->event is unregistered in trace_remove_event_call() */
@@ -316,12 +323,15 @@ static inline bool trace_probe_has_single_file(struct trace_probe *tp)int trace_probe_init (struct trace_probe *tp,const char *event,const char *group);void trace_probe_cleanup (struct trace_probe *tp); +int trace_probe_append (struct trace_probe *tp,struct trace_probe *to); +void trace_probe_unlink (struct trace_probe *tp);int trace_probe_register_event_call (struct trace_probe *tp);int trace_probe_add_file (struct trace_probe *tp,struct trace_event_file *file);int trace_probe_remove_file (struct trace_probe *tp,struct trace_event_file *file);struct event_file_link *trace_probe_get_file_link (struct trace_probe *tp,struct trace_event_file *file); +int trace_probe_compare_arg_type (struct trace_probe *a,struct trace_probe *b);#define trace_probe_for_each_link (pos, tp) \ list_for_each_entry(pos, &(tp)->event->files, list)
@@ -419,7 +429,9 @@ extern int traceprobe_define_arg_fields(struct trace_event_call *event_call,C (ARG_TOO_LONG ,"Argument expression is too long" ), \C (NO_ARG_BODY ,"No argument expression" ), \C (BAD_INSN_BNDRY ,"Probe point is not an instruction boundary" ),\ -C (FAIL_REG_PROBE ,"Failed to register probe event" ), +C (FAIL_REG_PROBE ,"Failed to register probe event" ),\ +C (DIFF_PROBE_TYPE ,"Probe type is different from existing probe" ),\ +C (DIFF_ARG_TYPE ,"Argument type or name is different from existing probe" ), #undef C #define C(a, b) TP_ERR_##a
Masami Hiramatsu
maintainerPATCH 14/21 tracing/uprobe: Add multi-probe per uprobe event support
In reply to Masami HiramatsuAllow user to define several probes on one uprobe event. Note that this only support appending method. So deleting event will delete all probes on the event.
--- kernel/trace/trace.c | 2 + kernel/trace/trace_uprobe.c | 60 ++++++++++++++++++++++++++++++------------- 2 files changed, 43 insertions(+), 19 deletions(-)
kernel/trace/trace.c +1 -1
@@ -4821,7 +4821,7 @@ static const char readme_msg[] = "\t\t\t Write into this file to define/undefine new trace events.\n"#endif #ifdef CONFIG_UPROBE_EVENTS -" uprobe_events\t\t- Add/remove/show the userspace dynamic events\n" +" uprobe_events\t\t- Create/append/remove/show the userspace dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n"#endif #if defined(CONFIG_KPROBE_EVENTS ) || defined(CONFIG_UPROBE_EVENTS )
kernel/trace/trace_uprobe.c +42 -18
100 lines not on this page · raw message
Masami Hiramatsu
maintainerPATCH 15/21 tracing/kprobe: Add per-probe delete from event
In reply to Masami HiramatsuAllow user to delete a probe from event. This is done by head match. For example, if we have 2 probes on an event
$ cat kprobe_events p:kprobes/testprobe _do_fork r1=%ax r2=%dx p:kprobes/testprobe idle_fork r1=%ax r2=%cx
Then you can remove one of them by passing the head of definition which identify the probe.
$ echo "-:kprobes/testprobe idle_fork" >> kprobe_events
--- kernel/trace/trace_kprobe.c | 25 ++++++++++++++++++++++++- kernel/trace/trace_probe.c | 18 ++++++++++++++++++ kernel/trace/trace_probe.h | 2 ++ 3 files changed, 44 insertions(+), 1 deletion(-)
kernel/trace/trace_kprobe.c +24 -1
@@ -137,13 +137,36 @@ static bool trace_kprobe_is_busy(struct dyn_event *ev)return trace_probe_is_enabled (&tk->tp); } +static bool trace_kprobe_match_command_head (struct trace_kprobe *tk, +int argc,const char **argv) +{ +char buf[MAX_ARGSTR_LEN +1 ]; + +if (!argc) +return true; + +if (!tk->symbol) +snprintf (buf,sizeof (buf),"0x%p" , tk->rp.kp.addr); +else if (tk->rp.kp.offset) +snprintf (buf,sizeof (buf),"%s+%u" , +trace_kprobe_symbol (tk), tk->rp.kp.offset); +else +snprintf (buf,sizeof (buf),"%s" ,trace_kprobe_symbol (tk)); +if (strcmp (buf, argv[0 ])) +return false; + argc--; argv++; + +return trace_probe_match_command_args (&tk->tp, argc, argv); +} +static bool trace_kprobe_match (const char *system,const char *event,int argc,const char **argv,struct dyn_event *ev) {struct trace_kprobe *tk =to_trace_kprobe (ev);return strcmp (trace_probe_name (&tk->tp), event) ==0 && - (!system ||strcmp (trace_probe_group_name (&tk->tp), system) ==0 ); + (!system ||strcmp (trace_probe_group_name (&tk->tp), system) ==0 ) && +trace_kprobe_match_command_head (tk, argc, argv); }static nokprobe_inline unsigned long trace_kprobe_nhit (struct trace_kprobe *tk)
kernel/trace/trace_probe.c +18 -0
@@ -1047,3 +1047,21 @@ int trace_probe_compare_arg_type(struct trace_probe *a, struct trace_probe *b)return 0 ; } + +bool trace_probe_match_command_args (struct trace_probe *tp, +int argc,const char **argv) +{ +char buf[MAX_ARGSTR_LEN +1 ]; +int i; + +if (tp->nr_args < argc) +return false; + +for (i =0 ; i < argc; i++) { +snprintf (buf,sizeof (buf),"%s=%s" , + tp->args[i].name, tp->args[i].comm); +if (strcmp (buf, argv[i])) +return false; + } +return true; +}
kernel/trace/trace_probe.h +2 -0
@@ -332,6 +332,8 @@ int trace_probe_remove_file(struct trace_probe *tp,struct event_file_link *trace_probe_get_file_link (struct trace_probe *tp,struct trace_event_file *file);int trace_probe_compare_arg_type (struct trace_probe *a,struct trace_probe *b); +bool trace_probe_match_command_args (struct trace_probe *tp, +int argc,const char **argv);#define trace_probe_for_each_link (pos, tp) \ list_for_each_entry(pos, &(tp)->event->files, list)
Masami Hiramatsu
maintainerPATCH 16/21 tracing/uprobe: Add per-probe delete from event
In reply to Masami HiramatsuAdd per-probe delete method from one event passing the head of definition. In other words, the events which match the head N parameters are deleted.
--- kernel/trace/trace_uprobe.c | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-)
kernel/trace/trace_uprobe.c +30 -1
@@ -284,13 +284,42 @@ static bool trace_uprobe_is_busy(struct dyn_event *ev)return trace_probe_is_enabled (&tu->tp); } +static bool trace_uprobe_match_command_head (struct trace_uprobe *tu, +int argc,const char **argv) +{ +char buf[MAX_ARGSTR_LEN +1 ]; +int len; + +if (!argc) +return true; + + len =strlen (tu->filename); +if (argv[0 ][len] !=':' ||strncmp (tu->filename, argv[0 ], len)) +return false; + +if (tu->ref_ctr_offset ==0 ) +snprintf (buf,sizeof (buf),"0x%0*lx" , + (int )(sizeof (void *) *2 ), tu->offset); +else +snprintf (buf,sizeof (buf),"0x%0*lx(0x%lx)" , + (int )(sizeof (void *) *2 ), tu->offset, + tu->ref_ctr_offset); +if (strcmp (buf, &argv[0 ][len +1 ])) +return false; + + argc--; argv++; + +return trace_probe_match_command_args (&tu->tp, argc, argv); +} +static bool trace_uprobe_match (const char *system,const char *event,int argc,const char **argv,struct dyn_event *ev) {struct trace_uprobe *tu =to_trace_uprobe (ev);return strcmp (trace_probe_name (&tu->tp), event) ==0 && - (!system ||strcmp (trace_probe_group_name (&tu->tp), system) ==0 ); + (!system ||strcmp (trace_probe_group_name (&tu->tp), system) ==0 ) && +trace_uprobe_match_command_head (tu, argc, argv); } static nokprobe_inline struct trace_uprobe *
Steven Rostedt
maintainerRe: [PATCH 16/21] tracing/uprobe: Add per-probe delete from event
kernel/trace/trace_uprobe.c static bool trace_uprobe_is_busy(struct dyn_event *ev) · line 297
Quoted 11 lines · On Sat, 1 Jun 2019 00:19:17 +0900 Masami Hiramatsu <[email protected]> wrote:
kernel/trace/trace_uprobe.c +11
-0+static bool trace_uprobe_match_command_head (struct trace_uprobe *tu, +int argc,const char **argv) +{ +char buf[MAX_ARGSTR_LEN +1 ]; +int len; + +if (!argc) +return true; + + len =strlen (tu->filename); +if (argv[0 ][len] !=':' ||strncmp (tu->filename, argv[0 ], len))
Hmm, isn't it possible that 'len' can be greater than whatever argv[0] is?
The argv[0][len] looks very dangerous to me.
Perhaps that should be changed to:
if (!(!strncmp(tu->filename, argv[0], len) && argv[0][len] == ':'))
That way, the test of argv[0][len] will only happen if argv[0] is of length len.
-- Steve
Quoted 17 lines
kernel/trace/trace_uprobe.c +17
-0+return false; + +if (tu->ref_ctr_offset ==0 ) +snprintf (buf,sizeof (buf),"0x%0*lx" , + (int )(sizeof (void *) *2 ), tu->offset); +else +snprintf (buf,sizeof (buf),"0x%0*lx(0x%lx)" , + (int )(sizeof (void *) *2 ), tu->offset, + tu->ref_ctr_offset); +if (strcmp (buf, &argv[0 ][len +1 ])) +return false; + + argc--; argv++; + +return trace_probe_match_command_args (&tu->tp, argc, argv); +} +
Masami Hiramatsu
maintainerRe: [PATCH 16/21] tracing/uprobe: Add per-probe delete from event
Quoted 17 lines · On Mon, 17 Jun 2019 22:16:46 -0400 Steven Rostedt <[email protected]> wrote:
kernel/trace/trace_uprobe.c static bool trace_uprobe_is_busy(struct dyn_event *ev) · line 297
Quoted 11 lines · On Sat, 1 Jun 2019 00:19:17 +0900 Masami Hiramatsu <[email protected]> wrote:
kernel/trace/trace_uprobe.c +11
-0+static bool trace_uprobe_match_command_head (struct trace_uprobe *tu, +int argc,const char **argv) +{ +char buf[MAX_ARGSTR_LEN +1 ]; +int len; + +if (!argc) +return true; + + len =strlen (tu->filename); +if (argv[0 ][len] !=':' ||strncmp (tu->filename, argv[0 ], len))Hmm, isn't it possible that 'len' can be greater than whatever argv[0] is?
Quoted 1 line
The argv[0][len] looks very dangerous to me.
Ah, right! it can lead an unexpected memory access!
Quoted 6 lines
Perhaps that should be changed to:
if (!(!strncmp(tu->filename, argv[0], len) && argv[0][len] == ':'))That way, the test of argv[0][len] will only happen if argv[0] is of length len.
OK, I'll take it! Thank you!
Quoted 21 lines
-- Steve
Quoted 17 lines
kernel/trace/trace_uprobe.c +17
-0+return false; + +if (tu->ref_ctr_offset ==0 ) +snprintf (buf,sizeof (buf),"0x%0*lx" , + (int )(sizeof (void *) *2 ), tu->offset); +else +snprintf (buf,sizeof (buf),"0x%0*lx(0x%lx)" , + (int )(sizeof (void *) *2 ), tu->offset, + tu->ref_ctr_offset); +if (strcmp (buf, &argv[0 ][len +1 ])) +return false; + + argc--; argv++; + +return trace_probe_match_command_args (&tu->tp, argc, argv); +} +
Signature · 1 line
Masami Hiramatsu <[email protected]>
Masami Hiramatsu
maintainerPATCH 17/21 tracing/probe: Add immediate parameter support
In reply to Masami HiramatsuAdd immediate value parameter (\1234) support to probe events. This allows you to specify an immediate (or dummy) parameter instead of fetching from memory or register.
This feature looks odd, but imagine when you put a probe on a code to trace some data. If the code is compiled into 2 instructions and 1 instruction has a value but other has nothing since it is optimized out.
In that case, you can not fold those into one event, even if ftrace supported multiple probes on one event. With this feature, you can set a dummy value like foo=\deadbeef instead of something like foo=%di.
--- Documentation/trace/kprobetrace.rst | 1 + Documentation/trace/uprobetracer.rst | 1 + kernel/trace/trace.c | 2 +- kernel/trace/trace_probe.c | 18 ++++++++++++++++++ kernel/trace/trace_probe.h | 1 + 5 files changed, 22 insertions(+), 1 deletion(-)
Documentation/trace/kprobetrace.rst +1 -0
@@ -52,6 +52,7 @@ Synopsis of kprobe_events $retval : Fetch return value.(\*2) $comm : Fetch current task comm. +|-[u]OFFS(FETCHARG) : Fetch memory at FETCHARG +|- OFFS address.(\*3)(\*4) + \IMM : Store an immediate value to the argument. NAME=FETCHARG : Set NAME as the argument name of FETCHARG. FETCHARG:TYPE : Set TYPE as the type of FETCHARG. Currently, basic types (u8/u16/u32/u64/s8/s16/s32/s64), hexadecimal types
Documentation/trace/uprobetracer.rst +1 -0
@@ -45,6 +45,7 @@ Synopsis of uprobe_tracer $retval : Fetch return value.(\*1) $comm : Fetch current task comm. +|-[u]OFFS(FETCHARG) : Fetch memory at FETCHARG +|- OFFS address.(\*2)(\*3) + \IMM : Store an immediate value to the argument. NAME=FETCHARG : Set NAME as the argument name of FETCHARG. FETCHARG:TYPE : Set TYPE as the type of FETCHARG. Currently, basic types (u8/u16/u32/u64/s8/s16/s32/s64), hexadecimal types
kernel/trace/trace.c +1 -1
@@ -4846,7 +4846,7 @@ static const char readme_msg[] =#else "\t $stack<index>, $stack, $retval, $comm,\n"#endif -"\t +|-[u]<offset>(<fetcharg>)\n" +"\t +|-[u]<offset>(<fetcharg>), \\imm-value\n" "\t type: s8/16/32/64, u8/16/32/64, x8/16/32/64, string, symbol,\n" "\t b<bit-width>@<bit-offset>/<container-size>, ustring,\n" "\t <type>\\[<array-size>\\]\n"
kernel/trace/trace_probe.c +18 -0
@@ -316,6 +316,17 @@ static int parse_probe_vars(char *arg, const struct fetch_type *t,return -EINVAL ; } +static int str_to_immediate (char *str,unsigned long *imm) +{ +if (isdigit (str[0 ])) +return kstrtoul (str,0 , imm); +else if (str[0 ] =='-' ) +return kstrtol (str,0 , (long *)imm); +else if (str[0 ] =='+' ) +return kstrtol (str +1 ,0 , (long *)imm); +return -EINVAL ; +} +/* Recursive argument parser */ static int parse_probe_arg(char *arg, const struct fetch_type *type,
@@ -444,6 +455,13 @@ parse_probe_arg(char *arg, const struct fetch_type *type, code->offset = offset; }break ; +case '\\' :/* Immediate value */ + ret =str_to_immediate (arg +1 , &code->immediate); +if (ret) +trace_probe_log_err (offs +1 ,BAD_IMM ); +else + code->op =FETCH_OP_IMM ; +break ; }if (!ret && code->op ==FETCH_OP_NOP ) {/* Parsed, but do not find fetch method */
kernel/trace/trace_probe.h +1 -0
@@ -408,6 +408,7 @@ extern int traceprobe_define_arg_fields(struct trace_event_call *event_call,C (BAD_VAR ,"Invalid $-valiable specified" ), \C (BAD_REG_NAME ,"Invalid register name" ), \C (BAD_MEM_ADDR ,"Invalid memory address" ), \ +C (BAD_IMM ,"Invalid immediate value" ), \C (FILE_ON_KPROBE ,"File offset is not available with kprobe" ), \C (BAD_FILE_OFFS ,"Invalid file offset value" ), \ C(SYM_ON_UPROBE, "Symbol is not available with uprobe"), \
Masami Hiramatsu
maintainerPATCH 18/21 tracing/probe: Add immediate string parameter support
In reply to Masami HiramatsuAdd immediate string parameter (\"string") support to probe events. This allows you to specify an immediate (or dummy) parameter instead of fetching a string from memory.
This feature looks odd, but imagine that you put a probe on a code to trace some string data. If the code is compiled into 2 instructions and 1 instruction has a string on memory but other has no string since it is optimized out. In that case, you can not fold those into one event, even if ftrace supported multiple probes on one event. With this feature, you can set a dummy string like foo=\"(optimized)":string instead of something like foo=+0(+0(%bp)):string.
--- kernel/trace/trace.c | 2 +- kernel/trace/trace_kprobe.c | 3 ++ kernel/trace/trace_probe.c | 56 ++++++++++++++++++++++++++++++++----------- kernel/trace/trace_probe.h | 2 ++ kernel/trace/trace_uprobe.c | 3 ++ 5 files changed, 51 insertions(+), 15 deletions(-)
kernel/trace/trace.c +1 -1
@@ -4846,7 +4846,7 @@ static const char readme_msg[] =#else "\t $stack<index>, $stack, $retval, $comm,\n"#endif -"\t +|-[u]<offset>(<fetcharg>), \\imm-value\n" +"\t +|-[u]<offset>(<fetcharg>), \\imm-value, \\\"imm-string\"\n" "\t type: s8/16/32/64, u8/16/32/64, x8/16/32/64, string, symbol,\n" "\t b<bit-width>@<bit-offset>/<container-size>, ustring,\n" "\t <type>\\[<array-size>\\]\n"
kernel/trace/trace_kprobe.c +3 -0
@@ -1055,6 +1055,9 @@ process_fetch_insn(struct fetch_insn *code, struct pt_regs *regs, void *dest,case FETCH_OP_COMM : val = (unsigned long )current->comm;break ; +case FETCH_OP_DATA : + val = (unsigned long )code->data; +break ;#ifdef CONFIG_HAVE_FUNCTION_ARG_ACCESS_API case FETCH_OP_ARG : val =regs_get_kernel_argument (regs, code->param);
kernel/trace/trace_probe.c +42 -14
104 lines not on this page · raw message
kernel/trace/trace_probe.h +2 -0
@@ -89,6 +89,7 @@ enum fetch_op {FETCH_OP_COMM ,/* Current comm */ FETCH_OP_ARG ,/* Function argument : .param */ FETCH_OP_FOFFS ,/* File offset: .immediate */ +FETCH_OP_DATA ,/* Allocated data: .data */ // Stage 2 (dereference) op FETCH_OP_DEREF ,/* Dereference: .offset */ FETCH_OP_UDEREF, /* User-space Dereference: .offset */
@@ -409,6 +410,7 @@ extern int traceprobe_define_arg_fields(struct trace_event_call *event_call,C (BAD_REG_NAME ,"Invalid register name" ), \C (BAD_MEM_ADDR ,"Invalid memory address" ), \C (BAD_IMM ,"Invalid immediate value" ), \ +C (IMMSTR_NO_CLOSE ,"String is not closed with '\"'" ), \C (FILE_ON_KPROBE ,"File offset is not available with kprobe" ), \C (BAD_FILE_OFFS ,"Invalid file offset value" ), \ C(SYM_ON_UPROBE, "Symbol is not available with uprobe"), \
kernel/trace/trace_uprobe.c +3 -0
@@ -248,6 +248,9 @@ process_fetch_insn(struct fetch_insn *code, struct pt_regs *regs, void *dest,case FETCH_OP_COMM : val =FETCH_TOKEN_COMM ;break ; +case FETCH_OP_DATA : + val = (unsigned long )code->data; +break ;case FETCH_OP_FOFFS : val =translate_user_vaddr (code->immediate);break ;
Masami Hiramatsu
maintainerPATCH 19/21 selftests/ftrace: Add a testcase for kprobe multiprobe event
In reply to Masami HiramatsuAdd a testcase for kprobe event with multi-probe.
--- .../ftrace/test.d/kprobe/kprobe_multiprobe.tc | 35 ++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_multiprobe.tc
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_multiprobe.tc new file +35 -0
@@ -0,0 +1,35 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: Create/delete multiprobe on kprobe event + +[ -f kprobe_events ] || exit_unsupported + +grep -q "Create/append/" README || exit_unsupported + +# Choose 2 symbols for target +SYM1=_do_fork +SYM2=do_exit +EVENT_NAME=kprobes/testevent + +DEF1="p:$EVENT_NAME $SYM1" +DEF2="p:$EVENT_NAME $SYM2" + +:;: "Define an event which has 2 probes" ;: +echo $DEF1 >> kprobe_events +echo $DEF2 >> kprobe_events +cat kprobe_events | grep "$DEF1" +cat kprobe_events | grep "$DEF2" + +:;: "Remove the event by name (should remove both)" ;: +echo "-:$EVENT_NAME" >> kprobe_events +test `cat kprobe_events | wc -l` -eq 0 + +:;: "Remove just 1 event" ;: +echo $DEF1 >> kprobe_events +echo $DEF2 >> kprobe_events +echo "-:$EVENT_NAME $SYM1" >> kprobe_events +! cat kprobe_events | grep "$DEF1" +cat kprobe_events | grep "$DEF2" + +:;: "Appending different type must fail" ;: +! echo "$DEF1 \$stack" >> kprobe_events
Masami Hiramatsu
maintainerPATCH 20/21 selftests/ftrace: Add syntax error test for immediates
In reply to Masami HiramatsuAdd syntax error test cases for immediate value and immediate string.
--- .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 5 +++++ 1 file changed, 5 insertions(+)
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc +5 -0
@@ -41,6 +41,11 @@ check_error 'p vfs_read ^%none_reg' # BAD_REG_NAME check_error 'p vfs_read ^@12345678abcde' # BAD_MEM_ADDR check_error 'p vfs_read ^@+10' # FILE_ON_KPROBE +grep -q "imm-value" README && \ +check_error 'p vfs_read arg1=\^x' # BAD_IMM +grep -q "imm-string" README && \ +check_error 'p vfs_read arg1=\"abcd^' # IMMSTR_NO_CLOSE + check_error 'p vfs_read ^+0@0)' # DEREF_NEED_BRACE check_error 'p vfs_read ^+0ab1(@0)' # BAD_DEREF_OFFS check_error 'p vfs_read +0(+0(@0^)' # DEREF_OPEN_BRACE
Masami Hiramatsu
maintainerPATCH 21/21 selftests/ftrace: Add syntax error test for multiprobe
In reply to Masami HiramatsuAdd syntax error test cases for multiprobe appending errors.
--- tools/testing/selftests/ftrace/test.d/functions | 2 +- .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-)
tools/testing/selftests/ftrace/test.d/functions +1 -1
@@ -115,7 +115,7 @@ ftrace_errlog_check() { # err-prefix command-with-error-pos-by-^ command-file command=$(echo "$2" | tr -d ^) echo "Test command: $command" echo > error_log - (! echo "$command" > "$3" ) 2> /dev/null + (! echo "$command" >> "$3" ) 2> /dev/null grep "$1: error:" -A 3 error_log N=$(tail -n 1 error_log | wc -c) # " Command: " and "^\n" => 13
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc +10 -0
@@ -87,4 +87,14 @@ case $(uname -m) in ;; esac +# multiprobe errors +if grep -q "Create/append/" README && grep -q "imm-value" README; then +echo 'p:kprobes/testevent _do_fork' > kprobe_events +check_error '^r:kprobes/testevent do_exit' # DIFF_PROBE_TYPE +echo 'p:kprobes/testevent _do_fork abcd=\1' > kprobe_events +check_error 'p:kprobes/testevent _do_fork ^bcd=\1' # DIFF_ARG_TYPE +check_error 'p:kprobes/testevent _do_fork ^abcd=\1:u8' # DIFF_ARG_TYPE +check_error 'p:kprobes/testevent _do_fork ^abcd=\"foo"' # DIFF_ARG_TYPE +fi + exit 0