Skip to contentSkip to conversation

ARM: dts: aspeed: swift: Add VDD (IR35219) devices

PATCH New Adriana Kobylak 2 participants 4 messages May 31, 2019 – Jun 3, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: swift: Add VDD (IR35219) devices

From: Adriana Kobylak <[email protected]>

Add the VDD (IR35219) devices to the Swift device tree.

---
 arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-swift.dts +10 -0
index 270c923..8590e6b 100644
@@ -723,6 +723,11 @@
 		reg = <0x4c>;
 	};
 
+	ir35219 at 70 {
+		compatible = "infineon,ir35219";
+		reg = <0x70>;
+	};
+
 	ir35221 at 71 {
 		compatible = "infineon,ir35221";
 		reg = <0x71>;
@@ -820,6 +825,11 @@
 		reg = <0x4c>;
 	};
 
+	ir35219 at 70 {
+		compatible = "infineon,ir35219";
+		reg = <0x70>;
+	};
+
 	ir35221 at 71 {
 		compatible = "infineon,ir35221";
 		reg = <0x71>;
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw

PATCH 1/1 ARM: dts: aspeed: swift: Add VDD (IR35219) devices

Review

Quoted 7 lines · Adriana Kobylak

From: Adriana Kobylak <[email protected]>

Add the VDD (IR35219) devices to the Swift device tree.

(quoted diff) +2 -0
+       ir35219 at 70 {
+               compatible = "infineon,ir35219";

There's no driver for these in our tree. Do you have one coming?

#2 lore raw

PATCH 1/1 ARM: dts: aspeed: swift: Add VDD (IR35219) devices

Quoted 10 lines · Joel Stanley

Review

Quoted 7 lines · Adriana Kobylak

From: Adriana Kobylak <[email protected]>

Add the VDD (IR35219) devices to the Swift device tree.

(quoted diff) +2 -0
+       ir35219@70 {
+               compatible = "infineon,ir35219";

There's no driver for these in our tree. Do you have one coming?

Eddie will be writing one [Swift VDD VRM device driver #311](https://github.com/ibm-openbmc/dev/issues/311) Should we put this patch on hold until the driver is done?

maintainer
#3 lore raw

PATCH 1/1 ARM: dts: aspeed: swift: Add VDD (IR35219) devices

Quoted 9 lines · Adriana Kobylak
Quoted 7 lines · Joel Stanley
Quoted 5 lines · Adriana Kobylak

From: Adriana Kobylak <[email protected]>

Add the VDD (IR35219) devices to the Swift device tree.

Quoted 8 lines
Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+       ir35219 at 70 {
+               compatible = "infineon,ir35219";

There's no driver for these in our tree. Do you have one coming?

Eddie will be writing one [Swift VDD VRM device driver #311](https://github.com/ibm-openbmc/dev/issues/311) Should we put this patch on hold until the driver is done?

Yes. We generally don't put things in the device tree if there's no driver.

Cheers,

Joel