Skip to contentSkip to conversation

devtools: move ABI scripts from buildtools

PATCH In review David Marchand 2 participants 4 messages Nov 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devtools: move ABI scripts from buildtools

Those scripts are only used by developers and not part of the build process.

---
 MAINTAINERS                                        | 8 ++++----
 {buildtools => devtools}/check-abi-version.sh      | 0
 {buildtools => devtools}/update-abi.sh             | 2 +-
 {buildtools => devtools}/update_version_map_abi.py | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
 rename {buildtools => devtools}/check-abi-version.sh (100%)
 rename {buildtools => devtools}/update-abi.sh (95%)
 rename {buildtools => devtools}/update_version_map_abi.py (99%)
MAINTAINERS +4 -4
index b51059bc2..4395d8df1 100644
@@ -143,13 +143,13 @@ M: Neil Horman <[email protected]>
 F: lib/librte_eal/common/include/rte_compat.h
 F: lib/librte_eal/common/include/rte_function_versioning.h
 F: doc/guides/rel_notes/deprecation.rst
-F: devtools/validate-abi.sh
+F: devtools/check-abi-version.sh
 F: devtools/check-symbol-change.sh
-F: buildtools/check-abi-version.sh
+F: devtools/update-abi.sh
+F: devtools/update_version_map_abi.py
+F: devtools/validate-abi.sh
 F: buildtools/check-experimental-syms.sh
 F: buildtools/map-list-symbol.sh
-F: buildtools/update-abi.sh
-F: buildtools/update_version_map_abi.py
 
 Driver information
 M: Neil Horman <[email protected]>
devtools/check-abi-version.sh renamed from buildtools/check-abi-version.sh +0 -0
similarity index 100%
rename from buildtools/check-abi-version.sh
rename to devtools/check-abi-version.sh
devtools/update-abi.sh renamed from buildtools/update-abi.sh +1 -1
similarity index 95%
rename from buildtools/update-abi.sh
rename to devtools/update-abi.sh
index 15bc6feab..b9b859a3e 100755
@@ -42,5 +42,5 @@ echo "Path to update:" $update_path
 echo $abi_version > $abi_version_file
 
 find $update_path -name  \*version.map -exec \
-      ./buildtools/update_version_map_abi.py {} \
+      devtools/update_version_map_abi.py {} \
       $abi_version \; -print
devtools/update_version_map_abi.py renamed from buildtools/update_version_map_abi.py +1 -1
similarity index 99%
rename from buildtools/update_version_map_abi.py
rename to devtools/update_version_map_abi.py
index 6b9aff7a4..616412a1c 100755
@@ -6,7 +6,7 @@
 A Python program that updates and merges all available stable ABI versions into
 one ABI version, while leaving experimental ABI exactly as it is. The intended
 ABI version is supplied via command-line parameter. This script is to be called
-from the buildtools/update-abi.sh utility.
+from the devtools/update-abi.sh utility.
 """
 
 from __future__ import print_function
Signature · 1 line
2.23.0
#2 lore raw
Quoted 9 lines · Thomas Monjalon

28/11/2019 14:46, David Marchand:

Quoted 4 lines

Those scripts are only used by developers and not part of the build process.

I hesitated to accept these scripts in buildtools. I agree it is better in devtools, and not installed.

Yes, forgot to mention that update_version_map_abi.py raised an issue in the Centos 8 packaging test in OBS.
Relooking at those scripts, there is no reason to install them as part of a dpdk package.

Signature · 1 line
David Marchand