Skip to contentSkip to conversation

mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()

PATCH Superseded Pingfan Liu 4 participants 15 messages Jun 3, 2019 – Jun 4, 2019

Subsystems (2)

v2 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()

As for FOLL_LONGTERM, it is checked in the slow path __gup_longterm_unlocked(). But it is not checked in the fast path, which means a possible leak of CMA page to longterm pinned requirement through this crack.

Place a check in the fast path.

Cc Ira Weiny <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Dan Williams <[email protected]>
Cc Matthew Wilcox <[email protected]>
Cc John Hubbard <[email protected]>
Cc "Aneesh Kumar K.V" <[email protected]>
Cc Keith Busch <[email protected]>
---
 mm/gup.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
mm/gup.c +24 -0
index f173fcb..6fe2feb 100644
@@ -2196,6 +2196,29 @@ static int __gup_longterm_unlocked(unsigned long start, int nr_pages,
 	return ret;
 }
 
+#if defined(CONFIG_CMA)
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)
+{
+	if (unlikely(gup_flags & FOLL_LONGTERM)) {
+		int i = 0;
+
+		for (i = 0; i < nr_pinned; i++)
+			if (is_migrate_cma_page(pages[i])) {
+				put_user_pages(pages + i, nr_pinned - i);
+				return i;
+			}
+	}
+	return nr_pinned;
+}
+#else
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)
+{
+	return nr_pinned;
+}
+#endif
+
 /**
  * get_user_pages_fast() - pin user pages in memory
  * @start:	starting user address
@@ -2236,6 +2259,7 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
 		ret = nr;
 	}
 
+	nr = reject_cma_pages(nr, gup_flags, pages);
 	if (nr < nr_pages) {
 		/* Try to get the remaining pages with get_user_pages */
 		start += nr << PAGE_SHIFT;
Signature · 1 line
2.7.5
#1 lore raw

PATCH v2 2/2 mm/gup: rename nr as nr_pinned in get_user_pages_fast()

To better reflect the held state of pages and make code self-explaining, rename nr as nr_pinned.

Cc Ira Weiny <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Dan Williams <[email protected]>
Cc Matthew Wilcox <[email protected]>
Cc John Hubbard <[email protected]>
Cc "Aneesh Kumar K.V" <[email protected]>
Cc Keith Busch <[email protected]>
---
 mm/gup.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
mm/gup.c +11 -11
index 6fe2feb..106ab22 100644
@@ -2239,7 +2239,7 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
 			unsigned int gup_flags, struct page **pages)
 {
 	unsigned long addr, len, end;
-	int nr = 0, ret = 0;
+	int nr_pinned = 0, ret = 0;
 
 	start &= PAGE_MASK;
 	addr = start;
@@ -2254,26 +2254,26 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
 
 	if (gup_fast_permitted(start, nr_pages)) {
 		local_irq_disable();
-		gup_pgd_range(addr, end, gup_flags, pages, &nr);
+		gup_pgd_range(addr, end, gup_flags, pages, &nr_pinned);
 		local_irq_enable();
-		ret = nr;
+		ret = nr_pinned;
 	}
 
-	nr = reject_cma_pages(nr, gup_flags, pages);
-	if (nr < nr_pages) {
+	nr_pinned = reject_cma_pages(nr_pinned, gup_flags, pages);
+	if (nr_pinned < nr_pages) {
 		/* Try to get the remaining pages with get_user_pages */
-		start += nr << PAGE_SHIFT;
-		pages += nr;
+		start += nr_pinned << PAGE_SHIFT;
+		pages += nr_pinned;
 
-		ret = __gup_longterm_unlocked(start, nr_pages - nr,
+		ret = __gup_longterm_unlocked(start, nr_pages - nr_pinned,
 					      gup_flags, pages);
 
 		/* Have to be a bit careful with return values */
-		if (nr > 0) {
+		if (nr_pinned > 0) {
 			if (ret < 0)
-				ret = nr;
+				ret = nr_pinned;
 			else
-				ret += nr;
+				ret += nr_pinned;
 		}
 	}
 
Signature · 1 line
2.7.5
Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCHv2 2/2] mm/gup: rename nr as nr_pinned in get_user_pages_fast()

Quoted 4 lines · Pingfan Liu

To better reflect the held state of pages and make code self-explaining, rename nr as nr_pinned.

Quoted 66 lines
Cc Ira Weiny <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Dan Williams <[email protected]>
Cc Matthew Wilcox <[email protected]>
Cc John Hubbard <[email protected]>
Cc "Aneesh Kumar K.V" <[email protected]>
Cc Keith Busch <[email protected]>
---
 mm/gup.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
mm/gup.c +11 -11
index 6fe2feb..106ab22 100644
@@ -2239,7 +2239,7 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
 			unsigned int gup_flags, struct page **pages)
 {
 	unsigned long addr, len, end;
-	int nr = 0, ret = 0;
+	int nr_pinned = 0, ret = 0;
 
 	start &= PAGE_MASK;
 	addr = start;
@@ -2254,26 +2254,26 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
 
 	if (gup_fast_permitted(start, nr_pages)) {
 		local_irq_disable();
-		gup_pgd_range(addr, end, gup_flags, pages, &nr);
+		gup_pgd_range(addr, end, gup_flags, pages, &nr_pinned);
 		local_irq_enable();
-		ret = nr;
+		ret = nr_pinned;
 	}
 
-	nr = reject_cma_pages(nr, gup_flags, pages);
-	if (nr < nr_pages) {
+	nr_pinned = reject_cma_pages(nr_pinned, gup_flags, pages);
+	if (nr_pinned < nr_pages) {
 		/* Try to get the remaining pages with get_user_pages */
-		start += nr << PAGE_SHIFT;
-		pages += nr;
+		start += nr_pinned << PAGE_SHIFT;
+		pages += nr_pinned;
 
-		ret = __gup_longterm_unlocked(start, nr_pages - nr,
+		ret = __gup_longterm_unlocked(start, nr_pages - nr_pinned,
 					      gup_flags, pages);
 
 		/* Have to be a bit careful with return values */
-		if (nr > 0) {
+		if (nr_pinned > 0) {
 			if (ret < 0)
-				ret = nr;
+				ret = nr_pinned;
 			else
-				ret += nr;
+				ret += nr_pinned;
 		}
 	}
 
Signature · 1 line
2.7.5
Reviewed-by on v2 1/2
#3 lore raw
In reply to Pingfan Liu
Quoted 8 lines · Pingfan Liu

As for FOLL_LONGTERM, it is checked in the slow path __gup_longterm_unlocked(). But it is not checked in the fast path, which means a possible leak of CMA page to longterm pinned requirement through this crack.

Place a check in the fast path.

Quoted 58 lines
Cc Ira Weiny <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Dan Williams <[email protected]>
Cc Matthew Wilcox <[email protected]>
Cc John Hubbard <[email protected]>
Cc "Aneesh Kumar K.V" <[email protected]>
Cc Keith Busch <[email protected]>
---
 mm/gup.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
mm/gup.c +24 -0
index f173fcb..6fe2feb 100644
@@ -2196,6 +2196,29 @@ static int __gup_longterm_unlocked(unsigned long start, int nr_pages,
 	return ret;
 }
 
+#if defined(CONFIG_CMA)
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)
+{
+	if (unlikely(gup_flags & FOLL_LONGTERM)) {
+		int i = 0;
+
+		for (i = 0; i < nr_pinned; i++)
+			if (is_migrate_cma_page(pages[i])) {
+				put_user_pages(pages + i, nr_pinned - i);
+				return i;
+			}
+	}
+	return nr_pinned;
+}
+#else
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)
+{
+	return nr_pinned;
+}
+#endif
+
 /**
  * get_user_pages_fast() - pin user pages in memory
  * @start:	starting user address
@@ -2236,6 +2259,7 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
 		ret = nr;
 	}
 
+	nr = reject_cma_pages(nr, gup_flags, pages);
 	if (nr < nr_pages) {
 		/* Try to get the remaining pages with get_user_pages */
 		start += nr << PAGE_SHIFT;
Signature · 1 line
2.7.5
#4 lore raw
In reply to Pingfan Liu
Quoted 1 line

+#if defined(CONFIG_CMA)

You can just use #ifdef here.

Review

Quoted 2 lines
(quoted diff) +2 -0
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)

Please use two instead of one tab to indent the continuing line of a function declaration.

mm/gup.c static int __gup_longterm_unlocked(unsigned long start, int nr_pages, · line 2203

Quoted 2 lines
mm/gup.c +2 -0
+{
+	if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.

reviewer
#5 lore raw
Quoted 10 lines · Christoph Hellwig
Quoted 1 line

+#if defined(CONFIG_CMA)

You can just use #ifdef here.

Review

Quoted 2 lines
(quoted diff) +2 -0
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)

Please use two instead of one tab to indent the continuing line of a function declaration.

Quoted 5 lines

mm/gup.c static int __gup_longterm_unlocked(unsigned long start, int nr_pages, · line 2203

Quoted 2 lines
mm/gup.c +2 -0
+{
+	if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.

It does feel wrong-ish to loop through potentially every page that gup_fast just followed. But could you clarify what you had in mind just a bit more detail? For example, in qib_user_sdma_pin_pages() we have:

    ret = get_user_pages_fast(addr, j, FOLL_LONGTERM, pages);

Should this call a filter routine to avoid CMA pages, is that it?

thanks,

Signature · 2 lines
John Hubbard
NVIDIA
#6 lore raw
In reply to Christoph Hellwig
Quoted 10 lines · Christoph Hellwig
Quoted 1 line

+#if defined(CONFIG_CMA)

You can just use #ifdef here.

Review

Quoted 2 lines
(quoted diff) +2 -0
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)

Please use two instead of one tab to indent the continuing line of a function declaration.

Quoted 4 lines

mm/gup.c static int __gup_longterm_unlocked(unsigned long start, int nr_pages, · line 2203

Quoted 2 lines
mm/gup.c +2 -0
+{
+	if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.

FWIW we already had this discussion and thought it better to put this here.

https://lkml.org/lkml/2019/5/30/1565

Ira

[PS John for some reason your responses don't appear in that thread?]

#7 lore raw
Quoted 11 lines · Ira Weiny
Quoted 10 lines · Christoph Hellwig
Quoted 1 line

+#if defined(CONFIG_CMA)

You can just use #ifdef here.

Review

Quoted 2 lines
(quoted diff) +2 -0
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)

Please use two instead of one tab to indent the continuing line of a function declaration.

Quoted 8 lines
Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+{
+	if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.

FWIW we already had this discussion and thought it better to put this here.

https://lkml.org/lkml/2019/5/30/1565

I don't see any discussion like this. FYI, this is what I mean, code might be easier than words:

mm/gup.c +24 -0
index ddde097cf9e4..62d770b18e2c 100644
@@ -2197,6 +2197,27 @@ static int __gup_longterm_unlocked(unsigned long start, int nr_pages,
 	return ret;
 }
 
+#ifdef CONFIG_CMA
+static int reject_cma_pages(struct page **pages, int nr_pinned)
+{
+	int i = 0;
+
+	for (i = 0; i < nr_pinned; i++)
+		if (is_migrate_cma_page(pages[i])) {
+			put_user_pages(pages + i, nr_pinned - i);
+			return i;
+		}
+	}
+
+	return nr_pinned;
+}
+#else
+static inline int reject_cma_pages(struct page **pages, int nr_pinned)
+{
+	return nr_pinned;
+}
+#endif /* CONFIG_CMA */
+
 /**
  * get_user_pages_fast() - pin user pages in memory
  * @start:	starting user address
@@ -2237,6 +2258,9 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
 		ret = nr;
 	}
 
+	if (nr && unlikely(gup_flags & FOLL_LONGTERM))
+		nr = reject_cma_pages(pages, nr);
+
 	if (nr < nr_pages) {
 		/* Try to get the remaining pages with get_user_pages */
 		start += nr << PAGE_SHIFT;
#8 lore raw
Quoted 59 lines · Christoph Hellwig
Quoted 11 lines · Ira Weiny
Quoted 10 lines · Christoph Hellwig
Quoted 1 line

+#if defined(CONFIG_CMA)

You can just use #ifdef here.

Quoted 2 lines

+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+ struct page **pages)

Please use two instead of one tab to indent the continuing line of a function declaration.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

+{
+ if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.

FWIW we already had this discussion and thought it better to put this here.

https://lkml.org/lkml/2019/5/30/1565

I don't see any discussion like this. FYI, this is what I mean, code might be easier than words:

mm/gup.c +21 -0
index ddde097cf9e4..62d770b18e2c 100644
@@ -2197,6 +2197,27 @@ static int __gup_longterm_unlocked(unsigned long start, int nr_pages,
        return ret;
 }
 
+#ifdef CONFIG_CMA
+static int reject_cma_pages(struct page **pages, int nr_pinned)
+{
+       int i = 0;
+
+       for (i = 0; i < nr_pinned; i++)
+               if (is_migrate_cma_page(pages[i])) {
+                       put_user_pages(pages + i, nr_pinned - i);
+                       return i;
+               }
+       }
+
+       return nr_pinned;
+}
+#else
+static inline int reject_cma_pages(struct page **pages, int nr_pinned)
+{
+       return nr_pinned;
+}
+#endif /* CONFIG_CMA */
+
 /**
  * get_user_pages_fast() - pin user pages in memory
  * @start:     starting user address

mm/gup.c int get_user_pages_fast(unsigned long start, int nr_pages, · line 2263

Quoted 6 lines
mm/gup.c +3 -0
@@ -2237,6 +2258,9 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
                ret = nr;
        }
 
+       if (nr && unlikely(gup_flags & FOLL_LONGTERM))
+               nr = reject_cma_pages(pages, nr);
+

Yeah. Looks better to keep reject_cma_pages() away from gup flags.

Quoted 3 lines
mm/gup.c +0 -0
        if (nr < nr_pages) {
                /* Try to get the remaining pages with get_user_pages */
                start += nr << PAGE_SHIFT;
#9 lore raw
In reply to Christoph Hellwig
Quoted 17 lines · Christoph Hellwig
Quoted 16 lines · Ira Weiny
Quoted 14 lines · Christoph Hellwig
Quoted 1 line

+#if defined(CONFIG_CMA)

You can just use #ifdef here.

Review

Quoted 2 lines
(quoted diff) +2 -0
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)

Please use two instead of one tab to indent the continuing line of a function declaration.

Review

Quoted 2 lines
(quoted diff) +2 -0
+{
+	if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.

Quoted 6 lines
Quoted 3 lines

FWIW we already had this discussion and thought it better to put this here.

https://lkml.org/lkml/2019/5/30/1565

I don't see any discussion like this. FYI, this is what I mean, code might be easier than words:

Indeed that is more clear. My apologies.

Ira

Quoted 45 lines
mm/gup.c +24 -0
index ddde097cf9e4..62d770b18e2c 100644
@@ -2197,6 +2197,27 @@ static int __gup_longterm_unlocked(unsigned long start, int nr_pages,
 	return ret;
 }
 
+#ifdef CONFIG_CMA
+static int reject_cma_pages(struct page **pages, int nr_pinned)
+{
+	int i = 0;
+
+	for (i = 0; i < nr_pinned; i++)
+		if (is_migrate_cma_page(pages[i])) {
+			put_user_pages(pages + i, nr_pinned - i);
+			return i;
+		}
+	}
+
+	return nr_pinned;
+}
+#else
+static inline int reject_cma_pages(struct page **pages, int nr_pinned)
+{
+	return nr_pinned;
+}
+#endif /* CONFIG_CMA */
+
 /**
  * get_user_pages_fast() - pin user pages in memory
  * @start:	starting user address
@@ -2237,6 +2258,9 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
 		ret = nr;
 	}
 
+	if (nr && unlikely(gup_flags & FOLL_LONGTERM))
+		nr = reject_cma_pages(pages, nr);
+
 	if (nr < nr_pages) {
 		/* Try to get the remaining pages with get_user_pages */
 		start += nr << PAGE_SHIFT;
reviewer
#10 lore raw
Quoted 67 lines · Ira Weiny
Quoted 17 lines · Christoph Hellwig
Quoted 16 lines · Ira Weiny
Quoted 14 lines · Christoph Hellwig
Quoted 1 line

+#if defined(CONFIG_CMA)

You can just use #ifdef here.

Review

Quoted 2 lines
(quoted diff) +2 -0
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)

Please use two instead of one tab to indent the continuing line of a function declaration.

Review

Quoted 2 lines
(quoted diff) +2 -0
+{
+	if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.

Quoted 6 lines
Quoted 3 lines

FWIW we already had this discussion and thought it better to put this here.

https://lkml.org/lkml/2019/5/30/1565

I don't see any discussion like this. FYI, this is what I mean, code might be easier than words:

Indeed that is more clear. My apologies.

Ira

Quoted 38 lines
mm/gup.c +21 -0
index ddde097cf9e4..62d770b18e2c 100644
@@ -2197,6 +2197,27 @@ static int __gup_longterm_unlocked(unsigned long start, int nr_pages,
 	return ret;
 }
 
+#ifdef CONFIG_CMA
+static int reject_cma_pages(struct page **pages, int nr_pinned)
+{
+	int i = 0;
+
+	for (i = 0; i < nr_pinned; i++)
+		if (is_migrate_cma_page(pages[i])) {
+			put_user_pages(pages + i, nr_pinned - i);
+			return i;
+		}
+	}
+
+	return nr_pinned;
+}
+#else
+static inline int reject_cma_pages(struct page **pages, int nr_pinned)
+{
+	return nr_pinned;
+}
+#endif /* CONFIG_CMA */
+
 /**
  * get_user_pages_fast() - pin user pages in memory
  * @start:	starting user address
@@ -2237,6 +2258,9 @@ int get_user_pages_fast(unsigned long start, int nr_pages,
 		ret = nr;
 	}
 
Quoted 3 lines

mm/gup.c int get_user_pages_fast(unsigned long start, int nr_pages, · line 2263

Quoted 3 lines
mm/gup.c +3 -0
+	if (nr && unlikely(gup_flags & FOLL_LONGTERM))
+		nr = reject_cma_pages(pages, nr);
+

Yes, now I see what you meant, and agree that that is cleaner.

thanks,

Signature · 2 lines
John Hubbard
NVIDIA
Quoted 4 lines
Quoted 4 lines
mm/gup.c +0 -0
 	if (nr < nr_pages) {
 		/* Try to get the remaining pages with get_user_pages */
 		start += nr << PAGE_SHIFT;
reviewer
#11 lore raw
In reply to Ira Weiny
Quoted 16 lines · Ira Weiny
Quoted 10 lines · Christoph Hellwig
Quoted 1 line

+#if defined(CONFIG_CMA)

You can just use #ifdef here.

Review

Quoted 2 lines
(quoted diff) +2 -0
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+	struct page **pages)

Please use two instead of one tab to indent the continuing line of a function declaration.

Quoted 4 lines

mm/gup.c static int __gup_longterm_unlocked(unsigned long start, int nr_pages, · line 2203

Quoted 2 lines
mm/gup.c +2 -0
+{
+	if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.

Quoted 7 lines

FWIW we already had this discussion and thought it better to put this here.

https://lkml.org/lkml/2019/5/30/1565

Ira

[PS John for some reason your responses don't appear in that thread?]

Thanks for pointing out the email glitches! It looks like it's making it over to lore.kernel.org/linux-mm, but not to lkml.org, nor to the lore.kernel.org/lkml section either:

    https://lore.kernel.org/linux-mm/[email protected]/

...and I've already checked the DKIM signatures, they're all good. So I think this is getting narrowed down to, messages from nvidia.com (or at least from me) are not making it onto the lkml list server. I'm told that this can actually happen *because* of DKIM domains: list servers may try to avoid retransmitting from DKIM domains. sigh.

Any hints are welcome, otherwise I'll try to locate the lkml admins and see what can be done.

(+Sanket, Ralph from our email team)

thanks,

Signature · 2 lines
John Hubbard
NVIDIA
#12 lore raw
In reply to Christoph Hellwig
Quoted 5 lines · Christoph Hellwig
Quoted 2 lines

+#if defined(CONFIG_CMA)

You can just use #ifdef here.

OK.

Quoted 6 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
+     struct page **pages)

Please use two instead of one tab to indent the continuing line of a function declaration.

Is it a convention? scripts/checkpatch.pl can not detect it. Could you show me some light so later I can avoid it?

Thanks for your review.

Regards,
Pingfan

Quoted 4 lines

mm/gup.c static int __gup_longterm_unlocked(unsigned long start, int nr_pages, · line 2203

Quoted 2 lines
mm/gup.c +2 -0
+{
+     if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.

#13 lore raw
Quoted 2 lines · Pingfan Liu

Is it a convention? scripts/checkpatch.pl can not detect it. Could you show me some light so later I can avoid it?

If you look at most kernel code you can see two conventions:

- double tabe indent
- indent to the start of the first agument line

Everything else is rather unusual.

#14 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 2 lines · Pingfan Liu

Is it a convention? scripts/checkpatch.pl can not detect it. Could you show me some light so later I can avoid it?

If you look at most kernel code you can see two conventions:

- double tabe indent
- indent to the start of the first agument line

Everything else is rather unusual.

OK.
Thanks