ath11k: Fix the rate mask value for legacy and peer fixed rate
PATCH 1/1 ath11k: Fix the rate mask value for legacy and peer fixed rate
The rate mask value is changed from 0xff to oxffff (u8 to u32) in the firmware for the legacy fixed rate and peer fixed rate setting in the set bitrate command.
Hence this patch is fixing the same in the driver.
--- drivers/net/wireless/ath/ath11k/mac.c | 6 +++--- drivers/net/wireless/ath/ath11k/wmi.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/wireless/ath/ath11k/mac.c +3 -3
@@ -4454,7 +4454,7 @@ static int ath11k_mac_get_single_legacy_rate(struct ath11k *ar, enum nl80211_band band, const struct cfg80211_bitrate_mask *mask, - u8 *rate, u8 *nss) + u32 *rate, u8 *nss) { int rate_idx;u16 bitrate;
@@ -4484,7 +4484,7 @@ ath11k_mac_get_single_legacy_rate(struct ath11k *ar, }static int ath11k_mac_set_fixed_rate_params (struct ath11k_vif *arvif, -u8 rate,u8 nss,u8 sgi,u8 ldpc) +u32 rate,u8 nss,u8 sgi,u8 ldpc) {struct ath11k *ar = arvif->ar;u32 vdev_param;
@@ -4584,7 +4584,7 @@ ath11k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw,enum nl80211_band band;const u8 *ht_mcs_mask;const u16 *vht_mcs_mask; -u8 rate; +u32 rate;u8 nss;u8 sgi;u8 ldpc;
drivers/net/wireless/ath/ath11k/wmi.h +1 -1
@@ -4926,7 +4926,7 @@ enum wmi_ap_ps_peer_param {#define WMI_CIPHER_AES_GMAC 0xa/* Value to disable fixed rate setting */ -#define WMI_FIXED_RATE_NONE (0xff) +#define WMI_FIXED_RATE_NONE (0xffff)#define ATH11K_RC_VERSION_OFFSET 28#define ATH11K_RC_PREAMBLE_OFFSET 8
Signature · 7 lines
2.21.0 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 6 lines · Maharaja Kennadyrajan
The rate mask value is changed from
0xffto oxffff (u8 to u32) in the firmware for the legacy fixed rate and peer fixed rate setting in the set bitrate command.
Hence this patch is fixing the same in the driver.Signed-off-by Maharaja Kennadyrajan <[email protected]>
Is this backwards compatible change? I'm not convinced about that.
Signature · 9 lines
https://patchwork.kernel.org/patch/10974783/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 10 lines · Kalle Valo
Quoted 6 lines · Maharaja Kennadyrajan
The rate mask value is changed from
0xffto oxffff (u8 to u32) in the firmware for the legacy fixed rate and peer fixed rate setting in the set bitrate command.
Hence this patch is fixing the same in the driver.Signed-off-by Maharaja Kennadyrajan <[email protected]>Is this backwards compatible change? I'm not convinced about that.
[Maha]: It won't break the backward compatibility as firmware is taking care of it. Firmware is using 0xffff as mask value from the beginning and this change is not added recently in the firmware.
Signature · 7 lines
Regards, Maha _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 8 lines · Maharaja Kennadyrajan
Quoted 7 lines · Kalle Valo
Quoted 5 lines · Maharaja Kennadyrajan
The rate mask value is changed from
0xffto oxffff (u8 to u32) in the firmware for the legacy fixed rate and peer fixed rate setting in the set bitrate command.
Hence this patch is fixing the same in the driver.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Maharaja Kennadyrajan <[email protected]>Is this backwards compatible change? I'm not convinced about that.
[Maha]: It won't break the backward compatibility as firmware is taking care of it. Firmware is using
0xffffas mask value from the beginning and this change is not added recently in the firmware.
Good, thanks for the clarification.
Signature · 6 lines
Kalle Valo _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 12 lines · Kalle Valo
Quoted 10 lines · Maharaja Kennadyrajan
Quoted 9 lines · Kalle Valo
Quoted 6 lines · Maharaja Kennadyrajan
The rate mask value is changed from
0xffto oxffff (u8 to u32) in the firmware for the legacy fixed rate and peer fixed rate setting in the set bitrate command.
Hence this patch is fixing the same in the driver.Signed-off-by Maharaja Kennadyrajan <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Is this backwards compatible change? I'm not convinced about that.
[Maha]: It won't break the backward compatibility as firmware is taking care of it. Firmware is using
0xffffas mask value from the beginning and this change is not added recently in the firmware.Good, thanks for the clarification.
[Maha]: Thanks, please apply this is patch in ath.git
Signature · 7 lines
Regards, Maha _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 7 lines · Maharaja Kennadyrajan
The rate mask value is changed from
0xffto oxffff (u8 to u32) in the firmware for the legacy fixed rate and peer fixed rate setting in the set bitrate command.
Hence this patch is fixing the same in the driver.Signed-off-by Maharaja Kennadyrajan <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath11k-bringup branch of ath.git, thanks.
b23bdcc21752 ath11k: Fix the rate mask value for legacy and peer fixed rate
Signature · 9 lines
https://patchwork.kernel.org/patch/10974783/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k