Amazon's Annapurna Labs Fabric Interrupt Controller
Talel Shenhar
maintainerv3 cover Amazon's Annapurna Labs Fabric Interrupt Controller
This series introduces support for Amazon's Annapurna Labs Fabric Interrupt Controller.
The Amazon's Annapurna Labs FIC (Fabric Interrupt Controller) has 32 inputs/sources. This FIC may be cascaded into another FIC or connected directly to the main CPU Interrupt Controller (e.g. GIC).
Changes since v2:
=================
- updated dt-bindings to use proper format for entry name
- removed kernel-doc format style from Copyright
- removed unneeded/misplaced selects from Kconfig
- changed used mmio operation to relaxed flavor
- changed error return value from EPERM to EINVAL int case of attempting to reconfigure the FIC after it has been configured
- fixed commenting format
- used drivers define instead of subsystem internals
- moved al_fic_hw_init function to caller
- removed al_fic_wire_get_domain from documentation
- removed argument validation from al_fic_wire_init
Changes since v1:
=================
- removing unused exported APIs
- updating cover letter and commit message accordingly
Talel Shenhar (2):
dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC
irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt
Controller Driver
.../interrupt-controller/amazon,al-fic.txt | 22 ++ MAINTAINERS | 6 + drivers/irqchip/Kconfig | 8 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-al-fic.c | 278 +++++++++++++++++++++ 5 files changed, 315 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt create mode 100644 drivers/irqchip/irq-al-fic.c
Signature · 1 line
2.7.4
Talel Shenhar
maintainerPATCH v3 1/2 dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC
Document Amazon's Annapurna Labs Fabric Interrupt Controller SoC binding.
--- .../interrupt-controller/amazon,al-fic.txt | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt
Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt new file +22 -0
@@ -0,0 +1,22 @@ +Amazon's Annapurna Labs Fabric Interrupt Controller + +Required properties: + +- compatible: should be "amazon,al-fic" +- reg: physical base address and size of the registers +- interrupt-controller: identifies the node as an interrupt controller +- #interrupt-cells: must be 2. +- interrupt-parent: specifies the parent interrupt controller. +- interrupts: describes which input line in the interrupt parent, this + fic's output is connected to. + +Example: + +amazon_fic: interrupt-controller@0xfd8a8500 { + compatible = "amazon,al-fic"; + interrupt-controller; + #interrupt-cells = <1>; + reg = <0x0 0xfd8a8500 0x0 0x1000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 0x0 IRQ_TYPE_LEVEL_HIGH>; +};
Signature · 1 line
2.7.4
Re: [PATCH v3 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC
Quoted 1 line · Talel Shenhar
../..
Quoted 6 lines
+- compatible: should be "amazon,al-fic" +- reg: physical base address and size of the registers +- interrupt-controller: identifies the node as an interrupt controller +- #interrupt-cells: must be 2. +- interrupt-parent: specifies the parent interrupt controller. +- interrupts: describes which input line in the interrupt parent, this
Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt line 18
Quoted 8 lines
Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt new file +8
-0+ fic's output is connected to. + +Example: + +amazon_fic: interrupt-controller@0xfd8a8500 { + compatible = "amazon,al-fic"; + interrupt-controller; + #interrupt-cells = <1>;
^ should be 2
Quoted 4 lines
Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt new file +4
-0+ reg = <0x0 0xfd8a8500 0x0 0x1000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 0x0 IRQ_TYPE_LEVEL_HIGH>; +};
Talel Shenhar
maintainerPATCH v3 2/2 irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver
In reply to Talel ShenharThe Amazon's Annapurna Labs Fabric Interrupt Controller has 32 inputs lines. A FIC (Fabric Interrupt Controller) may be cascaded into another FIC or directly to the main CPU Interrupt Controller (e.g. GIC).
--- MAINTAINERS | 6 + drivers/irqchip/Kconfig | 8 ++ drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-al-fic.c | 278 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 293 insertions(+) create mode 100644 drivers/irqchip/irq-al-fic.c
MAINTAINERS +6 -0
@@ -1209,6 +1209,12 @@ S: Maintained F: Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt F: drivers/irqchip/irq-vic.c +AMAZON ANNAPURNA LABS FIC DRIVER +M: Talel Shenhar <[email protected]> +S: Maintained +F: Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt +F: drivers/irqchip/irq-al-fic.c + ARM SMMU DRIVERS M: Will Deacon <[email protected]> R: Robin Murphy <[email protected]>
drivers/irqchip/Kconfig +8 -0
@@ -89,6 +89,14 @@ config ALPINE_MSI select PCI_MSI select GENERIC_IRQ_CHIP +config AL_FIC + bool "Amazon's Annapurna Labs Fabric Interrupt Controller" + depends on OF || COMPILE_TEST + select GENERIC_IRQ_CHIP + select IRQ_DOMAIN + help + Support Amazon's Annapurna Labs Fabric Interrupt Controller. + config ATMEL_AIC_IRQ bool select GENERIC_IRQ_CHIP
drivers/irqchip/Makefile +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_IRQCHIP) += irqchip.o +obj-$(CONFIG_AL_FIC) += irq-al-fic.o obj-$(CONFIG_ALPINE_MSI) += irq-alpine-msi.o obj-$(CONFIG_ATH79) += irq-ath79-cpu.o obj-$(CONFIG_ATH79) += irq-ath79-misc.o
drivers/irqchip/irq-al-fic.c new file +278 -0
278 lines not on this page · raw message
Signature · 1 line
2.7.4
Quoted 33 lines · Talel Shenhar
This series introduces support for Amazon's Annapurna Labs Fabric Interrupt Controller.
The Amazon's Annapurna Labs FIC (Fabric Interrupt Controller) has 32 inputs/sources. This FIC may be cascaded into another FIC or connected directly to the main CPU Interrupt Controller (e.g. GIC).
Changes since v2:
=================
- updated dt-bindings to use proper format for entry name
- removed kernel-doc format style from Copyright
- removed unneeded/misplaced selects fromKconfig
- changed used mmio operation to relaxed flavor
- changed error return value from EPERM to EINVAL int case of attempting to reconfigure the FIC after it has been configured
- fixed commenting format
- used drivers define instead of subsystem internals
- movedal_fic_hw_initfunction to caller
- removedal_fic_wire_get_domainfrom documentation
- removed argument validation fromal_fic_wire_initChanges since v1:
=================
- removing unused exported APIs
- updating cover letter and commit message accordinglyTalel Shenhar (2):
dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC
irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt
Controller Driver
Quoted 9 lines
.../interrupt-controller/amazon,al-fic.txt | 22 ++ MAINTAINERS | 6 + drivers/irqchip/Kconfig | 8 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-al-fic.c | 278 +++++++++++++++++++++ 5 files changed, 315 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt create mode 100644 drivers/irqchip/irq-al-fic.c
OK, that's 3 version in about 8 hours, I'm simply going to ignore it (you'll need to post a v4 anyway). Please see Documentation/process/submitting-patches.rst, specifically points (8) and (9).
M.
Signature · 1 line
Jazz is not dead. It just smells funny...