Skip to contentSkip to conversation

Add minimal boot support for IPQ6018

PATCH In review Sricharan R 7 participants 32 messages Jun 5, 2019 – Jun 24, 2019

Subsystems (9)
lore
Share & tools
lore
#0 lore raw

cover Add minimal boot support for IPQ6018

The IPQ6018 is Qualcomm’s 802.11ax SoC for Routers, Gateways and Access Points.

This series adds minimal board boot support for ipq6018-cp01 board.

Sricharan R (6):
pinctrl: qcom: Add ipq6018 pinctrl driver
dt-bindings: qcom: Add ipq6018 bindings
clk: qcom: Add DT bindings for ipq6018 gcc clock controller
clk: qcom: Add ipq6018 Global Clock Controller support
arm64: dts: Add ipq6018 SoC and CP01 board support
arm64: defconfig: Enable qcom ipq6018 clock and pinctrl

 Documentation/devicetree/bindings/arm/qcom.yaml    |    2 +
 .../devicetree/bindings/clock/qcom,gcc.txt         |    1 +
 arch/arm64/boot/dts/qcom/Makefile                  |    1 +
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts       |   35 +
 arch/arm64/boot/dts/qcom/ipq6018.dtsi              |  231 +
 arch/arm64/configs/defconfig                       |    2 +
 drivers/clk/qcom/Kconfig                           |    9 +
 drivers/clk/qcom/Makefile                          |    1 +
 drivers/clk/qcom/gcc-ipq6018.c                     | 5267 ++++++++++++++++++++
 drivers/pinctrl/qcom/Kconfig                       |   10 +
 drivers/pinctrl/qcom/Makefile                      |    1 +
 drivers/pinctrl/qcom/pinctrl-ipq6018.c             | 1183 +++++
 include/dt-bindings/clock/qcom,gcc-ipq6018.h       |  405 ++
 13 files changed, 7148 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi
 create mode 100644 drivers/clk/qcom/gcc-ipq6018.c
 create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq6018.c
 create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq6018.h
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw

PATCH 1/6 pinctrl: qcom: Add ipq6018 pinctrl driver

Add initial pinctrl driver to support pin configuration with pinctrl framework for ipq6018.

---
 .../bindings/pinctrl/qcom,ipq6018-pinctrl.txt      |  186 +++
 drivers/pinctrl/qcom/Kconfig                       |   10 +
 drivers/pinctrl/qcom/Makefile                      |    1 +
 drivers/pinctrl/qcom/pinctrl-ipq6018.c             | 1183 ++++++++++++++++++++
 4 files changed, 1380 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt
 create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq6018.c
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt new file +186 -0
new file mode 100644
index 0000000..5a3edb1
@@ -0,0 +1,186 @@
+Qualcomm Technologies, Inc. IPQ6018 TLMM block
+
+This binding describes the Top Level Mode Multiplexer block found in the
+IPQ6018 platform.
+
+- compatible:
+	Usage: required
+	Value type: <string>
+	Definition: must be "qcom,ipq6018-pinctrl"
+
+- reg:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: the base address and size of the TLMM register space.
+
+- interrupts:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: should specify the TLMM summary IRQ.
+
+- interrupt-controller:
+	Usage: required
+	Value type: <none>
+	Definition: identifies this node as an interrupt controller
+
+- #interrupt-cells:
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/interrupt-controller/irq.h>
+
+- gpio-controller:
+	Usage: required
+	Value type: <none>
+	Definition: identifies this node as a gpio controller
+
+- #gpio-cells:
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/gpio/gpio.h>
+
+Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for
+a general description of GPIO and interrupt bindings.
+
+Please refer to pinctrl-bindings.txt in this directory for details of the
+common pinctrl bindings used by client devices, including the meaning of the
+phrase "pin configuration node".
+
+The pin configuration nodes act as a container for an arbitrary number of
+subnodes. Each of these subnodes represents some desired configuration for a
+pin, a group, or a list of pins or groups. This configuration can include the
+mux function to select on those pin(s)/group(s), and various pin configuration
+parameters, such as pull-up, drive strength, etc.
+
+
+PIN CONFIGURATION NODES:
+
+The name of each subnode is not important; all subnodes should be enumerated
+and processed purely based on their content.
+
+Each subnode only affects those parameters that are explicitly listed. In
+other words, a subnode that lists a mux function but no pin configuration
+parameters implies no information about any pin configuration parameters.
+Similarly, a pin subnode that describes a pullup parameter implies no
+information about e.g. the mux function.
+
+
+The following generic properties as defined in pinctrl-bindings.txt are valid
+to specify in a pin configuration subnode:
+
+- pins:
+	Usage: required
+	Value type: <string-array>
+	Definition: List of gpio pins affected by the properties specified in
+		    this subnode.  Valid pins are:
+		    gpio0-gpio121,
+		    sdc1_clk,
+		    sdc1_cmd,
+		    sdc1_data
+		    sdc2_clk,
+		    sdc2_cmd,
+		    sdc2_data,
+		    qdsd_cmd,
+		    qdsd_data0,
+		    qdsd_data1,
+		    qdsd_data2,
+		    qdsd_data3
+
+- function:
+	Usage: required
+	Value type: <string>
+	Definition: Specify the alternative function to be configured for the
+		    specified pins. Functions are only valid for gpio pins.
+		    Valid values are:
+	adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char, atest_char0,
+	atest_char1, atest_char2, atest_char3, atest_combodac, atest_gpsadc0,
+	atest_gpsadc1, atest_tsens, atest_wlan0, atest_wlan1, backlight_en,
+	bimc_dte0,bimc_dte1, blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4,
+	blsp_i2c5, blsp_i2c6, blsp_spi1, blsp_spi1_cs1, blsp_spi1_cs2,
+	blsp_spi1_cs3, blsp_spi2, blsp_spi2_cs1, blsp_spi2_cs2, blsp_spi2_cs3,
+	blsp_spi3, blsp_spi3_cs1, blsp_spi3_cs2, blsp_spi3_cs3, blsp_spi4,
+	blsp_spi5, blsp_spi6, blsp_uart1, blsp_uart2, blsp_uim1, blsp_uim2,
+	cam1_rst, cam1_standby, cam_mclk0, cam_mclk1, cci_async, cci_i2c,
+	cci_timer0, cci_timer1, cci_timer2, cdc_pdm0, codec_mad, dbg_out,
+	display_5v, dmic0_clk, dmic0_data, dsi_rst, ebi0_wrcdc, euro_us,
+	ext_lpass, flash_strobe, gcc_gp1_clk_a, gcc_gp1_clk_b, gcc_gp2_clk_a,
+	gcc_gp2_clk_b, gcc_gp3_clk_a, gcc_gp3_clk_b, gpio, gsm0_tx0, gsm0_tx1,
+	gsm1_tx0, gsm1_tx1, gyro_accl, kpsns0, kpsns1, kpsns2, ldo_en,
+	ldo_update, mag_int, mdp_vsync, modem_tsync, m_voc, nav_pps, nav_tsync,
+	pa_indicator, pbs0, pbs1, pbs2, pri_mi2s, pri_mi2s_ws, prng_rosc,
+	pwr_crypto_enabled_a, pwr_crypto_enabled_b, pwr_modem_enabled_a,
+	pwr_modem_enabled_b, pwr_nav_enabled_a, pwr_nav_enabled_b,
+	qdss_ctitrig_in_a0, qdss_ctitrig_in_a1, qdss_ctitrig_in_b0,
+	qdss_ctitrig_in_b1, qdss_ctitrig_out_a0, qdss_ctitrig_out_a1,
+	qdss_ctitrig_out_b0, qdss_ctitrig_out_b1, qdss_traceclk_a,
+	qdss_traceclk_b, qdss_tracectl_a, qdss_tracectl_b, qdss_tracedata_a,
+	qdss_tracedata_b, reset_n, sd_card, sd_write, sec_mi2s, smb_int,
+	ssbi_wtr0, ssbi_wtr1, uim1, uim2, uim3, uim_batt, wcss_bt, wcss_fm,
+	wcss_wlan, webcam1_rst
+
+- bias-disable:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configued as no pull.
+
+- bias-pull-down:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configued as pull down.
+
+- bias-pull-up:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configued as pull up.
+
+- output-high:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins are configured in output mode, driven
+		    high.
+		    Not valid for sdc pins.
+
+- output-low:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins are configured in output mode, driven
+		    low.
+		    Not valid for sdc pins.
+
+- drive-strength:
+	Usage: optional
+	Value type: <u32>
+	Definition: Selects the drive strength for the specified pins, in mA.
+		    Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
+
+Example:
+
+	tlmm: pinctrl@1000000 {
+		compatible = "qcom,ipq6018-pinctrl";
+		reg = <0x1000000 0x300000>;
+		interrupts = <0 208 0>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+
+		uart2: uart2-default {
+			mux {
+				pins = "gpio4", "gpio5";
+				function = "blsp_uart2";
+			};
+
+			tx {
+				pins = "gpio4";
+				drive-strength = <4>;
+				bias-disable;
+			};
+
+			rx {
+				pins = "gpio5";
+				drive-strength = <2>;
+				bias-pull-up;
+			};
+		};
+	};
drivers/pinctrl/qcom/Kconfig +10 -0
index 890d0a3..c7b32e8 100644
@@ -50,6 +50,16 @@ config PINCTRL_IPQ8074
 	  Qualcomm Technologies Inc. IPQ8074 platform. Select this for
 	  IPQ8074.
 
+config PINCTRL_IPQ6018
+	tristate "Qualcomm Technologies, Inc. IPQ6018 pin controller driver"
+	depends on GPIOLIB && OF
+	select PINCTRL_MSM
+	help
+	  This is the pinctrl, pinmux, pinconf and gpiolib driver for
+	  the Qualcomm Technologies Inc. TLMM block found on the
+	  Qualcomm Technologies Inc. IPQ6018 platform. Select this for
+	  IPQ6018.
+
 config PINCTRL_MSM8660
 	tristate "Qualcomm 8660 pin controller driver"
 	depends on GPIOLIB && OF
drivers/pinctrl/qcom/Makefile +1 -0
index 344b4c6..0b8b769 100644
@@ -6,6 +6,7 @@ obj-$(CONFIG_PINCTRL_APQ8084)	+= pinctrl-apq8084.o
 obj-$(CONFIG_PINCTRL_IPQ4019)	+= pinctrl-ipq4019.o
 obj-$(CONFIG_PINCTRL_IPQ8064)	+= pinctrl-ipq8064.o
 obj-$(CONFIG_PINCTRL_IPQ8074)	+= pinctrl-ipq8074.o
+obj-$(CONFIG_PINCTRL_IPQ6018)	+= pinctrl-ipq6018.o
 obj-$(CONFIG_PINCTRL_MSM8660)	+= pinctrl-msm8660.o
 obj-$(CONFIG_PINCTRL_MSM8960)	+= pinctrl-msm8960.o
 obj-$(CONFIG_PINCTRL_MSM8X74)	+= pinctrl-msm8x74.o
drivers/pinctrl/qcom/pinctrl-ipq6018.c new file +1183 -0

1,183 lines not on this page · raw message

Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#2 lore raw

Re: [PATCH 1/6] pinctrl: qcom: Add ipq6018 pinctrl driver

Quoted 6 lines · Sricharan R

Add initial pinctrl driver to support pin configuration with pinctrl framework for ipq6018.

These should start with the author, then followed by each person that handled the patch on its way to the list - so your name should probably be last. If you have more than one author add Co-developed-by, in addition to the Signed-off-by.

And please spell our speriaka's first and last name.

[..]

Quoted 1 line
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt +0 -0

[..]

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt line 41

Quoted 5 lines

+- #gpio-cells:

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt +4 -0
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/gpio/gpio.h>

You're missing the required "gpio-ranges" property.

Quoted 1 line

+

[..]

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt line 96

Quoted 7 lines

+- function:

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt +6 -0
+	Usage: required
+	Value type: <string>
+	Definition: Specify the alternative function to be configured for the
+		    specified pins. Functions are only valid for gpio pins.
+		    Valid values are:
+	adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char, atest_char0,

Please indent these.

[..]

The rest should be in a separate patch from the binding.

Quoted 1 line
drivers/pinctrl/qcom/Kconfig +0 -0

[..]

Quoted 1 line

+enum ipq6018_functions {

[..]

drivers/pinctrl/qcom/Kconfig

Quoted 1 line
drivers/pinctrl/qcom/Kconfig +1 -0
+	msm_mux_NA,

I like when these are sorted, and if you make the last entry msm_mux__ the msm_pingroup array becomes easier to read.

Quoted 1 line

+};

[..]

Quoted 1 line

+static const struct msm_function ipq6018_functions[] = {

[..]

drivers/pinctrl/qcom/Kconfig

Quoted 1 line
drivers/pinctrl/qcom/Kconfig +1 -0
+	FUNCTION(gcc_tlmm),

As above, please sort these.

drivers/pinctrl/qcom/Kconfig

Quoted 5 lines
drivers/pinctrl/qcom/Kconfig +5 -0
+};
+
+static const struct msm_pingroup ipq6018_groups[] = {
+	PINGROUP(0, qpic_pad, wci20, qdss_traceclk_b, NA, burn0, NA, NA, NA,
+		 NA),

Please ignore the 80-char and skip the line breaks.

drivers/pinctrl/qcom/Kconfig

Quoted 6 lines
drivers/pinctrl/qcom/Kconfig +6 -0
+	PINGROUP(1, qpic_pad, mac12, qdss_tracectl_b, NA, burn1, NA, NA, NA,
+		 NA),
+	PINGROUP(2, qpic_pad, wci20, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),
+	PINGROUP(3, qpic_pad, mac01, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),
+	PINGROUP(4, qpic_pad, mac01, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),
+	PINGROUP(5, qpic_pad4, mac21, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),

Is there a reason to keep qpic_padN as separate functions from qpic_pad?

[..]

drivers/pinctrl/qcom/Kconfig

Quoted 4 lines
drivers/pinctrl/qcom/Kconfig +4 -0
+static struct platform_driver ipq6018_pinctrl_driver = {
+	.driver = {
+		.name = "ipq6018-pinctrl",
+		.owner = THIS_MODULE,

.owner is populated automagically by platform_driver_register, so please omit this.

drivers/pinctrl/qcom/Kconfig

Quoted 5 lines
drivers/pinctrl/qcom/Kconfig +5 -0
+		.of_match_table = ipq6018_pinctrl_of_match,
+	},
+	.probe = ipq6018_pinctrl_probe,
+	.remove = msm_pinctrl_remove,
+};

Regards,
Bjorn

#3 lore raw

Re: [PATCH 1/6] pinctrl: qcom: Add ipq6018 pinctrl driver

Hi Bjorn,

Quoted 9 lines · Bjorn Andersson
Quoted 6 lines · Sricharan R

Add initial pinctrl driver to support pin configuration with pinctrl framework for ipq6018.

Thanks for the review !!

Quoted 7 lines

These should start with the author, then followed by each person that handled the patch on its way to the list - so your name should probably be last. If you have more than one author add Co-developed-by, in addition to the Signed-off-by.

And please spell our speriaka's first and last name.

ok, will fix it.

Quoted 11 lines

[..]

Quoted 1 line
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt +0 -0

[..]

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt line 41

Quoted 5 lines

+- #gpio-cells:

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt +4 -0
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/gpio/gpio.h>

You're missing the required "gpio-ranges" property.

ok, will add.

Quoted 12 lines
Quoted 1 line

+

[..]

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt line 96

Quoted 7 lines

+- function:

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt +6 -0
+	Usage: required
+	Value type: <string>
+	Definition: Specify the alternative function to be configured for the
+		    specified pins. Functions are only valid for gpio pins.
+		    Valid values are:
+	adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char, atest_char0,

Please indent these.

ok.

Quoted 4 lines

[..]

The rest should be in a separate patch from the binding.

Quoted 9 lines
Quoted 1 line
drivers/pinctrl/qcom/Kconfig +0 -0

[..]

Quoted 1 line

+enum ipq6018_functions {

[..]

drivers/pinctrl/qcom/Kconfig

Quoted 1 line
drivers/pinctrl/qcom/Kconfig +1 -0
+	msm_mux_NA,

I like when these are sorted, and if you make the last entry msm_mux__ the msm_pingroup array becomes easier to read.

ok.

Quoted 8 lines
Quoted 1 line

+};

[..]

Quoted 1 line

+static const struct msm_function ipq6018_functions[] = {

[..]

drivers/pinctrl/qcom/Kconfig

Quoted 1 line
drivers/pinctrl/qcom/Kconfig +1 -0
+	FUNCTION(gcc_tlmm),

As above, please sort these.

ok.

Quoted 8 lines

drivers/pinctrl/qcom/Kconfig

Quoted 5 lines
drivers/pinctrl/qcom/Kconfig +5 -0
+};
+
+static const struct msm_pingroup ipq6018_groups[] = {
+	PINGROUP(0, qpic_pad, wci20, qdss_traceclk_b, NA, burn0, NA, NA, NA,
+		 NA),

Please ignore the 80-char and skip the line breaks.

ok.

Quoted 9 lines

drivers/pinctrl/qcom/Kconfig

Quoted 6 lines
drivers/pinctrl/qcom/Kconfig +6 -0
+	PINGROUP(1, qpic_pad, mac12, qdss_tracectl_b, NA, burn1, NA, NA, NA,
+		 NA),
+	PINGROUP(2, qpic_pad, wci20, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),
+	PINGROUP(3, qpic_pad, mac01, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),
+	PINGROUP(4, qpic_pad, mac01, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),
+	PINGROUP(5, qpic_pad4, mac21, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),

Is there a reason to keep qpic_padN as separate functions from qpic_pad?

Hmm, the auto-gen scripts needs to be fixed. Will correct it.

Quoted 9 lines

[..]

drivers/pinctrl/qcom/Kconfig

Quoted 4 lines
drivers/pinctrl/qcom/Kconfig +4 -0
+static struct platform_driver ipq6018_pinctrl_driver = {
+	.driver = {
+		.name = "ipq6018-pinctrl",
+		.owner = THIS_MODULE,

.owner is populated automagically by platform_driver_register, so please omit this.

ok, missed it. will fix.

Regards,
Sricharan

Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#4 lore raw

PATCH 2/6 dt-bindings: qcom: Add ipq6018 bindings

In reply to Sricharan R
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +2 -0
index f6316ab..7b19028 100644
@@ -36,6 +36,7 @@ description: |
   	mdm9615
   	ipq8074
   	sdm845
+	ipq6018
 
   The 'board' element must be one of the following strings:
 
@@ -45,6 +46,7 @@ description: |
   	mtp
   	sbc
   	hk01
+	cp01-c1
 
   The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
   where the minor number may be omitted when it's zero, i.e.  v1.0 is the same
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#5 lore raw

Re: [PATCH 2/6] dt-bindings: qcom: Add ipq6018 bindings

Quoted 11 lines · Sricharan R
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +0 -0
index f6316ab..7b19028 100644

Documentation/devicetree/bindings/arm/qcom.yaml description: | · line 39

Quoted 4 lines
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -36,6 +36,7 @@ description: |
   	mdm9615
   	ipq8074
   	sdm845
+	ipq6018

It would be nice if these lists where sorted, but as that's not the case, please sort it wrt the other ipq at least.

Regards,
Bjorn

Quoted 14 lines
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
   The 'board' element must be one of the following strings:
 
@@ -45,6 +46,7 @@ description: |
   	mtp
   	sbc
   	hk01
+	cp01-c1
 
   The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
   where the minor number may be omitted when it's zero, i.e.  v1.0 is the same
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#6 lore raw

Re: [PATCH 2/6] dt-bindings: qcom: Add ipq6018 bindings

Quoted 8 lines · Bjorn Andersson
Quoted 6 lines · Sricharan R
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)
Quoted 13 lines

Documentation/devicetree/bindings/arm/qcom.yaml description: | · line 39

Quoted 9 lines
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
index f6316ab..7b19028 100644
@@ -36,6 +36,7 @@ description: |
   	mdm9615
   	ipq8074
   	sdm845
+	ipq6018

It would be nice if these lists where sorted, but as that's not the case, please sort it wrt the other ipq at least.

ok.

Regards,
Sricharan

Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#7 lore raw

Re: [PATCH 2/6] dt-bindings: qcom: Add ipq6018 bindings

In reply to Sricharan R
Quoted 12 lines · Sricharan R
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +0 -0
index f6316ab..7b19028 100644

Documentation/devicetree/bindings/arm/qcom.yaml description: | · line 39

Quoted 4 lines
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -36,6 +36,7 @@ description: |
        mdm9615
        ipq8074
        sdm845
+       ipq6018

You need to add actual schema for this, not just a description.

Quoted 14 lines
Documentation/devicetree/bindings/arm/qcom.yaml +1 -1
   The 'board' element must be one of the following strings:
 
@@ -45,6 +46,7 @@ description: |
        mtp
        sbc
        hk01
+       cp01-c1
 
   The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
   where the minor number may be omitted when it's zero, i.e.  v1.0 is the same
--

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

#8 lore raw

PATCH 3/6 clk: qcom: Add DT bindings for ipq6018 gcc clock controller

In reply to Sricharan R

Add the compatible strings and the include file for ipq6018 gcc clock controller.

---
 .../devicetree/bindings/clock/qcom,gcc.txt         |   1 +
 include/dt-bindings/clock/qcom,gcc-ipq6018.h       | 405 +++++++++++++++++++++
 2 files changed, 406 insertions(+)
 create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq6018.h
Documentation/devicetree/bindings/clock/qcom,gcc.txt +1 -0
index 8661c3c..40bb3de 100644
@@ -9,6 +9,7 @@ Required properties :
 			"qcom,gcc-ipq8064"
 			"qcom,gcc-ipq4019"
 			"qcom,gcc-ipq8074"
+			"qcom,gcc-ipq6018"
 			"qcom,gcc-msm8660"
 			"qcom,gcc-msm8916"
 			"qcom,gcc-msm8960"
include/dt-bindings/clock/qcom,gcc-ipq6018.h new file +405 -0

405 lines not on this page · raw message

Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#9 lore raw

Re: [PATCH 3/6] clk: qcom: Add DT bindings for ipq6018 gcc clock controller

Quoted 6 lines · Sricharan R

Add the compatible strings and the include file for ipq6018 gcc clock controller.

Please fix your s-o-b chain.

Quoted 11 lines
---
 .../devicetree/bindings/clock/qcom,gcc.txt         |   1 +
 include/dt-bindings/clock/qcom,gcc-ipq6018.h       | 405 +++++++++++++++++++++
 2 files changed, 406 insertions(+)
 create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq6018.h
Documentation/devicetree/bindings/clock/qcom,gcc.txt +0 -0
index 8661c3c..40bb3de 100644

Documentation/devicetree/bindings/clock/qcom,gcc.txt Required properties : · line 12

Quoted 4 lines
Documentation/devicetree/bindings/clock/qcom,gcc.txt +1 -0
@@ -9,6 +9,7 @@ Required properties :
 			"qcom,gcc-ipq8064"
 			"qcom,gcc-ipq4019"
 			"qcom,gcc-ipq8074"
+			"qcom,gcc-ipq6018"

And please maintain sort order.

Regards,
Bjorn

Quoted 417 lines
Documentation/devicetree/bindings/clock/qcom,gcc.txt +0 -0
 			"qcom,gcc-msm8660"
 			"qcom,gcc-msm8916"
 			"qcom,gcc-msm8960"
include/dt-bindings/clock/qcom,gcc-ipq6018.h new file +405 -0
new file mode 100644
index 0000000..b8aec10
@@ -0,0 +1,405 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_CLOCK_IPQ_GCC_6018_H
+#define _DT_BINDINGS_CLOCK_IPQ_GCC_6018_H
+
+#define GPLL0					0
+#define UBI32_PLL				1
+#define GPLL6					2
+#define GPLL4					3
+#define PCNOC_BFDCD_CLK_SRC			4
+#define GPLL2					5
+#define NSS_CRYPTO_PLL				6
+#define NSS_PPE_CLK_SRC				7
+#define GCC_XO_CLK_SRC				8
+#define NSS_CE_CLK_SRC				9
+#define GCC_SLEEP_CLK_SRC			10
+#define APSS_AHB_CLK_SRC			11
+#define NSS_PORT5_RX_CLK_SRC			12
+#define NSS_PORT5_TX_CLK_SRC			13
+#define PCIE0_AXI_CLK_SRC			14
+#define USB0_MASTER_CLK_SRC			15
+#define APSS_AHB_POSTDIV_CLK_SRC		16
+#define NSS_PORT1_RX_CLK_SRC			17
+#define NSS_PORT1_TX_CLK_SRC			18
+#define NSS_PORT2_RX_CLK_SRC			19
+#define NSS_PORT2_TX_CLK_SRC			20
+#define NSS_PORT3_RX_CLK_SRC			21
+#define NSS_PORT3_TX_CLK_SRC			22
+#define NSS_PORT4_RX_CLK_SRC			23
+#define NSS_PORT4_TX_CLK_SRC			24
+#define NSS_PORT5_RX_DIV_CLK_SRC		25
+#define NSS_PORT5_TX_DIV_CLK_SRC		26
+#define APSS_AXI_CLK_SRC			27
+#define NSS_CRYPTO_CLK_SRC			28
+#define NSS_PORT1_RX_DIV_CLK_SRC		29
+#define NSS_PORT1_TX_DIV_CLK_SRC		30
+#define NSS_PORT2_RX_DIV_CLK_SRC		31
+#define NSS_PORT2_TX_DIV_CLK_SRC		32
+#define NSS_PORT3_RX_DIV_CLK_SRC		33
+#define NSS_PORT3_TX_DIV_CLK_SRC		34
+#define NSS_PORT4_RX_DIV_CLK_SRC		35
+#define NSS_PORT4_TX_DIV_CLK_SRC		36
+#define NSS_UBI0_CLK_SRC			37
+#define BLSP1_QUP1_I2C_APPS_CLK_SRC		38
+#define BLSP1_QUP1_SPI_APPS_CLK_SRC		39
+#define BLSP1_QUP2_I2C_APPS_CLK_SRC		40
+#define BLSP1_QUP2_SPI_APPS_CLK_SRC		41
+#define BLSP1_QUP3_I2C_APPS_CLK_SRC		42
+#define BLSP1_QUP3_SPI_APPS_CLK_SRC		43
+#define BLSP1_QUP4_I2C_APPS_CLK_SRC		44
+#define BLSP1_QUP4_SPI_APPS_CLK_SRC		45
+#define BLSP1_QUP5_I2C_APPS_CLK_SRC		46
+#define BLSP1_QUP5_SPI_APPS_CLK_SRC		47
+#define BLSP1_QUP6_I2C_APPS_CLK_SRC		48
+#define BLSP1_QUP6_SPI_APPS_CLK_SRC		49
+#define BLSP1_UART1_APPS_CLK_SRC		50
+#define BLSP1_UART2_APPS_CLK_SRC		51
+#define BLSP1_UART3_APPS_CLK_SRC		52
+#define BLSP1_UART4_APPS_CLK_SRC		53
+#define BLSP1_UART5_APPS_CLK_SRC		54
+#define BLSP1_UART6_APPS_CLK_SRC		55
+#define CRYPTO_CLK_SRC				56
+#define NSS_UBI0_DIV_CLK_SRC			57
+#define PCIE0_AUX_CLK_SRC			58
+#define PCIE0_PIPE_CLK_SRC			59
+#define SDCC1_APPS_CLK_SRC			60
+#define USB0_AUX_CLK_SRC			61
+#define USB0_MOCK_UTMI_CLK_SRC			62
+#define USB0_PIPE_CLK_SRC			63
+#define USB1_MOCK_UTMI_CLK_SRC			64
+#define GCC_APSS_AHB_CLK			65
+#define GCC_APSS_AXI_CLK			66
+#define GCC_BLSP1_AHB_CLK			67
+#define GCC_BLSP1_QUP1_I2C_APPS_CLK		68
+#define GCC_BLSP1_QUP1_SPI_APPS_CLK		69
+#define GCC_BLSP1_QUP2_I2C_APPS_CLK		70
+#define GCC_BLSP1_QUP2_SPI_APPS_CLK		71
+#define GCC_BLSP1_QUP3_I2C_APPS_CLK		72
+#define GCC_BLSP1_QUP3_SPI_APPS_CLK		73
+#define GCC_BLSP1_QUP4_I2C_APPS_CLK		74
+#define GCC_BLSP1_QUP4_SPI_APPS_CLK		75
+#define GCC_BLSP1_QUP5_I2C_APPS_CLK		76
+#define GCC_BLSP1_QUP5_SPI_APPS_CLK		77
+#define GCC_BLSP1_QUP6_I2C_APPS_CLK		78
+#define GCC_BLSP1_QUP6_SPI_APPS_CLK		79
+#define GCC_BLSP1_UART1_APPS_CLK		80
+#define GCC_BLSP1_UART2_APPS_CLK		81
+#define GCC_BLSP1_UART3_APPS_CLK		82
+#define GCC_BLSP1_UART4_APPS_CLK		83
+#define GCC_BLSP1_UART5_APPS_CLK		84
+#define GCC_BLSP1_UART6_APPS_CLK		85
+#define GCC_CRYPTO_AHB_CLK			86
+#define GCC_CRYPTO_AXI_CLK			87
+#define GCC_CRYPTO_CLK				88
+#define GCC_XO_CLK				89
+#define GCC_XO_DIV4_CLK				90
+#define GCC_MDIO_AHB_CLK			91
+#define GCC_CRYPTO_PPE_CLK			92
+#define GCC_NSS_CE_APB_CLK			93
+#define GCC_NSS_CE_AXI_CLK			94
+#define GCC_NSS_CFG_CLK				95
+#define GCC_NSS_CRYPTO_CLK			96
+#define GCC_NSS_CSR_CLK				97
+#define GCC_NSS_EDMA_CFG_CLK			98
+#define GCC_NSS_EDMA_CLK			99
+#define GCC_NSS_NOC_CLK				100
+#define GCC_NSS_PORT1_RX_CLK			101
+#define GCC_NSS_PORT1_TX_CLK			102
+#define GCC_NSS_PORT2_RX_CLK			103
+#define GCC_NSS_PORT2_TX_CLK			104
+#define GCC_NSS_PORT3_RX_CLK			105
+#define GCC_NSS_PORT3_TX_CLK			106
+#define GCC_NSS_PORT4_RX_CLK			107
+#define GCC_NSS_PORT4_TX_CLK			108
+#define GCC_NSS_PORT5_RX_CLK			109
+#define GCC_NSS_PORT5_TX_CLK			110
+#define GCC_NSS_PPE_CFG_CLK			111
+#define GCC_NSS_PPE_CLK				112
+#define GCC_NSS_PPE_IPE_CLK			113
+#define GCC_NSS_PTP_REF_CLK			114
+#define GCC_NSSNOC_CE_APB_CLK			115
+#define GCC_NSSNOC_CE_AXI_CLK			116
+#define GCC_NSSNOC_CRYPTO_CLK			117
+#define GCC_NSSNOC_PPE_CFG_CLK			118
+#define GCC_NSSNOC_PPE_CLK			119
+#define GCC_NSSNOC_QOSGEN_REF_CLK		120
+#define GCC_NSSNOC_TIMEOUT_REF_CLK		121
+#define GCC_NSSNOC_UBI0_AHB_CLK			122
+#define GCC_PORT1_MAC_CLK			123
+#define GCC_PORT2_MAC_CLK			124
+#define GCC_PORT3_MAC_CLK			125
+#define GCC_PORT4_MAC_CLK			126
+#define GCC_PORT5_MAC_CLK			127
+#define GCC_UBI0_AHB_CLK			128
+#define GCC_UBI0_AXI_CLK			129
+#define GCC_UBI0_CORE_CLK			130
+#define GCC_PCIE0_AHB_CLK			131
+#define GCC_PCIE0_AUX_CLK			132
+#define GCC_PCIE0_AXI_M_CLK			133
+#define GCC_PCIE0_AXI_S_CLK			134
+#define GCC_PCIE0_PIPE_CLK			135
+#define GCC_PRNG_AHB_CLK			136
+#define GCC_QPIC_AHB_CLK			137
+#define GCC_QPIC_CLK				138
+#define GCC_SDCC1_AHB_CLK			139
+#define GCC_SDCC1_APPS_CLK			140
+#define GCC_UNIPHY0_AHB_CLK			141
+#define GCC_UNIPHY0_PORT1_RX_CLK		142
+#define GCC_UNIPHY0_PORT1_TX_CLK		143
+#define GCC_UNIPHY0_PORT2_RX_CLK		144
+#define GCC_UNIPHY0_PORT2_TX_CLK		145
+#define GCC_UNIPHY0_PORT3_RX_CLK		146
+#define GCC_UNIPHY0_PORT3_TX_CLK		147
+#define GCC_UNIPHY0_PORT4_RX_CLK		148
+#define GCC_UNIPHY0_PORT4_TX_CLK		149
+#define GCC_UNIPHY0_PORT5_RX_CLK		150
+#define GCC_UNIPHY0_PORT5_TX_CLK		151
+#define GCC_UNIPHY0_SYS_CLK			152
+#define GCC_UNIPHY1_AHB_CLK			153
+#define GCC_UNIPHY1_PORT5_RX_CLK		154
+#define GCC_UNIPHY1_PORT5_TX_CLK		155
+#define GCC_UNIPHY1_SYS_CLK			156
+#define GCC_USB0_AUX_CLK			157
+#define GCC_USB0_MASTER_CLK			158
+#define GCC_USB0_MOCK_UTMI_CLK			159
+#define GCC_USB0_PHY_CFG_AHB_CLK		160
+#define GCC_USB0_PIPE_CLK			161
+#define GCC_USB0_SLEEP_CLK			162
+#define GCC_USB1_MASTER_CLK			163
+#define GCC_USB1_MOCK_UTMI_CLK			164
+#define GCC_USB1_PHY_CFG_AHB_CLK		165
+#define GCC_USB1_SLEEP_CLK			166
+#define GP1_CLK_SRC				167
+#define GP2_CLK_SRC				168
+#define GP3_CLK_SRC				169
+#define GCC_GP1_CLK				170
+#define GCC_GP2_CLK				171
+#define GCC_GP3_CLK				172
+#define SYSTEM_NOC_BFDCD_CLK_SRC		173
+#define GCC_NSSNOC_SNOC_CLK			174
+#define GCC_UBI0_NC_AXI_CLK			175
+#define GCC_UBI1_NC_AXI_CLK			176
+#define GPLL0_MAIN				177
+#define UBI32_PLL_MAIN				178
+#define GPLL6_MAIN				179
+#define GPLL4_MAIN				180
+#define GPLL2_MAIN				181
+#define NSS_CRYPTO_PLL_MAIN			182
+#define GCC_CMN_12GPLL_AHB_CLK			183
+#define GCC_CMN_12GPLL_SYS_CLK			184
+#define GCC_SNOC_BUS_TIMEOUT2_AHB_CLK		185
+#define GCC_SYS_NOC_USB0_AXI_CLK		186
+#define GCC_SYS_NOC_PCIE0_AXI_CLK		187
+#define QDSS_TSCTR_CLK_SRC			188
+#define QDSS_AT_CLK_SRC				189
+#define GCC_QDSS_AT_CLK				190
+#define GCC_QDSS_DAP_CLK			191
+#define ADSS_PWM_CLK_SRC			192
+#define GCC_ADSS_PWM_CLK			193
+#define SDCC1_ICE_CORE_CLK_SRC			194
+#define GCC_SDCC1_ICE_CORE_CLK			195
+#define GCC_DCC_CLK				196
+#define PCIE0_RCHNG_CLK_SRC			197
+#define GCC_PCIE0_AXI_S_BRIDGE_CLK		198
+#define PCIE0_RCHNG_CLK				199
+#define UBI32_MEM_NOC_BFDCD_CLK_SRC		200
+#define WCSS_AHB_CLK_SRC			201
+#define Q6_AXI_CLK_SRC				202
+#define GCC_Q6SS_PCLKDBG_CLK			203
+#define GCC_Q6_TSCTR_1TO2_CLK			204
+#define GCC_WCSS_CORE_TBU_CLK			205
+#define GCC_WCSS_AXI_M_CLK			206
+#define GCC_SYS_NOC_WCSS_AHB_CLK		207
+#define GCC_Q6_AXIM_CLK				208
+#define GCC_Q6SS_ATBM_CLK			209
+#define GCC_WCSS_Q6_TBU_CLK			210
+#define GCC_Q6_AXIM2_CLK			211
+#define GCC_Q6_AHB_CLK				212
+#define GCC_Q6_AHB_S_CLK			213
+#define GCC_WCSS_DBG_IFC_APB_CLK		214
+#define GCC_WCSS_DBG_IFC_ATB_CLK		215
+#define GCC_WCSS_DBG_IFC_NTS_CLK		216
+#define GCC_WCSS_DBG_IFC_DAPBUS_CLK		217
+#define GCC_WCSS_DBG_IFC_APB_BDG_CLK		218
+#define GCC_WCSS_DBG_IFC_ATB_BDG_CLK		219
+#define GCC_WCSS_DBG_IFC_NTS_BDG_CLK		220
+#define GCC_WCSS_DBG_IFC_DAPBUS_BDG_CLK		221
+#define GCC_WCSS_ECAHB_CLK			222
+#define GCC_WCSS_ACMT_CLK			223
+#define GCC_WCSS_AHB_S_CLK			224
+#define GCC_RBCPR_WCSS_CLK			225
+#define RBCPR_WCSS_CLK_SRC			226
+#define GCC_RBCPR_WCSS_AHB_CLK			227
+#define GCC_LPASS_CORE_AXIM_CLK			228
+#define GCC_LPASS_SNOC_CFG_CLK			229
+#define GCC_LPASS_Q6_AXIM_CLK			230
+#define GCC_LPASS_Q6_ATBM_AT_CLK		231
+#define GCC_LPASS_Q6_PCLKDBG_CLK		232
+#define GCC_LPASS_Q6SS_TSCTR_1TO2_CLK		233
+#define GCC_LPASS_Q6SS_TRIG_CLK			234
+#define GCC_LPASS_TBU_CLK			235
+#define LPASS_CORE_AXIM_CLK_SRC			236
+#define LPASS_SNOC_CFG_CLK_SRC			237
+#define LPASS_Q6_AXIM_CLK_SRC			238
+#define GCC_PCNOC_LPASS_CLK			239
+#define GCC_UBI0_UTCM_CLK			240
+#define SNOC_NSSNOC_BFDCD_CLK_SRC		241
+#define GCC_SNOC_NSSNOC_CLK			242
+#define GCC_MEM_NOC_Q6_AXI_CLK			243
+#define GCC_MEM_NOC_UBI32_CLK			244
+#define GCC_MEM_NOC_LPASS_CLK			245
+#define GCC_SNOC_LPASS_CFG_CLK			246
+
+#define GCC_BLSP1_BCR				0
+#define GCC_BLSP1_QUP1_BCR			1
+#define GCC_BLSP1_UART1_BCR			2
+#define GCC_BLSP1_QUP2_BCR			3
+#define GCC_BLSP1_UART2_BCR			4
+#define GCC_BLSP1_QUP3_BCR			5
+#define GCC_BLSP1_UART3_BCR			6
+#define GCC_BLSP1_QUP4_BCR			7
+#define GCC_BLSP1_UART4_BCR			8
+#define GCC_BLSP1_QUP5_BCR			9
+#define GCC_BLSP1_UART5_BCR			10
+#define GCC_BLSP1_QUP6_BCR			11
+#define GCC_BLSP1_UART6_BCR			12
+#define GCC_IMEM_BCR				13
+#define GCC_SMMU_BCR				14
+#define GCC_APSS_TCU_BCR			15
+#define GCC_SMMU_XPU_BCR			16
+#define GCC_PCNOC_TBU_BCR			17
+#define GCC_SMMU_CFG_BCR			18
+#define GCC_PRNG_BCR				19
+#define GCC_BOOT_ROM_BCR			20
+#define GCC_CRYPTO_BCR				21
+#define GCC_WCSS_BCR				22
+#define GCC_WCSS_Q6_BCR				23
+#define GCC_NSS_BCR				24
+#define GCC_SEC_CTRL_BCR			25
+#define GCC_DDRSS_BCR				26
+#define GCC_SYSTEM_NOC_BCR			27
+#define GCC_PCNOC_BCR				28
+#define GCC_TCSR_BCR				29
+#define GCC_QDSS_BCR				30
+#define GCC_DCD_BCR				31
+#define GCC_MSG_RAM_BCR				32
+#define GCC_MPM_BCR				33
+#define GCC_SPDM_BCR				34
+#define GCC_RBCPR_BCR				35
+#define GCC_RBCPR_MX_BCR			36
+#define GCC_TLMM_BCR				37
+#define GCC_RBCPR_WCSS_BCR			38
+#define GCC_USB0_PHY_BCR			39
+#define GCC_USB3PHY_0_PHY_BCR			40
+#define GCC_USB0_BCR				41
+#define GCC_USB1_BCR				42
+#define GCC_QUSB2_0_PHY_BCR			43
+#define GCC_QUSB2_1_PHY_BCR			44
+#define GCC_SDCC1_BCR				45
+#define GCC_SNOC_BUS_TIMEOUT0_BCR		46
+#define GCC_SNOC_BUS_TIMEOUT1_BCR		47
+#define GCC_SNOC_BUS_TIMEOUT2_BCR		48
+#define GCC_PCNOC_BUS_TIMEOUT0_BCR		49
+#define GCC_PCNOC_BUS_TIMEOUT1_BCR		50
+#define GCC_PCNOC_BUS_TIMEOUT2_BCR		51
+#define GCC_PCNOC_BUS_TIMEOUT3_BCR		52
+#define GCC_PCNOC_BUS_TIMEOUT4_BCR		53
+#define GCC_PCNOC_BUS_TIMEOUT5_BCR		54
+#define GCC_PCNOC_BUS_TIMEOUT6_BCR		55
+#define GCC_PCNOC_BUS_TIMEOUT7_BCR		56
+#define GCC_PCNOC_BUS_TIMEOUT8_BCR		57
+#define GCC_PCNOC_BUS_TIMEOUT9_BCR		58
+#define GCC_UNIPHY0_BCR				59
+#define GCC_UNIPHY1_BCR				60
+#define GCC_CMN_12GPLL_BCR			61
+#define GCC_QPIC_BCR				62
+#define GCC_MDIO_BCR				63
+#define GCC_WCSS_CORE_TBU_BCR			64
+#define GCC_WCSS_Q6_TBU_BCR			65
+#define GCC_USB0_TBU_BCR			66
+#define GCC_PCIE0_TBU_BCR			67
+#define GCC_PCIE0_BCR				68
+#define GCC_PCIE0_PHY_BCR			69
+#define GCC_PCIE0PHY_PHY_BCR			70
+#define GCC_PCIE0_LINK_DOWN_BCR			71
+#define GCC_DCC_BCR				72
+#define GCC_APC0_VOLTAGE_DROOP_DETECTOR_BCR	73
+#define GCC_SMMU_CATS_BCR			74
+#define GCC_UBI0_AXI_ARES			75
+#define GCC_UBI0_AHB_ARES			76
+#define GCC_UBI0_NC_AXI_ARES			77
+#define GCC_UBI0_DBG_ARES			78
+#define GCC_UBI0_CORE_CLAMP_ENABLE		79
+#define GCC_UBI0_CLKRST_CLAMP_ENABLE		80
+#define GCC_UBI0_UTCM_ARES			81
+#define GCC_NSS_CFG_ARES			82
+#define GCC_NSS_NOC_ARES			83
+#define GCC_NSS_CRYPTO_ARES			84
+#define GCC_NSS_CSR_ARES			85
+#define GCC_NSS_CE_APB_ARES			86
+#define GCC_NSS_CE_AXI_ARES			87
+#define GCC_NSSNOC_CE_APB_ARES			88
+#define GCC_NSSNOC_CE_AXI_ARES			89
+#define GCC_NSSNOC_UBI0_AHB_ARES		90
+#define GCC_NSSNOC_SNOC_ARES			91
+#define GCC_NSSNOC_CRYPTO_ARES			92
+#define GCC_NSSNOC_ATB_ARES			93
+#define GCC_NSSNOC_QOSGEN_REF_ARES		94
+#define GCC_NSSNOC_TIMEOUT_REF_ARES		95
+#define GCC_PCIE0_PIPE_ARES			96
+#define GCC_PCIE0_SLEEP_ARES			97
+#define GCC_PCIE0_CORE_STICKY_ARES		98
+#define GCC_PCIE0_AXI_MASTER_ARES		99
+#define GCC_PCIE0_AXI_SLAVE_ARES		100
+#define GCC_PCIE0_AHB_ARES			101
+#define GCC_PCIE0_AXI_MASTER_STICKY_ARES	102
+#define GCC_PCIE0_AXI_SLAVE_STICKY_ARES		103
+#define GCC_PPE_FULL_RESET			104
+#define GCC_UNIPHY0_SOFT_RESET			105
+#define GCC_UNIPHY0_XPCS_RESET			106
+#define GCC_UNIPHY1_SOFT_RESET			107
+#define GCC_UNIPHY1_XPCS_RESET			108
+#define GCC_EDMA_HW_RESET			109
+#define GCC_ADSS_BCR				110
+#define GCC_NSS_NOC_TBU_BCR			111
+#define GCC_NSSPORT1_RESET			112
+#define GCC_NSSPORT2_RESET			113
+#define GCC_NSSPORT3_RESET			114
+#define GCC_NSSPORT4_RESET			115
+#define GCC_NSSPORT5_RESET			116
+#define GCC_UNIPHY0_PORT1_ARES			117
+#define GCC_UNIPHY0_PORT2_ARES			118
+#define GCC_UNIPHY0_PORT3_ARES			119
+#define GCC_UNIPHY0_PORT4_ARES			120
+#define GCC_UNIPHY0_PORT5_ARES			121
+#define GCC_UNIPHY0_PORT_4_5_RESET		122
+#define GCC_UNIPHY0_PORT_4_RESET		123
+#define GCC_LPASS_BCR				124
+#define GCC_UBI32_TBU_BCR			125
+#define GCC_LPASS_TBU_BCR			126
+#define GCC_WCSSAON_RESET			127
+#define GCC_LPASS_Q6_AXIM_ARES			128
+#define GCC_LPASS_Q6SS_TSCTR_1TO2_ARES		129
+#define GCC_LPASS_Q6SS_TRIG_ARES		130
+#define GCC_LPASS_Q6_ATBM_AT_ARES		131
+#define GCC_LPASS_Q6_PCLKDBG_ARES		132
+#define GCC_LPASS_CORE_AXIM_ARES		133
+#define GCC_LPASS_SNOC_CFG_ARES			134
+#define GCC_WCSS_DBG_ARES			135
+#define GCC_WCSS_ECAHB_ARES			136
+#define GCC_WCSS_ACMT_ARES			137
+#define GCC_WCSS_DBG_BDG_ARES			138
+#define GCC_WCSS_AHB_S_ARES			139
+#define GCC_WCSS_AXI_M_ARES			140
+#define GCC_Q6SS_DBG_ARES			141
+#define GCC_Q6_AHB_S_ARES			142
+#define GCC_Q6_AHB_ARES				143
+#define GCC_Q6_AXIM2_ARES			144
+#define GCC_Q6_AXIM_ARES			145
+#define GCC_UBI0_CORE_ARES			146
+
+#endif
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#10 lore raw

PATCH 4/6 clk: qcom: Add ipq6018 Global Clock Controller support

In reply to Sricharan R

This patch adds support for the global clock controller found on the ipq6018 based devices.

---
 drivers/clk/qcom/Kconfig       |    9 +
 drivers/clk/qcom/Makefile      |    1 +
 drivers/clk/qcom/gcc-ipq6018.c | 5267 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 5277 insertions(+)
 create mode 100644 drivers/clk/qcom/gcc-ipq6018.c
drivers/clk/qcom/Kconfig +9 -0
index e1ff83c..e5fb091 100644
@@ -120,6 +120,15 @@ config IPQ_GCC_8074
 	  i2c, USB, SD/eMMC, etc. Select this for the root clock
 	  of ipq8074.
 
+config IPQ_GCC_6018
+	tristate "IPQ6018 Global Clock Controller"
+	depends on COMMON_CLK_QCOM
+	help
+	  Support for global clock controller on ipq6018 devices.
+	  Say Y if you want to use peripheral devices such as UART, SPI,
+	  i2c, USB, SD/eMMC, etc. Select this for the root clock
+	  of ipq6018.
+
 config MSM_GCC_8660
 	tristate "MSM8660 Global Clock Controller"
 	help
drivers/clk/qcom/Makefile +1 -0
index f0768fb..025137d 100644
@@ -22,6 +22,7 @@ obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o
 obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o
 obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o
 obj-$(CONFIG_IPQ_GCC_8074) += gcc-ipq8074.o
+obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o
 obj-$(CONFIG_IPQ_LCC_806X) += lcc-ipq806x.o
 obj-$(CONFIG_MDM_GCC_9615) += gcc-mdm9615.o
 obj-$(CONFIG_MDM_LCC_9615) += lcc-mdm9615.o
drivers/clk/qcom/gcc-ipq6018.c new file +5267 -0

2,978 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

Part of the diff is not shown here. View the raw message.

#11 lore raw

Re: [PATCH 4/6] clk: qcom: Add ipq6018 Global Clock Controller support

Quoted 6 lines · Sricharan R

This patch adds support for the global clock controller found on the ipq6018 based devices.

Please fix your s-o-b chain, as described in my reply to 1/8..

Quoted 12 lines
---
 drivers/clk/qcom/Kconfig       |    9 +
 drivers/clk/qcom/Makefile      |    1 +
 drivers/clk/qcom/gcc-ipq6018.c | 5267 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 5277 insertions(+)
 create mode 100644 drivers/clk/qcom/gcc-ipq6018.c
drivers/clk/qcom/Kconfig +0 -0
index e1ff83c..e5fb091 100644

drivers/clk/qcom/Kconfig config IPQ_GCC_8074 · line 123

Quoted 4 lines
drivers/clk/qcom/Kconfig +1 -0
@@ -120,6 +120,15 @@ config IPQ_GCC_8074
 	  i2c, USB, SD/eMMC, etc. Select this for the root clock
 	  of ipq8074.
 
+config IPQ_GCC_6018

Please maintain sort order.

Quoted 16 lines
drivers/clk/qcom/Kconfig +8 -0
+	tristate "IPQ6018 Global Clock Controller"
+	depends on COMMON_CLK_QCOM
+	help
+	  Support for global clock controller on ipq6018 devices.
+	  Say Y if you want to use peripheral devices such as UART, SPI,
+	  i2c, USB, SD/eMMC, etc. Select this for the root clock
+	  of ipq6018.
+
 config MSM_GCC_8660
 	tristate "MSM8660 Global Clock Controller"
 	help
drivers/clk/qcom/Makefile +0 -0
index f0768fb..025137d 100644

drivers/clk/qcom/Makefile obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o · line 25

Quoted 4 lines
drivers/clk/qcom/Makefile +1 -0
@@ -22,6 +22,7 @@ obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o
 obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o
 obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o
 obj-$(CONFIG_IPQ_GCC_8074) += gcc-ipq8074.o
+obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o

Ditto.

Quoted 4 lines
drivers/clk/qcom/Makefile +0 -0
 obj-$(CONFIG_IPQ_LCC_806X) += lcc-ipq806x.o
 obj-$(CONFIG_MDM_GCC_9615) += gcc-mdm9615.o
 obj-$(CONFIG_MDM_LCC_9615) += lcc-mdm9615.o
drivers/clk/qcom/gcc-ipq6018.c +0 -0

[..]

drivers/clk/qcom/gcc-ipq6018.c line 5240

Quoted 8 lines
drivers/clk/qcom/gcc-ipq6018.c +8 -0
+static int gcc_ipq6018_probe(struct platform_device *pdev)
+{
+	return qcom_cc_probe(pdev, &gcc_ipq6018_desc);
+}
+
+static int gcc_ipq6018_remove(struct platform_device *pdev)
+{
+	return 0;

Just omit .remove from the gcc_ipq6018_driver instead of providing a dummy function.

drivers/clk/qcom/gcc-ipq6018.c line 5248

Quoted 8 lines
drivers/clk/qcom/gcc-ipq6018.c +8 -0
+}
+
+static struct platform_driver gcc_ipq6018_driver = {
+	.probe = gcc_ipq6018_probe,
+	.remove = gcc_ipq6018_remove,
+	.driver = {
+		.name   = "qcom,gcc-ipq6018",
+		.owner  = THIS_MODULE,

Don't specify .owner in platform drivers.

[..]

drivers/clk/qcom/gcc-ipq6018.c line 5267

Quoted 3 lines
drivers/clk/qcom/gcc-ipq6018.c +3 -0
+MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ6018 Driver");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:gcc-ipq6018");

This modalias won't be used.

Regards,
Bjorn

#12 lore raw

Re: [PATCH 4/6] clk: qcom: Add ipq6018 Global Clock Controller support

Hi Bjorn,

Quoted 11 lines · Bjorn Andersson
Quoted 6 lines · Sricharan R

This patch adds support for the global clock controller found on the ipq6018 based devices.

Please fix your s-o-b chain, as described in my reply to 1/8..

ok.

Quoted 15 lines
Quoted 15 lines
---
 drivers/clk/qcom/Kconfig       |    9 +
 drivers/clk/qcom/Makefile      |    1 +
 drivers/clk/qcom/gcc-ipq6018.c | 5267 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 5277 insertions(+)
 create mode 100644 drivers/clk/qcom/gcc-ipq6018.c
drivers/clk/qcom/Kconfig +0 -0
index e1ff83c..e5fb091 100644
@@ -120,6 +120,15 @@ config IPQ_GCC_8074
 	  i2c, USB, SD/eMMC, etc. Select this for the root clock
 	  of ipq8074.
 
Quoted 4 lines

drivers/clk/qcom/Kconfig config IPQ_GCC_8074 · line 123

Quoted 1 line
drivers/clk/qcom/Kconfig +1 -0
+config IPQ_GCC_6018

Please maintain sort order.

ok.

Quoted 14 lines
Quoted 14 lines
drivers/clk/qcom/Kconfig +8 -0
+	tristate "IPQ6018 Global Clock Controller"
+	depends on COMMON_CLK_QCOM
+	help
+	  Support for global clock controller on ipq6018 devices.
+	  Say Y if you want to use peripheral devices such as UART, SPI,
+	  i2c, USB, SD/eMMC, etc. Select this for the root clock
+	  of ipq6018.
+
 config MSM_GCC_8660
 	tristate "MSM8660 Global Clock Controller"
 	help
drivers/clk/qcom/Makefile +0 -1
index f0768fb..025137d 100644
--- a/drivers/clk/qcom/Makefile
Quoted 9 lines

drivers/clk/qcom/Makefile obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o · line 25

Quoted 6 lines

+++ b/drivers/clk/qcom/Makefile

drivers/clk/qcom/Makefile +1 -0
@@ -22,6 +22,7 @@ obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o
 obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o
 obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o
 obj-$(CONFIG_IPQ_GCC_8074) += gcc-ipq8074.o
+obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o

Ditto.

ok.

Quoted 5 lines
Quoted 4 lines
drivers/clk/qcom/Makefile +0 -0
 obj-$(CONFIG_IPQ_LCC_806X) += lcc-ipq806x.o
 obj-$(CONFIG_MDM_GCC_9615) += gcc-mdm9615.o
 obj-$(CONFIG_MDM_LCC_9615) += lcc-mdm9615.o
drivers/clk/qcom/gcc-ipq6018.c +0 -0

[..]

Quoted 12 lines

drivers/clk/qcom/gcc-ipq6018.c line 5240

Quoted 8 lines
drivers/clk/qcom/gcc-ipq6018.c +8 -0
+static int gcc_ipq6018_probe(struct platform_device *pdev)
+{
+	return qcom_cc_probe(pdev, &gcc_ipq6018_desc);
+}
+
+static int gcc_ipq6018_remove(struct platform_device *pdev)
+{
+	return 0;

Just omit .remove from the gcc_ipq6018_driver instead of providing a dummy function.

ok.

Quoted 11 lines

drivers/clk/qcom/gcc-ipq6018.c line 5248

Quoted 8 lines
drivers/clk/qcom/gcc-ipq6018.c +8 -0
+}
+
+static struct platform_driver gcc_ipq6018_driver = {
+	.probe = gcc_ipq6018_probe,
+	.remove = gcc_ipq6018_remove,
+	.driver = {
+		.name   = "qcom,gcc-ipq6018",
+		.owner  = THIS_MODULE,

Don't specify .owner in platform drivers.

ok.

Quoted 7 lines

[..]

drivers/clk/qcom/gcc-ipq6018.c line 5267

Quoted 3 lines
drivers/clk/qcom/gcc-ipq6018.c +3 -0
+MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ6018 Driver");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:gcc-ipq6018");

This modalias won't be used.

ok. But it looks to be there in other clk drivers as well.

Regards,
Sricharan

Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#13 lore raw

Re: [PATCH 4/6] clk: qcom: Add ipq6018 Global Clock Controller support

Quoted 100 lines · Sricharan R

Hi Bjorn,

Quoted 11 lines · Bjorn Andersson
Quoted 6 lines · Sricharan R

This patch adds support for the global clock controller found on the ipq6018 based devices.

Please fix your s-o-b chain, as described in my reply to 1/8..

ok.

Quoted 15 lines
Quoted 15 lines
---
 drivers/clk/qcom/Kconfig       |    9 +
 drivers/clk/qcom/Makefile      |    1 +
 drivers/clk/qcom/gcc-ipq6018.c | 5267 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 5277 insertions(+)
 create mode 100644 drivers/clk/qcom/gcc-ipq6018.c
drivers/clk/qcom/Kconfig +0 -0
index e1ff83c..e5fb091 100644
@@ -120,6 +120,15 @@ config IPQ_GCC_8074
 	  i2c, USB, SD/eMMC, etc. Select this for the root clock
 	  of ipq8074.
 
Quoted 4 lines

drivers/clk/qcom/Kconfig config IPQ_GCC_8074 · line 123

Quoted 1 line
drivers/clk/qcom/Kconfig +1 -0
+config IPQ_GCC_6018

Please maintain sort order.

ok.

Quoted 14 lines
Quoted 14 lines
drivers/clk/qcom/Kconfig +8 -0
+	tristate "IPQ6018 Global Clock Controller"
+	depends on COMMON_CLK_QCOM
+	help
+	  Support for global clock controller on ipq6018 devices.
+	  Say Y if you want to use peripheral devices such as UART, SPI,
+	  i2c, USB, SD/eMMC, etc. Select this for the root clock
+	  of ipq6018.
+
 config MSM_GCC_8660
 	tristate "MSM8660 Global Clock Controller"
 	help
drivers/clk/qcom/Makefile +0 -1
index f0768fb..025137d 100644
--- a/drivers/clk/qcom/Makefile
Quoted 9 lines

drivers/clk/qcom/Makefile obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o · line 25

Quoted 6 lines

+++ b/drivers/clk/qcom/Makefile

drivers/clk/qcom/Makefile +1 -0
@@ -22,6 +22,7 @@ obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o
 obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o
 obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o
 obj-$(CONFIG_IPQ_GCC_8074) += gcc-ipq8074.o
+obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o

Ditto.

ok.

Quoted 5 lines
Quoted 4 lines
drivers/clk/qcom/Makefile +0 -0
 obj-$(CONFIG_IPQ_LCC_806X) += lcc-ipq806x.o
 obj-$(CONFIG_MDM_GCC_9615) += gcc-mdm9615.o
 obj-$(CONFIG_MDM_LCC_9615) += lcc-mdm9615.o
drivers/clk/qcom/gcc-ipq6018.c +0 -0

[..]

Quoted 12 lines

drivers/clk/qcom/gcc-ipq6018.c line 5240

Quoted 8 lines
drivers/clk/qcom/gcc-ipq6018.c +8 -0
+static int gcc_ipq6018_probe(struct platform_device *pdev)
+{
+	return qcom_cc_probe(pdev, &gcc_ipq6018_desc);
+}
+
+static int gcc_ipq6018_remove(struct platform_device *pdev)
+{
+	return 0;

Just omit .remove from the gcc_ipq6018_driver instead of providing a dummy function.

ok.

Quoted 11 lines

drivers/clk/qcom/gcc-ipq6018.c line 5248

Quoted 8 lines
drivers/clk/qcom/gcc-ipq6018.c +8 -0
+}
+
+static struct platform_driver gcc_ipq6018_driver = {
+	.probe = gcc_ipq6018_probe,
+	.remove = gcc_ipq6018_remove,
+	.driver = {
+		.name   = "qcom,gcc-ipq6018",
+		.owner  = THIS_MODULE,

Don't specify .owner in platform drivers.

ok.

Quoted 1 line

[..]

Quoted 9 lines
Quoted 6 lines

drivers/clk/qcom/gcc-ipq6018.c line 5267

Quoted 3 lines
drivers/clk/qcom/gcc-ipq6018.c +3 -0
+MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ6018 Driver");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:gcc-ipq6018");

This modalias won't be used.

ok. But it looks to be there in other clk drivers as well.

It serves the purpose that the driver will be automatically modprobed if someone calls:

  platform_device_register*(...,  "gcc-ipq6018", ...);

So for everything that is only going be probed from DT (or ACPI) this does not add any value. As such there are several other places where these aliases should be dropped.

Regards,
Bjorn

#14 lore raw

PATCH 5/6 arm64: dts: Add ipq6018 SoC and CP01 board support

In reply to Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

---
 arch/arm64/boot/dts/qcom/Makefile            |   1 +
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  35 ++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 231 +++++++++++++++++++++++++++
 3 files changed, 267 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 21d548f..ac22dbb 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-bullhead-rev-101.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8994-angler-rev-101.dtb
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +35 -0
new file mode 100644
index 0000000..ac7cb22
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IPQ6018 CP01 board device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq6018.dtsi"
+
+/ {
+	#address-cells = <0x2>;
+	#size-cells = <0x2>;
+	model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
+	compatible = "qcom,ipq6018-cp01", "qcom,ipq6018";
+	interrupt-parent = <&intc>;
+};
+
+&tlmm {
+	uart_pins: uart_pins {
+		mux {
+			pins = "gpio44", "gpio45";
+			function = "blsp2_uart";
+			drive-strength = <8>;
+			bias-pull-down;
+		};
+	};
+};
+
+&blsp1_uart3 {
+	pinctrl-0 = <&uart_pins>;
+	pinctrl-names = "default";
+	status = "ok";
+};
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +231 -0

231 lines not on this page · raw message

Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#15 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Quoted 104 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

---
 arch/arm64/boot/dts/qcom/Makefile            |   1 +
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  35 ++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 231 +++++++++++++++++++++++++++
 3 files changed, 267 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 21d548f..ac22dbb 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-bullhead-rev-101.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8994-angler-rev-101.dtb
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +35 -0
new file mode 100644
index 0000000..ac7cb22
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IPQ6018 CP01 board device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq6018.dtsi"
+
+/ {
+	#address-cells = <0x2>;
+	#size-cells = <0x2>;
+	model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
+	compatible = "qcom,ipq6018-cp01", "qcom,ipq6018";
+	interrupt-parent = <&intc>;
+};
+
+&tlmm {
+	uart_pins: uart_pins {
+		mux {
+			pins = "gpio44", "gpio45";
+			function = "blsp2_uart";
+			drive-strength = <8>;
+			bias-pull-down;
+		};
+	};
+};
+
+&blsp1_uart3 {
+	pinctrl-0 = <&uart_pins>;
+	pinctrl-names = "default";
+	status = "ok";
+};
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +32 -0
new file mode 100644
index 0000000..79cccdd
@@ -0,0 +1,231 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IPQ6018 SoC device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/clock/qcom,gcc-ipq6018.h>
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ6018";
+	compatible = "qcom,ipq6018";
+
+	chosen {
+		bootargs = "console=ttyMSM0,115200,n8 rw init=/init";
+		bootargs-append = " swiotlb=1 clk_ignore_unused";
+	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		tz:tz@48500000 {
+			no-map;
+			reg = <0x0 0x48500000 0x0 0x00200000>;
+		};
+	};
+
+	soc: soc {
+		#address-cells = <0x1>;

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 42

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +10 -0
+		#size-cells = <0x1>;
+		ranges = <0 0 0 0xffffffff>;
+		dma-ranges;
+		compatible = "simple-bus";
+
+		intc: interrupt-controller@b000000 {
+			compatible = "qcom,msm-qgic2";
+			interrupt-controller;
+			#interrupt-cells = <0x3>;
+			reg = <0xb000000 0x1000>, <0xb002000 0x1000>;

Where are the rest of the GICv2 MMIO regions, such as GICV and GICH? And the maintenance interrupt?

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 50

Quoted 8 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +8 -0
+		};
+
+		timer {
+			compatible = "arm,armv8-timer";
+			interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;

The fact that you expose the EL2 timer interrupt would tend to confirm the idea that this system supports virtualization... Hence my questions above.

Thanks,

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...
#16 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Hi Marc,

Quoted 110 lines · Marc Zyngier
Quoted 109 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

---
 arch/arm64/boot/dts/qcom/Makefile            |   1 +
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  35 ++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 231 +++++++++++++++++++++++++++
 3 files changed, 267 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 21d548f..ac22dbb 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-bullhead-rev-101.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8994-angler-rev-101.dtb
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +35 -0
new file mode 100644
index 0000000..ac7cb22
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IPQ6018 CP01 board device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq6018.dtsi"
+
+/ {
+	#address-cells = <0x2>;
+	#size-cells = <0x2>;
+	model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
+	compatible = "qcom,ipq6018-cp01", "qcom,ipq6018";
+	interrupt-parent = <&intc>;
+};
+
+&tlmm {
+	uart_pins: uart_pins {
+		mux {
+			pins = "gpio44", "gpio45";
+			function = "blsp2_uart";
+			drive-strength = <8>;
+			bias-pull-down;
+		};
+	};
+};
+
+&blsp1_uart3 {
+	pinctrl-0 = <&uart_pins>;
+	pinctrl-names = "default";
+	status = "ok";
+};
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +37 -0
new file mode 100644
index 0000000..79cccdd
@@ -0,0 +1,231 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IPQ6018 SoC device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/clock/qcom,gcc-ipq6018.h>
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ6018";
+	compatible = "qcom,ipq6018";
+
+	chosen {
+		bootargs = "console=ttyMSM0,115200,n8 rw init=/init";
+		bootargs-append = " swiotlb=1 clk_ignore_unused";
+	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		tz:tz@48500000 {
+			no-map;
+			reg = <0x0 0x48500000 0x0 0x00200000>;
+		};
+	};
+
+	soc: soc {
+		#address-cells = <0x1>;
+		#size-cells = <0x1>;
+		ranges = <0 0 0 0xffffffff>;
+		dma-ranges;
+		compatible = "simple-bus";
+
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 42

Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +5 -0
+		intc: interrupt-controller@b000000 {
+			compatible = "qcom,msm-qgic2";
+			interrupt-controller;
+			#interrupt-cells = <0x3>;
+			reg = <0xb000000 0x1000>, <0xb002000 0x1000>;

Where are the rest of the GICv2 MMIO regions, such as GICV and GICH? And the maintenance interrupt?

GICH - 0xB001000 -- 0xB002000
GICV - 0xB004000 -- 0xB005000
Will add this and the PPI as well.

Regards,
Sricharan

Quoted 17 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 50

Quoted 8 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +8 -0
+		};
+
+		timer {
+			compatible = "arm,armv8-timer";
+			interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;

The fact that you expose the EL2 timer interrupt would tend to confirm the idea that this system supports virtualization... Hence my questions above.

Thanks,

	M.
Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#17 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

In reply to Sricharan R
Quoted 8 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 206

Quoted 8 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
 
+       clocks {
+               sleep_clk: sleep_clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <32000>;
+                       #clock-cells = <0>;
+               };
+

Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML.

Quoted 1 line

From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK

declares them at 32000 Hz. Since you probably have access to the BOM and datasheets. Can you please confirm what's the real clock frequency for the IPQ6018.
(And maybe also for the sleep_clk of the IPQ4018 as well?).

Cheers,
Christian

#18 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Hi Christian,

Quoted 10 lines · Christian Lamparter
Quoted 9 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +0 -0
Quoted 15 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 206

Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
+       clocks {
+               sleep_clk: sleep_clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <32000>;
+                       #clock-cells = <0>;
+               };
+

Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK declares them at 32000 Hz. Since you probably have access to the BOM and datasheets. Can you please confirm what's the real clock frequency for the IPQ6018.
(And maybe also for the sleep_clk of the IPQ4018 as well?).

What exactly is the issue that you faced ?
Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well.

Regards,
Sricharan

Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#19 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Quoted 29 lines · CEST Sricharan R

Hi Christian,

Quoted 10 lines · Christian Lamparter
Quoted 9 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +0 -0
Quoted 15 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 206

Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
+       clocks {
+               sleep_clk: sleep_clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <32000>;
+                       #clock-cells = <0>;
+               };
+

Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK declares them at 32000 Hz. Since you probably have access to the BOM and datasheets. Can you please confirm what's the real clock frequency for the IPQ6018.
(And maybe also for the sleep_clk of the IPQ4018 as well?).

Quoted 2 lines

What exactly is the issue that you faced ?
Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well.

We need just a confirmation.

Then again, Currently the qcom-ipq4019.dtsi is using 32768 Hz.

|		sleep_clk: sleep_clk {
|			compatible = "fixed-clock";
|			clock-frequency = <32768>;
|			#clock-cells = <0>;
|		};

<https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/qcom-ipq4019.dtsi#L144>

Which makes sense, because all previous Qualcomm Atheros MIPS and the future IPQ8072 SoCs have been either using or deriving a 32768 Hz clock.

For example: The AR9344 derives the clock from the 25MHz/40MHz external oscillator. This is explained in "8.16.9 Derived RTC Clock (DERIVED_RTC_CLK)". Which mentions that the "32KHz" clock interval is 30.5 usec / 30.48 usec depending whenever the external reference crystal has 40MHz or 25MHz. (1/30.5usec = 32.7868852 kilohertz!). The QCA9558 datasheet says the same in "10.19.11 Derived RTC Clock".

For IPQ8072: I point to the post by Sven Eckelmann on the OpenWrt ML:
<http://lists.infradead.org/pipermail/openwrt-devel/2019-May/017131.html>
"I was only able to verify for IPQ8072 that it had a 32.768 KHz sleep clock."

So this is pretty much "why there is an issue", it's confusing. Is possible can you please look if there are (fixed) divisors values listed in the documentation or the registers and bits that the values are stored in? Because then we could just calculate it.

Regards,
Christian

#20 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Hi Christian,

Quoted 60 lines · Christian Lamparter
Quoted 29 lines · CEST Sricharan R

Hi Christian,

Quoted 10 lines · Christian Lamparter
Quoted 9 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +0 -0
Quoted 15 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 206

Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
+       clocks {
+               sleep_clk: sleep_clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <32000>;
+                       #clock-cells = <0>;
+               };
+

Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK declares them at 32000 Hz. Since you probably have access to the BOM and datasheets. Can you please confirm what's the real clock frequency for the IPQ6018.
(And maybe also for the sleep_clk of the IPQ4018 as well?).

Quoted 2 lines

What exactly is the issue that you faced ?
Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well.

We need just a confirmation.

Then again, Currently the qcom-ipq4019.dtsi is using 32768 Hz.

|		sleep_clk: sleep_clk {
|			compatible = "fixed-clock";
|			clock-frequency = <32768>;
|			#clock-cells = <0>;
|		};

<https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/qcom-ipq4019.dtsi#L144>

Which makes sense, because all previous Qualcomm Atheros MIPS and the future IPQ8072 SoCs have been either using or deriving a 32768 Hz clock.

For example: The AR9344 derives the clock from the 25MHz/40MHz external oscillator. This is explained in "8.16.9 Derived RTC Clock (DERIVED_RTC_CLK)". Which mentions that the "32KHz" clock interval is 30.5 usec / 30.48 usec depending whenever the external reference crystal has 40MHz or 25MHz. (1/30.5usec = 32.7868852 kilohertz!). The QCA9558 datasheet says the same in "10.19.11 Derived RTC Clock".

For IPQ8072: I point to the post by Sven Eckelmann on the OpenWrt ML:
<http://lists.infradead.org/pipermail/openwrt-devel/2019-May/017131.html>
"I was only able to verify for IPQ8072 that it had a 32.768 KHz sleep clock."

Quoted 5 lines

So this is pretty much "why there is an issue", it's confusing. Is possible can you please look if there are (fixed) divisors values listed in the documentation or the registers and bits that the values are stored in? Because then we could just calculate it.

Really sorry for the confusion. So looking little more, SLEEP_CLK is derived from an external 38.4MHZ crystal, it is 32.768 KHZ. Somehow the clk freq plan etc seems to mention them only as .032 MHZ and misses out. That means i will correct the patch for 32768 and probably the ipq8074.dtsi as well

Regards,
Sricharan

Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#21 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Quoted 63 lines · CEST Sricharan R

Hi Christian,

Quoted 60 lines · Christian Lamparter
Quoted 29 lines · CEST Sricharan R

Hi Christian,

Quoted 10 lines · Christian Lamparter
Quoted 9 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +0 -0
Quoted 15 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 206

Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
+       clocks {
+               sleep_clk: sleep_clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <32000>;
+                       #clock-cells = <0>;
+               };
+

Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK declares them at 32000 Hz. Since you probably have access to the BOM and datasheets. Can you please confirm what's the real clock frequency for the IPQ6018.
(And maybe also for the sleep_clk of the IPQ4018 as well?).

Quoted 2 lines

What exactly is the issue that you faced ?
Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well.

We need just a confirmation.

Then again, Currently the qcom-ipq4019.dtsi is using 32768 Hz.

|		sleep_clk: sleep_clk {
|			compatible = "fixed-clock";
|			clock-frequency = <32768>;
|			#clock-cells = <0>;
|		};

<https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/qcom-ipq4019.dtsi#L144>

Which makes sense, because all previous Qualcomm Atheros MIPS and the future IPQ8072 SoCs have been either using or deriving a 32768 Hz clock.

For example: The AR9344 derives the clock from the 25MHz/40MHz external oscillator. This is explained in "8.16.9 Derived RTC Clock (DERIVED_RTC_CLK)". Which mentions that the "32KHz" clock interval is 30.5 usec / 30.48 usec depending whenever the external reference crystal has 40MHz or 25MHz. (1/30.5usec = 32.7868852 kilohertz!). The QCA9558 datasheet says the same in "10.19.11 Derived RTC Clock".

For IPQ8072: I point to the post by Sven Eckelmann on the OpenWrt ML:
<http://lists.infradead.org/pipermail/openwrt-devel/2019-May/017131.html>
"I was only able to verify for IPQ8072 that it had a 32.768 KHz sleep clock."

Quoted 8 lines
Quoted 5 lines

So this is pretty much "why there is an issue", it's confusing. Is possible can you please look if there are (fixed) divisors values listed in the documentation or the registers and bits that the values are stored in? Because then we could just calculate it.

Really sorry for the confusion. So looking little more, SLEEP_CLK is derived from an external 38.4MHZ crystal, it is 32.768 KHZ.

That's really valuable information to have. Thank you!

Quoted 3 lines

Somehow the clk freq plan etc seems to mention them only as .032 MHZ and misses out. That means i will correct the patch for 32768 and probably the ipq8074.dtsi as well

Ok, there's one more issue that Paul found (at least with the IPQ4019),
https://patchwork.ozlabs.org/patch/1099482

it seems that the "sleep_clk" node in the qcom-ipq4019.dtsi is not used by the gcc-ipq4019.c clk driver. this causes both wifi rtc_clks and the usb sleep clks to dangle in the /sys/kernel/debug/clk/clk_summary (from a RT-AC58U)

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 9 9 48000000 0 0
[...]

 sleep_clk                                1            1       32768          0 0  
 gcc_wcss5g_rtc_clk                       1            1           0          0 0  
 gcc_wcss2g_rtc_clk                       1            1           0          0 0  
 gcc_usb3_sleep_clk                       1            1           0          0 0  
 gcc_usb2_sleep_clk                       1            1           0          0 0  

with his patch the /sys/kernel/debug/clk/clk_summary looks "better"

(something like this:)

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 9 9 48000000 0 0
[...]

 gcc_sleep_clk_src                        5            5       32000          0 0  
    gcc_wcss5g_rtc_clk                    1            1       32000          0 0  
    gcc_wcss2g_rtc_clk                    1            1       32000          0 0  
    gcc_usb3_sleep_clk                    1            1       32000          0 0  
    gcc_usb2_sleep_clk                    1            1       32000          0 0  

but judging from your comment "SLEEP_CLK is derived from an external 38.4MHZ crystal" the gcc_sleep_clk_src / sleep_clk should have xo as the parent. so the ideal output should be:

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 10 10 48000000 0 0
[...]

    gcc_sleep_clk                         5            5       32768          0 0  
       gcc_wcss5g_rtc_clk                 1            1       32768          0 0  
       gcc_wcss2g_rtc_clk                 1            1       32768          0 0  
       gcc_usb3_sleep_clk                 1            1       32768          0 0  
       gcc_usb2_sleep_clk                 1            1       32768          0 0  

or am I missing/skipping over something important?

Regards,
Christian

#22 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Hi Christian,

Quoted 117 lines · Christian Lamparter
Quoted 63 lines · CEST Sricharan R

Hi Christian,

Quoted 60 lines · Christian Lamparter
Quoted 29 lines · CEST Sricharan R

Hi Christian,

Quoted 10 lines · Christian Lamparter
Quoted 9 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +0 -0
Quoted 15 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 206

Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
+       clocks {
+               sleep_clk: sleep_clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <32000>;
+                       #clock-cells = <0>;
+               };
+

Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK declares them at 32000 Hz. Since you probably have access to the BOM and datasheets. Can you please confirm what's the real clock frequency for the IPQ6018.
(And maybe also for the sleep_clk of the IPQ4018 as well?).

Quoted 2 lines

What exactly is the issue that you faced ?
Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well.

We need just a confirmation.

Then again, Currently the qcom-ipq4019.dtsi is using 32768 Hz.

|		sleep_clk: sleep_clk {
|			compatible = "fixed-clock";
|			clock-frequency = <32768>;
|			#clock-cells = <0>;
|		};

<https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/qcom-ipq4019.dtsi#L144>

Which makes sense, because all previous Qualcomm Atheros MIPS and the future IPQ8072 SoCs have been either using or deriving a 32768 Hz clock.

For example: The AR9344 derives the clock from the 25MHz/40MHz external oscillator. This is explained in "8.16.9 Derived RTC Clock (DERIVED_RTC_CLK)". Which mentions that the "32KHz" clock interval is 30.5 usec / 30.48 usec depending whenever the external reference crystal has 40MHz or 25MHz. (1/30.5usec = 32.7868852 kilohertz!). The QCA9558 datasheet says the same in "10.19.11 Derived RTC Clock".

For IPQ8072: I point to the post by Sven Eckelmann on the OpenWrt ML:
<http://lists.infradead.org/pipermail/openwrt-devel/2019-May/017131.html>
"I was only able to verify for IPQ8072 that it had a 32.768 KHz sleep clock."

Quoted 8 lines
Quoted 5 lines

So this is pretty much "why there is an issue", it's confusing. Is possible can you please look if there are (fixed) divisors values listed in the documentation or the registers and bits that the values are stored in? Because then we could just calculate it.

Really sorry for the confusion. So looking little more, SLEEP_CLK is derived from an external 38.4MHZ crystal, it is 32.768 KHZ.

That's really valuable information to have. Thank you!

Quoted 3 lines

Somehow the clk freq plan etc seems to mention them only as .032 MHZ and misses out. That means i will correct the patch for 32768 and probably the ipq8074.dtsi as well

Ok, there's one more issue that Paul found (at least with the IPQ4019),
https://patchwork.ozlabs.org/patch/1099482

it seems that the "sleep_clk" node in the qcom-ipq4019.dtsi is not used by the gcc-ipq4019.c clk driver. this causes both wifi rtc_clks and the usb sleep clks to dangle in the /sys/kernel/debug/clk/clk_summary (from a RT-AC58U)

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 9 9 48000000 0 0
[...]

 sleep_clk                                1            1       32768          0 0  
 gcc_wcss5g_rtc_clk                       1            1           0          0 0  
 gcc_wcss2g_rtc_clk                       1            1           0          0 0  
 gcc_usb3_sleep_clk                       1            1           0          0 0  
 gcc_usb2_sleep_clk                       1            1           0          0 0  

with his patch the /sys/kernel/debug/clk/clk_summary looks "better"

(something like this:)

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 9 9 48000000 0 0
[...]

 gcc_sleep_clk_src                        5            5       32000          0 0  
    gcc_wcss5g_rtc_clk                    1            1       32000          0 0  
    gcc_wcss2g_rtc_clk                    1            1       32000          0 0  
    gcc_usb3_sleep_clk                    1            1       32000          0 0  
    gcc_usb2_sleep_clk                    1            1       32000          0 0  

but judging from your comment "SLEEP_CLK is derived from an external 38.4MHZ crystal" the gcc_sleep_clk_src / sleep_clk should have xo as the parent. so the ideal output should be:

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 10 10 48000000 0 0
[...]

Quoted 8 lines
    gcc_sleep_clk                         5            5       32768          0 0  
       gcc_wcss5g_rtc_clk                 1            1       32768          0 0  
       gcc_wcss2g_rtc_clk                 1            1       32768          0 0  
       gcc_usb3_sleep_clk                 1            1       32768          0 0  
       gcc_usb2_sleep_clk                 1            1       32768          0 0  

or am I missing/skipping over something important?

Sorry for the delayed response. So what i said above (32768 clk) looks like true only for ipq8074. For ipq4019, looks like 32000.

That means, there is still some thing unclear. I am checking for precise information from HW team for ipq4019/8074/6018. Please hang on, will update you asap.

Regards,
Sricharan

Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#23 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Hello Sricharan,

Quoted 127 lines · CEST Sricharan R
Quoted 117 lines · Christian Lamparter
Quoted 63 lines · CEST Sricharan R

Hi Christian,

Quoted 60 lines · Christian Lamparter
Quoted 29 lines · CEST Sricharan R

Hi Christian,

Quoted 10 lines · Christian Lamparter
Quoted 9 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +0 -0
Quoted 15 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi

Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
+       clocks {
+               sleep_clk: sleep_clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <32000>;
+                       #clock-cells = <0>;
+               };
+

Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK declares them at 32000 Hz. Since you probably have access to the BOM and datasheets. Can you please confirm what's the real clock frequency for the IPQ6018.
(And maybe also for the sleep_clk of the IPQ4018 as well?).

Quoted 2 lines

What exactly is the issue that you faced ?
Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well.

We need just a confirmation.

Then again, Currently the qcom-ipq4019.dtsi is using 32768 Hz.

|		sleep_clk: sleep_clk {
|			compatible = "fixed-clock";
|			clock-frequency = <32768>;
|			#clock-cells = <0>;
|		};

<https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/qcom-ipq4019.dtsi#L144>

Which makes sense, because all previous Qualcomm Atheros MIPS and the future IPQ8072 SoCs have been either using or deriving a 32768 Hz clock.

For example: The AR9344 derives the clock from the 25MHz/40MHz external oscillator. This is explained in "8.16.9 Derived RTC Clock (DERIVED_RTC_CLK)". Which mentions that the "32KHz" clock interval is 30.5 usec / 30.48 usec depending whenever the external reference crystal has 40MHz or 25MHz. (1/30.5usec = 32.7868852 kilohertz!). The QCA9558 datasheet says the same in "10.19.11 Derived RTC Clock".

For IPQ8072: I point to the post by Sven Eckelmann on the OpenWrt ML:
<http://lists.infradead.org/pipermail/openwrt-devel/2019-May/017131.html>
"I was only able to verify for IPQ8072 that it had a 32.768 KHz sleep clock."

Quoted 8 lines
Quoted 5 lines

So this is pretty much "why there is an issue", it's confusing. Is possible can you please look if there are (fixed) divisors values listed in the documentation or the registers and bits that the values are stored in? Because then we could just calculate it.

Really sorry for the confusion. So looking little more, SLEEP_CLK is derived from an external 38.4MHZ crystal, it is 32.768 KHZ.

That's really valuable information to have. Thank you!

Quoted 3 lines

Somehow the clk freq plan etc seems to mention them only as .032 MHZ and misses out. That means i will correct the patch for 32768 and probably the ipq8074.dtsi as well

Ok, there's one more issue that Paul found (at least with the IPQ4019),
https://patchwork.ozlabs.org/patch/1099482

it seems that the "sleep_clk" node in the qcom-ipq4019.dtsi is not used by the gcc-ipq4019.c clk driver. this causes both wifi rtc_clks and the usb sleep clks to dangle in the /sys/kernel/debug/clk/clk_summary (from a RT-AC58U)

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 9 9 48000000 0 0
[...]

 sleep_clk                                1            1       32768          0 0  
 gcc_wcss5g_rtc_clk                       1            1           0          0 0  
 gcc_wcss2g_rtc_clk                       1            1           0          0 0  
 gcc_usb3_sleep_clk                       1            1           0          0 0  
 gcc_usb2_sleep_clk                       1            1           0          0 0  

with his patch the /sys/kernel/debug/clk/clk_summary looks "better"

(something like this:)

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 9 9 48000000 0 0
[...]

 gcc_sleep_clk_src                        5            5       32000          0 0  
    gcc_wcss5g_rtc_clk                    1            1       32000          0 0  
    gcc_wcss2g_rtc_clk                    1            1       32000          0 0  
    gcc_usb3_sleep_clk                    1            1       32000          0 0  
    gcc_usb2_sleep_clk                    1            1       32000          0 0  

but judging from your comment "SLEEP_CLK is derived from an external 38.4MHZ crystal" the gcc_sleep_clk_src / sleep_clk should have xo as the parent. so the ideal output should be:

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 10 10 48000000 0 0
[...]

Quoted 8 lines
    gcc_sleep_clk                         5            5       32768          0 0  
       gcc_wcss5g_rtc_clk                 1            1       32768          0 0  
       gcc_wcss2g_rtc_clk                 1            1       32768          0 0  
       gcc_usb3_sleep_clk                 1            1       32768          0 0  
       gcc_usb2_sleep_clk                 1            1       32768          0 0  

or am I missing/skipping over something important?

Quoted 6 lines

Sorry for the delayed response. So what i said above (32768 clk) looks like true only for ipq8074. For ipq4019, looks like 32000.

That means, there is still some thing unclear. I am checking for precise information from HW team for ipq4019/8074/6018. Please hang on, will update you asap.

Thank you for looking this up! I'll definitely stick around for the final verdict.

Also, I think the "xo" clk of your IPQ6018 dts should get the "always-on;" property (any maybe sleep_clk as well?).

Paul discovered that the QSDK had this extra commit
<https://lore.kernel.org/patchwork/patch/1089385/>
(Maybe the changeid can help you look it up internally)

For IPQ4019, this enables the high resolution with a 1ns resolution instead of 10ms.

(echo q > /proc/sysrq-trigger can be used to check this just look for the "resolution" value before and after.)

Cheers,
Christian

#24 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Hi Christian,

Quoted 133 lines · Christian Lamparter

Hello Sricharan,

Quoted 130 lines · CEST Sricharan R
Quoted 117 lines · Christian Lamparter
Quoted 63 lines · CEST Sricharan R

Hi Christian,

Quoted 60 lines · Christian Lamparter
Quoted 29 lines · CEST Sricharan R

Hi Christian,

Quoted 10 lines · Christian Lamparter
Quoted 9 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +0 -0
Quoted 15 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi

Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
+       clocks {
+               sleep_clk: sleep_clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <32000>;
+                       #clock-cells = <0>;
+               };
+

Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK declares them at 32000 Hz. Since you probably have access to the BOM and datasheets. Can you please confirm what's the real clock frequency for the IPQ6018.
(And maybe also for the sleep_clk of the IPQ4018 as well?).

Quoted 2 lines

What exactly is the issue that you faced ?
Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well.

We need just a confirmation.

Then again, Currently the qcom-ipq4019.dtsi is using 32768 Hz.

|		sleep_clk: sleep_clk {
|			compatible = "fixed-clock";
|			clock-frequency = <32768>;
|			#clock-cells = <0>;
|		};

<https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/qcom-ipq4019.dtsi#L144>

Which makes sense, because all previous Qualcomm Atheros MIPS and the future IPQ8072 SoCs have been either using or deriving a 32768 Hz clock.

For example: The AR9344 derives the clock from the 25MHz/40MHz external oscillator. This is explained in "8.16.9 Derived RTC Clock (DERIVED_RTC_CLK)". Which mentions that the "32KHz" clock interval is 30.5 usec / 30.48 usec depending whenever the external reference crystal has 40MHz or 25MHz. (1/30.5usec = 32.7868852 kilohertz!). The QCA9558 datasheet says the same in "10.19.11 Derived RTC Clock".

For IPQ8072: I point to the post by Sven Eckelmann on the OpenWrt ML:
<http://lists.infradead.org/pipermail/openwrt-devel/2019-May/017131.html>
"I was only able to verify for IPQ8072 that it had a 32.768 KHz sleep clock."

Quoted 8 lines
Quoted 5 lines

So this is pretty much "why there is an issue", it's confusing. Is possible can you please look if there are (fixed) divisors values listed in the documentation or the registers and bits that the values are stored in? Because then we could just calculate it.

Really sorry for the confusion. So looking little more, SLEEP_CLK is derived from an external 38.4MHZ crystal, it is 32.768 KHZ.

That's really valuable information to have. Thank you!

Quoted 3 lines

Somehow the clk freq plan etc seems to mention them only as .032 MHZ and misses out. That means i will correct the patch for 32768 and probably the ipq8074.dtsi as well

Ok, there's one more issue that Paul found (at least with the IPQ4019),
https://patchwork.ozlabs.org/patch/1099482

it seems that the "sleep_clk" node in the qcom-ipq4019.dtsi is not used by the gcc-ipq4019.c clk driver. this causes both wifi rtc_clks and the usb sleep clks to dangle in the /sys/kernel/debug/clk/clk_summary (from a RT-AC58U)

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 9 9 48000000 0 0
[...]

 sleep_clk                                1            1       32768          0 0  
 gcc_wcss5g_rtc_clk                       1            1           0          0 0  
 gcc_wcss2g_rtc_clk                       1            1           0          0 0  
 gcc_usb3_sleep_clk                       1            1           0          0 0  
 gcc_usb2_sleep_clk                       1            1           0          0 0  

with his patch the /sys/kernel/debug/clk/clk_summary looks "better"

(something like this:)

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 9 9 48000000 0 0
[...]

 gcc_sleep_clk_src                        5            5       32000          0 0  
    gcc_wcss5g_rtc_clk                    1            1       32000          0 0  
    gcc_wcss2g_rtc_clk                    1            1       32000          0 0  
    gcc_usb3_sleep_clk                    1            1       32000          0 0  
    gcc_usb2_sleep_clk                    1            1       32000          0 0  

but judging from your comment "SLEEP_CLK is derived from an external 38.4MHZ crystal" the gcc_sleep_clk_src / sleep_clk should have xo as the parent. so the ideal output should be:

clock enable_cnt prepare_cnt rate accuracy phase
----------------------------------------------------------------------------------------
xo 10 10 48000000 0 0
[...]

Quoted 8 lines
    gcc_sleep_clk                         5            5       32768          0 0  
       gcc_wcss5g_rtc_clk                 1            1       32768          0 0  
       gcc_wcss2g_rtc_clk                 1            1       32768          0 0  
       gcc_usb3_sleep_clk                 1            1       32768          0 0  
       gcc_usb2_sleep_clk                 1            1       32768          0 0  

or am I missing/skipping over something important?

Sorry for the delayed response. So what i said above (32768 clk) looks like true only for ipq8074. For ipq4019, looks like 32000.

Quoted 7 lines
Quoted 3 lines

That means, there is still some thing unclear. I am checking for precise information from HW team for ipq4019/8074/6018. Please hang on, will update you asap.

Thank you for looking this up! I'll definitely stick around for the final verdict.

So the HW guys responded and as per that, ipq4019/ipq6018 it is 32000. It is derived from a 48M wifi refclk

48M wifi ref clk -> [/2 divider] -> [/750 divider] -> sleep_clk (32000)

In case of ipq8074, it is derived from the pmic and 32768.

Quoted 10 lines

Also, I think the "xo" clk of your IPQ6018 dts should get the "always-on;" property (any maybe sleep_clk as well?).

Paul discovered that the QSDK had this extra commit
<https://lore.kernel.org/patchwork/patch/1089385/>
(Maybe the changeid can help you look it up internally)

For IPQ4019, this enables the high resolution with a 1ns resolution instead of 10ms.

ho ok, this patch is needed.

Regards,
Sricharan

Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#25 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

In reply to Sricharan R
Quoted 5 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

Please fix the order of these (or add a Co-developed-by).

Quoted 13 lines
---
 arch/arm64/boot/dts/qcom/Makefile            |   1 +
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  35 ++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 231 +++++++++++++++++++++++++++
 3 files changed, 267 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi
arch/arm64/boot/dts/qcom/Makefile +0 -0
index 21d548f..ac22dbb 100644

arch/arm64/boot/dts/qcom/Makefile line 5

Quoted 4 lines
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb

Sort order.

Quoted 13 lines
arch/arm64/boot/dts/qcom/Makefile +0 -0
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-bullhead-rev-101.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8994-angler-rev-101.dtb
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +4 -0
new file mode 100644
index 0000000..ac7cb22
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IPQ6018 CP01 board device tree source
+ *

arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts line 14

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +10 -0
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq6018.dtsi"
+
+/ {
+	#address-cells = <0x2>;
+	#size-cells = <0x2>;

This is a count, write it in base 10..

arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts line 17

Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +3 -0
+	model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
+	compatible = "qcom,ipq6018-cp01", "qcom,ipq6018";
+	interrupt-parent = <&intc>;

Changing #address-cells, #size-cells and interrupt-parent will break the dtsi, so I think you should specify them there.

arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts line 20

Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +3 -0
+};
+
+&tlmm {

Please sort your nodes based on address, then node name, then label.

Quoted 24 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +15 -0
+	uart_pins: uart_pins {
+		mux {
+			pins = "gpio44", "gpio45";
+			function = "blsp2_uart";
+			drive-strength = <8>;
+			bias-pull-down;
+		};
+	};
+};
+
+&blsp1_uart3 {
+	pinctrl-0 = <&uart_pins>;
+	pinctrl-names = "default";
+	status = "ok";
+};
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +3 -0
new file mode 100644
index 0000000..79cccdd
@@ -0,0 +1,231 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IPQ6018 SoC device tree source

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 13

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +10 -0
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/clock/qcom,gcc-ipq6018.h>
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ6018";
+	compatible = "qcom,ipq6018";

No need for model and compatible in the dtsi, these should always be specified by the including file.

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 16

Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +3 -0
+
+	chosen {
+		bootargs = "console=ttyMSM0,115200,n8 rw init=/init";

Do you really need console? Can't you use stdout-path?

And there's no need to specify init=/init.

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 17

Quoted 1 line
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +1 -0
+		bootargs-append = " swiotlb=1 clk_ignore_unused";

I'm hoping that you will work on removing the need for clk_ignore_unused.

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 25

Quoted 8 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +8 -0
+	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		tz:tz@48500000 {

Space after :

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 27

Quoted 2 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +2 -0
+			no-map;
+			reg = <0x0 0x48500000 0x0 0x00200000>;

I would prefer to have the reg first in these nodes, then the region's properties.

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 38

Quoted 11 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +11 -0
+		};
+	};
+
+	soc: soc {
+		#address-cells = <0x1>;
+		#size-cells = <0x1>;
+		ranges = <0 0 0 0xffffffff>;
+		dma-ranges;
+		compatible = "simple-bus";
+
+		intc: interrupt-controller@b000000 {

As described above, please sort your nodes based on address, node name and lastly label name.

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +10 -0
+			compatible = "qcom,msm-qgic2";
+			interrupt-controller;
+			#interrupt-cells = <0x3>;
+			reg = <0xb000000 0x1000>, <0xb002000 0x1000>;
+		};
+
+		timer {
+			compatible = "arm,armv8-timer";
+			interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 58

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +10 -0
+				     <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
+		};
+
+		timer@b120000 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+			compatible = "arm,armv7-timer-mem";
+			reg = <0xb120000 0x1000>;

Please pad addresses in reg to 8 digits, to make them faster to compare.

Quoted 47 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +47 -0
+			clock-frequency = <19200000>;
+
+			frame@b120000 {
+				frame-number = <0>;
+				interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb121000 0x1000>,
+				      <0xb122000 0x1000>;
+			};
+
+			frame@b123000 {
+				frame-number = <1>;
+				interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb123000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b124000 {
+				frame-number = <2>;
+				interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb124000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b125000 {
+				frame-number = <3>;
+				interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb125000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b126000 {
+				frame-number = <4>;
+				interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb126000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b127000 {
+				frame-number = <5>;
+				interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb127000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b128000 {
+				frame-number = <6>;

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 115

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +10 -0
+				interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb128000 0x1000>;
+				status = "disabled";
+			};
+		};
+
+		gcc: gcc@1800000 {
+			compatible = "qcom,gcc-ipq6018";
+			reg = <0x1800000 0x80000>;
+			#clock-cells = <0x1>;

This is a count, use base 10.

Quoted 9 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +9 -0
+			#reset-cells = <0x1>;
+		};
+
+		blsp1_uart3: serial@78b1000 {
+			compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
+			reg = <0x78b1000 0x200>;
+			interrupts = <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&gcc GCC_BLSP1_UART3_APPS_CLK>,
+				<&gcc GCC_BLSP1_AHB_CLK>;

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 134

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +10 -0
+			clock-names = "core", "iface";
+			status = "disabled";
+		};
+
+		tlmm: pinctrl@1000000 {
+			compatible = "qcom,ipq6018-pinctrl";
+			reg = <0x1000000 0x300000>;
+			interrupts = <GIC_SPI 0xd0 IRQ_TYPE_NONE>;
+			gpio-controller;
+			#gpio-cells = <0x2>;

gpio-ranges = <&tlmm 0 80>;

Quoted 57 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +57 -0
+			interrupt-controller;
+			#interrupt-cells = <0x2>;
+
+			uart_pins: uart_pins {
+				pins = "gpio44", "gpio45";
+				function = "blsp2_uart";
+				drive-strength = <8>;
+				bias-pull-down;
+			};
+		};
+	};
+
+	psci: psci {
+		compatible = "arm,psci-1.0";
+		method = "smc";
+	};
+
+	cpus: cpus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		CPU0: cpu@0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			reg = <0x0>;
+			enable-method = "psci";
+			next-level-cache = <&L2_0>;
+		};
+
+		CPU1: cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			enable-method = "psci";
+			reg = <0x1>;
+			next-level-cache = <&L2_0>;
+		};
+
+		CPU2: cpu@2 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			enable-method = "psci";
+			reg = <0x2>;
+			next-level-cache = <&L2_0>;
+		};
+
+		CPU3: cpu@3 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			enable-method = "psci";
+			reg = <0x3>;
+			next-level-cache = <&L2_0>;
+		};
+
+		L2_0: l2-cache {
+			compatible = "cache";
+			cache-level = <0x2>;
+		};

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 201

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +10 -0
+	};
+
+	pmuv8: pmu {
+		compatible = "arm,armv8-pmuv3";
+		interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) |
+					 IRQ_TYPE_LEVEL_HIGH)>;
+	};
+
+	clocks {
+		sleep_clk: sleep_clk {

Don't use _ in the node names.

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 213

Quoted 12 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +12 -0
+			compatible = "fixed-clock";
+			clock-frequency = <32000>;
+			#clock-cells = <0>;
+		};
+
+		xo: xo {
+			compatible = "fixed-clock";
+			clock-frequency = <24000000>;
+			#clock-cells = <0>;
+		};
+
+		bias_pll_cc_clk {

Please give this a label and reference it from the node that uses it (regardless of the implementation matching by clock name).

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 225

Quoted 12 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +12 -0
+			compatible = "fixed-clock";
+			clock-frequency = <300000000>;
+			#clock-cells = <0>;
+		};
+
+		bias_pll_nss_noc_clk {
+			compatible = "fixed-clock";
+			clock-frequency = <416500000>;
+			#clock-cells = <0>;
+		};
+
+		usb3phy_0_cc_pipe_clk {

This should come from the PHY.

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 229

Quoted 4 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +4 -0
+			compatible = "fixed-clock";
+			clock-frequency = <125000000>;
+			#clock-cells = <0>;
+		};

Regards,
Bjorn

#26 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Hi Bjorn,

Quoted 10 lines · Bjorn Andersson
Quoted 5 lines · Sricharan R

Add initial device tree support for the Qualcomm IPQ6018 SoC and CP01 evaluation board.

Please fix the order of these (or add a Co-developed-by).

ok

Quoted 8 lines
Quoted 8 lines
---
 arch/arm64/boot/dts/qcom/Makefile            |   1 +
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  35 ++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 231 +++++++++++++++++++++++++++
 3 files changed, 267 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi
Quoted 12 lines

arch/arm64/boot/dts/qcom/Makefile line 5

Quoted 9 lines
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 21d548f..ac22dbb 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb

Sort order.

ok

Quoted 17 lines
Quoted 17 lines
arch/arm64/boot/dts/qcom/Makefile +0 -0
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-bullhead-rev-101.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8994-angler-rev-101.dtb
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +8 -0
new file mode 100644
index 0000000..ac7cb22
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IPQ6018 CP01 board device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts line 14

Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +6 -0
+
+#include "ipq6018.dtsi"
+
+/ {
+	#address-cells = <0x2>;
+	#size-cells = <0x2>;

This is a count, write it in base 10..

ok

Quoted 7 lines

arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts line 17

Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +3 -0
+	model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
+	compatible = "qcom,ipq6018-cp01", "qcom,ipq6018";
+	interrupt-parent = <&intc>;

Changing #address-cells, #size-cells and interrupt-parent will break the dtsi, so I think you should specify them there.

ok, will move it to the dtsi.

Quoted 6 lines

arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts line 20

Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +3 -0
+};
+
+&tlmm {

Please sort your nodes based on address, then node name, then label.

ok

Quoted 29 lines
Quoted 29 lines
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts new file +15 -0
+	uart_pins: uart_pins {
+		mux {
+			pins = "gpio44", "gpio45";
+			function = "blsp2_uart";
+			drive-strength = <8>;
+			bias-pull-down;
+		};
+	};
+};
+
+&blsp1_uart3 {
+	pinctrl-0 = <&uart_pins>;
+	pinctrl-names = "default";
+	status = "ok";
+};
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +8 -0
new file mode 100644
index 0000000..79cccdd
@@ -0,0 +1,231 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IPQ6018 SoC device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 13

Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +5 -0
+#include <dt-bindings/clock/qcom,gcc-ipq6018.h>
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ6018";
+	compatible = "qcom,ipq6018";

No need for model and compatible in the dtsi, these should always be specified by the including file.

ok, will move it to the dts.

Quoted 6 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 16

Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +3 -0
+
+	chosen {
+		bootargs = "console=ttyMSM0,115200,n8 rw init=/init";

Do you really need console? Can't you use stdout-path?

ok, will change.

Quoted 2 lines

And there's no need to specify init=/init.

ok.

Quoted 5 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 17

Quoted 1 line
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +1 -0
+		bootargs-append = " swiotlb=1 clk_ignore_unused";

I'm hoping that you will work on removing the need for clk_ignore_unused.

hmm, should not be required even now. will remove that.

Quoted 11 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 25

Quoted 8 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +8 -0
+	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		tz:tz@48500000 {

Space after :

ok.

Quoted 6 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 27

Quoted 2 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +2 -0
+			no-map;
+			reg = <0x0 0x48500000 0x0 0x00200000>;

I would prefer to have the reg first in these nodes, then the region's properties.

ok.

Quoted 6 lines
Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +6 -0
+		};
+	};
+
+	soc: soc {
+		#address-cells = <0x1>;
+		#size-cells = <0x1>;
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 38

Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +5 -0
+		ranges = <0 0 0 0xffffffff>;
+		dma-ranges;
+		compatible = "simple-bus";
+
+		intc: interrupt-controller@b000000 {

As described above, please sort your nodes based on address, node name and lastly label name.

ok.

Quoted 14 lines
Quoted 14 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +14 -0
+			compatible = "qcom,msm-qgic2";
+			interrupt-controller;
+			#interrupt-cells = <0x3>;
+			reg = <0xb000000 0x1000>, <0xb002000 0x1000>;
+		};
+
+		timer {
+			compatible = "arm,armv8-timer";
+			interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+				     <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
+		};
+
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 58

Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +6 -0
+		timer@b120000 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+			compatible = "arm,armv7-timer-mem";
+			reg = <0xb120000 0x1000>;

Please pad addresses in reg to 8 digits, to make them faster to compare.

ok.

Quoted 51 lines
Quoted 51 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +51 -0
+			clock-frequency = <19200000>;
+
+			frame@b120000 {
+				frame-number = <0>;
+				interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb121000 0x1000>,
+				      <0xb122000 0x1000>;
+			};
+
+			frame@b123000 {
+				frame-number = <1>;
+				interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb123000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b124000 {
+				frame-number = <2>;
+				interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb124000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b125000 {
+				frame-number = <3>;
+				interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb125000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b126000 {
+				frame-number = <4>;
+				interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb126000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b127000 {
+				frame-number = <5>;
+				interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb127000 0x1000>;
+				status = "disabled";
+			};
+
+			frame@b128000 {
+				frame-number = <6>;
+				interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
+				reg = <0xb128000 0x1000>;
+				status = "disabled";
+			};
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 115

Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +6 -0
+		};
+
+		gcc: gcc@1800000 {
+			compatible = "qcom,gcc-ipq6018";
+			reg = <0x1800000 0x80000>;
+			#clock-cells = <0x1>;

This is a count, use base 10.

ok.

Quoted 13 lines
Quoted 13 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +13 -0
+			#reset-cells = <0x1>;
+		};
+
+		blsp1_uart3: serial@78b1000 {
+			compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
+			reg = <0x78b1000 0x200>;
+			interrupts = <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&gcc GCC_BLSP1_UART3_APPS_CLK>,
+				<&gcc GCC_BLSP1_AHB_CLK>;
+			clock-names = "core", "iface";
+			status = "disabled";
+		};
+
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 134

Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +6 -0
+		tlmm: pinctrl@1000000 {
+			compatible = "qcom,ipq6018-pinctrl";
+			reg = <0x1000000 0x300000>;
+			interrupts = <GIC_SPI 0xd0 IRQ_TYPE_NONE>;
+			gpio-controller;
+			#gpio-cells = <0x2>;

gpio-ranges = <&tlmm 0 80>;

ok.

Quoted 61 lines
Quoted 61 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +61 -0
+			interrupt-controller;
+			#interrupt-cells = <0x2>;
+
+			uart_pins: uart_pins {
+				pins = "gpio44", "gpio45";
+				function = "blsp2_uart";
+				drive-strength = <8>;
+				bias-pull-down;
+			};
+		};
+	};
+
+	psci: psci {
+		compatible = "arm,psci-1.0";
+		method = "smc";
+	};
+
+	cpus: cpus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		CPU0: cpu@0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			reg = <0x0>;
+			enable-method = "psci";
+			next-level-cache = <&L2_0>;
+		};
+
+		CPU1: cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			enable-method = "psci";
+			reg = <0x1>;
+			next-level-cache = <&L2_0>;
+		};
+
+		CPU2: cpu@2 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			enable-method = "psci";
+			reg = <0x2>;
+			next-level-cache = <&L2_0>;
+		};
+
+		CPU3: cpu@3 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			enable-method = "psci";
+			reg = <0x3>;
+			next-level-cache = <&L2_0>;
+		};
+
+		L2_0: l2-cache {
+			compatible = "cache";
+			cache-level = <0x2>;
+		};
+	};
+
+	pmuv8: pmu {
+		compatible = "arm,armv8-pmuv3";
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 201

Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +6 -0
+		interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) |
+					 IRQ_TYPE_LEVEL_HIGH)>;
+	};
+
+	clocks {
+		sleep_clk: sleep_clk {

Don't use _ in the node names.

ok.

Quoted 7 lines
Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
+			compatible = "fixed-clock";
+			clock-frequency = <32000>;
+			#clock-cells = <0>;
+		};
+
+		xo: xo {
+			compatible = "fixed-clock";
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 213

Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +5 -0
+			clock-frequency = <24000000>;
+			#clock-cells = <0>;
+		};
+
+		bias_pll_cc_clk {

Please give this a label and reference it from the node that uses it (regardless of the implementation matching by clock name).

ok, in that case, so might have to remove these for now, till we add the corresponding users.

Quoted 6 lines
Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +6 -0
+			compatible = "fixed-clock";
+			clock-frequency = <300000000>;
+			#clock-cells = <0>;
+		};
+
+		bias_pll_nss_noc_clk {
Quoted 8 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 225

Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +6 -0
+			compatible = "fixed-clock";
+			clock-frequency = <416500000>;
+			#clock-cells = <0>;
+		};
+
+		usb3phy_0_cc_pipe_clk {

This should come from the PHY.

ok, will remove it here and add it later when adding USB node

Regards,
Sricharan

Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
maintainer
#27 lore raw

Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support

Quoting Sricharan R (2019-06-10 08:45:22)

Quoted 23 lines · Bjorn Andersson
Quoted 13 lines · Sricharan R
Quoted 12 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +7 -0
new file mode 100644
index 0000000..79cccdd
+                    compatible = "fixed-clock";
+                    clock-frequency = <32000>;
+                    #clock-cells = <0>;
+            };
+
+            xo: xo {
+                    compatible = "fixed-clock";
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq6018.dtsi line 213

Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +5 -0
+                    clock-frequency = <24000000>;
+                    #clock-cells = <0>;
+            };
+
+            bias_pll_cc_clk {

Please give this a label and reference it from the node that uses it (regardless of the implementation matching by clock name).

Quoted 2 lines

ok, in that case, so might have to remove these for now, till we add the corresponding users.

Yes, please remove them. They don't look like board clks, instead they're SoC level details that need to be created by some clk driver like GCC.

Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
arch/arm64/boot/dts/qcom/ipq6018.dtsi new file +11 -0
+                    compatible = "fixed-clock";
+                    clock-frequency = <300000000>;
+                    #clock-cells = <0>;
+            };
+
+            bias_pll_nss_noc_clk {
+                    compatible = "fixed-clock";
+                    clock-frequency = <416500000>;
+                    #clock-cells = <0>;
+            };
+
#28 lore raw

PATCH 6/6 arm64: defconfig: Enable qcom ipq6018 clock and pinctrl

In reply to Sricharan R

These configs are required for booting kernel in qcom ipq6018 boards.

---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/configs/defconfig +2 -0
index 4d58351..abf64ee 100644
@@ -373,6 +373,7 @@ CONFIG_PINCTRL_MAX77620=y
 CONFIG_PINCTRL_IMX8MQ=y
 CONFIG_PINCTRL_IMX8QXP=y
 CONFIG_PINCTRL_IPQ8074=y
+CONFIG_PINCTRL_IPQ6018=y
 CONFIG_PINCTRL_MSM8916=y
 CONFIG_PINCTRL_MSM8994=y
 CONFIG_PINCTRL_MSM8996=y
@@ -646,6 +647,7 @@ CONFIG_COMMON_CLK_QCOM=y
 CONFIG_QCOM_CLK_SMD_RPM=y
 CONFIG_QCOM_CLK_RPMH=y
 CONFIG_IPQ_GCC_8074=y
+CONFIG_IPQ_GCC_6018=y
 CONFIG_MSM_GCC_8916=y
 CONFIG_MSM_GCC_8994=y
 CONFIG_MSM_MMCC_8996=y
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v1 6/6
#29 lore raw

Re: [PATCH 6/6] arm64: defconfig: Enable qcom ipq6018 clock and pinctrl

Quoted 4 lines · Sricharan R

These configs are required for booting kernel in qcom ipq6018 boards.

Quoted 27 lines
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/configs/defconfig +2 -0
index 4d58351..abf64ee 100644
@@ -373,6 +373,7 @@ CONFIG_PINCTRL_MAX77620=y
 CONFIG_PINCTRL_IMX8MQ=y
 CONFIG_PINCTRL_IMX8QXP=y
 CONFIG_PINCTRL_IPQ8074=y
+CONFIG_PINCTRL_IPQ6018=y
 CONFIG_PINCTRL_MSM8916=y
 CONFIG_PINCTRL_MSM8994=y
 CONFIG_PINCTRL_MSM8996=y
@@ -646,6 +647,7 @@ CONFIG_COMMON_CLK_QCOM=y
 CONFIG_QCOM_CLK_SMD_RPM=y
 CONFIG_QCOM_CLK_RPMH=y
 CONFIG_IPQ_GCC_8074=y
+CONFIG_IPQ_GCC_6018=y
 CONFIG_MSM_GCC_8916=y
 CONFIG_MSM_GCC_8994=y
 CONFIG_MSM_MMCC_8996=y
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#30 lore raw
In reply to Sricharan R

Sorry, Got [email protected] wrong. Will fix and repost

Regards,
Sricharan

Quoted 34 lines · Sricharan R

The IPQ6018 is Qualcomm’s 802.11ax SoC for Routers, Gateways and Access Points.

This series adds minimal board boot support for ipq6018-cp01 board.

Sricharan R (6):
pinctrl: qcom: Add ipq6018 pinctrl driver
dt-bindings: qcom: Add ipq6018 bindings
clk: qcom: Add DT bindings for ipq6018 gcc clock controller
clk: qcom: Add ipq6018 Global Clock Controller support
arm64: dts: Add ipq6018 SoC and CP01 board support
arm64: defconfig: Enable qcom ipq6018 clock and pinctrl

 Documentation/devicetree/bindings/arm/qcom.yaml    |    2 +
 .../devicetree/bindings/clock/qcom,gcc.txt         |    1 +
 arch/arm64/boot/dts/qcom/Makefile                  |    1 +
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts       |   35 +
 arch/arm64/boot/dts/qcom/ipq6018.dtsi              |  231 +
 arch/arm64/configs/defconfig                       |    2 +
 drivers/clk/qcom/Kconfig                           |    9 +
 drivers/clk/qcom/Makefile                          |    1 +
 drivers/clk/qcom/gcc-ipq6018.c                     | 5267 ++++++++++++++++++++
 drivers/pinctrl/qcom/Kconfig                       |   10 +
 drivers/pinctrl/qcom/Makefile                      |    1 +
 drivers/pinctrl/qcom/pinctrl-ipq6018.c             | 1183 +++++
 include/dt-bindings/clock/qcom,gcc-ipq6018.h       |  405 ++
 13 files changed, 7148 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018.dtsi
 create mode 100644 drivers/clk/qcom/gcc-ipq6018.c
 create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq6018.c
 create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq6018.h
Signature · 1 line
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#31 lore raw
In reply to Sricharan R
Quoted 9 lines · Sricharan R

The IPQ6018 is Qualcomm’s 802.11ax SoC for Routers, Gateways and Access Points.

This series adds minimal board boot support for ipq6018-cp01 board.

Sricharan R (6):
pinctrl: qcom: Add ipq6018 pinctrl driver
dt-bindings: qcom: Add ipq6018 bindings

I'm happy to merge these two if I can get a review from Bjorn Andersson on them.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel