FAILED: patch "[PATCH] ovl: support the FS_IOC_FS[SG]ETXATTR ioctls" failed to apply to 5.1-stable tree

PATCH [email protected] 3 participants 12 messages Jun 9, 2019 – Sep 19, 2019

Subsystems (2)

Stable branch Overlay filesystem

lore

Share & tools

lore

[email protected]

author maintainer

2019-06-09 09:45 UTC #0 lore raw

The patch below does not apply to the 5.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From b21d9c435f935014d3e3fa6914f2e4fbabb0e94d Mon Sep 17 00:00:00 2001
From: Amir Goldstein <[email protected]>
Date: Sun, 26 May 2019 09:28:25 +0300
Subject: [PATCH] ovl: support the FS_IOC_FS[SG]ETXATTR ioctls

They are the extended version of FS_IOC_FS[SG]ETFLAGS ioctls. xfs_io -c "chattr <flags>" uses the new ioctls for setting flags.

This used to work in kernel pre v4.19, before stacked file ops introduced the ovl_ioctl whitelist.

Reported-by Dave Chinner <[email protected]>

Fixes d1d04ef8572b ("ovl: stack file ops")

Cc <[email protected]> # v4.19

Signed-off-by Amir Goldstein <[email protected]>

Signed-off-by Miklos Szeredi <[email protected]>

fs/overlayfs/file.c +6 -3

index 540a8b845145..340a6ad45914 100644
@@ -426,7 +426,8 @@ static unsigned int ovl_get_inode_flags(struct inode *inode)
 	return ovl_iflags;
 }
 
-static long ovl_ioctl_set_flags(struct file *file, unsigned long arg)
+static long ovl_ioctl_set_flags(struct file *file, unsigned int cmd,
+				unsigned long arg)
 {
 	long ret;
 	struct inode *inode = file_inode(file);

@@ -456,7 +457,7 @@ static long ovl_ioctl_set_flags(struct file *file, unsigned long arg)
 	if (ret)
 		goto unlock;
 
-	ret = ovl_real_ioctl(file, FS_IOC_SETFLAGS, arg);
+	ret = ovl_real_ioctl(file, cmd, arg);
 
 	ovl_copyflags(ovl_inode_real(inode), inode);
 unlock:

@@ -474,11 +475,13 @@ static long ovl_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 
 	switch (cmd) {
 	case FS_IOC_GETFLAGS:
+	case FS_IOC_FSGETXATTR:
 		ret = ovl_real_ioctl(file, cmd, arg);
 		break;
 
 	case FS_IOC_SETFLAGS:
-		ret = ovl_ioctl_set_flags(file, arg);
+	case FS_IOC_FSSETXATTR:
+		ret = ovl_ioctl_set_flags(file, cmd, arg);
 		break;
 
 	default:

Amir Goldstein

maintainer

2019-06-13 08:49 UTC #1 lore raw

Quoted 11 lines · On Sun, Jun 9, 2019 at 12:45 PM <[email protected]> wrote:

The patch below does not apply to the 5.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h

FYI, the failure to apply this patch would be resolved after you picked up "ovl: check the capability before cred overridden" for stable, please hold off from taking this patch just yet, because it has a bug, whose fix wasn't picked upstream yet.

Thanks,
Amir.

Amir Goldstein

maintainer

2019-06-21 08:15 UTC #2 lore raw

Quoted 11 lines · Amir Goldstein

Quoted 9 lines · On Sun, Jun 9, 2019 at 12:45 PM <[email protected]> wrote:
The patch below does not apply to the 5.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,

Quoted 8 lines

Quoted 2 lines
greg k-h
FYI, the failure to apply this patch would be resolved after you picked up "ovl: check the capability before cred overridden" for stable, please hold off from taking this patch just yet, because it has a bug, whose fix wasn't picked upstream yet.

Greg,

Please apply these patches to stable 4.19. They fix a docker regression (project quotas feature).

b21d9c435f93 ovl: support the FS_IOC_FS[SG]ETXATTR ioctls 941d935ac763 ovl: fix wrong flags check in FS_IOC_FS[SG]ETXATTR ioctls

They apply cleanly and tested on v4.19.53.

While at it, I also tested that the following patches apply cleanly and solve relevant issues on v4.19.53, but they are not clear stable candidates.

1) /proc/locks shows incorrect ino. Only reported by xfstests (so far):
6dde1e42f497 ovl: make i_ino consistent with st_ino in more cases

2) Fix output of modinfo overlay:
253e74833911 ovl: fix typo in MODULE_PARM_DESC

3) Disallow bogus layer combinations.
syzbot has started to produce repros that create bogus layer combinations. So far it has only been able to reproduce a WARN_ON, which has already been fixed in stable, by acf3062a7e1c ("ovl: relax WARN_ON()..."), but other real bugs could be lurking if those setups are allowed. We decided to detect and error on these setups on mount, to stop syzbot (and attackers) from trying to attack overlayfs this way.
To stop syzbot from mutating this class of repros on stable kernel you MAY apply these 3 patches, but in any case, I would wait a while to see if more bugs are reported on master.
Although this solves a problem dating before 4.19, I have no plans of backporting these patches further back.

146d62e5a586 ovl: detect overlapping layers 9179c21dc6ed ovl: don't fail with disconnected lower NFS 1dac6f5b0ed2 ovl: fix bogus -Wmaybe-unitialized warning

Thanks,
Amir.

Sasha Levin

maintainer

2019-06-23 01:03 UTC #3 lore raw

Quoted 23 lines · Amir Goldstein

Quoted 11 lines · Amir Goldstein
Quoted 9 lines · On Sun, Jun 9, 2019 at 12:45 PM <[email protected]> wrote:
The patch below does not apply to the 5.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
Quoted 8 lines
Quoted 2 lines
greg k-h
FYI, the failure to apply this patch would be resolved after you picked up "ovl: check the capability before cred overridden" for stable, please hold off from taking this patch just yet, because it has a bug, whose fix wasn't picked upstream yet.
Greg,

Quoted 7 lines

Please apply these patches to stable 4.19. They fix a docker regression (project quotas feature).
b21d9c435f93 ovl: support the FS_IOC_FS[SG]ETXATTR ioctls 941d935ac763 ovl: fix wrong flags check in FS_IOC_FS[SG]ETXATTR ioctls
They apply cleanly and tested on v4.19.53.

I've queued these for 4.19.

Quoted 5 lines

While at it, I also tested that the following patches apply cleanly and solve relevant issues on v4.19.53, but they are not clear stable candidates.
1) /proc/locks shows incorrect ino. Only reported by xfstests (so far):
6dde1e42f497 ovl: make i_ino consistent with st_ino in more cases

And this.

Quoted 2 lines

2) Fix output of modinfo overlay:
253e74833911 ovl: fix typo in MODULE_PARM_DESC

But not this one. Maybe we should be including these in stable trees since the risk factor is low and it fixes something user-visible, but our current rules object this this kind of patches so I've left it out.

Quoted 13 lines

3) Disallow bogus layer combinations.
syzbot has started to produce repros that create bogus layer combinations. So far it has only been able to reproduce a WARN_ON, which has already been fixed in stable, by acf3062a7e1c ("ovl: relax WARN_ON()..."), but other real bugs could be lurking if those setups are allowed. We decided to detect and error on these setups on mount, to stop syzbot (and attackers) from trying to attack overlayfs this way.
To stop syzbot from mutating this class of repros on stable kernel you MAY apply these 3 patches, but in any case, I would wait a while to see if more bugs are reported on master.
Although this solves a problem dating before 4.19, I have no plans of backporting these patches further back.

Quoted 3 lines

146d62e5a586 ovl: detect overlapping layers 9179c21dc6ed ovl: don't fail with disconnected lower NFS 1dac6f5b0ed2 ovl: fix bogus -Wmaybe-unitialized warning

I've queued these 3 for 4.19.

Greg KH

author maintainer

2019-06-23 20:29 UTC #4 lore raw

Quoted 62 lines · Sasha Levin

Quoted 23 lines · Amir Goldstein
Quoted 11 lines · Amir Goldstein
Quoted 9 lines · On Sun, Jun 9, 2019 at 12:45 PM <[email protected]> wrote:
The patch below does not apply to the 5.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
Quoted 8 lines
Quoted 2 lines
greg k-h
FYI, the failure to apply this patch would be resolved after you picked up "ovl: check the capability before cred overridden" for stable, please hold off from taking this patch just yet, because it has a bug, whose fix wasn't picked upstream yet.
Greg,
Quoted 7 lines
Please apply these patches to stable 4.19. They fix a docker regression (project quotas feature).
b21d9c435f93 ovl: support the FS_IOC_FS[SG]ETXATTR ioctls 941d935ac763 ovl: fix wrong flags check in FS_IOC_FS[SG]ETXATTR ioctls
They apply cleanly and tested on v4.19.53.
I've queued these for 4.19.
Quoted 5 lines
While at it, I also tested that the following patches apply cleanly and solve relevant issues on v4.19.53, but they are not clear stable candidates.
1) /proc/locks shows incorrect ino. Only reported by xfstests (so far):
6dde1e42f497 ovl: make i_ino consistent with st_ino in more cases
And this.
Quoted 2 lines
2) Fix output of modinfo overlay:
253e74833911 ovl: fix typo in MODULE_PARM_DESC
But not this one. Maybe we should be including these in stable trees since the risk factor is low and it fixes something user-visible, but our current rules object this this kind of patches so I've left it out.
Quoted 13 lines
3) Disallow bogus layer combinations.
syzbot has started to produce repros that create bogus layer combinations. So far it has only been able to reproduce a WARN_ON, which has already been fixed in stable, by acf3062a7e1c ("ovl: relax WARN_ON()..."), but other real bugs could be lurking if those setups are allowed. We decided to detect and error on these setups on mount, to stop syzbot (and attackers) from trying to attack overlayfs this way.
To stop syzbot from mutating this class of repros on stable kernel you MAY apply these 3 patches, but in any case, I would wait a while to see if more bugs are reported on master.
Although this solves a problem dating before 4.19, I have no plans of backporting these patches further back.

Quoted 5 lines

Quoted 3 lines
146d62e5a586 ovl: detect overlapping layers 9179c21dc6ed ovl: don't fail with disconnected lower NFS 1dac6f5b0ed2 ovl: fix bogus -Wmaybe-unitialized warning
I've queued these 3 for 4.19.

What about the ones that are needed for 5.1?

thanks,

greg k-h

Sasha Levin

maintainer

2019-06-24 00:34 UTC #5 lore raw

Quoted 63 lines · Greg KH

Quoted 62 lines · Sasha Levin
Quoted 23 lines · Amir Goldstein
Quoted 11 lines · Amir Goldstein
Quoted 9 lines · On Sun, Jun 9, 2019 at 12:45 PM <[email protected]> wrote:
The patch below does not apply to the 5.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
Quoted 8 lines
Quoted 2 lines
greg k-h
FYI, the failure to apply this patch would be resolved after you picked up "ovl: check the capability before cred overridden" for stable, please hold off from taking this patch just yet, because it has a bug, whose fix wasn't picked upstream yet.
Greg,
Quoted 7 lines
Please apply these patches to stable 4.19. They fix a docker regression (project quotas feature).
b21d9c435f93 ovl: support the FS_IOC_FS[SG]ETXATTR ioctls 941d935ac763 ovl: fix wrong flags check in FS_IOC_FS[SG]ETXATTR ioctls
They apply cleanly and tested on v4.19.53.
I've queued these for 4.19.
Quoted 5 lines
While at it, I also tested that the following patches apply cleanly and solve relevant issues on v4.19.53, but they are not clear stable candidates.
1) /proc/locks shows incorrect ino. Only reported by xfstests (so far):
6dde1e42f497 ovl: make i_ino consistent with st_ino in more cases
And this.
Quoted 2 lines
2) Fix output of modinfo overlay:
253e74833911 ovl: fix typo in MODULE_PARM_DESC
But not this one. Maybe we should be including these in stable trees since the risk factor is low and it fixes something user-visible, but our current rules object this this kind of patches so I've left it out.
Quoted 13 lines
3) Disallow bogus layer combinations.
syzbot has started to produce repros that create bogus layer combinations. So far it has only been able to reproduce a WARN_ON, which has already been fixed in stable, by acf3062a7e1c ("ovl: relax WARN_ON()..."), but other real bugs could be lurking if those setups are allowed. We decided to detect and error on these setups on mount, to stop syzbot (and attackers) from trying to attack overlayfs this way.
To stop syzbot from mutating this class of repros on stable kernel you MAY apply these 3 patches, but in any case, I would wait a while to see if more bugs are reported on master.
Although this solves a problem dating before 4.19, I have no plans of backporting these patches further back.

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
146d62e5a586 ovl: detect overlapping layers 9179c21dc6ed ovl: don't fail with disconnected lower NFS 1dac6f5b0ed2 ovl: fix bogus -Wmaybe-unitialized warning
I've queued these 3 for 4.19.
What about the ones that are needed for 5.1?

Ah yes, I haven't realized that the syzkaller ones are needed for 5.1. I'll queue them up.

Amir Goldstein

maintainer

2019-06-24 04:52 UTC #6 lore raw

Quoted 69 lines · Sasha Levin

Quoted 67 lines · Greg KH
Quoted 66 lines · Sasha Levin
Quoted 23 lines · Amir Goldstein
Quoted 11 lines · Amir Goldstein
Quoted 9 lines · On Sun, Jun 9, 2019 at 12:45 PM <[email protected]> wrote:
The patch below does not apply to the 5.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
Quoted 8 lines
Quoted 2 lines
greg k-h
FYI, the failure to apply this patch would be resolved after you picked up "ovl: check the capability before cred overridden" for stable, please hold off from taking this patch just yet, because it has a bug, whose fix wasn't picked upstream yet.
Greg,
Quoted 7 lines
Please apply these patches to stable 4.19. They fix a docker regression (project quotas feature).
b21d9c435f93 ovl: support the FS_IOC_FS[SG]ETXATTR ioctls 941d935ac763 ovl: fix wrong flags check in FS_IOC_FS[SG]ETXATTR ioctls
They apply cleanly and tested on v4.19.53.
I've queued these for 4.19.
Quoted 5 lines
While at it, I also tested that the following patches apply cleanly and solve relevant issues on v4.19.53, but they are not clear stable candidates.
1) /proc/locks shows incorrect ino. Only reported by xfstests (so far):
6dde1e42f497 ovl: make i_ino consistent with st_ino in more cases
And this.
Quoted 2 lines
2) Fix output of modinfo overlay:
253e74833911 ovl: fix typo in MODULE_PARM_DESC
But not this one. Maybe we should be including these in stable trees since the risk factor is low and it fixes something user-visible, but our current rules object this this kind of patches so I've left it out.
Quoted 16 lines
3) Disallow bogus layer combinations.
syzbot has started to produce repros that create bogus layer combinations. So far it has only been able to reproduce a WARN_ON, which has already been fixed in stable, by acf3062a7e1c ("ovl: relax WARN_ON()..."), but other real bugs could be lurking if those setups are allowed. We decided to detect and error on these setups on mount, to stop syzbot (and attackers) from trying to attack overlayfs this way.
To stop syzbot from mutating this class of repros on stable kernel you MAY apply these 3 patches, but in any case, I would wait a while to see if more bugs are reported on master.
Although this solves a problem dating before 4.19, I have no plans of backporting these patches further back.
146d62e5a586 ovl: detect overlapping layers 9179c21dc6ed ovl: don't fail with disconnected lower NFS 1dac6f5b0ed2 ovl: fix bogus -Wmaybe-unitialized warning

Quoted 7 lines

Quoted 3 lines
Quoted 1 line
I've queued these 3 for 4.19.
What about the ones that are needed for 5.1?
Ah yes, I haven't realized that the syzkaller ones are needed for 5.1. I'll queue them up.

I don't think syzkaller ones are more relevant to 5.1 then the rest of the patches applied to 4.19. If anything, its the other way around. According to syzbot dashboard, it is being run on LTS kernels, not on latest stable.

Please forgive me if my language caused confusion, when I said "please apply to 4.19" I meant 4.19+.

Thanks,
Amir.

Greg KH

author maintainer

2019-07-24 11:57 UTC #7 lore raw

Quoted 78 lines · Amir Goldstein

Quoted 69 lines · Sasha Levin
Quoted 67 lines · Greg KH
Quoted 66 lines · Sasha Levin
Quoted 23 lines · Amir Goldstein
Quoted 11 lines · Amir Goldstein
Quoted 9 lines · On Sun, Jun 9, 2019 at 12:45 PM <[email protected]> wrote:
The patch below does not apply to the 5.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
Quoted 8 lines
Quoted 2 lines
greg k-h
FYI, the failure to apply this patch would be resolved after you picked up "ovl: check the capability before cred overridden" for stable, please hold off from taking this patch just yet, because it has a bug, whose fix wasn't picked upstream yet.
Greg,
Quoted 7 lines
Please apply these patches to stable 4.19. They fix a docker regression (project quotas feature).
b21d9c435f93 ovl: support the FS_IOC_FS[SG]ETXATTR ioctls 941d935ac763 ovl: fix wrong flags check in FS_IOC_FS[SG]ETXATTR ioctls
They apply cleanly and tested on v4.19.53.
I've queued these for 4.19.
Quoted 5 lines
While at it, I also tested that the following patches apply cleanly and solve relevant issues on v4.19.53, but they are not clear stable candidates.
1) /proc/locks shows incorrect ino. Only reported by xfstests (so far):
6dde1e42f497 ovl: make i_ino consistent with st_ino in more cases
And this.
Quoted 2 lines
2) Fix output of modinfo overlay:
253e74833911 ovl: fix typo in MODULE_PARM_DESC
But not this one. Maybe we should be including these in stable trees since the risk factor is low and it fixes something user-visible, but our current rules object this this kind of patches so I've left it out.
Quoted 16 lines
3) Disallow bogus layer combinations.
syzbot has started to produce repros that create bogus layer combinations. So far it has only been able to reproduce a WARN_ON, which has already been fixed in stable, by acf3062a7e1c ("ovl: relax WARN_ON()..."), but other real bugs could be lurking if those setups are allowed. We decided to detect and error on these setups on mount, to stop syzbot (and attackers) from trying to attack overlayfs this way.
To stop syzbot from mutating this class of repros on stable kernel you MAY apply these 3 patches, but in any case, I would wait a while to see if more bugs are reported on master.
Although this solves a problem dating before 4.19, I have no plans of backporting these patches further back.
146d62e5a586 ovl: detect overlapping layers 9179c21dc6ed ovl: don't fail with disconnected lower NFS 1dac6f5b0ed2 ovl: fix bogus -Wmaybe-unitialized warning
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
I've queued these 3 for 4.19.
What about the ones that are needed for 5.1?
Ah yes, I haven't realized that the syzkaller ones are needed for 5.1. I'll queue them up.

Quoted 7 lines

I don't think syzkaller ones are more relevant to 5.1 then the rest of the patches applied to 4.19. If anything, its the other way around. According to syzbot dashboard, it is being run on LTS kernels, not on latest stable.
Please forgive me if my language caused confusion, when I said "please apply to 4.19" I meant 4.19+.

So is anything else needed to be done here, or are we all caught up and everything merged properly?

thanks,

greg k-h

Amir Goldstein

maintainer

2019-07-24 13:46 UTC #8 lore raw

Quoted 11 lines

Quoted 7 lines
I don't think syzkaller ones are more relevant to 5.1 then the rest of the patches applied to 4.19. If anything, its the other way around. According to syzbot dashboard, it is being run on LTS kernels, not on latest stable.
Please forgive me if my language caused confusion, when I said "please apply to 4.19" I meant 4.19+.
So is anything else needed to be done here, or are we all caught up and everything merged properly?

All the needed patches have been merged, but
Upstream commit 146d62e5a5867fbf84490d82455718bfb10fe824 ("ovl: detect overlapping layers") did introduce a regression to docker and friends into stable kernels :-/

The fix commit is already tested and waiting in linux-next:
0be0bfd2de9d ("ovl: fix regression caused by overlapping layers detection") but did not hit upstream yet. When it does, will need to apply it to v4.19+

Thanks,
Amir.

Greg KH

author maintainer

2019-09-19 19:04 UTC #9 lore raw

Quoted 12 lines · Amir Goldstein

Quoted 11 lines
Quoted 7 lines
I don't think syzkaller ones are more relevant to 5.1 then the rest of the patches applied to 4.19. If anything, its the other way around. According to syzbot dashboard, it is being run on LTS kernels, not on latest stable.
Please forgive me if my language caused confusion, when I said "please apply to 4.19" I meant 4.19+.
So is anything else needed to be done here, or are we all caught up and everything merged properly?

Quoted 8 lines

All the needed patches have been merged, but
Upstream commit 146d62e5a5867fbf84490d82455718bfb10fe824 ("ovl: detect overlapping layers") did introduce a regression to docker and friends into stable kernels :-/
The fix commit is already tested and waiting in linux-next:
0be0bfd2de9d ("ovl: fix regression caused by overlapping layers detection") but did not hit upstream yet. When it does, will need to apply it to v4.19+

That is now in Linus's tree and I've queued it up now.

thanks,

greg k-h

Amir Goldstein

maintainer

2019-07-11 14:14 UTC #10 lore raw

overlayfs regression in master and stable trees

In reply to Sasha Levin

Quoted 14 lines

Quoted 14 lines
3) Disallow bogus layer combinations.
syzbot has started to produce repros that create bogus layer combinations. So far it has only been able to reproduce a WARN_ON, which has already been fixed in stable, by acf3062a7e1c ("ovl: relax WARN_ON()..."), but other real bugs could be lurking if those setups are allowed. We decided to detect and error on these setups on mount, to stop syzbot (and attackers) from trying to attack overlayfs this way.
To stop syzbot from mutating this class of repros on stable kernel you MAY apply these 3 patches, but in any case, I would wait a while to see if more bugs are reported on master.
Although this solves a problem dating before 4.19, I have no plans of backporting these patches further back.

Quoted 6 lines

Quoted 3 lines
146d62e5a586 ovl: detect overlapping layers 9179c21dc6ed ovl: don't fail with disconnected lower NFS 1dac6f5b0ed2 ovl: fix bogus -Wmaybe-unitialized warning
I've queued these 3 for 4.19.

FYI, an overlayfs regression has been reported:
https://github.com/containers/libpod/issues/3540

Caused by commit "ovl: detect overlapping layers"

I am working on a fix.
In retrospect, given my lengthy disclaimer above, it seems that this patch should not have been applied to stable (yet). I believe that this patch belongs to a class of fixed that should soak in master for a while before being considered for stable. On my part, I will not propose these sort of fixed in the future, with or without a disclaimer until they have soaked in master.

Thanks,
Amir.

Greg KH

author maintainer

2019-07-11 15:41 UTC #11 lore raw

Re: overlayfs regression in master and stable trees

Quoted 26 lines · Amir Goldstein

Quoted 14 lines
Quoted 14 lines
3) Disallow bogus layer combinations.
syzbot has started to produce repros that create bogus layer combinations. So far it has only been able to reproduce a WARN_ON, which has already been fixed in stable, by acf3062a7e1c ("ovl: relax WARN_ON()..."), but other real bugs could be lurking if those setups are allowed. We decided to detect and error on these setups on mount, to stop syzbot (and attackers) from trying to attack overlayfs this way.
To stop syzbot from mutating this class of repros on stable kernel you MAY apply these 3 patches, but in any case, I would wait a while to see if more bugs are reported on master.
Although this solves a problem dating before 4.19, I have no plans of backporting these patches further back.
Quoted 6 lines
Quoted 3 lines
146d62e5a586 ovl: detect overlapping layers 9179c21dc6ed ovl: don't fail with disconnected lower NFS 1dac6f5b0ed2 ovl: fix bogus -Wmaybe-unitialized warning
I've queued these 3 for 4.19.
FYI, an overlayfs regression has been reported:
https://github.com/containers/libpod/issues/3540
Caused by commit "ovl: detect overlapping layers"

Quoted 7 lines

I am working on a fix.
In retrospect, given my lengthy disclaimer above, it seems that this patch should not have been applied to stable (yet). I believe that this patch belongs to a class of fixed that should soak in master for a while before being considered for stable. On my part, I will not propose these sort of fixed in the future, with or without a disclaimer until they have soaked in master.

That's fair enough, send the git ids to stable@vger when you feel they have "soaked" long enough in the future.

thanks,

greg k-h