Skip to contentSkip to conversation

board: atmel: fix pda variable not being reset

PATCH New Eugen.Hristev at microchip.com 1 participant 2 messages Jun 13, 2019 – Jun 27, 2019 Arm/Microchip (AT91) SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: atmel: fix pda variable not being reset

From: Eugen Hristev <[email protected]>

In case someone detects a PDA and u-boot sets the 'pda' variable, and the user does a saveenv, the pda is set in env, and if the screen is removed, u-boot will still have in the env the 'pda' variable, even if no screen is attached.
In order to fix this, we have to reset the 'pda' variable, such that it's not just set if the screen is detected, but also unset if no screen is detected.

---
 board/atmel/common/board.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
board/atmel/common/board.c +4 -2
index fc300a4..20c3b8c 100644
@@ -29,7 +29,7 @@ void at91_pda_detect(void)
 
 	ret = w1_get_bus(AT91_PDA_EEPROM_DEFAULT_BUS, &bus);
 	if (ret)
-		return;
+		goto pda_detect_err;
 
 	for (device_find_first_child(bus, &dev);
 	     dev;
@@ -41,7 +41,7 @@ void at91_pda_detect(void)
 			ret = w1_eeprom_read_buf(dev, AT91_PDA_EEPROM_ID_OFFSET,
 						 (u8 *)buf, AT91_PDA_EEPROM_ID_LENGTH);
 			if (ret)
-				return;
+				goto pda_detect_err;
 			break;
 		}
 	}
@@ -61,6 +61,8 @@ void at91_pda_detect(void)
 		printf("PDA TM5000 detected\n");
 		break;
 	}
+
+pda_detect_err:
 	env_set("pda", (const char *)buf);
 }
 #else
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 board: atmel: fix pda variable not being reset

Quoted 10 lines · On 13.06.2019 09:22, Eugen Hristev - M18282 wrote:

From: Eugen Hristev <[email protected]>

In case someone detects a PDA and u-boot sets the 'pda' variable, and the user does a saveenv, the pda is set in env, and if the screen is removed, u-boot will still have in the env the 'pda' variable, even if no screen is attached.
In order to fix this, we have to reset the 'pda' variable, such that it's not just set if the screen is detected, but also unset if no screen is detected.

Quoted 2 lines

---

Applied to u-boot-atmel/master