ACPI: PM: Export the function acpi_sleep_state_supported()
Subsystems (6)
Dexuan Cui
maintainerPATCH 1/1 ACPI: PM: Export the function acpi_sleep_state_supported()
In a Linux VM running on Hyper-V, when ACPI S4 is enabled, the balloon driver (drivers/hv/hv_balloon.c) needs to ask the host not to do memory hot-add/remove.
So let's export acpi_sleep_state_supported() for the hv_balloon driver. This might also be useful to the other drivers in the future.
--- drivers/acpi/sleep.c | 3 ++- include/acpi/acpi_bus.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/acpi/sleep.c +2 -1
@@ -79,7 +79,7 @@ static int acpi_sleep_prepare(u32 acpi_state)return 0 ; } -static bool acpi_sleep_state_supported (u8 sleep_state) +bool acpi_sleep_state_supported (u8 sleep_state) {acpi_status status;u8 type_a, type_b;
@@ -89,6 +89,7 @@ static bool acpi_sleep_state_supported(u8 sleep_state) || (acpi_gbl_FADT.sleep_control.address && acpi_gbl_FADT.sleep_status.address)); } +EXPORT_SYMBOL_GPL (acpi_sleep_state_supported);#ifdef CONFIG_ACPI_SLEEP static u32 acpi_target_sleep_state =ACPI_STATE_S0 ;
include/acpi/acpi_bus.h +2 -0
@@ -651,6 +651,8 @@ static inline int acpi_pm_set_bridge_wakeup(struct device *dev, bool enable) }#endif +bool acpi_sleep_state_supported (u8 sleep_state); +#ifdef CONFIG_ACPI_SLEEP u32 acpi_target_system_state (void );#else
Signature · 1 line
2.19.1
From: Dexuan Cui <[email protected]> Sent: Friday, June 14, 2019 11:19 AM
Quoted 48 lines
In a Linux VM running on Hyper-V, when ACPI S4 is enabled, the balloon driver (
drivers/hv/hv_balloon.c) needs to ask the host not to do memory hot-add/remove.So let's export
acpi_sleep_state_supported()for thehv_balloondriver. This might also be useful to the other drivers in the future.Signed-off-by Dexuan Cui <[email protected]>--- drivers/acpi/sleep.c | 3 ++- include/acpi/acpi_bus.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-)drivers/acpi/sleep.c +2
-1@@ -79,7 +79,7 @@ static int acpi_sleep_prepare(u32 acpi_state)return 0 ; } -static bool acpi_sleep_state_supported (u8 sleep_state) +bool acpi_sleep_state_supported (u8 sleep_state) {acpi_status status;u8 type_a, type_b;@@ -89,6 +89,7 @@ static bool acpi_sleep_state_supported(u8 sleep_state) || (acpi_gbl_FADT.sleep_control.address && acpi_gbl_FADT.sleep_status.address)); } +EXPORT_SYMBOL_GPL (acpi_sleep_state_supported);#ifdef CONFIG_ACPI_SLEEP static u32 acpi_target_sleep_state =ACPI_STATE_S0 ;include/acpi/acpi_bus.h +2
-0@@ -651,6 +651,8 @@ static inline int acpi_pm_set_bridge_wakeup(struct device *dev, bool enable) }#endif +bool acpi_sleep_state_supported (u8 sleep_state); +#ifdef CONFIG_ACPI_SLEEP u32 acpi_target_system_state (void );
Quoted 3 lines
#else
--
2.19.1
It seems that sleep.c isn't built when on the ARM64 architecture. Using acpi_sleep_state_supported() directly in hv_balloon.c will be problematic since hv_balloon.c needs to be architecture independent when the Hyper-V ARM64 support is added. If that doesn't change, a per-architecture wrapper will be needed to give hv_balloon.c the correct information. This may affect whether acpi_sleep_state_supported() needs to be exported vs.
just removing the "static". I'm not sure what the best approach is.
Michael
Dexuan Cui
maintainerQuoted 78 lines
-----Original Message-----
From: Michael Kelley <[email protected]>
Sent: Friday, June 14, 2019 1:48 PM
To: Dexuan Cui <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]; KY Srinivasan <[email protected]>; Stephen Hemminger <[email protected]>; Haiyang Zhang <[email protected]>; Sasha Levin <[email protected]>; [email protected]; [email protected]; [email protected]; vkuznets <[email protected]>; [email protected]
Subject: RE: [PATCH] ACPI: PM: Export the functionacpi_sleep_state_supported()From: Dexuan Cui <[email protected]> Sent: Friday, June 14, 2019 11:19 AM
include/acpi/acpi_bus.h static inline int acpi_pm_set_bridge_wakeup(struct
Quoted 40 lines
In a Linux VM running on Hyper-V, when ACPI S4 is enabled, the balloon driver (
drivers/hv/hv_balloon.c) needs to ask the host not to do memory hot-add/remove.So let's export
acpi_sleep_state_supported()for thehv_balloondriver. This might also be useful to the other drivers in the future.Signed-off-by Dexuan Cui <[email protected]>--- drivers/acpi/sleep.c | 3 ++- include/acpi/acpi_bus.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-)drivers/acpi/sleep.c +2
-1@@ -79,7 +79,7 @@ static int acpi_sleep_prepare(u32 acpi_state)return 0 ; } -static bool acpi_sleep_state_supported (u8 sleep_state) +bool acpi_sleep_state_supported (u8 sleep_state) {acpi_status status;u8 type_a, type_b;@@ -89,6 +89,7 @@ static bool acpi_sleep_state_supported(u8 sleep_state) || (acpi_gbl_FADT.sleep_control.address && acpi_gbl_FADT.sleep_status.address)); } +EXPORT_SYMBOL_GPL (acpi_sleep_state_supported);#ifdef CONFIG_ACPI_SLEEP static u32 acpi_target_sleep_state =ACPI_STATE_S0 ;include/acpi/acpi_bus.h +0
-0@@ -651,6 +651,8 @@ static inline int acpi_pm_set_bridge_wakeup(structdevice *dev,
Quoted 11 lines
include/acpi/acpi_bus.h +2
-0bool enable) }#endif +bool acpi_sleep_state_supported (u8 sleep_state); +#ifdef CONFIG_ACPI_SLEEP u32 acpi_target_system_state (void );#else
--
2.19.1It seems that
sleep.cisn't built when on the ARM64 architecture. Usingacpi_sleep_state_supported()directly inhv_balloon.cwill be problematic sincehv_balloon.cneeds to be architecture independent when the Hyper-V ARM64 support is added. If that doesn't change, a per-architecture wrapper will be needed to givehv_balloon.cthe correct information. This may affect whetheracpi_sleep_state_supported()needs to be exported vs.
just removing the "static". I'm not sure what the best approach is.
Quoted 1 line
Michael
+ some ARM experts who worked on arch/arm/kernel/hibernate.c.
drivers/acpi/sleep.c is only built if ACPI_SYSTEM_POWER_STATES_SUPPORT is defined, but it looks this option is not defined on ARM.
It looks ARM does not support the ACPI S4 state, then how do we know if an ARM host supports hibernation or not?
Thanks,
-- Dexuan
Hi,
Quoted 25 lines · Dexuan Cui
Quoted 23 lines
-----Original Message-----
From: Michael Kelley <[email protected]>
Sent: Friday, June 14, 2019 1:48 PM
To: Dexuan Cui <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]; KY Srinivasan <[email protected]>; Stephen Hemminger <[email protected]>; Haiyang Zhang <[email protected]>; Sasha Levin <[email protected]>; [email protected]; [email protected]; [email protected]; vkuznets <[email protected]>; [email protected]
Subject: RE: [PATCH] ACPI: PM: Export the functionacpi_sleep_state_supported()It seems that
sleep.cisn't built when on the ARM64 architecture. Usingacpi_sleep_state_supported()directly inhv_balloon.cwill be problematic sincehv_balloon.cneeds to be architecture independent when the Hyper-V ARM64 support is added. If that doesn't change, a per-architecture wrapper will be needed to givehv_balloon.cthe correct information. This may affect whetheracpi_sleep_state_supported()needs to be exported vs.
just removing the "static". I'm not sure what the best approach is.Quoted 1 line
Michael
Quoted 7 lines
+ some ARM experts who worked on
arch/arm/kernel/hibernate.c.
drivers/acpi/sleep.cis only built ifACPI_SYSTEM_POWER_STATES_SUPPORTis defined, but it looks this option is not defined on ARM.It looks ARM does not support the ACPI S4 state, then how do we know if an ARM host supports hibernation or not?
Don't forget that Linux does not support ACPI on 32-bit ARM, which is quite different from the situation on 64-bit ARM.
arch/arm/kernel/hibernate.c is only for 32-bit ARM, and is written with the assumption that there is no interaction required with any firmware to save state, and later restore state upon resuming.
Or am I missing something?
Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
Dexuan Cui
maintainerQuoted 6 lines
From: [email protected] <[email protected]> On Behalf Of Russell King
Quoted 2 lines · Dexuan Cui
It looks ARM does not support the ACPI S4 state, then how do we know if an ARM host supports hibernation or not?
Quoted 8 lines
Don't forget that Linux does not support ACPI on 32-bit ARM, which is quite different from the situation on 64-bit ARM.
arch/arm/kernel/hibernate.cis only for 32-bit ARM, and is written with the assumption that there is no interaction required with any firmware to save state, and later restore state upon resuming.Or am I missing something?
Hi Russell,
Thanks for your reply and please excuse me for my ignorance of ARM.
So 32-bit ARM Linux can hibernate even if it doesn't support ACPI, but I guess not all 32-bit ARM machines support hibernation? If my guess is correct, is there any standard capability bit or something that can be used to tell if an ARM machine supports hibernation? I'm purely curious. :-)
Do you imply 64-bit ARM Linux supports ACPI and the ACPI S4 state? If not, how can we tell if a 64-bit ARM machine supports hibernation or not?
Thanks,
-- Dexuan
Hi!
Quoted 20 lines
Quoted 18 lines
Quoted 8 lines
In a Linux VM running on Hyper-V, when ACPI S4 is enabled, the balloon driver (
drivers/hv/hv_balloon.c) needs to ask the host not to do memory hot-add/remove.So let's export
acpi_sleep_state_supported()for thehv_balloondriver. This might also be useful to the other drivers in the future.Signed-off-by Dexuan Cui <[email protected]>It seems that
sleep.cisn't built when on the ARM64 architecture. Usingacpi_sleep_state_supported()directly inhv_balloon.cwill be problematic sincehv_balloon.cneeds to be architecture independent when the Hyper-V ARM64 support is added. If that doesn't change, a per-architecture wrapper will be needed to givehv_balloon.cthe correct information. This may affect whetheracpi_sleep_state_supported()needs to be exported vs.
just removing the "static". I'm not sure what the best approach is.Quoted 1 line
Michael
Quoted 7 lines
+ some ARM experts who worked on
arch/arm/kernel/hibernate.c.
drivers/acpi/sleep.cis only built ifACPI_SYSTEM_POWER_STATES_SUPPORTis defined, but it looks this option is not defined on ARM.It looks ARM does not support the ACPI S4 state, then how do we know if an ARM host supports hibernation or not?
You should be able to do hibernation without ACPI S4 support. All you need is ability to powerdown...
It is well possible that noone tested hibernation on ARM.. people usually do suspend-to-ram there.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 11 lines
Quoted 10 lines
It seems that
sleep.cisn't built when on the ARM64 architecture. Usingacpi_sleep_state_supported()directly inhv_balloon.cwill be problematic sincehv_balloon.cneeds to be architecture independent when the Hyper-V ARM64 support is added. If that doesn't change, a per-architecture wrapper will be needed to givehv_balloon.cthe correct information. This may affect whetheracpi_sleep_state_supported()needs to be exported vs.
just removing the "static". I'm not sure what the best approach is.Michael
Quoted 7 lines
+ some ARM experts who worked on
arch/arm/kernel/hibernate.c.
drivers/acpi/sleep.cis only built ifACPI_SYSTEM_POWER_STATES_SUPPORTis defined, but it looks this option is not defined on ARM.It looks ARM does not support the ACPI S4 state, then how do we know if an ARM host supports hibernation or not?
But actually... I remember ELCE talk about hibernation or ARM32. Not sure if patches are mainline, but someone was working on that.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 80 lines · Dexuan Cui
Quoted 78 lines
-----Original Message-----
From: Michael Kelley <[email protected]>
Sent: Friday, June 14, 2019 1:48 PM
To: Dexuan Cui <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]; KY Srinivasan <[email protected]>; Stephen Hemminger <[email protected]>; Haiyang Zhang <[email protected]>; Sasha Levin <[email protected]>; [email protected]; [email protected]; [email protected]; vkuznets <[email protected]>; [email protected]
Subject: RE: [PATCH] ACPI: PM: Export the functionacpi_sleep_state_supported()From: Dexuan Cui <[email protected]> Sent: Friday, June 14, 2019 11:19 AM
include/acpi/acpi_bus.h static inline int acpi_pm_set_bridge_wakeup(struct
Quoted 40 lines
In a Linux VM running on Hyper-V, when ACPI S4 is enabled, the balloon driver (
drivers/hv/hv_balloon.c) needs to ask the host not to do memory hot-add/remove.So let's export
acpi_sleep_state_supported()for thehv_balloondriver. This might also be useful to the other drivers in the future.Signed-off-by Dexuan Cui <[email protected]>--- drivers/acpi/sleep.c | 3 ++- include/acpi/acpi_bus.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-)drivers/acpi/sleep.c +2
-1@@ -79,7 +79,7 @@ static int acpi_sleep_prepare(u32 acpi_state)return 0 ; } -static bool acpi_sleep_state_supported (u8 sleep_state) +bool acpi_sleep_state_supported (u8 sleep_state) {acpi_status status;u8 type_a, type_b;@@ -89,6 +89,7 @@ static bool acpi_sleep_state_supported(u8 sleep_state) || (acpi_gbl_FADT.sleep_control.address && acpi_gbl_FADT.sleep_status.address)); } +EXPORT_SYMBOL_GPL (acpi_sleep_state_supported);#ifdef CONFIG_ACPI_SLEEP static u32 acpi_target_sleep_state =ACPI_STATE_S0 ;include/acpi/acpi_bus.h +0
-0@@ -651,6 +651,8 @@ static inline int acpi_pm_set_bridge_wakeup(structdevice *dev,
Quoted 11 lines
include/acpi/acpi_bus.h +2
-0bool enable) }#endif +bool acpi_sleep_state_supported (u8 sleep_state); +#ifdef CONFIG_ACPI_SLEEP u32 acpi_target_system_state (void );#else
--
2.19.1It seems that
sleep.cisn't built when on the ARM64 architecture. Usingacpi_sleep_state_supported()directly inhv_balloon.cwill be problematic sincehv_balloon.cneeds to be architecture independent when the Hyper-V ARM64 support is added. If that doesn't change, a per-architecture wrapper will be needed to givehv_balloon.cthe correct information. This may affect whetheracpi_sleep_state_supported()needs to be exported vs.
just removing the "static". I'm not sure what the best approach is.Quoted 1 line
Michael
Quoted 7 lines
+ some ARM experts who worked on
arch/arm/kernel/hibernate.c.
drivers/acpi/sleep.cis only built ifACPI_SYSTEM_POWER_STATES_SUPPORTis defined, but it looks this option is not defined on ARM.It looks ARM does not support the ACPI S4 state, then how do we know if an ARM host supports hibernation or not?
Maybe we should start from understanding why you need to know whether Hibernate is possible to answer your question ?
On ARM64 platforms system states are entered through PSCI firmware interface that works for ACPI and device tree alike.
Lorenzo
Dexuan Cui
maintainerQuoted 12 lines
From: [email protected] <[email protected]> On Behalf Of Lorenzo Pieralisi
Sent: Monday, June 17, 2019 9:15 AMQuoted 8 lines
...
+ some ARM experts who worked onarch/arm/kernel/hibernate.c.
drivers/acpi/sleep.cis only built ifACPI_SYSTEM_POWER_STATES_SUPPORTis defined, but it looks this option is not defined on ARM.It looks ARM does not support the ACPI S4 state, then how do we know if an ARM host supports hibernation or not?
Quoted 7 lines
Maybe we should start from understanding why you need to know whether Hibernate is possible to answer your question ?
On ARM64 platforms system states are entered through PSCI firmware interface that works for ACPI and device tree alike.
Lorenzo
Hi Lorenzo,
It looks I may have confused you as I didn't realize the word "ARM" only means 32-bit ARM. It looks the "ARM" arch and the "ARM64" arch are very different.
As far as I know, Hyper-V only supports x86 and "ARM64", and it's unlikely to support 32-bit ARM in the future, so actually I don't really need to know if and how a 32-bit ARM machine supports hibernation.
When a Linux guest runs on Hyper-V (x86_32, x86_64, or ARM64) , we have a front-end balloon driver in the guest, which balloons up/down and hot adds/removes the guest's memory when the host requests that. The problem
is: the back-end driver on the host can not really save and restore the states related to the front-end balloon driver on guest hibernation, so we made the decision that balloon up/down and hot-add/remove are not supported when we enable hibernation for a guest; BTW, we still want to load the front-end driver in the guest, because the dirver has a functionality of reporting the guest's memory pressure to the host, which we think is useful.
On x86_32 and x86_64, we enable hibernation for a guest by enabling the virtual ACPI S4 state for the guest; on ARM64, so far we don't have the host side changes required to support guest hibernation, so the details are still unclear.
After I discussed with Michael Kelley, it looks we don't really need to export drivers/acpi/sleep.c: acpi_sleep_state_supported(), but I think we do need to make it non-static.
Now I propose the below changes. I plan to submit a patch first for the changes made to drivers/acpi/sleep.c and include/acpi/acpi_bus.h in a few days, if there is no objection.
Please let me know how you think of this. Thanks!
drivers/acpi/sleep.c +1 -1
@@ -79,7 +79,7 @@ static int acpi_sleep_prepare(u32 acpi_state)return 0 ; } -static bool acpi_sleep_state_supported (u8 sleep_state) +bool acpi_sleep_state_supported (u8 sleep_state) {acpi_status status;u8 type_a, type_b;
include/acpi/acpi_bus.h +6 -0
@@ -651,6 +651,12 @@ static inline int acpi_pm_set_bridge_wakeup(struct device *dev, bool enable) }#endif +#ifdef CONFIG_ACPI_SYSTEM_POWER_STATES_SUPPORT +bool acpi_sleep_state_supported (u8 sleep_state); +#else +bool acpi_sleep_state_supported (u8 sleep_state) {return false; } +#endif +#ifdef CONFIG_ACPI_SLEEP u32 acpi_target_system_state (void );#else
arch/x86/hyperv/hv_init.c +7 -0
@@ -17,6 +17,7 @@* */ +#include <linux/acpi.h> #include <linux/efi.h> #include <linux/types.h> #include <asm/apic.h>
@@ -420,3 +421,9 @@ bool hv_is_hyperv_initialized(void)return hypercall_msr.enable; }EXPORT_SYMBOL_GPL (hv_is_hyperv_initialized); + +bool hv_is_hibernation_supported (void ) +{ +return acpi_sleep_state_supported (ACPI_STATE_S4 ); +} +EXPORT_SYMBOL_GPL (hv_is_hibernation_supported);
include/asm-generic/mshyperv.h +2 -0
@@ -166,9 +166,11 @@ static inline int cpumask_to_vpset(struct hv_vpset *vpset,void hyperv_report_panic (struct pt_regs *regs,long err);void hyperv_report_panic_msg (phys_addr_t pa,size_t size);bool hv_is_hyperv_initialized (void ); +bool hv_is_hibernation_supported (void );void hyperv_cleanup (void );#else /* CONFIG_HYPERV */ static inline bool hv_is_hyperv_initialized (void ) {return false; } +static inline bool hv_is_hibernation_supported (void ) {return false; }static inline void hyperv_cleanup (void ) {}#endif /* CONFIG_HYPERV */
drivers/hv/hv_balloon.c +5 -0
@@ -34,6 +34,8 @@#include <linux/hyperv.h> +#include <asm/mshyperv.h> +#define CREATE_TRACE_POINTS #include "hv_trace_balloon.h"
@@ -1682,6 +1684,9 @@ static int balloon_probe(struct hv_device *dev, {int ret; +if (hv_is_hibernation_supported ()) + hot_add = false; +#ifdef CONFIG_MEMORY_HOTPLUG do_hot_add = hot_add;#else
Thanks,
-- Dexuan
Quoted 47 lines
Quoted 12 lines
From: [email protected] <[email protected]> On Behalf Of Lorenzo Pieralisi
Sent: Monday, June 17, 2019 9:15 AMQuoted 8 lines
...
+ some ARM experts who worked onarch/arm/kernel/hibernate.c.
drivers/acpi/sleep.cis only built ifACPI_SYSTEM_POWER_STATES_SUPPORTis defined, but it looks this option is not defined on ARM.It looks ARM does not support the ACPI S4 state, then how do we know if an ARM host supports hibernation or not?
Quoted 7 lines
Maybe we should start from understanding why you need to know whether Hibernate is possible to answer your question ?
On ARM64 platforms system states are entered through PSCI firmware interface that works for ACPI and device tree alike.
Lorenzo
Hi Lorenzo,
It looks I may have confused you as I didn't realize the word "ARM" only means 32-bit ARM. It looks the "ARM" arch and the "ARM64" arch are very different.As far as I know, Hyper-V only supports x86 and "ARM64", and it's unlikely to support 32-bit ARM in the future, so actually I don't really need to know if and how a 32-bit ARM machine supports hibernation.
When a Linux guest runs on Hyper-V (
x86_32,x86_64, or ARM64) , we have a front-end balloon driver in the guest, which balloons up/down and hot adds/removes the guest's memory when the host requests that. The problem
is: the back-end driver on the host can not really save and restore the states related to the front-end balloon driver on guest hibernation, so we made the decision that balloon up/down and hot-add/remove are not supported when we enable hibernation for a guest; BTW, we still want to load the front-end driver in the guest, because the dirver has a functionality of reporting the guest's memory pressure to the host, which we think is useful.On
x86_32andx86_64, we enable hibernation for a guest by enabling the virtual ACPI S4 state for the guest; on ARM64, so far we don't have the host side changes required to support guest hibernation, so the details are still unclear.After I discussed with Michael Kelley, it looks we don't really need to export
drivers/acpi/sleep.c:acpi_sleep_state_supported(), but I think we do need to make it non-static.
Quoted 5 lines
Now I propose the below changes. I plan to submit a patch first for the changes made to
drivers/acpi/sleep.candinclude/acpi/acpi_bus.hin a few days, if there is no objection.Please let me know how you think of this. Thanks!
No.
Hibernation should be always supported, no matter what firmware. If it can powerdown, it can hibernate.
That is for x86-32/64, too.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Dexuan Cui
maintainerQuoted 28 lines
From: [email protected]
Quoted 21 lines
...
When a Linux guest runs on Hyper-V (x86_32,x86_64, or ARM64) , we have a front-end balloon driver in the guest, which balloons up/down and hot adds/removes the guest's memory when the host requests that. The problem
is: the back-end driver on the host can not really save and restore the states related to the front-end balloon driver on guest hibernation, so we made the decision that balloon up/down and hot-add/remove are not supported when we enable hibernation for a guest; BTW, we still want to load the front-end driver in the guest, because the driver has a functionality of reporting the guest's memory pressure to the host, which we think is useful.On
x86_32andx86_64, we enable hibernation for a guest by enabling the virtual ACPI S4 state for the guest; on ARM64, so far we don't have the host side changes required to support guest hibernation, so the details are still unclear.After I discussed with Michael Kelley, it looks we don't really need to export
drivers/acpi/sleep.c:acpi_sleep_state_supported(), but I think we do need to make it non-static.Quoted 5 lines
Now I propose the below changes. I plan to submit a patch first for the changes made to
drivers/acpi/sleep.candinclude/acpi/acpi_bus.hin a few days, if there is no objection.Please let me know how you think of this. Thanks!
Quoted 7 lines
No.
Hibernation should be always supported, no matter what firmware. If it can powerdown, it can hibernate.
That is for x86-32/64, too.
Pavel
Hi Pavel,
Yes, I totally agree hibernation should be always supported, as long as the system can power down. This is also true for Linux guest running on Hyper-V, when the pava-virtualized drivers are not loaded in the guest
However, unluckily the situation is a little different when the pava-virtualized drivers are loaded in the guest:
1) Old Hyper-V hosts are unable to support guest hibernation and these hosts don't support the virtual ACPI S4 state.
2) The recent Hyper-V host is able to support guest hibernation, but when guest hibernation is used, the guest needs to disable some features in the guest balloon driver, as I explained in the previous mail; on the other hand, we also want to keep the ability to enable the features, so the Hyper-V guys decided to use the absence of the virtual ACPI S4 state to signify the ability of enabling the features, and there is a host command tool which can enable or disable the virtual ACPI S4 state for a guest.
In summary:
1) On old Hyper-V hosts or a recent host, the virtual ACPI S4 state is unsupported or disabled, respectively, and we don't allow Linux guest hibernation so we can use the full features of the guest balloon driver.
2) On a recent host, after we use the host command tool to enable the virtual ACPI S4 state, we allow Linux guest hibernation and we only use a subset of the full features of the guest balloon driver.
This is why I need to know if the virtual ACPI S4 state is supported-and-enabled.
Exporting acpi_sleep_state_supported() may be overkill, and now making it non-static seems the only way to help me out. IMO the function is unlikely to change in the future, and it should be stable enough to become non-static.
Looking forward to your insights!
Thanks,
-- Dexuan