Skip to contentSkip to conversation

i2c: at91: filters support for at91 SoCs

PATCH Superseded [email protected] 4 participants 20 messages Jun 25, 2019 – Jun 27, 2019

Subsystems (4)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v2 cover i2c: at91: filters support for at91 SoCs

From: Eugen Hristev <[email protected]>

This series adds the support for i2c filters: analog and digital filter

digital filter is available for sama5d4
an advanced digital filter that allows threshold configuration is available for sama5d2 and sam9x60
analog filtering is available for sama5d2 and sam9x60

This series also adds platform data for sam9x60 to the driver

In this series version, the enablement of the filters is via Device tree, as requested by Alexandre Belloni. The PCB/board specific noise is hardware dependent.

The platform data properties keep the same pattern : set for each SoC true/false value as it is done for previous properties.

Changes in v2:
- added device tree bindings and support for enable-ana-filt and enable-dig-filt
- added the new properties to the DT for sama5d4_xplained/sama5d2_xplained

Eugen Hristev (9):
dt-bindings: i2c: at91: add new compatible
i2c: at91: add new platform support for sam9x60
dt-bindings: i2c: at91: add binding for enable-dig-filtr
i2c: at91: add support for digital filtering
i2c: at91: add support for advanced digital filtering
dt-bindings: i2c: at91: add binding for enable-ana-filt
i2c: at91: add support for analog filtering
ARM: dts: at91: sama5d2_xplained: add analogic and digital filter for

    i2c

ARM: dts: at91: sama5d4_xplained: add analogic filter for i2c

 Documentation/devicetree/bindings/i2c/i2c-at91.txt | 11 ++++++-
 arch/arm/boot/dts/at91-sama5d2_xplained.dts        |  4 +++
 arch/arm/boot/dts/at91-sama5d4_xplained.dts        |  1 +
 drivers/i2c/busses/i2c-at91-core.c                 | 38 ++++++++++++++++++++++
 drivers/i2c/busses/i2c-at91-master.c               | 24 ++++++++++++++
 drivers/i2c/busses/i2c-at91.h                      | 12 +++++++
 6 files changed, 89 insertions(+), 1 deletion(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/9 dt-bindings: i2c: at91: add new compatible

From: Eugen Hristev <[email protected]>

Add compatible for new Microchip SoC, sam9x60

---
 Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/i2c/i2c-at91.txt +2 -1
index b7cec17..2210f43 100644
@@ -3,7 +3,8 @@ I2C for Atmel platforms
 Required properties :
 - compatible : Must be "atmel,at91rm9200-i2c", "atmel,at91sam9261-i2c",
      "atmel,at91sam9260-i2c", "atmel,at91sam9g20-i2c", "atmel,at91sam9g10-i2c",
-     "atmel,at91sam9x5-i2c", "atmel,sama5d4-i2c" or "atmel,sama5d2-i2c"
+     "atmel,at91sam9x5-i2c", "atmel,sama5d4-i2c", "atmel,sama5d2-i2c" or
+     "microchip,sam9x60-i2c"
 - reg: physical base address of the controller and length of memory mapped
      region.
 - interrupts: interrupt number to the cpu.
Signature · 1 line
2.7.4
#2 lore raw

PATCH v2 2/9 i2c: at91: add new platform support for sam9x60

In reply to [email protected]

From: Eugen Hristev <[email protected]>

Add new platform data support for the sam9x60 SoC

---
 drivers/i2c/busses/i2c-at91-core.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/i2c/busses/i2c-at91-core.c +11 -0
index 8d55cdd..a663a7a 100644
@@ -148,6 +148,14 @@ static struct at91_twi_pdata sama5d2_config = {
 	.has_hold_field = true,
 };
 
+static struct at91_twi_pdata sam9x60_config = {
+	.clk_max_div = 7,
+	.clk_offset = 4,
+	.has_unre_flag = true,
+	.has_alt_cmd = true,
+	.has_hold_field = true,
+};
+
 static const struct of_device_id atmel_twi_dt_ids[] = {
 	{
 		.compatible = "atmel,at91rm9200-i2c",
@@ -174,6 +182,9 @@ static const struct of_device_id atmel_twi_dt_ids[] = {
 		.compatible = "atmel,sama5d2-i2c",
 		.data = &sama5d2_config,
 	}, {
+		.compatible = "microchip,sam9x60-i2c",
+		.data = &sam9x60_config,
+	}, {
 		/* sentinel */
 	}
 };
Signature · 1 line
2.7.4
#3 lore raw

PATCH v2 3/9 dt-bindings: i2c: at91: add binding for enable-dig-filtr

In reply to [email protected]

From: Eugen Hristev <[email protected]>

Add binding specificatoin for digital filter inside the i2c controller

---
 Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/i2c/i2c-at91.txt +4 -0
index 2210f43..8268595 100644
@@ -20,6 +20,9 @@ Optional properties:
   capable I2C controllers.
 - i2c-sda-hold-time-ns: TWD hold time, only available for "atmel,sama5d4-i2c"
   and "atmel,sama5d2-i2c".
+- enable-dig-filt: Enable the built-in digital filter on the i2c lines,
+  specifically required depending on the hardware PCB/board and if the
+  version of the controller includes it.
 - Child nodes conforming to i2c bus binding
 
 Examples :
@@ -56,6 +59,7 @@ i2c0: i2c@f8034600 {
 	clocks = <&flx0>;
 	atmel,fifo-size = <16>;
 	i2c-sda-hold-time-ns = <336>;
+	enable-dig-filt;
 
 	wm8731: wm8731@1a {
 		compatible = "wm8731";
Signature · 1 line
2.7.4
#4 lore raw

Re: [PATCH v2 3/9] dt-bindings: i2c: at91: add binding for enable-dig-filtr

Quoted 24 lines · On 2019-06-25 10:04, [email protected] wrote:

From: Eugen Hristev <[email protected]>

Add binding specificatoin for digital filter inside the i2c controller

---
 Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/i2c/i2c-at91.txt +3 -0
index 2210f43..8268595 100644
@@ -20,6 +20,9 @@ Optional properties:
   capable I2C controllers.
 - i2c-sda-hold-time-ns: TWD hold time, only available for "atmel,sama5d4-i2c"
   and "atmel,sama5d2-i2c".
+- enable-dig-filt: Enable the built-in digital filter on the i2c lines,
+  specifically required depending on the hardware PCB/board and if the
+  version of the controller includes it.
 - Child nodes conforming to i2c bus binding
 
 Examples :

Documentation/devicetree/bindings/i2c/i2c-at91.txt i2c0: i2c@f8034600 { · line 62

Quoted 4 lines
Documentation/devicetree/bindings/i2c/i2c-at91.txt +1 -0
@@ -56,6 +59,7 @@ i2c0: i2c@f8034600 {
 	clocks = <&flx0>;
 	atmel,fifo-size = <16>;
 	i2c-sda-hold-time-ns = <336>;
+	enable-dig-filt;

This spelling does not match the spelling in the subject. But please see my comment on patch 6/9...

Cheers,
Peter

Quoted 4 lines
Documentation/devicetree/bindings/i2c/i2c-at91.txt +0 -0
 	wm8731: wm8731@1a {
 		compatible = "wm8731";
 
#5 lore raw

PATCH v2 4/9 i2c: at91: add support for digital filtering

In reply to [email protected]

From: Eugen Hristev <[email protected]>

Add new platform data support for digital filtering for i2c. The sama5d4, sama5d2 and sam9x60 support this feature.

---
 drivers/i2c/busses/i2c-at91-core.c   | 9 +++++++++
 drivers/i2c/busses/i2c-at91-master.c | 9 +++++++++
 drivers/i2c/busses/i2c-at91.h        | 5 +++++
 3 files changed, 23 insertions(+)
drivers/i2c/busses/i2c-at91-core.c +9 -0
index a663a7a..62610af 100644
@@ -68,6 +68,7 @@ static struct at91_twi_pdata at91rm9200_config = {
 	.has_unre_flag = true,
 	.has_alt_cmd = false,
 	.has_hold_field = false,
+	.has_dig_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9261_config = {
@@ -76,6 +77,7 @@ static struct at91_twi_pdata at91sam9261_config = {
 	.has_unre_flag = false,
 	.has_alt_cmd = false,
 	.has_hold_field = false,
+	.has_dig_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9260_config = {
@@ -84,6 +86,7 @@ static struct at91_twi_pdata at91sam9260_config = {
 	.has_unre_flag = false,
 	.has_alt_cmd = false,
 	.has_hold_field = false,
+	.has_dig_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9g20_config = {
@@ -92,6 +95,7 @@ static struct at91_twi_pdata at91sam9g20_config = {
 	.has_unre_flag = false,
 	.has_alt_cmd = false,
 	.has_hold_field = false,
+	.has_dig_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9g10_config = {
@@ -100,6 +104,7 @@ static struct at91_twi_pdata at91sam9g10_config = {
 	.has_unre_flag = false,
 	.has_alt_cmd = false,
 	.has_hold_field = false,
+	.has_dig_filtr = false,
 };
 
 static const struct platform_device_id at91_twi_devtypes[] = {
@@ -130,6 +135,7 @@ static struct at91_twi_pdata at91sam9x5_config = {
 	.has_unre_flag = false,
 	.has_alt_cmd = false,
 	.has_hold_field = false,
+	.has_dig_filtr = false,
 };
 
 static struct at91_twi_pdata sama5d4_config = {
@@ -138,6 +144,7 @@ static struct at91_twi_pdata sama5d4_config = {
 	.has_unre_flag = false,
 	.has_alt_cmd = false,
 	.has_hold_field = true,
+	.has_dig_filtr = true,
 };
 
 static struct at91_twi_pdata sama5d2_config = {
@@ -146,6 +153,7 @@ static struct at91_twi_pdata sama5d2_config = {
 	.has_unre_flag = true,
 	.has_alt_cmd = true,
 	.has_hold_field = true,
+	.has_dig_filtr = true,
 };
 
 static struct at91_twi_pdata sam9x60_config = {
@@ -154,6 +162,7 @@ static struct at91_twi_pdata sam9x60_config = {
 	.has_unre_flag = true,
 	.has_alt_cmd = true,
 	.has_hold_field = true,
+	.has_dig_filtr = true,
 };
 
 static const struct of_device_id atmel_twi_dt_ids[] = {
drivers/i2c/busses/i2c-at91-master.c +9 -0
index e87232f..7afce62 100644
@@ -31,12 +31,18 @@
 
 void at91_init_twi_bus_master(struct at91_twi_dev *dev)
 {
+	struct at91_twi_pdata *pdata = dev->pdata;
+
 	/* FIFO should be enabled immediately after the software reset */
 	if (dev->fifo_size)
 		at91_twi_write(dev, AT91_TWI_CR, AT91_TWI_FIFOEN);
 	at91_twi_write(dev, AT91_TWI_CR, AT91_TWI_MSEN);
 	at91_twi_write(dev, AT91_TWI_CR, AT91_TWI_SVDIS);
 	at91_twi_write(dev, AT91_TWI_CWGR, dev->twi_cwgr_reg);
+
+	/* enable digital filter */
+	if (pdata->has_dig_filtr && dev->enable_dig_filt)
+		at91_twi_write(dev, AT91_TWI_FILTR, AT91_TWI_FILTR_FILT);
 }
 
 /*
@@ -792,6 +798,9 @@ int at91_twi_probe_master(struct platform_device *pdev,
 		dev_info(dev->dev, "Using FIFO (%u data)\n", dev->fifo_size);
 	}
 
+	dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node,
+						     "enable-dig-filt");
+
 	at91_calc_twi_clock(dev);
 
 	dev->adapter.algo = &at91_twi_algorithm;
drivers/i2c/busses/i2c-at91.h +5 -0
index 499b506..c75447e 100644
@@ -84,6 +84,9 @@
 #define	AT91_TWI_ACR_DATAL(len)	((len) & 0xff)
 #define	AT91_TWI_ACR_DIR	BIT(8)
 
+#define AT91_TWI_FILTR		0x0044
+#define AT91_TWI_FILTR_FILT	BIT(0)
+
 #define	AT91_TWI_FMR		0x0050	/* FIFO Mode Register */
 #define	AT91_TWI_FMR_TXRDYM(mode)	(((mode) & 0x3) << 0)
 #define	AT91_TWI_FMR_TXRDYM_MASK	(0x3 << 0)
@@ -108,6 +111,7 @@ struct at91_twi_pdata {
 	bool has_unre_flag;
 	bool has_alt_cmd;
 	bool has_hold_field;
+	bool has_dig_filtr;
 	struct at_dma_slave dma_slave;
 };
 
@@ -145,6 +149,7 @@ struct at91_twi_dev {
 	unsigned smr;
 	struct i2c_client *slave;
 #endif
+	bool enable_dig_filt;
 };
 
 unsigned at91_twi_read(struct at91_twi_dev *dev, unsigned reg);
Signature · 1 line
2.7.4
#6 lore raw

PATCH v2 5/9 i2c: at91: add support for advanced digital filtering

In reply to [email protected]

From: Eugen Hristev <[email protected]>

Add new platform data support for advanced digital filtering for i2c. The sama5d2 and sam9x60 support this feature.
This digital filter allows the user to configure the maximum width of the spikes that can be filtered.

---
 drivers/i2c/busses/i2c-at91-core.c   | 9 +++++++++
 drivers/i2c/busses/i2c-at91-master.c | 6 ++++++
 drivers/i2c/busses/i2c-at91.h        | 3 +++
 3 files changed, 18 insertions(+)
drivers/i2c/busses/i2c-at91-core.c +9 -0
index 62610af..3bbe37c 100644
@@ -69,6 +69,7 @@ static struct at91_twi_pdata at91rm9200_config = {
 	.has_alt_cmd = false,
 	.has_hold_field = false,
 	.has_dig_filtr = false,
+	.has_adv_dig_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9261_config = {
@@ -78,6 +79,7 @@ static struct at91_twi_pdata at91sam9261_config = {
 	.has_alt_cmd = false,
 	.has_hold_field = false,
 	.has_dig_filtr = false,
+	.has_adv_dig_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9260_config = {
@@ -87,6 +89,7 @@ static struct at91_twi_pdata at91sam9260_config = {
 	.has_alt_cmd = false,
 	.has_hold_field = false,
 	.has_dig_filtr = false,
+	.has_adv_dig_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9g20_config = {
@@ -96,6 +99,7 @@ static struct at91_twi_pdata at91sam9g20_config = {
 	.has_alt_cmd = false,
 	.has_hold_field = false,
 	.has_dig_filtr = false,
+	.has_adv_dig_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9g10_config = {
@@ -105,6 +109,7 @@ static struct at91_twi_pdata at91sam9g10_config = {
 	.has_alt_cmd = false,
 	.has_hold_field = false,
 	.has_dig_filtr = false,
+	.has_adv_dig_filtr = false,
 };
 
 static const struct platform_device_id at91_twi_devtypes[] = {
@@ -136,6 +141,7 @@ static struct at91_twi_pdata at91sam9x5_config = {
 	.has_alt_cmd = false,
 	.has_hold_field = false,
 	.has_dig_filtr = false,
+	.has_adv_dig_filtr = false,
 };
 
 static struct at91_twi_pdata sama5d4_config = {
@@ -145,6 +151,7 @@ static struct at91_twi_pdata sama5d4_config = {
 	.has_alt_cmd = false,
 	.has_hold_field = true,
 	.has_dig_filtr = true,
+	.has_adv_dig_filtr = false,
 };
 
 static struct at91_twi_pdata sama5d2_config = {
@@ -154,6 +161,7 @@ static struct at91_twi_pdata sama5d2_config = {
 	.has_alt_cmd = true,
 	.has_hold_field = true,
 	.has_dig_filtr = true,
+	.has_adv_dig_filtr = true,
 };
 
 static struct at91_twi_pdata sam9x60_config = {
@@ -163,6 +171,7 @@ static struct at91_twi_pdata sam9x60_config = {
 	.has_alt_cmd = true,
 	.has_hold_field = true,
 	.has_dig_filtr = true,
+	.has_adv_dig_filtr = true,
 };
 
 static const struct of_device_id atmel_twi_dt_ids[] = {
drivers/i2c/busses/i2c-at91-master.c +6 -0
index 7afce62..d82601b 100644
@@ -43,6 +43,12 @@ void at91_init_twi_bus_master(struct at91_twi_dev *dev)
 	/* enable digital filter */
 	if (pdata->has_dig_filtr && dev->enable_dig_filt)
 		at91_twi_write(dev, AT91_TWI_FILTR, AT91_TWI_FILTR_FILT);
+
+	/* enable advanced digital filter */
+	if (pdata->has_adv_dig_filtr && dev->enable_dig_filt)
+		at91_twi_write(dev, AT91_TWI_FILTR, AT91_TWI_FILTR_FILT |
+			       (AT91_TWI_FILTR_THRES(7) &
+				AT91_TWI_FILTR_THRES_MASK));
 }
 
 /*
drivers/i2c/busses/i2c-at91.h +3 -0
index c75447e..7b8c371 100644
@@ -86,6 +86,8 @@
 
 #define AT91_TWI_FILTR		0x0044
 #define AT91_TWI_FILTR_FILT	BIT(0)
+#define AT91_TWI_FILTR_THRES(v)		((v) << 8)
+#define AT91_TWI_FILTR_THRES_MASK	GENMASK(10, 8)
 
 #define	AT91_TWI_FMR		0x0050	/* FIFO Mode Register */
 #define	AT91_TWI_FMR_TXRDYM(mode)	(((mode) & 0x3) << 0)
@@ -112,6 +114,7 @@ struct at91_twi_pdata {
 	bool has_alt_cmd;
 	bool has_hold_field;
 	bool has_dig_filtr;
+	bool has_adv_dig_filtr;
 	struct at_dma_slave dma_slave;
 };
 
Signature · 1 line
2.7.4
#7 lore raw

PATCH v2 6/9 dt-bindings: i2c: at91: add binding for enable-ana-filt

In reply to [email protected]

From: Eugen Hristev <[email protected]>

Add binding specification for analogic filter inside the i2c controller

---
 Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/i2c/i2c-at91.txt +4 -0
index 8268595..20d334c 100644
@@ -23,6 +23,9 @@ Optional properties:
 - enable-dig-filt: Enable the built-in digital filter on the i2c lines,
   specifically required depending on the hardware PCB/board and if the
   version of the controller includes it.
+- enable-ana-filt: Enable the built-in analogic filter on the i2c lines,
+  specifically required depending on the hardware PCB/board and if the
+  version of the controller includes it.
 - Child nodes conforming to i2c bus binding
 
 Examples :
@@ -60,6 +63,7 @@ i2c0: i2c@f8034600 {
 	atmel,fifo-size = <16>;
 	i2c-sda-hold-time-ns = <336>;
 	enable-dig-filt;
+	enable-ana-filt;
 
 	wm8731: wm8731@1a {
 		compatible = "wm8731";
Signature · 1 line
2.7.4
#8 lore raw

Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt

Quoted 3 lines · On 2019-06-25 10:05, [email protected] wrote:

From: Eugen Hristev <[email protected]>

Add binding specification for analogic filter inside the i2c controller

s/analogic/the analog/

Quoted 20 lines
---
 Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/i2c/i2c-at91.txt +3 -0
index 8268595..20d334c 100644
@@ -23,6 +23,9 @@ Optional properties:
 - enable-dig-filt: Enable the built-in digital filter on the i2c lines,
   specifically required depending on the hardware PCB/board and if the
   version of the controller includes it.
+- enable-ana-filt: Enable the built-in analogic filter on the i2c lines,
+  specifically required depending on the hardware PCB/board and if the
+  version of the controller includes it.
 - Child nodes conforming to i2c bus binding
 
 Examples :

Documentation/devicetree/bindings/i2c/i2c-at91.txt i2c0: i2c@f8034600 { · line 66

Quoted 4 lines
Documentation/devicetree/bindings/i2c/i2c-at91.txt +1 -0
@@ -60,6 +63,7 @@ i2c0: i2c@f8034600 {
 	atmel,fifo-size = <16>;
 	i2c-sda-hold-time-ns = <336>;
 	enable-dig-filt;
+	enable-ana-filt;

Perhaps

	microchip,digital-filter;
	microchip,analog-filter;

?

Cheers,
Peter

Quoted 4 lines
Documentation/devicetree/bindings/i2c/i2c-at91.txt +0 -0
 	wm8731: wm8731@1a {
 		compatible = "wm8731";
 
#9 lore raw

Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt

Quoted 35 lines · Peter Rosin
Quoted 3 lines · On 2019-06-25 10:05, [email protected] wrote:

From: Eugen Hristev <[email protected]>

Add binding specification for analogic filter inside the i2c controller

s/analogic/the analog/

Quoted 20 lines
---
  Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 ++++
  1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/i2c/i2c-at91.txt +3 -0
index 8268595..20d334c 100644
@@ -23,6 +23,9 @@ Optional properties:
  - enable-dig-filt: Enable the built-in digital filter on the i2c lines,
    specifically required depending on the hardware PCB/board and if the
    version of the controller includes it.
+- enable-ana-filt: Enable the built-in analogic filter on the i2c lines,
+  specifically required depending on the hardware PCB/board and if the
+  version of the controller includes it.
  - Child nodes conforming to i2c bus binding
 
  Examples :

Documentation/devicetree/bindings/i2c/i2c-at91.txt i2c0: i2c@f8034600 { · line 66

Quoted 4 lines
Documentation/devicetree/bindings/i2c/i2c-at91.txt +1 -0
@@ -60,6 +63,7 @@ i2c0: i2c@f8034600 {
  	atmel,fifo-size = <16>;
  	i2c-sda-hold-time-ns = <336>;
  	enable-dig-filt;
+	enable-ana-filt;

Perhaps

Quoted 4 lines
	microchip,digital-filter;
	microchip,analog-filter;

?

Hi Peter,

Thanks for reviewing. The name of the property does not matter much to me, and we have properties prefixed with vendor, and some are not.

@Alexandre Belloni: which name you think it's best ?

Eugen

Quoted 9 lines

Cheers,
Peter

Quoted 4 lines
Documentation/devicetree/bindings/i2c/i2c-at91.txt +0 -0
  	wm8731: wm8731@1a {
  		compatible = "wm8731";
 
#10 lore raw

Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt

Quoted 5 lines · On 25/06/2019 09:14:13+0000, [email protected] wrote:
Quoted 5 lines

Perhaps

	microchip,digital-filter;
	microchip,analog-filter;
Quoted 9 lines
Quoted 1 line

?

Hi Peter,

Thanks for reviewing. The name of the property does not matter much to me, and we have properties prefixed with vendor, and some are not.

@Alexandre Belloni: which name you think it's best ?

I'm not sure, it depends on whether Wolfram thinks it is generic enough to be used without a vendor prefix.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#11 lore raw

I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

Quoted 10 lines · Alexandre Belloni
Quoted 9 lines · On 25/06/2019 09:14:13+0000, [email protected] wrote:
Quoted 6 lines

Perhaps

	microchip,digital-filter;
	microchip,analog-filter;

?

Hi Peter,

Quoted 8 lines
Quoted 5 lines

Thanks for reviewing. The name of the property does not matter much to me, and we have properties prefixed with vendor, and some are not.

@Alexandre Belloni: which name you think it's best ?

I'm not sure, it depends on whether Wolfram thinks it is generic enough to be used without a vendor prefix.

I could imagine that we design a generic property for filters. The ones above make me wonder, though, because they are bool. I'd think you can configure the filters in some way, too?

I never used such filtering, so I am unaware of the parameters needed / suitable. Quick grepping through I2C master drivers reveals that i2c-stm32f7.c also handles filters, but only with default values. Maybe DT configuration would be benefitial to that driver, too?

Adding some people to CC.

#12 lore raw

Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

Quoted 17 lines · Wolfram Sang
Quoted 16 lines · Alexandre Belloni
Quoted 14 lines · On 25/06/2019 09:14:13+0000, [email protected] wrote:
Quoted 6 lines

Perhaps

	microchip,digital-filter;
	microchip,analog-filter;

?

Hi Peter,

Thanks for reviewing. The name of the property does not matter much to me, and we have properties prefixed with vendor, and some are not.

@Alexandre Belloni: which name you think it's best ?

Quoted 7 lines
Quoted 2 lines

I'm not sure, it depends on whether Wolfram thinks it is generic enough to be used without a vendor prefix.

I could imagine that we design a generic property for filters. The ones above make me wonder, though, because they are bool. I'd think you can configure the filters in some way, too?

Apart from enabling the filter there is indeed one configuration setting, the maximum pulse width of spikes to be suppressed by the input filter.

Quoted 7 lines

I never used such filtering, so I am unaware of the parameters needed / suitable. Quick grepping through I2C master drivers reveals that i2c-stm32f7.c also handles filters, but only with default values. Maybe DT configuration would be benefitial to that driver, too?

Adding some people to CC.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#13 lore raw

Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

Quoted 24 lines · Alexandre Belloni

External E-Mail

Quoted 20 lines · Wolfram Sang
Quoted 18 lines · Alexandre Belloni
Quoted 5 lines · On 25/06/2019 09:14:13+0000, [email protected] wrote:
Quoted 5 lines

Perhaps

	microchip,digital-filter;
	microchip,analog-filter;
Quoted 9 lines
Quoted 1 line

?

Hi Peter,

Thanks for reviewing. The name of the property does not matter much to me, and we have properties prefixed with vendor, and some are not.

@Alexandre Belloni: which name you think it's best ?

I'm not sure, it depends on whether Wolfram thinks it is generic enough to be used without a vendor prefix.

Quoted 8 lines
Quoted 4 lines

I could imagine that we design a generic property for filters. The ones above make me wonder, though, because they are bool. I'd think you can configure the filters in some way, too?

Apart from enabling the filter there is indeed one configuration setting, the maximum pulse width of spikes to be suppressed by the input filter.

Hello,

This is a number 0 to 7 (3 bits) that represents the width of the spike in periph clock cycles.
I am looking to see what is PADFCFG , as it's related to the PAD analog filter configuration. It may be unused by the filter.

Eugen

Quoted 11 lines
Quoted 8 lines

I never used such filtering, so I am unaware of the parameters needed / suitable. Quick grepping through I2C master drivers reveals that i2c-stm32f7.c also handles filters, but only with default values. Maybe DT configuration would be benefitial to that driver, too?

Adding some people to CC.

#14 lore raw

Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

Quoted 4 lines
Quoted 4 lines

Apart from enabling the filter there is indeed one configuration setting, the maximum pulse width of spikes to be suppressed by the input filter.

Yup, this is what I anticipated.

Quoted 2 lines

This is a number 0 to 7 (3 bits) that represents the width of the spike in periph clock cycles.

For a generic binding, we would need some time-value as a parameter and convert it to clock cycles in the driver then, I'd think.

Quoted 2 lines

I am looking to see what is PADFCFG , as it's related to the PAD analog filter configuration. It may be unused by the filter.

Thanks!

#15 lore raw

Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

Quoted 5 lines · Wolfram Sang
Quoted 4 lines
Quoted 4 lines

Apart from enabling the filter there is indeed one configuration setting, the maximum pulse width of spikes to be suppressed by the input filter.

Quoted 8 lines

Yup, this is what I anticipated.

Quoted 2 lines

This is a number 0 to 7 (3 bits) that represents the width of the spike in periph clock cycles.

For a generic binding, we would need some time-value as a parameter and convert it to clock cycles in the driver then, I'd think.

Yes, that is what I was going to suggest.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#16 lore raw

PATCH v2 7/9 i2c: at91: add support for analog filtering

In reply to [email protected]

From: Eugen Hristev <[email protected]>

Add support for analog filtering for i2c lines.
The sama5d2 and sam9x60 support this feature.

---
 drivers/i2c/busses/i2c-at91-core.c   |  9 +++++++++
 drivers/i2c/busses/i2c-at91-master.c | 17 +++++++++++++----
 drivers/i2c/busses/i2c-at91.h        |  4 ++++
 3 files changed, 26 insertions(+), 4 deletions(-)
drivers/i2c/busses/i2c-at91-core.c +9 -0
index 3bbe37c..d2840ba 100644
@@ -70,6 +70,7 @@ static struct at91_twi_pdata at91rm9200_config = {
 	.has_hold_field = false,
 	.has_dig_filtr = false,
 	.has_adv_dig_filtr = false,
+	.has_ana_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9261_config = {
@@ -80,6 +81,7 @@ static struct at91_twi_pdata at91sam9261_config = {
 	.has_hold_field = false,
 	.has_dig_filtr = false,
 	.has_adv_dig_filtr = false,
+	.has_ana_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9260_config = {
@@ -90,6 +92,7 @@ static struct at91_twi_pdata at91sam9260_config = {
 	.has_hold_field = false,
 	.has_dig_filtr = false,
 	.has_adv_dig_filtr = false,
+	.has_ana_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9g20_config = {
@@ -100,6 +103,7 @@ static struct at91_twi_pdata at91sam9g20_config = {
 	.has_hold_field = false,
 	.has_dig_filtr = false,
 	.has_adv_dig_filtr = false,
+	.has_ana_filtr = false,
 };
 
 static struct at91_twi_pdata at91sam9g10_config = {
@@ -110,6 +114,7 @@ static struct at91_twi_pdata at91sam9g10_config = {
 	.has_hold_field = false,
 	.has_dig_filtr = false,
 	.has_adv_dig_filtr = false,
+	.has_ana_filtr = false,
 };
 
 static const struct platform_device_id at91_twi_devtypes[] = {
@@ -142,6 +147,7 @@ static struct at91_twi_pdata at91sam9x5_config = {
 	.has_hold_field = false,
 	.has_dig_filtr = false,
 	.has_adv_dig_filtr = false,
+	.has_ana_filtr = false,
 };
 
 static struct at91_twi_pdata sama5d4_config = {
@@ -152,6 +158,7 @@ static struct at91_twi_pdata sama5d4_config = {
 	.has_hold_field = true,
 	.has_dig_filtr = true,
 	.has_adv_dig_filtr = false,
+	.has_ana_filtr = false,
 };
 
 static struct at91_twi_pdata sama5d2_config = {
@@ -162,6 +169,7 @@ static struct at91_twi_pdata sama5d2_config = {
 	.has_hold_field = true,
 	.has_dig_filtr = true,
 	.has_adv_dig_filtr = true,
+	.has_ana_filtr = true,
 };
 
 static struct at91_twi_pdata sam9x60_config = {
@@ -172,6 +180,7 @@ static struct at91_twi_pdata sam9x60_config = {
 	.has_hold_field = true,
 	.has_dig_filtr = true,
 	.has_adv_dig_filtr = true,
+	.has_ana_filtr = true,
 };
 
 static const struct of_device_id atmel_twi_dt_ids[] = {
drivers/i2c/busses/i2c-at91-master.c +13 -4
index d82601b..8fe3a2c 100644
@@ -32,6 +32,7 @@
 void at91_init_twi_bus_master(struct at91_twi_dev *dev)
 {
 	struct at91_twi_pdata *pdata = dev->pdata;
+	u32 filtr = 0;
 
 	/* FIFO should be enabled immediately after the software reset */
 	if (dev->fifo_size)
@@ -42,13 +43,19 @@ void at91_init_twi_bus_master(struct at91_twi_dev *dev)
 
 	/* enable digital filter */
 	if (pdata->has_dig_filtr && dev->enable_dig_filt)
-		at91_twi_write(dev, AT91_TWI_FILTR, AT91_TWI_FILTR_FILT);
+		filtr |= AT91_TWI_FILTR_FILT;
 
 	/* enable advanced digital filter */
 	if (pdata->has_adv_dig_filtr && dev->enable_dig_filt)
-		at91_twi_write(dev, AT91_TWI_FILTR, AT91_TWI_FILTR_FILT |
-			       (AT91_TWI_FILTR_THRES(7) &
-				AT91_TWI_FILTR_THRES_MASK));
+		filtr |= AT91_TWI_FILTR_FILT |
+			 (AT91_TWI_FILTR_THRES(7) & AT91_TWI_FILTR_THRES_MASK);
+
+	/* enable analog filter */
+	if (pdata->has_ana_filtr && dev->enable_ana_filt)
+		filtr |= AT91_TWI_FILTR_PADFEN | AT91_TWI_FILTR_PADFCFG;
+
+	if (filtr)
+		at91_twi_write(dev, AT91_TWI_FILTR, filtr);
 }
 
 /*
@@ -807,6 +814,8 @@ int at91_twi_probe_master(struct platform_device *pdev,
 	dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node,
 						     "enable-dig-filt");
 
+	dev->enable_ana_filt = of_property_read_bool(pdev->dev.of_node,
+						     "enable-ana-filt");
 	at91_calc_twi_clock(dev);
 
 	dev->adapter.algo = &at91_twi_algorithm;
drivers/i2c/busses/i2c-at91.h +4 -0
index 7b8c371..4ca9c191 100644
@@ -86,6 +86,8 @@
 
 #define AT91_TWI_FILTR		0x0044
 #define AT91_TWI_FILTR_FILT	BIT(0)
+#define AT91_TWI_FILTR_PADFEN	BIT(1)
+#define AT91_TWI_FILTR_PADFCFG	BIT(2)
 #define AT91_TWI_FILTR_THRES(v)		((v) << 8)
 #define AT91_TWI_FILTR_THRES_MASK	GENMASK(10, 8)
 
@@ -115,6 +117,7 @@ struct at91_twi_pdata {
 	bool has_hold_field;
 	bool has_dig_filtr;
 	bool has_adv_dig_filtr;
+	bool has_ana_filtr;
 	struct at_dma_slave dma_slave;
 };
 
@@ -153,6 +156,7 @@ struct at91_twi_dev {
 	struct i2c_client *slave;
 #endif
 	bool enable_dig_filt;
+	bool enable_ana_filt;
 };
 
 unsigned at91_twi_read(struct at91_twi_dev *dev, unsigned reg);
Signature · 1 line
2.7.4
#17 lore raw

PATCH v2 8/9 ARM: dts: at91: sama5d2_xplained: add analogic and digital filter for i2c

In reply to [email protected]

From: Eugen Hristev <[email protected]>

Add property for analogic and digital filter for i2c1 and i2c2 nodes for sama5d2_xplained

---
 arch/arm/boot/dts/at91-sama5d2_xplained.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/at91-sama5d2_xplained.dts +4 -0
index 808e399..bde4a711b 100644
@@ -334,6 +334,8 @@
 					pinctrl-names = "default";
 					pinctrl-0 = <&pinctrl_flx4_default>;
 					atmel,fifo-size = <16>;
+					enable-ana-filt;
+					enable-dig-filt;
 					status = "okay";
 				};
 			};
@@ -342,6 +344,8 @@
 				dmas = <0>, <0>;
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_i2c1_default>;
+				enable-ana-filt;
+				enable-dig-filt;
 				status = "okay";
 
 				at24@54 {
Signature · 1 line
2.7.4
#18 lore raw

PATCH v2 9/9 ARM: dts: at91: sama5d4_xplained: add analogic filter for i2c

In reply to [email protected]

From: Eugen Hristev <[email protected]>

Add property for digital filter for i2c0 node sama5d4_xplained

---
 arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/at91-sama5d4_xplained.dts +1 -0
index fdfc37d..06068dc 100644
@@ -49,6 +49,7 @@
 			};
 
 			i2c0: i2c@f8014000 {
+				enable-ana-filt;
 				status = "okay";
 			};
 
Signature · 1 line
2.7.4
#19 lore raw

Re: [PATCH v2 9/9] ARM: dts: at91: sama5d4_xplained: add analogic filter for i2c

Quoted 3 lines · On 2019-06-25 10:05, [email protected] wrote:

From: Eugen Hristev <[email protected]>

Add property for digital filter for i2c0 node sama5d4_xplained

This does not match the below hunk.

Cheers,
Peter

Quoted 18 lines
---
 arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/at91-sama5d4_xplained.dts +1 -0
index fdfc37d..06068dc 100644
@@ -49,6 +49,7 @@
 			};
 
 			i2c0: i2c@f8014000 {
+				enable-ana-filt;
 				status = "okay";
 			};