drm/amdgpu: fix scheduler timeout calc
Subsystems (2)
PATCH v2 1/1 drm/amdgpu: fix scheduler timeout calc
scheduler timeout is in jiffies
v2: move timeout check to amdgpu_device_get_job_timeout_settings after parsing the value & add negative value check
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +5 -1
@@ -1300,7 +1300,7 @@ int amdgpu_device_get_job_timeout_settings(struct amdgpu_device *adev)* By default timeout for non compute jobs is 10000. * And there is no timeout enforced on compute jobs. */ - adev->gfx_timeout = adev->sdma_timeout = adev->video_timeout =10000 ; + adev->gfx_timeout = adev->sdma_timeout = adev->video_timeout =msecs_to_jiffies (10000 ); adev->compute_timeout =MAX_SCHEDULE_TIMEOUT ;if (strnlen (input,AMDGPU_MAX_TIMEOUT_PARAM_LENTH )) {
@@ -1314,6 +1314,10 @@ int amdgpu_device_get_job_timeout_settings(struct amdgpu_device *adev)if (timeout <=0 ) { index++;continue ; + }else if ((long )msecs_to_jiffies (timeout) <0 ) { + timeout =MAX_SCHEDULE_TIMEOUT ; + }else { + timeout =msecs_to_jiffies (timeout); }switch (index++) {
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1561455804-9644-1-git-send-email-flora.cui-5C7GfCeVMHo@public.gmane.org
please ignore this mail. I'll prepare v3 patch to simplify code logic.
获取 Outlook for Android<https://aka.ms/ghei36>
________________________________
From: Cui, Flora
Sent: Tuesday, June 25, 2019 5:43:38 PM
To: [email protected]
Cc: Cui, Flora
Subject: [PATCH v2] drm/amdgpu: fix scheduler timeout calc
scheduler timeout is in jiffies
v2: move timeout check to amdgpu_device_get_job_timeout_settings after parsing the value & add negative value check
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +5 -1
@@ -1300,7 +1300,7 @@ int amdgpu_device_get_job_timeout_settings(struct amdgpu_device *adev)* By default timeout for non compute jobs is 10000. * And there is no timeout enforced on compute jobs. */ - adev->gfx_timeout = adev->sdma_timeout = adev->video_timeout =10000 ; + adev->gfx_timeout = adev->sdma_timeout = adev->video_timeout =msecs_to_jiffies (10000 ); adev->compute_timeout =MAX_SCHEDULE_TIMEOUT ;if (strnlen (input,AMDGPU_MAX_TIMEOUT_PARAM_LENTH )) {
@@ -1314,6 +1314,10 @@ int amdgpu_device_get_job_timeout_settings(struct amdgpu_device *adev)if (timeout <=0 ) { index++;continue ; + }else if ((long )msecs_to_jiffies (timeout) <0 ) { + timeout =MAX_SCHEDULE_TIMEOUT ; + }else { + timeout =msecs_to_jiffies (timeout); }switch (index++) {
--
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx