Skip to contentSkip to conversation

arm64: dts: sdm845: Add video nodes

PATCH Superseded Aniket Masule 2 participants 2 messages Jun 26, 2019

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: sdm845: Add video nodes

This adds video nodes to sdm845 based on the examples in the bindings.

---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
arch/arm64/boot/dts/qcom/sdm845.dtsi +30 -0
index fcb9330..ff94cfa 100644
@@ -2437,6 +2437,36 @@
 				<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
 			iommus = <&apps_smmu 0x0040 0x1>;
 		};
+
+		video-codec@aa00000 {
+			compatible = "qcom,sdm845-venus";
+			reg = <0x0aa00000 0xff000>;
+			interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+			power-domains = <&videocc VENUS_GDSC>;
+			clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
+				 <&videocc VIDEO_CC_VENUS_AHB_CLK>,
+				 <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>;
+			clock-names = "core", "iface", "bus";
+			iommus = <&apps_smmu 0x10a0 0x8>,
+				 <&apps_smmu 0x10b0 0x0>;
+			memory-region = <&venus_region>;
+
+			video-core0 {
+				compatible = "venus-decoder";
+				clocks = <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
+					 <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
+				clock-names = "core", "bus";
+				power-domains = <&videocc VCODEC0_GDSC>;
+			};
+
+			video-core1 {
+				compatible = "venus-encoder";
+				clocks = <&videocc VIDEO_CC_VCODEC1_CORE_CLK>,
+					 <&videocc VIDEO_CC_VCODEC1_AXI_CLK>;
+				clock-names = "core", "bus";
+				power-domains = <&videocc VCODEC1_GDSC>;
+			};
+		};
 	};
 
 	thermal-zones {
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#1 lore raw

Quoting Aniket Masule (2019-06-26 04:54:07)

Quoted 4 lines

This adds video nodes to sdm845 based on the examples in the bindings.

There should be a From: line with this person's name in the email if they're the author. Otherwise this sign-off chain doesn't make sense and it should most likely have a Co-developed-by tag instead.

Quoted 10 lines
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
arch/arm64/boot/dts/qcom/sdm845.dtsi +0 -0
index fcb9330..ff94cfa 100644

arch/arm64/boot/dts/qcom/sdm845.dtsi line 2441

Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +2 -0
@@ -2437,6 +2437,36 @@
                                <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
                        iommus = <&apps_smmu 0x0040 0x1>;
                };
+
+               video-codec@aa00000 {

This needs to be sorted by address. It doesn't come after 18800000 (the address of the node above).

Quoted 3 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +3 -0
+                       compatible = "qcom,sdm845-venus";
+                       reg = <0x0aa00000 0xff000>;
+                       interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;