ath11k: Alignment should match open parenthesis
PATCH 1/4 ath11k: Alignment should match open parenthesis
Fix checkpatch warning:
drivers/net/wireless/ath/ath11k/mac.c:5029: Alignment should match open parenthesis
--- drivers/net/wireless/ath/ath11k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/mac.c +1 -1
@@ -5026,7 +5026,7 @@ ath11k_mac_update_bss_chan_survey(struct ath11k *ar, }static int ath11k_mac_op_get_survey (struct ieee80211_hw *hw,int idx, -struct survey_info *survey) +struct survey_info *survey) {struct ath11k *ar = hw->priv;struct ieee80211_supported_band *sband;
Signature · 7 lines
2.7.4 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 2/4 ath11k: Remove prototype interface
From: Venkateswara Naralasetty <[email protected]>
Remove prototype interfaces which we don't support any of these prototype interfaces in upstream.
--- drivers/net/wireless/ath/ath11k/wmi.h | 1 - 1 file changed, 1 deletion(-)
drivers/net/wireless/ath/ath11k/wmi.h +0 -1
@@ -1936,7 +1936,6 @@ enum wmi_tlv_service {WMI_TLV_SERVICE_PER_VDEV_CHAINMASK_CONFIG_SUPPORT =173 ,WMI_TLV_SERVICE_TX_DATA_MGMT_ACK_RSSI =174 ,WMI_TLV_SERVICE_NAN_DISABLE_SUPPORT =175 , - WMI_TLV_SERVICE_NAN_DISABLE_SUPPORT__prototype =WMI_TLV_SERVICE_NAN_DISABLE_SUPPORT ,WMI_TLV_SERVICE_HTT_H2T_NO_HTC_HDR_LEN_IN_MSG_LEN =176 ,WMI_MAX_EXT_SERVICE
Signature · 7 lines
2.7.4 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 3/4 ath11k: line over 90 characters
In reply to Kalle ValoFix checkpatch warning:
drivers/net/wireless/ath/ath11k/dp_rx.c:2283: line over 90 characters
--- drivers/net/wireless/ath/ath11k/dp_rx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +3 -1
@@ -2280,7 +2280,9 @@ int ath11k_dp_process_rx(struct ath11k_base *ab, int mac_id,if (ret == -EIO ) {ath11k_err (ab,"rx ring got corrupted %d\n" , ret);__skb_queue_purge (&msdu_list); -/* Should stop processing any more rx in future from this ring? */ +/* Should stop processing any more rx in +* future from this ring? +*/ goto rcu_unlock; }
Signature · 7 lines
2.7.4 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 4/4 ath11k: use kstrtoint_from_user() instead of sscanf()
In reply to Kalle ValoFix checkpatch warning:
drivers/net/wireless/ath/ath11k/debugfs_sta.c:494: Prefer kstrto<type> to single variable sscanf
As kstrtoint_from_user() can read directly from user buffer no need copy the buffer separately.
Compile tested only.
--- drivers/net/wireless/ath/ath11k/debugfs_sta.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-)
drivers/net/wireless/ath/ath11k/debugfs_sta.c +3 -14
@@ -467,15 +467,13 @@ static const struct file_operations fops_htt_peer_stats = { };static ssize_t ath11k_dbg_sta_write_peer_pktlog (struct file *file, -const char __user *ubuf, +const char __user *buf,size_t count,loff_t *ppos) {struct ieee80211_sta *sta = file->private_data;struct ath11k_sta *arsta = (struct ath11k_sta *)sta->drv_priv;struct ath11k *ar = arsta->arvif->ar; -u8 buf[32 ] = {0 };int ret, enable; -ssize_t rc;mutex_lock (&ar->conf_mutex);
@@ -484,18 +482,9 @@ static ssize_t ath11k_dbg_sta_write_peer_pktlog(struct file *file, goto out; } - rc =simple_write_to_buffer (buf,sizeof (buf) -1 , ppos, ubuf, count); -if (rc <0 ) { - ret = rc; + ret =kstrtoint_from_user (buf, count,0 , &enable); +if (ret) goto out; - } - buf[rc] ='\0' ; - - ret =sscanf (buf,"%d" , &enable); -if (ret !=1 ) { - ret = -EINVAL ; - goto out; - } ar->debug.pktlog_peer_valid = enable;memcpy (ar->debug.pktlog_peer_addr, sta->addr,ETH_ALEN );
Signature · 7 lines
2.7.4 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 5 lines · Kalle Valo
Fix checkpatch warning:
drivers/net/wireless/ath/ath11k/mac.c:5029: Alignment should match open parenthesisSigned-off-by Kalle Valo <[email protected]>
4 patches applied to ath11k-bringup branch of ath.git, thanks.
8f5a39b1cdaf ath11k: Alignment should match open parenthesis 810a4fb71e6a ath11k: Remove prototype interface 7b5a3ac963cb ath11k: line over 90 characters 4c6476d00657 ath11k: use kstrtoint_from_user() instead of sscanf()
Signature · 9 lines
https://patchwork.kernel.org/patch/11018091/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k