csky: Fixup abiv1 memset error
Subsystems (2)
[email protected]
maintainerPATCH 1/1 csky: Fixup abiv1 memset error
From: Guo Ren <[email protected]>
Current memset implementation in abiv1 is wrong and it'll cause unalign access. Just remove it and use the generic one. This patch will cause performance degradation and we will improve it with a new design in next patchset.
Signed-off-by Guo Ren <[email protected]>
Cc Arnd Bergmann <[email protected]>
--- arch/csky/abiv1/Makefile | 1 - arch/csky/abiv1/inc/abi/string.h | 3 --- arch/csky/abiv1/memset.c | 37 ------------------------------------- arch/csky/abiv1/strksyms.c | 1 - 4 files changed, 42 deletions(-) delete mode 100644 arch/csky/abiv1/memset.c
arch/csky/abiv1/Makefile +0 -1
@@ -5,5 +5,4 @@ obj-y += bswapsi.o obj-y += cacheflush.o obj-y += mmap.o obj-y += memcpy.o -obj-y += memset.o obj-y += strksyms.o
arch/csky/abiv1/inc/abi/string.h +0 -3
@@ -7,7 +7,4 @@#define __HAVE_ARCH_MEMCPYextern void *memcpy (void *,const void *,__kernel_size_t ); -#define __HAVE_ARCH_MEMSET -extern void *memset (void *,int ,__kernel_size_t ); -#endif /* __ABI_CSKY_STRING_H */
arch/csky/abiv1/memset.c deleted +0 -37
@@ -1,37 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -// Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. - -#include <linux/types.h> - -void *memset (void *dest,int c,size_t l) -{ -char *d = dest; -int ch = c &0xff ; -int tmp = (ch | ch <<8 | ch <<16 | ch <<24 ); - -while (((uintptr_t )d &0x3 ) && l--) - *d++ = ch; - -while (l >=16 ) { - *(((u32 *)d)) = tmp; - *(((u32 *)d)+1 ) = tmp; - *(((u32 *)d)+2 ) = tmp; - *(((u32 *)d)+3 ) = tmp; - l -=16 ; - d +=16 ; - } - -while (l >3 ) { - *(((u32 *)d)) = tmp; - l -=4 ; - d +=4 ; - } - -while (l) { - *d = ch; - l--; - d++; - } - -return dest; -}
arch/csky/abiv1/strksyms.c +0 -1
@@ -4,4 +4,3 @@#include <linux/module.h> EXPORT_SYMBOL (memcpy); -EXPORT_SYMBOL (memset);
Signature · 1 line
2.7.4