Skip to contentSkip to conversation

fix vendor prefix for arcxcnn driver and bindings

PATCH In review Brian Dodge 4 participants 12 messages Jul 1, 2019 – Jul 9, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v2 cover fix vendor prefix for arcxcnn driver and bindings

These v2 patches incorporate the following changes

1/2 dt-bindings: backlight:

The documentation for "arc" has been re-added but marked (deprecated) to match the actual driver support for that

2/2 backlight: arcxcnn:

Added new-lines and fixed spelling as per feedback

Original patch description:

This patch is to update the arcxcnn backlight driver to use the proper "arctic" vendor-prefix and document that in the device- tree bindings.

There is at least one existing device using the old "arc" vendor-prefix (Samsung Chromebook Plus), so support for that remains in the driver source.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#1 lore raw

PATCH v2 1/2 dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

The vendor-prefixes.txt file properly refers to ArcticSand as arctic but the driver bindings improperly abbreviated the prefix to arc. This was a mistake in the original patch. This patch adds "arctic" and retains "arc" (deprecated) bindings

---
 .../bindings/leds/backlight/arcxcnn_bl.txt         | 31 +++++++++++++++-------
 1 file changed, 21 insertions(+), 10 deletions(-)
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +21 -10
index 230abde..4d98394 100644
@@ -1,8 +1,13 @@
-Binding for ArcticSand arc2c0608 LED driver
+Binding for ArcticSand arc family LED drivers
 
 Required properties:
-- compatible:		should be "arc,arc2c0608"
-- reg:			slave address
+- compatible: one of
+	"arctic,arc1c0608"
+	"arctic,arc2c0608"
+	"arctic,arc3c0845"
+	"arc,arc2c0608" (deprecated)
+
+- reg:		slave address
 
 Optional properties:
 - default-brightness:	brightness value on boot, value from: 0-4095
@@ -11,19 +16,25 @@ Optional properties:
 - led-sources:		List of enabled channels from 0 to 5.
 			See Documentation/devicetree/bindings/leds/common.txt
 
-- arc,led-config-0:	setting for register ILED_CONFIG_0
-- arc,led-config-1:	setting for register ILED_CONFIG_1
-- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used)
-- arc,comp-config:	setting for register CONFIG_COMP
-- arc,filter-config:	setting for register FILTER_CONFIG
-- arc,trim-config:	setting for register IMAXTUNE
+- arctic,led-config-0:	setting for register ILED_CONFIG_0
+- arctic,led-config-1:	setting for register ILED_CONFIG_1
+- arctic,dim-freq:	PWM mode frequence setting (bits [3:0] used)
+- arctic,comp-config:	setting for register CONFIG_COMP
+- arctic,filter-config:	setting for register FILTER_CONFIG
+- arctic,trim-config:	setting for register IMAXTUNE
+- arc,led-config-0:	setting for register ILED_CONFIG_0 (deprecated)
+- arc,led-config-1:	setting for register ILED_CONFIG_1 (deprecated)
+- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used) (deprecated)
+- arc,comp-config:	setting for register CONFIG_COMP (deprecated)
+- arc,filter-config:	setting for register FILTER_CONFIG (deprecated)
+- arc,trim-config:	setting for register IMAXTUNE (deprecated)
 
 Note: Optional properties not specified will default to values in IC EPROM
 
 Example:
 
 arc2c0608@30 {
-	compatible = "arc,arc2c0608";
+	compatible = "arctic,arc2c0608";
 	reg = <0x30>;
 	default-brightness = <500>;
 	label = "lcd-backlight";
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v2 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

Quoted 2 lines

[PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

The "v2" is normally applied to the whole patchset (if you prepare the patchset using git format-patch then you can use the --subject-prefix argument for that).

Quoted 16 lines · Brian Dodge

The vendor-prefixes.txt file properly refers to ArcticSand as arctic but the driver bindings improperly abbreviated the prefix to arc. This was a mistake in the original patch. This patch adds "arctic" and retains "arc" (deprecated) bindings

---
 .../bindings/leds/backlight/arcxcnn_bl.txt         | 31 +++++++++++++++-------
 1 file changed, 21 insertions(+), 10 deletions(-)
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +0 -1
index 230abde..4d98394 100644
@@ -1,8 +1,13 @@
-Binding for ArcticSand arc2c0608 LED driver

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt line 8

Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +6 -2
+Binding for ArcticSand arc family LED drivers
 
 Required properties:
-- compatible:		should be "arc,arc2c0608"
-- reg:			slave address
+- compatible: one of
+	"arctic,arc1c0608"
+	"arctic,arc2c0608"
+	"arctic,arc3c0845"
+	"arc,arc2c0608" (deprecated)

Nothing wrong with adding compatible strings for arc1 and arc3 but I would expect it to be mentioned in the description to reassure reviewers that the right depth of thought has been applied Something like "Also added compatible strings for other family members, all the existing optional properties work the same way for the new devices." (if you agree that it is true) is good to show you were paying proper attention!

However this does perhaps verge a little towards nitpicking so maybe wait to see what the DT folks say. From my point of view:

Daniel.

Quoted 41 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +15 -7
+
+- reg:		slave address
 
 Optional properties:
 - default-brightness:	brightness value on boot, value from: 0-4095
@@ -11,19 +16,25 @@ Optional properties:
 - led-sources:		List of enabled channels from 0 to 5.
 			See Documentation/devicetree/bindings/leds/common.txt
 
-- arc,led-config-0:	setting for register ILED_CONFIG_0
-- arc,led-config-1:	setting for register ILED_CONFIG_1
-- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used)
-- arc,comp-config:	setting for register CONFIG_COMP
-- arc,filter-config:	setting for register FILTER_CONFIG
-- arc,trim-config:	setting for register IMAXTUNE
+- arctic,led-config-0:	setting for register ILED_CONFIG_0
+- arctic,led-config-1:	setting for register ILED_CONFIG_1
+- arctic,dim-freq:	PWM mode frequence setting (bits [3:0] used)
+- arctic,comp-config:	setting for register CONFIG_COMP
+- arctic,filter-config:	setting for register FILTER_CONFIG
+- arctic,trim-config:	setting for register IMAXTUNE
+- arc,led-config-0:	setting for register ILED_CONFIG_0 (deprecated)
+- arc,led-config-1:	setting for register ILED_CONFIG_1 (deprecated)
+- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used) (deprecated)
+- arc,comp-config:	setting for register CONFIG_COMP (deprecated)
+- arc,filter-config:	setting for register FILTER_CONFIG (deprecated)
+- arc,trim-config:	setting for register IMAXTUNE (deprecated)
 
 Note: Optional properties not specified will default to values in IC EPROM
 
 Example:
 
 arc2c0608@30 {
-	compatible = "arc,arc2c0608";
+	compatible = "arctic,arc2c0608";
 	reg = <0x30>;
 	default-brightness = <500>;
 	label = "lcd-backlight";
Signature · 1 line
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

Quoted 5 lines · Daniel Thompson
Quoted 2 lines

[PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

The "v2" is normally applied to the whole patchset (if you prepare the patchset using git format-patch then you can use the --subject-prefix argument for that).

Sorry and noted

Quoted 35 lines · Brian Dodge
Quoted 16 lines

The vendor-prefixes.txt file properly refers to ArcticSand as arctic but the driver bindings improperly abbreviated the prefix to arc. This was a mistake in the original patch. This patch adds "arctic" and retains "arc" (deprecated) bindings

---
  .../bindings/leds/backlight/arcxcnn_bl.txt         | 31 +++++++++++++++-------
  1 file changed, 21 insertions(+), 10 deletions(-)
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +0 -1
index 230abde..4d98394 100644
@@ -1,8 +1,13 @@
-Binding for ArcticSand arc2c0608 LED driver

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt line 8

Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +6 -2
+Binding for ArcticSand arc family LED drivers
 
  Required properties:
-- compatible:		should be "arc,arc2c0608"
-- reg:			slave address
+- compatible: one of
+	"arctic,arc1c0608"
+	"arctic,arc2c0608"
+	"arctic,arc3c0845"
+	"arc,arc2c0608" (deprecated)

Nothing wrong with adding compatible strings for arc1 and arc3 but I would expect it to be mentioned in the description to reassure reviewers that the right depth of thought has been applied Something like "Also added compatible strings for other family members, all the existing optional properties work the same way for the new devices." (if you agree that it is true) is good to show you were paying proper attention!

Quoted 6 lines

However this does perhaps verge a little towards nitpicking so maybe wait to see what the DT folks say. From my point of view:

Daniel.

Good point. I did actually think about this a bit. The *only* chip available at the time of the original driver was the arc2c0608 and that is the chip that is currently in use in the Samsung Chromebook Plus, and the only use I know of using the "arc" prefix. There will be no reason to ever support "arc,arc1.." or "arc,arc3..." in the bindings for past or future use.

The new two chips are just basically supported by this driver. There is more functionality to them which will be enabled in my next patch. I wanted to separate the move to "arctic" from the move to fully support the other chips for clarity (you guys are all rightly picky!) I did put the new chip bindings in the driver/bindings in this patch though so I could test this patch against the actual h/w instances: I have three boards, one with each chip type and each has a dtb with the "arctic,.." type binding onboard.

Quoted 32 lines
Quoted 32 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +14 -6
+
+- reg:		slave address
 
  Optional properties:
  - default-brightness:	brightness value on boot, value from: 0-4095
@@ -11,19 +16,25 @@ Optional properties:
  - led-sources:		List of enabled channels from 0 to 5.
  			See Documentation/devicetree/bindings/leds/common.txt
 
-- arc,led-config-0:	setting for register ILED_CONFIG_0
-- arc,led-config-1:	setting for register ILED_CONFIG_1
-- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used)
-- arc,comp-config:	setting for register CONFIG_COMP
-- arc,filter-config:	setting for register FILTER_CONFIG
-- arc,trim-config:	setting for register IMAXTUNE
+- arctic,led-config-0:	setting for register ILED_CONFIG_0
+- arctic,led-config-1:	setting for register ILED_CONFIG_1
+- arctic,dim-freq:	PWM mode frequence setting (bits [3:0] used)
+- arctic,comp-config:	setting for register CONFIG_COMP
+- arctic,filter-config:	setting for register FILTER_CONFIG
+- arctic,trim-config:	setting for register IMAXTUNE
+- arc,led-config-0:	setting for register ILED_CONFIG_0 (deprecated)
+- arc,led-config-1:	setting for register ILED_CONFIG_1 (deprecated)
+- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used) (deprecated)
+- arc,comp-config:	setting for register CONFIG_COMP (deprecated)
+- arc,filter-config:	setting for register FILTER_CONFIG (deprecated)
+- arc,trim-config:	setting for register IMAXTUNE (deprecated)
 
  Note: Optional properties not specified will default to values in IC EPROM
 
  Example:
 
Quoted 9 lines
Quoted 9 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +1 -1
  arc2c0608@30 {
-	compatible = "arc,arc2c0608";
+	compatible = "arctic,arc2c0608";
  	reg = <0x30>;
  	default-brightness = <500>;
  	label = "lcd-backlight";
Signature · 1 line
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

Quoted 55 lines · Brian Dodge
Quoted 5 lines · Daniel Thompson
Quoted 2 lines

[PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

The "v2" is normally applied to the whole patchset (if you prepare the patchset using git format-patch then you can use the --subject-prefix argument for that).

Sorry and noted

Quoted 34 lines · Brian Dodge
Quoted 15 lines

The vendor-prefixes.txt file properly refers to ArcticSand as arctic but the driver bindings improperly abbreviated the prefix to arc. This was a mistake in the original patch. This patch adds "arctic" and retains "arc" (deprecated) bindings

---
  .../bindings/leds/backlight/arcxcnn_bl.txt         | 31 +++++++++++++++-------
  1 file changed, 21 insertions(+), 10 deletions(-)
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +0 -0
index 230abde..4d98394 100644

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt line 7

Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +6 -3
@@ -1,8 +1,13 @@
-Binding for ArcticSand arc2c0608 LED driver
+Binding for ArcticSand arc family LED drivers
  Required properties:
-- compatible:		should be "arc,arc2c0608"
-- reg:			slave address
+- compatible: one of
+	"arctic,arc1c0608"
+	"arctic,arc2c0608"
+	"arctic,arc3c0845"
+	"arc,arc2c0608" (deprecated)

Nothing wrong with adding compatible strings for arc1 and arc3 but I would expect it to be mentioned in the description to reassure reviewers that the right depth of thought has been applied Something like "Also added compatible strings for other family members, all the existing optional properties work the same way for the new devices." (if you agree that it is true) is good to show you were paying proper attention!

Quoted 6 lines

However this does perhaps verge a little towards nitpicking so maybe wait to see what the DT folks say. From my point of view:

Daniel.

Good point. I did actually think about this a bit. The *only* chip available at the time of the original driver was the arc2c0608 and that is the chip that is currently in use in the Samsung Chromebook Plus, and the only use I know of using the "arc" prefix. There will be no reason to ever support "arc,arc1.." or "arc,arc3..." in the bindings for past or future use.

Quoted 7 lines

The new two chips are just basically supported by this driver. There is more functionality to them which will be enabled in my next patch. I wanted to separate the move to "arctic" from the move to fully support the other chips for clarity (you guys are all rightly picky!) I did put the new chip bindings in the driver/bindings in this patch though so I could test this patch against the actual h/w instances: I have three boards, one with each chip type and each has a dtb with the "arctic,.." type binding onboard.

I think you have misunderstood. I've got no problem with renaming the properties as well.

What I was bringing up is that you have extended the scope of the bindings to cover the arc1 and arc3 devices. It would be good for you to explicitly confirm that the existing properties all still apply to arc1 and arc3 devices, and that no new properties are needed to model them properly.

As it happens I *did* glance at your old arc1/arc3 patch to check it for myself before I offered you the Acked-by and didn't see anything that offended me. However a good patch description would have spared me that work...

Daniel.

Quoted 29 lines
Quoted 29 lines
Quoted 29 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +14 -6
+
+- reg:		slave address
  Optional properties:
  - default-brightness:	brightness value on boot, value from: 0-4095
@@ -11,19 +16,25 @@ Optional properties:
  - led-sources:		List of enabled channels from 0 to 5.
  			See Documentation/devicetree/bindings/leds/common.txt
-- arc,led-config-0:	setting for register ILED_CONFIG_0
-- arc,led-config-1:	setting for register ILED_CONFIG_1
-- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used)
-- arc,comp-config:	setting for register CONFIG_COMP
-- arc,filter-config:	setting for register FILTER_CONFIG
-- arc,trim-config:	setting for register IMAXTUNE
+- arctic,led-config-0:	setting for register ILED_CONFIG_0
+- arctic,led-config-1:	setting for register ILED_CONFIG_1
+- arctic,dim-freq:	PWM mode frequence setting (bits [3:0] used)
+- arctic,comp-config:	setting for register CONFIG_COMP
+- arctic,filter-config:	setting for register FILTER_CONFIG
+- arctic,trim-config:	setting for register IMAXTUNE
+- arc,led-config-0:	setting for register ILED_CONFIG_0 (deprecated)
+- arc,led-config-1:	setting for register ILED_CONFIG_1 (deprecated)
+- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used) (deprecated)
+- arc,comp-config:	setting for register CONFIG_COMP (deprecated)
+- arc,filter-config:	setting for register FILTER_CONFIG (deprecated)
+- arc,trim-config:	setting for register IMAXTUNE (deprecated)
  Note: Optional properties not specified will default to values in IC EPROM
  Example:
  arc2c0608@30 {
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +1 -1
-	compatible = "arc,arc2c0608";
+	compatible = "arctic,arc2c0608";
  	reg = <0x30>;
  	default-brightness = <500>;
  	label = "lcd-backlight";
Signature · 1 line
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by on v2 1/2
#5 lore raw

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

In reply to Brian Dodge

Brian

Quoted 54 lines · Brian Dodge

The vendor-prefixes.txt file properly refers to ArcticSand as arctic but the driver bindings improperly abbreviated the prefix to arc. This was a mistake in the original patch. This patch adds "arctic" and retains "arc" (deprecated) bindings

---
  .../bindings/leds/backlight/arcxcnn_bl.txt         | 31 +++++++++++++++-------
  1 file changed, 21 insertions(+), 10 deletions(-)
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +20 -9
index 230abde..4d98394 100644
@@ -1,8 +1,13 @@
-Binding for ArcticSand arc2c0608 LED driver
+Binding for ArcticSand arc family LED drivers
 
  Required properties:
-- compatible:		should be "arc,arc2c0608"
-- reg:			slave address
+- compatible: one of
+	"arctic,arc1c0608"
+	"arctic,arc2c0608"
+	"arctic,arc3c0845"
+	"arc,arc2c0608" (deprecated)
+
+- reg:		slave address
 
  Optional properties:
  - default-brightness:	brightness value on boot, value from: 0-4095
@@ -11,19 +16,25 @@ Optional properties:
  - led-sources:		List of enabled channels from 0 to 5.
  			See Documentation/devicetree/bindings/leds/common.txt
 
-- arc,led-config-0:	setting for register ILED_CONFIG_0
-- arc,led-config-1:	setting for register ILED_CONFIG_1
-- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used)
-- arc,comp-config:	setting for register CONFIG_COMP
-- arc,filter-config:	setting for register FILTER_CONFIG
-- arc,trim-config:	setting for register IMAXTUNE
+- arctic,led-config-0:	setting for register ILED_CONFIG_0
+- arctic,led-config-1:	setting for register ILED_CONFIG_1
+- arctic,dim-freq:	PWM mode frequence setting (bits [3:0] used)
+- arctic,comp-config:	setting for register CONFIG_COMP
+- arctic,filter-config:	setting for register FILTER_CONFIG
+- arctic,trim-config:	setting for register IMAXTUNE
+- arc,led-config-0:	setting for register ILED_CONFIG_0 (deprecated)
+- arc,led-config-1:	setting for register ILED_CONFIG_1 (deprecated)
+- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used) (deprecated)
+- arc,comp-config:	setting for register CONFIG_COMP (deprecated)
+- arc,filter-config:	setting for register FILTER_CONFIG (deprecated)
+- arc,trim-config:	setting for register IMAXTUNE (deprecated)
 

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt Optional properties: · line 40

Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +1 -1
  Note: Optional properties not specified will default to values in IC EPROM
 
  Example:
 
  arc2c0608@30 {
-	compatible = "arc,arc2c0608";
+	compatible = "arctic,arc2c0608";
  	reg = <0x30>;
  	default-brightness = <500>;
  	label = "lcd-backlight";

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

FYI: please note that pSemi's legal department has informed me that they do *not* want to keep the "ArcticSand" copyright notices and the single pSemi line is appropriate.

Quoted 77 lines · Dan Murphy

Brian

Quoted 8 lines · Brian Dodge

The vendor-prefixes.txt file properly refers to ArcticSand as arctic but the driver bindings improperly abbreviated the prefix to arc. This was a mistake in the original patch. This patch adds "arctic" and retains "arc" (deprecated) bindings

---
  .../bindings/leds/backlight/arcxcnn_bl.txt         | 31

+++++++++++++++-------

Quoted 3 lines
  1 file changed, 21 insertions(+), 10 deletions(-)

diff --git

a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt

Quoted 10 lines

index 230abde..4d98394 100644

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +1 -3
@@ -1,8 +1,13 @@
-Binding for ArcticSand arc2c0608 LED driver
+Binding for ArcticSand arc family LED drivers
 
  Required properties:
-- compatible:                should be "arc,arc2c0608"
-- reg:                       slave address

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt line 13

Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +7 -0
+- compatible: one of
+     "arctic,arc1c0608"
+     "arctic,arc2c0608"
+     "arctic,arc3c0845"
+     "arc,arc2c0608" (deprecated)
+
+- reg:               slave address
 
  Optional properties:
  - default-brightness:       brightness value on boot, value from:

0-4095

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt Optional properties: · line 17

Quoted 3 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +0 -0
@@ -11,19 +16,25 @@ Optional properties:
  - led-sources:              List of enabled channels from 0 to 5.
                      See

Documentation/devicetree/bindings/leds/common.txt

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt Optional properties:

Quoted 4 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +0 -3
-- arc,led-config-0:  setting for register ILED_CONFIG_0
-- arc,led-config-1:  setting for register ILED_CONFIG_1
-- arc,dim-freq:              PWM mode frequence setting (bits [3:0]

used)

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt Optional properties:

Quoted 12 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +9 -3
-- arc,comp-config:   setting for register CONFIG_COMP
-- arc,filter-config: setting for register FILTER_CONFIG
-- arc,trim-config:   setting for register IMAXTUNE
+- arctic,led-config-0:       setting for register ILED_CONFIG_0
+- arctic,led-config-1:       setting for register ILED_CONFIG_1
+- arctic,dim-freq:   PWM mode frequence setting (bits [3:0] used)
+- arctic,comp-config:        setting for register CONFIG_COMP
+- arctic,filter-config:      setting for register FILTER_CONFIG
+- arctic,trim-config:        setting for register IMAXTUNE
+- arc,led-config-0:  setting for register ILED_CONFIG_0 (deprecated)
+- arc,led-config-1:  setting for register ILED_CONFIG_1 (deprecated)
+- arc,dim-freq:              PWM mode frequence setting (bits [3:0]

used) (deprecated)

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt Optional properties:

Quoted 5 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +3 -0
+- arc,comp-config:   setting for register CONFIG_COMP (deprecated)
+- arc,filter-config: setting for register FILTER_CONFIG (deprecated)
+- arc,trim-config:   setting for register IMAXTUNE (deprecated)
 
  Note: Optional properties not specified will default to values in IC

EPROM

Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt Optional properties: · line 40

Quoted 9 lines
Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt +1 -1
  Example:
 
  arc2c0608@30 {
-     compatible = "arc,arc2c0608";
+     compatible = "arctic,arc2c0608";
      reg = <0x30>;
      default-brightness = <500>;
      label = "lcd-backlight";
Quoted 3 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#7 lore raw

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

Brian

Quoted 2 lines · Brian Dodge

FYI: please note that pSemi's legal department has informed me that they do *not* want to keep the "ArcticSand" copyright notices and the single pSemi line is appropriate.

Thanks for the follow up.  Lawyers can be fickle about this stuff.

Quoted 85 lines · On Mon, Jul 8, 2019 at 2:02 PM Dan Murphy <[email protected]…

Brian

On 6/30/19 7:28 PM, Brian Dodge wrote:
> The vendor-prefixes.txt file properly refers to ArcticSand > as arctic but the driver bindings improperly abbreviated the > prefix to arc. This was a mistake in the original patch. This > patch adds "arctic" and retains "arc" (deprecated) bindings >
> Signed-off-by: Brian Dodge <[email protected] <mailto:[email protected]>>
> ---
>   .../bindings/leds/backlight/arcxcnn_bl.txt         | 31
+++++++++++++++-------
>   1 file changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > index 230abde..4d98394 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > @@ -1,8 +1,13 @@
> -Binding for ArcticSand arc2c0608 LED driver
> +Binding for ArcticSand arc family LED drivers
>
>   Required properties:
> -- compatible:                should be "arc,arc2c0608" > -- reg:                       slave address
> +- compatible: one of
> +     "arctic,arc1c0608"
> +     "arctic,arc2c0608"
> +     "arctic,arc3c0845"
> +     "arc,arc2c0608" (deprecated)
> +
> +- reg:               slave address
>
>   Optional properties:
>   - default-brightness:       brightness value on boot, value
from: 0-4095
> @@ -11,19 +16,25 @@ Optional properties:
>   - led-sources:              List of enabled channels from 0 to 5. >                       See Documentation/devicetree/bindings/leds/common.txt
>
> -- arc,led-config-0:  setting for register ILED_CONFIG_0 > -- arc,led-config-1:  setting for register ILED_CONFIG_1 > -- arc,dim-freq:              PWM mode frequence setting (bits [3:0] used)
> -- arc,comp-config:   setting for register CONFIG_COMP > -- arc,filter-config: setting for register FILTER_CONFIG > -- arc,trim-config:   setting for register IMAXTUNE
> +- arctic,led-config-0:       setting for register ILED_CONFIG_0 > +- arctic,led-config-1:       setting for register ILED_CONFIG_1 > +- arctic,dim-freq:   PWM mode frequence setting (bits [3:0] used) > +- arctic,comp-config:        setting for register CONFIG_COMP > +- arctic,filter-config:      setting for register FILTER_CONFIG > +- arctic,trim-config:        setting for register IMAXTUNE > +- arc,led-config-0:  setting for register ILED_CONFIG_0 (deprecated)
> +- arc,led-config-1:  setting for register ILED_CONFIG_1 (deprecated)
> +- arc,dim-freq:              PWM mode frequence setting (bits [3:0] used) (deprecated)
> +- arc,comp-config:   setting for register CONFIG_COMP (deprecated) > +- arc,filter-config: setting for register FILTER_CONFIG (deprecated)
> +- arc,trim-config:   setting for register IMAXTUNE (deprecated) >
>   Note: Optional properties not specified will default to values in IC EPROM
>
>   Example:
>
>   arc2c0608@30 {
> -     compatible = "arc,arc2c0608";
> +     compatible = "arctic,arc2c0608";
>       reg = <0x30>;
>       default-brightness = <500>;
>       label = "lcd-backlight";

Quoted 2 lines
Reviewed-by Dan Murphy <[email protected] <mailto:[email protected]>>

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#8 lore raw

PATCH v2 2/2 backlight: arcxcnn: add "arctic" vendor prefix

In reply to Brian Dodge

The original patch adding this driver and DT bindings improperly used "arc" as the vendor-prefix. This adds "arctic" which is the proper prefix and retains "arc" to allow existing users of the "arc" prefix to update to new kernels. There is at least one (Samsung Chromebook Plus)

---
 drivers/video/backlight/arcxcnn_bl.c | 41 +++++++++++++++++++++++++++---------
 1 file changed, 31 insertions(+), 10 deletions(-)
drivers/video/backlight/arcxcnn_bl.c +31 -10
index 7b1c0a0..a419554 100644
@@ -1,9 +1,9 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * Backlight driver for ArcticSand ARC_X_C_0N_0N Devices
+ * Backlight driver for pSemi (formerly ArcticSand) ARC_X_C_0N_0N Devices
  *
- * Copyright 2016 ArcticSand, Inc.
- * Author : Brian Dodge <[email protected]>
+ * Copyright 2016-2019  pSemi, Inc.
+ * Author : Brian Dodge <[email protected]>
  */
 
 #include <linux/backlight.h>
@@ -191,27 +191,46 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)
 	if (ret == 0)
 		lp->pdata->initial_brightness = prog_val;
 
-	ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
+	ret = of_property_read_u32(node, "arctic,led-config-0", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
+
 	if (ret == 0)
 		lp->pdata->led_config_0 = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,led-config-1", &prog_val);
+	ret = of_property_read_u32(node, "arctic,led-config-1", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,led-config-1", &prog_val);
+
 	if (ret == 0)
 		lp->pdata->led_config_1 = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,dim-freq", &prog_val);
+	ret = of_property_read_u32(node, "arctic,dim-freq", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,dim-freq", &prog_val);
+
 	if (ret == 0)
 		lp->pdata->dim_freq = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,comp-config", &prog_val);
+	ret = of_property_read_u32(node, "arctic,comp-config", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,comp-config", &prog_val);
+
 	if (ret == 0)
 		lp->pdata->comp_config = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,filter-config", &prog_val);
+	ret = of_property_read_u32(node, "arctic,filter-config", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node,
+				"arc,filter-config", &prog_val);
+
 	if (ret == 0)
 		lp->pdata->filter_config = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,trim-config", &prog_val);
+	ret = of_property_read_u32(node, "arctic,trim-config", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,trim-config", &prog_val);
+
 	if (ret == 0)
 		lp->pdata->trim_config = (u8)prog_val;
 
@@ -381,6 +400,8 @@ static int arcxcnn_remove(struct i2c_client *cl)
 }
 
 static const struct of_device_id arcxcnn_dt_ids[] = {
+	{ .compatible = "arctic,arc2c0608" },
+	/* here to remain compatible with an older binding, do not use */
 	{ .compatible = "arc,arc2c0608" },
 	{ }
 };
@@ -404,5 +425,5 @@ static struct i2c_driver arcxcnn_driver = {
 module_i2c_driver(arcxcnn_driver);
 
 MODULE_LICENSE("GPL v2");
-MODULE_AUTHOR("Brian Dodge <[email protected]>");
+MODULE_AUTHOR("Brian Dodge <[email protected]>");
 MODULE_DESCRIPTION("ARCXCNN Backlight driver");
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#9 lore raw

Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix

Quoted 8 lines · Brian Dodge

The original patch adding this driver and DT bindings improperly used "arc" as the vendor-prefix. This adds "arctic" which is the proper prefix and retains "arc" to allow existing users of the "arc" prefix to update to new kernels. There is at least one (Samsung Chromebook Plus)

ack.

Signature · 6 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v2 2/2
#10 lore raw

Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix

In reply to Brian Dodge

Brian

Quoted 17 lines · Brian Dodge

The original patch adding this driver and DT bindings improperly used "arc" as the vendor-prefix. This adds "arctic" which is the proper prefix and retains "arc" to allow existing users of the "arc" prefix to update to new kernels. There is at least one (Samsung Chromebook Plus)

---
  drivers/video/backlight/arcxcnn_bl.c | 41 +++++++++++++++++++++++++++---------
  1 file changed, 31 insertions(+), 10 deletions(-)
drivers/video/backlight/arcxcnn_bl.c +0 -0
index 7b1c0a0..a419554 100644

drivers/video/backlight/arcxcnn_bl.c line 6

Quoted 7 lines
drivers/video/backlight/arcxcnn_bl.c +1 -3
@@ -1,9 +1,9 @@
  // SPDX-License-Identifier: GPL-2.0-only
  /*
- * Backlight driver for ArcticSand ARC_X_C_0N_0N Devices
+ * Backlight driver for pSemi (formerly ArcticSand) ARC_X_C_0N_0N Devices
   *
- * Copyright 2016 ArcticSand, Inc.
- * Author : Brian Dodge <[email protected]>

I know you are the original author from ArcticSand but did pSemi actually own the copyright in 2016?

I don't think this is a big issue just wondering if we should retain the ArcticSand copyright as well.

Probably a question for your legal department.

Otherwise

Quoted 68 lines
drivers/video/backlight/arcxcnn_bl.c +29 -6
+ * Copyright 2016-2019  pSemi, Inc.
+ * Author : Brian Dodge <[email protected]>
   */
 
  #include <linux/backlight.h>
@@ -191,27 +191,46 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)
  	if (ret == 0)
  		lp->pdata->initial_brightness = prog_val;
 
-	ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
+	ret = of_property_read_u32(node, "arctic,led-config-0", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
+
  	if (ret == 0)
  		lp->pdata->led_config_0 = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,led-config-1", &prog_val);
+	ret = of_property_read_u32(node, "arctic,led-config-1", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,led-config-1", &prog_val);
+
  	if (ret == 0)
  		lp->pdata->led_config_1 = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,dim-freq", &prog_val);
+	ret = of_property_read_u32(node, "arctic,dim-freq", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,dim-freq", &prog_val);
+
  	if (ret == 0)
  		lp->pdata->dim_freq = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,comp-config", &prog_val);
+	ret = of_property_read_u32(node, "arctic,comp-config", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,comp-config", &prog_val);
+
  	if (ret == 0)
  		lp->pdata->comp_config = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,filter-config", &prog_val);
+	ret = of_property_read_u32(node, "arctic,filter-config", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node,
+				"arc,filter-config", &prog_val);
+
  	if (ret == 0)
  		lp->pdata->filter_config = (u8)prog_val;
 
-	ret = of_property_read_u32(node, "arc,trim-config", &prog_val);
+	ret = of_property_read_u32(node, "arctic,trim-config", &prog_val);
+	if (ret)
+		ret = of_property_read_u32(node, "arc,trim-config", &prog_val);
+
  	if (ret == 0)
  		lp->pdata->trim_config = (u8)prog_val;
 
@@ -381,6 +400,8 @@ static int arcxcnn_remove(struct i2c_client *cl)
  }
 
  static const struct of_device_id arcxcnn_dt_ids[] = {
+	{ .compatible = "arctic,arc2c0608" },
+	/* here to remain compatible with an older binding, do not use */
  	{ .compatible = "arc,arc2c0608" },
  	{ }
  };

drivers/video/backlight/arcxcnn_bl.c static struct i2c_driver arcxcnn_driver = { · line 429

Quoted 6 lines
drivers/video/backlight/arcxcnn_bl.c +1 -1
@@ -404,5 +425,5 @@ static struct i2c_driver arcxcnn_driver = {
  module_i2c_driver(arcxcnn_driver);
 
  MODULE_LICENSE("GPL v2");
-MODULE_AUTHOR("Brian Dodge <[email protected]>");
+MODULE_AUTHOR("Brian Dodge <[email protected]>");
  MODULE_DESCRIPTION("ARCXCNN Backlight driver");

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#11 lore raw

Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix

Thanks. pSemi purchased ArcticSand a few years ago so they are the same legal entity. I will ask them if they want to retain the original copyright notice

Quoted 119 lines · Dan Murphy

Brian

Quoted 10 lines · Brian Dodge

The original patch adding this driver and DT bindings improperly used "arc" as the vendor-prefix. This adds "arctic" which is the proper prefix and retains "arc" to allow existing users of the "arc" prefix to update to new kernels. There is at least one (Samsung Chromebook Plus)

---
  drivers/video/backlight/arcxcnn_bl.c | 41

+++++++++++++++++++++++++++---------

Review

Quoted 3 lines
  1 file changed, 31 insertions(+), 10 deletions(-)
(quoted diff) +0 -0

b/drivers/video/backlight/arcxcnn_bl.c

drivers/video/backlight/arcxcnn_bl.c line 3

Quoted 8 lines

index 7b1c0a0..a419554 100644

drivers/video/backlight/arcxcnn_bl.c +1 -1
@@ -1,9 +1,9 @@
  // SPDX-License-Identifier: GPL-2.0-only
  /*
- * Backlight driver for ArcticSand ARC_X_C_0N_0N Devices
+ * Backlight driver for pSemi (formerly ArcticSand) ARC_X_C_0N_0N

Devices

drivers/video/backlight/arcxcnn_bl.c line 6

Quoted 3 lines
drivers/video/backlight/arcxcnn_bl.c +0 -2
   *
- * Copyright 2016 ArcticSand, Inc.
- * Author : Brian Dodge <[email protected]>

I know you are the original author from ArcticSand but did pSemi actually own the copyright in 2016?

I don't think this is a big issue just wondering if we should retain the ArcticSand copyright as well.

Probably a question for your legal department.

Otherwise

drivers/video/backlight/arcxcnn_bl.c static void arcxcnn_parse_dt(struct arcxcnn *lp) · line 196

Quoted 13 lines
drivers/video/backlight/arcxcnn_bl.c +5 -1
+ * Copyright 2016-2019  pSemi, Inc.
+ * Author : Brian Dodge <[email protected]>
   */
 
  #include <linux/backlight.h>
@@ -191,27 +191,46 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)
      if (ret == 0)
              lp->pdata->initial_brightness = prog_val;
 
-     ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
+     ret = of_property_read_u32(node, "arctic,led-config-0", &prog_val);
+     if (ret)
+             ret = of_property_read_u32(node, "arc,led-config-0",

&prog_val);

drivers/video/backlight/arcxcnn_bl.c static void arcxcnn_parse_dt(struct arcxcnn *lp)

Quoted 8 lines
drivers/video/backlight/arcxcnn_bl.c +4 -1
+
      if (ret == 0)
              lp->pdata->led_config_0 = (u8)prog_val;
 
-     ret = of_property_read_u32(node, "arc,led-config-1", &prog_val);
+     ret = of_property_read_u32(node, "arctic,led-config-1", &prog_val);
+     if (ret)
+             ret = of_property_read_u32(node, "arc,led-config-1",

&prog_val);

drivers/video/backlight/arcxcnn_bl.c static void arcxcnn_parse_dt(struct arcxcnn *lp)

Quoted 8 lines
drivers/video/backlight/arcxcnn_bl.c +4 -1
+
      if (ret == 0)
              lp->pdata->led_config_1 = (u8)prog_val;
 
-     ret = of_property_read_u32(node, "arc,dim-freq", &prog_val);
+     ret = of_property_read_u32(node, "arctic,dim-freq", &prog_val);
+     if (ret)
+             ret = of_property_read_u32(node, "arc,dim-freq",

&prog_val);

drivers/video/backlight/arcxcnn_bl.c static void arcxcnn_parse_dt(struct arcxcnn *lp)

Quoted 8 lines
drivers/video/backlight/arcxcnn_bl.c +4 -1
+
      if (ret == 0)
              lp->pdata->dim_freq = (u8)prog_val;
 
-     ret = of_property_read_u32(node, "arc,comp-config", &prog_val);
+     ret = of_property_read_u32(node, "arctic,comp-config", &prog_val);
+     if (ret)
+             ret = of_property_read_u32(node, "arc,comp-config",

&prog_val);

drivers/video/backlight/arcxcnn_bl.c static void arcxcnn_parse_dt(struct arcxcnn *lp)

Quoted 6 lines
drivers/video/backlight/arcxcnn_bl.c +2 -1
+
      if (ret == 0)
              lp->pdata->comp_config = (u8)prog_val;
 
-     ret = of_property_read_u32(node, "arc,filter-config", &prog_val);
+     ret = of_property_read_u32(node, "arctic,filter-config",

&prog_val);

drivers/video/backlight/arcxcnn_bl.c static void arcxcnn_parse_dt(struct arcxcnn *lp)

Quoted 11 lines
drivers/video/backlight/arcxcnn_bl.c +7 -1
+     if (ret)
+             ret = of_property_read_u32(node,
+                             "arc,filter-config", &prog_val);
+
      if (ret == 0)
              lp->pdata->filter_config = (u8)prog_val;
 
-     ret = of_property_read_u32(node, "arc,trim-config", &prog_val);
+     ret = of_property_read_u32(node, "arctic,trim-config", &prog_val);
+     if (ret)
+             ret = of_property_read_u32(node, "arc,trim-config",

&prog_val);

Quoted 16 lines
drivers/video/backlight/arcxcnn_bl.c +3 -0
+
      if (ret == 0)
              lp->pdata->trim_config = (u8)prog_val;
 
@@ -381,6 +400,8 @@ static int arcxcnn_remove(struct i2c_client *cl)
  }
 
  static const struct of_device_id arcxcnn_dt_ids[] = {
+     { .compatible = "arctic,arc2c0608" },
+     /* here to remain compatible with an older binding, do not use */
      { .compatible = "arc,arc2c0608" },
      { }
  };
@@ -404,5 +425,5 @@ static struct i2c_driver arcxcnn_driver = {
  module_i2c_driver(arcxcnn_driver);
 
Quoted 5 lines

drivers/video/backlight/arcxcnn_bl.c static struct i2c_driver arcxcnn_driver = { · line 429

Quoted 4 lines
drivers/video/backlight/arcxcnn_bl.c +1 -1
  MODULE_LICENSE("GPL v2");
-MODULE_AUTHOR("Brian Dodge <[email protected]>");
+MODULE_AUTHOR("Brian Dodge <[email protected]>");
  MODULE_DESCRIPTION("ARCXCNN Backlight driver");

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel