mm/page_isolate: change the prototype of undo_isolate_page_range()
Subsystems (3)
PATCH 1/1 mm/page_isolate: change the prototype of undo_isolate_page_range()
undo_isolate_page_range() never fails, so no need to return value.
Signed-off-by Pingfan Liu <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Oscar Salvador <[email protected]>
Cc Qian Cai <[email protected]>
Cc Anshuman Khandual <[email protected]>
--- include/linux/page-isolation.h | 2 +- mm/page_isolation.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
include/linux/page-isolation.h +1 -1
@@ -50,7 +50,7 @@ start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,* Changes MIGRATE_ISOLATE to MIGRATE_MOVABLE. * target range is [start_pfn, end_pfn) */ -int +void undo_isolate_page_range (unsigned long start_pfn,unsigned long end_pfn,unsigned migratetype);
mm/page_isolation.c +1 -2
@@ -230,7 +230,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,/* * Make isolated pages available again. */ -int undo_isolate_page_range (unsigned long start_pfn,unsigned long end_pfn, +void undo_isolate_page_range (unsigned long start_pfn,unsigned long end_pfn,unsigned migratetype) {unsigned long pfn;
@@ -247,7 +247,6 @@ int undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,continue ;unset_migratetype_isolate (page, migratetype); } -return 0 ; }/* * Test all pages in the range is free(means isolated) or not.
Signature · 1 line
2.7.5
Quoted 9 lines · Pingfan Liu
undo_isolate_page_range()never fails, so no need to return value.Signed-off-by Pingfan Liu <[email protected]>Cc Andrew Morton <[email protected]>Cc Michal Hocko <[email protected]>Cc Oscar Salvador <[email protected]>Cc Qian Cai <[email protected]>Cc Anshuman Khandual <[email protected]>
Acked-by Michal Hocko <[email protected]>
Quoted 41 lines
--- include/linux/page-isolation.h | 2 +- mm/page_isolation.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)include/linux/page-isolation.h +1
-1@@ -50,7 +50,7 @@ start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,* Changes MIGRATE_ISOLATE to MIGRATE_MOVABLE. * target range is [start_pfn, end_pfn) */ -int +void undo_isolate_page_range (unsigned long start_pfn,unsigned long end_pfn,unsigned migratetype);mm/page_isolation.c +1
-2@@ -230,7 +230,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,/* * Make isolated pages available again. */ -int undo_isolate_page_range (unsigned long start_pfn,unsigned long end_pfn, +void undo_isolate_page_range (unsigned long start_pfn,unsigned long end_pfn,unsigned migratetype) {unsigned long pfn;@@ -247,7 +247,6 @@ int undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,continue ;unset_migratetype_isolate (page, migratetype); } -return 0 ; }/* * Test all pages in the range is free(means isolated) or not. Signature · 1 line
2.7.5
Signature · 2 lines
Michal Hocko SUSE Labs
Quoted 1 line · Pingfan Liu
undo_isolate_page_range()never fails, so no need to return value.
Heh, this goes back to 2007.
Quoted 8 lines
Signed-off-by Pingfan Liu <[email protected]>Cc Andrew Morton <[email protected]>Cc Michal Hocko <[email protected]>Cc Oscar Salvador <[email protected]>Cc Qian Cai <[email protected]>Cc Anshuman Khandual <[email protected]>
Reviewed-by Oscar Salvador <[email protected]>
Signature · 2 lines
Oscar Salvador SUSE L3
Quoted 9 lines · Pingfan Liu
undo_isolate_page_range()never fails, so no need to return value.Signed-off-by Pingfan Liu <[email protected]>Cc Andrew Morton <[email protected]>Cc Michal Hocko <[email protected]>Cc Oscar Salvador <[email protected]>Cc Qian Cai <[email protected]>Cc Anshuman Khandual <[email protected]>
Reviewed-by Anshuman Khandual <[email protected]>