Skip to contentSkip to conversation

patch "coresight: Potential uninitialized variable in probe()" added to char-misc-next

PATCH [email protected] 1 participant 1 message Jul 4, 2019

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

coresight: Potential uninitialized variable in probe()

to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-next branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will also be merged in the next major kernel release during the merge window.

If you have any questions about this process, please let me know.

From 0530ef6b41e80c5cc979e0e50682302161edb6b7 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <[email protected]>
Date: Thu, 20 Jun 2019 16:12:37 -0600
Subject: coresight: Potential uninitialized variable in probe()

The "drvdata->atclk" clock is optional, but if it gets set to an error pointer then we're accidentally return an uninitialized variable instead of success.

Fixes 78e6427b4e7b ("coresight: funnel: Support static funnel")
Cc stable <[email protected]>
---
 drivers/hwtracing/coresight/coresight-funnel.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hwtracing/coresight/coresight-funnel.c +1 -0
index 5867fcb4503b..fa97cb9ab4f9 100644
@@ -244,6 +244,7 @@ static int funnel_probe(struct device *dev, struct resource *res)
 	}
 
 	pm_runtime_put(dev);
+	ret = 0;
 
 out_disable_clk:
 	if (ret && !IS_ERR_OR_NULL(drvdata->atclk))
Signature · 1 line
2.22.0