Skip to contentSkip to conversation

usb: host: xhci-hub: fix extra endianness conversion

PATCH New Ruslan Bilovol 1 participant 1 message Jul 7, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: host: xhci-hub: fix extra endianness conversion

Don't do extra cpu_to_le32 conversion for put_unaligned_le32 because it is already implemented in this function.

Fixes sparse error:
xhci-hub.c:1152:44: warning: incorrect type in argument 1 (different base types)
xhci-hub.c:1152:44: expected unsigned int [usertype] val
xhci-hub.c:1152:44: got restricted __le32 [usertype]

Fixes 395f540 "xhci: support new USB 3.1 hub request to get extended port status"
Cc Mathias Nyman <[email protected]>
---
 drivers/usb/host/xhci-hub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/xhci-hub.c +1 -1
index 3abe70f..b7d23c4 100644
@@ -1149,7 +1149,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
 			}
 			port_li = readl(ports[wIndex]->addr + PORTLI);
 			status = xhci_get_ext_port_status(temp, port_li);
-			put_unaligned_le32(cpu_to_le32(status), &buf[4]);
+			put_unaligned_le32(status, &buf[4]);
 		}
 		break;
 	case SetPortFeature:
Signature · 1 line
1.9.1