video: fbdev: nvidia: Remove dead code
PATCH 1/1 video: fbdev: nvidia: Remove dead code
This is dead code since 3.15. If there is no plan to use it further, this can be removed forever.
Signed-off-by Souptick Joarder <[email protected]>
--- drivers/video/fbdev/nvidia/nv_setup.c | 24 ------------------------ 1 file changed, 24 deletions(-)
drivers/video/fbdev/nvidia/nv_setup.c +0 -24
@@ -119,34 +119,10 @@ u8 NVReadMiscOut(struct nvidia_par *par) {return (VGA_RD08 (par->PVIO,VGA_MIS_R )); } -#if 0 -void NVEnablePalette (struct nvidia_par *par) -{ -volatile u8 tmp; - - tmp =VGA_RD08 (par->PCIO, par->IOBase +0x0a ); -VGA_WR08 (par->PCIO,VGA_ATT_IW ,0x00 ); - par->paletteEnabled =1 ; -} -void NVDisablePalette (struct nvidia_par *par) -{ -volatile u8 tmp; - - tmp =VGA_RD08 (par->PCIO, par->IOBase +0x0a ); -VGA_WR08 (par->PCIO,VGA_ATT_IW ,0x20 ); - par->paletteEnabled =0 ; -} -#endif /* 0 */ void NVWriteDacMask (struct nvidia_par *par,u8 value) {VGA_WR08 (par->PDIO,VGA_PEL_MSK , value); } -#if 0 -u8 NVReadDacMask (struct nvidia_par *par) -{ -return (VGA_RD08 (par->PDIO,VGA_PEL_MSK )); -} -#endif /* 0 */ void NVWriteDacReadAddr (struct nvidia_par *par,u8 value) {VGA_WR08 (par->PDIO,VGA_PEL_IR , value);
Signature · 1 line
1.9.1
Quoted 3 lines · Souptick Joarder
This is dead code since 3.15. If there is no plan to use it further, this can be removed forever.
Any comment on this patch ?
Quoted 48 lines
Signed-off-by Souptick Joarder <[email protected]>--- drivers/video/fbdev/nvidia/nv_setup.c | 24 ------------------------ 1 file changed, 24 deletions(-)drivers/video/fbdev/nvidia/nv_setup.c +0
-25@@ -119,34 +119,10 @@ u8 NVReadMiscOut(struct nvidia_par *par) {return (VGA_RD08 (par->PVIO,VGA_MIS_R )); } -#if 0 -void NVEnablePalette (struct nvidia_par *par) -{ -volatile u8 tmp; - - tmp =VGA_RD08 (par->PCIO, par->IOBase +0x0a ); -VGA_WR08 (par->PCIO,VGA_ATT_IW ,0x00 ); - par->paletteEnabled =1 ; -} -void NVDisablePalette (struct nvidia_par *par) -{ -volatile u8 tmp; - - tmp =VGA_RD08 (par->PCIO, par->IOBase +0x0a ); -VGA_WR08 (par->PCIO,VGA_ATT_IW ,0x20 ); - par->paletteEnabled =0 ; -} -#endif /* 0 */ void NVWriteDacMask (struct nvidia_par *par,u8 value) {VGA_WR08 (par->PDIO,VGA_PEL_MSK , value); } -#if 0 -u8 NVReadDacMask (struct nvidia_par *par) -{ -return (VGA_RD08 (par->PDIO,VGA_PEL_MSK )); -} -#endif /* 0 */ void NVWriteDacReadAddr (struct nvidia_par *par,u8 value) {VGA_WR08 (par->PDIO,VGA_PEL_IR , value); --1.9.1
Quoted 9 lines · Souptick Joarder
Quoted 3 lines · Souptick Joarder
This is dead code since 3.15. If there is no plan to use it further, this can be removed forever.
Any comment on this patch ?
Quoted 2 lines
Signed-off-by Souptick Joarder <[email protected]>
Patch queued for v5.4, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics