mm: vmscan: check if mem cgroup is disabled or not before calling memcg slab shrinker
Subsystems (4)
PATCH 1/1 mm: vmscan: check if mem cgroup is disabled or not before calling memcg slab shrinker
Shakeel Butt reported premature oom on kernel with "cgroup_disable=memory" since mem_cgroup_is_root() returns false even though memcg is actually NULL. The drop_caches is also broken.
It is because commit aeed1d325d42 ("mm/vmscan.c: generalize shrink_slab() calls in shrink_node()") removed the !memcg check before !mem_cgroup_is_root(). And, surprisingly root memcg is allocated even though memory cgroup is disabled by kernel boot parameter.
Add mem_cgroup_disabled() check to make reclaimer work as expected.
--- mm/vmscan.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
mm/vmscan.c +8 -1
@@ -684,7 +684,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,unsigned long ret, freed =0 ;struct shrinker *shrinker; -if (!mem_cgroup_is_root (memcg)) +/* +* The root memcg might be allocated even though memcg is disabled +* via "cgroup_disable=memory" boot parameter. This could make +* mem_cgroup_is_root() return false, then just run memcg slab +* shrink, but skip global shrink. This may result in premature +* oom. +*/ +if (!mem_cgroup_disabled () && !mem_cgroup_is_root (memcg))return shrink_slab_memcg (gfp_mask, nid, memcg, priority);if (!down_read_trylock (&shrinker_rwsem))
Signature · 1 line
1.8.3.1
Quoted 12 lines · Yang Shi
Shakeel Butt reported premature oom on kernel with "cgroup_disable=memory" since
mem_cgroup_is_root()returns false even though memcg is actually NULL. Thedrop_cachesis also broken.It is because commit
aeed1d325d42("mm/vmscan.c: generalizeshrink_slab()calls inshrink_node()") removed the !memcg check before !mem_cgroup_is_root(). And, surprisingly root memcg is allocated even though memory cgroup is disabled by kernel boot parameter.Add
mem_cgroup_disabled()check to make reclaimer work as expected.
Quoted 12 lines
Fixes aeed1d325d42 ("mm/vmscan.c: generalize shrink_slab() calls in shrink_node()")Reported-by Shakeel Butt <[email protected]>Cc Vladimir Davydov <[email protected]>Cc Johannes Weiner <[email protected]>Cc Michal Hocko <[email protected]>Cc Kirill Tkhai <[email protected]>Cc Roman Gushchin <[email protected]>Cc Hugh Dickins <[email protected]>Cc Qian Cai <[email protected]>Cc Kirill A. Shutemov <[email protected]>Cc [email protected] 4.19+Signed-off-by Yang Shi <[email protected]>
Quoted 27 lines
--- mm/vmscan.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)mm/vmscan.c +8
-2@@ -684,7 +684,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,unsigned long ret, freed =0 ;struct shrinker *shrinker; -if (!mem_cgroup_is_root (memcg)) +/* +* The root memcg might be allocated even though memcg is disabled +* via "cgroup_disable=memory" boot parameter. This could make +* mem_cgroup_is_root() return false, then just run memcg slab +* shrink, but skip global shrink. This may result in premature +* oom. +*/ +if (!mem_cgroup_disabled () && !mem_cgroup_is_root (memcg))return shrink_slab_memcg (gfp_mask, nid, memcg, priority);if (!down_read_trylock (&shrinker_rwsem)) --1.8.3.1
Quoted 11 lines · Yang Shi
Shakeel Butt reported premature oom on kernel with "cgroup_disable=memory" since
mem_cgroup_is_root()returns false even though memcg is actually NULL. Thedrop_cachesis also broken.It is because commit
aeed1d325d42("mm/vmscan.c: generalizeshrink_slab()calls inshrink_node()") removed the !memcg check before !mem_cgroup_is_root(). And, surprisingly root memcg is allocated even though memory cgroup is disabled by kernel boot parameter.Add
mem_cgroup_disabled()check to make reclaimer work as expected.
Quoted 12 lines
Fixes aeed1d325d42 ("mm/vmscan.c: generalize shrink_slab() calls in shrink_node()")Reported-by Shakeel Butt <[email protected]>Cc Vladimir Davydov <[email protected]>Cc Johannes Weiner <[email protected]>Cc Michal Hocko <[email protected]>Cc Kirill Tkhai <[email protected]>Cc Roman Gushchin <[email protected]>Cc Hugh Dickins <[email protected]>Cc Qian Cai <[email protected]>Cc Kirill A. Shutemov <[email protected]>Cc [email protected] 4.19+Signed-off-by Yang Shi <[email protected]>
Surprise really.
We have mem_cgroup as not early inited, so all of these boundary cases and checks has to be supported. But it looks like it's not possible to avoid that in any way.
Quoted 25 lines
--- mm/vmscan.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)mm/vmscan.c +8
-1@@ -684,7 +684,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,unsigned long ret, freed =0 ;struct shrinker *shrinker; -if (!mem_cgroup_is_root (memcg)) +/* +* The root memcg might be allocated even though memcg is disabled +* via "cgroup_disable=memory" boot parameter. This could make +* mem_cgroup_is_root() return false, then just run memcg slab +* shrink, but skip global shrink. This may result in premature +* oom. +*/ +if (!mem_cgroup_disabled () && !mem_cgroup_is_root (memcg))return shrink_slab_memcg (gfp_mask, nid, memcg, priority);if (!down_read_trylock (&shrinker_rwsem))
Quoted 11 lines · Yang Shi
Shakeel Butt reported premature oom on kernel with "cgroup_disable=memory" since
mem_cgroup_is_root()returns false even though memcg is actually NULL. Thedrop_cachesis also broken.It is because commit
aeed1d325d42("mm/vmscan.c: generalizeshrink_slab()calls inshrink_node()") removed the !memcg check before !mem_cgroup_is_root(). And, surprisingly root memcg is allocated even though memory cgroup is disabled by kernel boot parameter.Add
mem_cgroup_disabled()check to make reclaimer work as expected.
Quoted 12 lines
Fixes aeed1d325d42 ("mm/vmscan.c: generalize shrink_slab() calls in shrink_node()")Reported-by Shakeel Butt <[email protected]>Cc Vladimir Davydov <[email protected]>Cc Johannes Weiner <[email protected]>Cc Michal Hocko <[email protected]>Cc Kirill Tkhai <[email protected]>Cc Roman Gushchin <[email protected]>Cc Hugh Dickins <[email protected]>Cc Qian Cai <[email protected]>Cc Kirill A. Shutemov <[email protected]>Cc [email protected] 4.19+Signed-off-by Yang Shi <[email protected]>
Quoted 26 lines
--- mm/vmscan.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)mm/vmscan.c +8
-1@@ -684,7 +684,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,unsigned long ret, freed =0 ;struct shrinker *shrinker; -if (!mem_cgroup_is_root (memcg)) +/* +* The root memcg might be allocated even though memcg is disabled +* via "cgroup_disable=memory" boot parameter. This could make +* mem_cgroup_is_root() return false, then just run memcg slab +* shrink, but skip global shrink. This may result in premature +* oom. +*/ +if (!mem_cgroup_disabled () && !mem_cgroup_is_root (memcg))return shrink_slab_memcg (gfp_mask, nid, memcg, priority);if (!down_read_trylock (&shrinker_rwsem))Signature · 1 line
1.8.3.1
Signature · 2 lines
Michal Hocko SUSE Labs