Skip to contentSkip to conversation

drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

PATCH Superseded Ashish Kumar 2 participants 7 messages Jul 18, 2019 Memory technology devices (MTD)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

mt35xu512a and mt35xu02g suports Single I/O and OCTAL I/O also enable use of SPI_NOR_4B_OPCODES.

These flashes are tested on LX2160ARDB and LS1028ARDB respectively

---
v4:
Correct flash name to mt35xu512a in place of mt35xu512g v3:
1. Add version info, rebase to top
v2:
1. Adding more description in commit msg.
2. consolidating "http://patchwork.ozlabs.org/patch/1097867/" and "http://patchwork.ozlabs.org/patch/1097867/" in single patch.

 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +2 -0
index d99c4c5..32a540d 100644
@@ -170,6 +170,8 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
+	{ INFO6("mt35xu512a", 0x2c5b1a, 0x104100,  128 * 1024,  512, USE_FSR | SPI_NOR_4B_OPCODES) },
+	{ INFO("mt35xu02g",  0x2c5b1c, 0x0, 128 * 1024,  2048, USE_FSR | SPI_NOR_4B_OPCODES) },
 #endif
 #ifdef CONFIG_SPI_FLASH_SPANSION	/* SPANSION */
 	/* Spansion/Cypress -- single (large) sector size only, at least
Signature · 1 line
2.7.4
#1 lore raw

PATCH v4 1/1 drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Quoted 26 lines · Ashish Kumar

mt35xu512a and mt35xu02g suports Single I/O and OCTAL I/O also enable use of SPI_NOR_4B_OPCODES.

These flashes are tested on LX2160ARDB and LS1028ARDB respectively

---
v4:
Correct flash name to mt35xu512a in place of mt35xu512g v3:
1. Add version info, rebase to top
v2:
1. Adding more description in commit msg.
2. consolidating "http://patchwork.ozlabs.org/patch/1097867/" and "http://patchwork.ozlabs.org/patch/1097867/" in single patch.

 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index d99c4c5..32a540d 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 173

Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c +1 -0
@@ -170,6 +170,8 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
        { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
        { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
+       { INFO6("mt35xu512a", 0x2c5b1a, 0x104100,  128 * 1024,  512, USE_FSR | SPI_NOR_4B_OPCODES) },

Again is this same as mt35xu512aba? if yes we can have it on INFO itself is it?

#2 lore raw
Quoted 61 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: Thursday, July 18, 2019 4:32 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Kuldeep Singh <[email protected]>
Subject: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Caution: EXT Email

Quoted 8 lines · Ashish Kumar

mt35xu512a and mt35xu02g suports Single I/O and OCTAL I/O also enable use of SPI_NOR_4B_OPCODES.

These flashes are tested on LX2160ARDB and LS1028ARDB respectively

Quoted 8 lines

---
v4:
Correct flash name to mt35xu512a in place of mt35xu512g v3:
1. Add version info, rebase to top
v2:
1. Adding more description in commit msg.
2. consolidating

"https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b 4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0"

Quoted 1 line

and

"https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b 4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0" in single patch.

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 170

Quoted 10 lines
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/drivers/mtd/spi/spi-nor-ids.c index d99c4c5..32a540d 100644

drivers/mtd/spi/spi-nor-ids.c +0 -0
@@ -170,6 +170,8 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>         { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>         { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K |
USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
> +       { INFO6("mt35xu512a", 0x2c5b1a, 0x104100,  128 * 1024,  512,
> + USE_FSR | SPI_NOR_4B_OPCODES) },
Quoted 1 line

Again is this same as mt35xu512aba? if yes we can have it on INFO itself is it?

Update to INFO from INFO6

Regards
Ashish

#3 lore raw
Quoted 57 lines · Ashish Kumar
Quoted 57 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: Thursday, July 18, 2019 4:32 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Kuldeep Singh <[email protected]>
Subject: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Caution: EXT Email

Quoted 8 lines · Ashish Kumar

mt35xu512a and mt35xu02g suports Single I/O and OCTAL I/O also enable use of SPI_NOR_4B_OPCODES.

These flashes are tested on LX2160ARDB and LS1028ARDB respectively

Quoted 8 lines

---
v4:
Correct flash name to mt35xu512a in place of mt35xu512g v3:
1. Add version info, rebase to top
v2:
1. Adding more description in commit msg.
2. consolidating

"https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b 4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0"

Quoted 1 line

and

"https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b 4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0" in single patch.

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 170

Quoted 10 lines
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/drivers/mtd/spi/spi-nor-ids.c index d99c4c5..32a540d 100644

drivers/mtd/spi/spi-nor-ids.c +0 -0
@@ -170,6 +170,8 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>         { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
Quoted 8 lines
Quoted 6 lines

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 171

Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +0 -0
        { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K |

USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 173

Quoted 2 lines
drivers/mtd/spi/spi-nor-ids.c +2 -0
+       { INFO6("mt35xu512a", 0x2c5b1a, 0x104100,  128 * 1024,  512,
+ USE_FSR | SPI_NOR_4B_OPCODES) },

Again is this same as mt35xu512aba? if yes we can have it on INFO itself is it?

Update to INFO from INFO6

but mt35xu512a is same as mt35xu512aba? if yes I can apply your v5 by updating this.

#4 lore raw
Quoted 86 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: Thursday, July 18, 2019 4:48 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Kuldeep Singh <[email protected]>
Subject: Re: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Caution: EXT Email

Quoted 32 lines · Ashish Kumar
Quoted 32 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: Thursday, July 18, 2019 4:32 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Kuldeep Singh <[email protected]>
Subject: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Caution: EXT Email

Quoted 16 lines · Ashish Kumar

mt35xu512a and mt35xu02g suports Single I/O and OCTAL I/O also enable use of SPI_NOR_4B_OPCODES.

These flashes are tested on LX2160ARDB and LS1028ARDB respectively

---
v4:
Correct flash name to mt35xu512a in place of mt35xu512g v3:
1. Add version info, rebase to top
v2:
1. Adding more description in commit msg.
2. consolidating

Quoted 2 lines
Quoted 2 lines

"http://patch

work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku

Quoted 1 line
Quoted 1 line

mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b

Quoted 1 line
Quoted 1 line

4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ

Quoted 4 lines
Quoted 4 lines

haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0"

Quoted 1 line

and

"http://patch

work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku

Quoted 1 line
Quoted 1 line

mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b

Quoted 1 line
Quoted 1 line

4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ

Quoted 1 line
Quoted 1 line

haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0"

in single

Quoted 11 lines
Quoted 11 lines

patch.

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 170

Quoted 10 lines
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/drivers/mtd/spi/spi-nor-ids.c index d99c4c5..32a540d 100644

drivers/mtd/spi/spi-nor-ids.c +0 -0
@@ -170,6 +170,8 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K |

USE_FSR

Quoted 2 lines
Quoted 2 lines
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>         { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K |

USE_FSR

Quoted 6 lines
Quoted 6 lines
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>         { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K |
USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
> +       { INFO6("mt35xu512a", 0x2c5b1a, 0x104100,  128 * 1024,
> + 512, USE_FSR | SPI_NOR_4B_OPCODES) },
Quoted 7 lines
Quoted 1 line
Quoted 1 line

Again is this same as mt35xu512aba? if yes we can have it on INFO itself

is it?

Quoted 2 lines

Update to INFO from INFO6

but mt35xu512a is same as mt35xu512aba? if yes I can apply your v5 by updating this.

Yes, but I thought we are not mentioning device generation and die revision (mt25xu512aBA) option in id-table. Device Generation
B = 2nd generation
Die Revision
A = Rev. A

Regards
Ashish

#5 lore raw
Quoted 92 lines · Ashish Kumar
Quoted 92 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: Thursday, July 18, 2019 4:48 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Kuldeep Singh <[email protected]>
Subject: Re: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Caution: EXT Email

Quoted 32 lines · Ashish Kumar
Quoted 32 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: Thursday, July 18, 2019 4:32 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Kuldeep Singh <[email protected]>
Subject: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Caution: EXT Email

Quoted 16 lines · Ashish Kumar

mt35xu512a and mt35xu02g suports Single I/O and OCTAL I/O also enable use of SPI_NOR_4B_OPCODES.

These flashes are tested on LX2160ARDB and LS1028ARDB respectively

---
v4:
Correct flash name to mt35xu512a in place of mt35xu512g v3:
1. Add version info, rebase to top
v2:
1. Adding more description in commit msg.
2. consolidating

Quoted 2 lines
Quoted 2 lines

"http://patch

work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku

Quoted 1 line
Quoted 1 line

mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b

Quoted 1 line
Quoted 1 line

4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ

Quoted 4 lines
Quoted 4 lines

haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0"

Quoted 1 line

and

"http://patch

work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku

Quoted 1 line
Quoted 1 line

mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b

Quoted 1 line
Quoted 1 line

4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ

Quoted 1 line
Quoted 1 line

haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0"

in single

Quoted 11 lines
Quoted 11 lines

patch.

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 170

Quoted 10 lines
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/drivers/mtd/spi/spi-nor-ids.c index d99c4c5..32a540d 100644

drivers/mtd/spi/spi-nor-ids.c +0 -0
@@ -170,6 +170,8 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K |

USE_FSR

Quoted 2 lines
Quoted 2 lines
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>         { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K |

USE_FSR

Quoted 7 lines
Quoted 7 lines
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>         { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K |
USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
> +       { INFO6("mt35xu512a", 0x2c5b1a, 0x104100,  128 * 1024,
> + 512, USE_FSR | SPI_NOR_4B_OPCODES) },

Again is this same as mt35xu512aba? if yes we can have it on INFO itself

is it?

Quoted 2 lines

Update to INFO from INFO6

Quoted 8 lines
Quoted 2 lines

but mt35xu512a is same as mt35xu512aba? if yes I can apply your v5 by updating this.

Yes, but I thought we are not mentioning device generation and die revision (mt25xu512aBA) option in id-table. Device Generation
B = 2nd generation
Die Revision
A = Rev. A

Since Linux follow this, I wonder something has been discussed for this.

#6 lore raw
Quoted 121 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: Thursday, July 18, 2019 5:00 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Kuldeep Singh <[email protected]>
Subject: Re: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Caution: EXT Email

Quoted 50 lines · Ashish Kumar
Quoted 50 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: Thursday, July 18, 2019 4:48 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Kuldeep Singh <[email protected]>
Subject: Re: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Caution: EXT Email

Quoted 34 lines · Ashish Kumar
Quoted 34 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: Thursday, July 18, 2019 4:32 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot-Denx <[email protected]>; Kuldeep Singh <[email protected]>
Subject: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

Caution: EXT Email

Quoted 17 lines · Ashish Kumar

mt35xu512a and mt35xu02g suports Single I/O and OCTAL I/O also enable use of SPI_NOR_4B_OPCODES.

These flashes are tested on LX2160ARDB and LS1028ARDB respectively

---
v4:
Correct flash name to mt35xu512a in place of mt35xu512g v3:
1. Add version info, rebase to top
v2:
1. Adding more description in commit msg.
2. consolidating

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines

"http://patch

work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku

Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line

mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b

Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line

4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0"

Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

and

"http://patch

work.ozlabs.org%2Fpatch%2F1097867%2F&amp;data=02%7C01%7CAshish.Ku

Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line

mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b

Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line

4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&amp;sdata=FqeZ

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&amp;reserved=0"

Quoted 31 lines
Quoted 30 lines

in single

Quoted 11 lines
Quoted 11 lines

patch.

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 170

Quoted 10 lines
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/drivers/mtd/spi/spi-nor-ids.c index d99c4c5..32a540d 100644

drivers/mtd/spi/spi-nor-ids.c +0 -0
@@ -170,6 +170,8 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K |

USE_FSR

Quoted 2 lines
Quoted 2 lines
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>         { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K |

USE_FSR

Quoted 8 lines
Quoted 8 lines
| SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>         { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K |
USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
> +       { INFO6("mt35xu512a", 0x2c5b1a, 0x104100,  128 * 1024,
> + 512, USE_FSR | SPI_NOR_4B_OPCODES) },

Again is this same as mt35xu512aba? if yes we can have it on INFO itself

is it?

Quoted 2 lines

Update to INFO from INFO6

but mt35xu512a is same as mt35xu512aba? if yes I can apply your v5 by updating this.

Quoted 8 lines
Quoted 1 line

Yes, but I thought we are not mentioning device generation and die

revision (mt25xu512aBA) option in id-table.

Quoted 4 lines

Device Generation
B = 2nd generation
Die Revision
A = Rev. A

Since Linux follow this, I wonder something has been discussed for this.

Ok, I do not see any harm in keeping mt35xu512aba in place mt35xu512a.

Regards
Ashish