Skip to contentSkip to conversation

hv_netvsc: Fix extra rcu_read_unlock in netvsc_recv_callback()

PATCH In review Haiyang Zhang 2 participants 2 messages Jul 19, 2019 – Jul 22, 2019

Subsystems (4)
lore
Share & tools
lore

Haiyang Zhang

author maintainer
#0 lore raw

PATCH 1/1 hv_netvsc: Fix extra rcu_read_unlock in netvsc_recv_callback()

There is an extra rcu_read_unlock left in netvsc_recv_callback(), after a previous patch that removes RCU from this function. This patch removes the extra RCU unlock.

Fixes 345ac08990b8 ("hv_netvsc: pass netvsc_device to receive callback")
---
 drivers/net/hyperv/netvsc_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/hyperv/netvsc_drv.c +0 -1
index afdcc56..3544e19 100644
@@ -836,7 +836,6 @@ int netvsc_recv_callback(struct net_device *net,
 
 	if (unlikely(!skb)) {
 		++net_device_ctx->eth_stats.rx_no_memory;
-		rcu_read_unlock();
 		return NVSP_STAT_FAIL;
 	}
 
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw

From: Haiyang Zhang <[email protected]>
Date: Fri, 19 Jul 2019 17:33:51 +0000

Quoted 6 lines

There is an extra rcu_read_unlock left in netvsc_recv_callback(), after a previous patch that removes RCU from this function. This patch removes the extra RCU unlock.

Fixes 345ac08990b8 ("hv_netvsc: pass netvsc_device to receive callback")

Applied and queued up for -stable.