Skip to contentSkip to conversation

meta-virtualization: add layer depends on selinux

PATCH In review [email protected] 3 participants 10 messages Jul 25, 2019 – Aug 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meta-virtualization: add layer depends on selinux

From: Mingli Yu <[email protected]>

Since cri-o of meta-virtualization depends on
libselinux which comes from selinux, add missing
layer depends back.

---
 conf/layer.conf | 1 +
 1 file changed, 1 insertion(+)
conf/layer.conf +1 -0
index be1f222..23efcb8 100644
@@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \
     networking-layer \
     filesystems-layer \
     meta-python \
+    selinux \
 "
 
 # webserver: naigos requires apache2
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · On Wed, Jul 24, 2019 at 11:43 PM <[email protected]> wrote:

From: Mingli Yu <[email protected]>

Since cri-o of meta-virtualization depends on
libselinux which comes from selinux, add missing
layer depends back.

This is already covered in the README. Since cri-o is optional, I didn't want it to be a hard depends.

Required for cri-o:
URI: git://github.com/advancedtelematic/meta-updater
URI: git://git.yoctoproject.org/meta-selinux
URI: git://git.yoctoproject.org/meta-security
branch: master
revision: HEAD
prio: default

I haven't seen a way to do a conditional depends .. has anyone else ?

Bruce

Quoted 21 lines
---
 conf/layer.conf | 1 +
 1 file changed, 1 insertion(+)
conf/layer.conf +1 -1
index be1f222..23efcb8 100644
@@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \
     networking-layer \
     filesystems-layer \
     meta-python \
+    selinux \
 "
 
 # webserver: naigos requires apache2
--

2.7.4

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#2 lore raw
Quoted 10 lines · Bruce Ashfield
Quoted 6 lines · On Wed, Jul 24, 2019 at 11:43 PM <[email protected]> wrote:

From: Mingli Yu <[email protected]>

Since cri-o of meta-virtualization depends on
libselinux which comes from selinux, add missing
layer depends back.

This is already covered in the README. Since cri-o is optional, I didn't want it to be a hard depends.

Not matter cri-o is optional or not, but first the cri-o recipe indeed exists in meta-virtualization layer until now as ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and second there is below logic in ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and clearly it depends on libselinux.

DEPENDS = " \
    glib-2.0 \
    btrfs-tools \
    gpgme \
    ostree \
    libdevmapper \
    libseccomp \
    libselinux \
    "

So we should add the layer depends selinux(libselinux in selinux layer) for meta-virtualization layer, otherwise there comes below error when do yocto compliance check:
ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it)

ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux' ]

Thanks,

Quoted 37 lines

Required for cri-o:
URI: git://github.com/advancedtelematic/meta-updater
URI: git://git.yoctoproject.org/meta-selinux
URI: git://git.yoctoproject.org/meta-security
branch: master
revision: HEAD
prio: default

I haven't seen a way to do a conditional depends .. has anyone else ?

Bruce

Quoted 21 lines
---
  conf/layer.conf | 1 +
  1 file changed, 1 insertion(+)
conf/layer.conf +1 -1
index be1f222..23efcb8 100644
@@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \
      networking-layer \
      filesystems-layer \
      meta-python \
+    selinux \
  "
 
  # webserver: naigos requires apache2
--

2.7.4

#3 lore raw
Quoted 11 lines · Mingli
Quoted 8 lines · Bruce Ashfield
Quoted 6 lines · On Wed, Jul 24, 2019 at 11:43 PM <[email protected]> wrote:

From: Mingli Yu <[email protected]>

Since cri-o of meta-virtualization depends on
libselinux which comes from selinux, add missing
layer depends back.

Quoted 8 lines
Quoted 2 lines

This is already covered in the README. Since cri-o is optional, I didn't want it to be a hard depends.

Not matter cri-o is optional or not, but first the cri-o recipe indeed exists in meta-virtualization layer until now as ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and second there is below logic in

considering that I wrote the recipe .. I know this.

Quoted 12 lines

./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and clearly it depends on libselinux.

DEPENDS = " \
     glib-2.0 \
     btrfs-tools \
     gpgme \
     ostree \
     libdevmapper \
     libseccomp \
     libselinux \
     "
Quoted 9 lines

So we should add the layer depends selinux(libselinux in selinux layer) for meta-virtualization layer, otherwise there comes below error when do yocto compliance check:
ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/ cri-o_git.bb
DEPENDS on or otherwise requires it)

My point is that I disagree with that compliance check. Unless I'm building the recipe, I don't have that dependency, I want a way to express that.

Bruce

Quoted 47 lines

ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux'
]

Thanks,

Quoted 37 lines

Required for cri-o:
URI: git://github.com/advancedtelematic/meta-updater
URI: git://git.yoctoproject.org/meta-selinux
URI: git://git.yoctoproject.org/meta-security
branch: master
revision: HEAD
prio: default

I haven't seen a way to do a conditional depends .. has anyone else ?

Bruce

Quoted 21 lines
---
  conf/layer.conf | 1 +
  1 file changed, 1 insertion(+)
conf/layer.conf +1 -1
index be1f222..23efcb8 100644
@@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \
      networking-layer \
      filesystems-layer \
      meta-python \
+    selinux \
  "
 
  # webserver: naigos requires apache2
--

2.7.4

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
#4 lore raw
Quoted 50 lines · Bruce Ashfield
Quoted 11 lines · Mingli
Quoted 8 lines · Bruce Ashfield
Quoted 6 lines · On Wed, Jul 24, 2019 at 11:43 PM <[email protected]> wrote:

From: Mingli Yu <[email protected]>

Since cri-o of meta-virtualization depends on
libselinux which comes from selinux, add missing
layer depends back.

Quoted 8 lines
Quoted 2 lines

This is already covered in the README. Since cri-o is optional, I didn't want it to be a hard depends.

Not matter cri-o is optional or not, but first the cri-o recipe indeed exists in meta-virtualization layer until now as ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and second there is below logic in

considering that I wrote the recipe .. I know this.

Quoted 12 lines

./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb and clearly it depends on libselinux.

DEPENDS = " \
     glib-2.0 \
     btrfs-tools \
     gpgme \
     ostree \
     libdevmapper \
     libseccomp \
     libselinux \
     "
Quoted 9 lines

So we should add the layer depends selinux(libselinux in selinux layer) for meta-virtualization layer, otherwise there comes below error when do yocto compliance check:
ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/ cri-o_git.bb
DEPENDS on or otherwise requires it)

Quoted 4 lines

My point is that I disagree with that compliance check. Unless I'm building the recipe, I don't have that dependency, I want a way to express that.

That being said, I did merge the patch so the layer will be in compliance while I look into options for not always requiring that dependency.

Bruce

Quoted 60 lines

Bruce

Quoted 47 lines

ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux'
]

Thanks,

Quoted 37 lines

Required for cri-o:
URI: git://github.com/advancedtelematic/meta-updater
URI: git://git.yoctoproject.org/meta-selinux
URI: git://git.yoctoproject.org/meta-security
branch: master
revision: HEAD
prio: default

I haven't seen a way to do a conditional depends .. has anyone else ?

Bruce

Quoted 21 lines
---
  conf/layer.conf | 1 +
  1 file changed, 1 insertion(+)
conf/layer.conf +1 -1
index be1f222..23efcb8 100644
@@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \
      networking-layer \
      filesystems-layer \
      meta-python \
+    selinux \
  "
 
  # webserver: naigos requires apache2
--

2.7.4

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#5 lore raw
Quoted 60 lines · Bruce Ashfield

On Thu, Jul 25, 2019 at 10:31 PM Bruce Ashfield <[email protected] <mailto:[email protected]>> wrote:

On Thu, Jul 25, 2019 at 9:57 PM Yu, Mingli <[email protected] <mailto:[email protected]>> wrote:

On 2019年07月26日 02:28, Bruce Ashfield wrote:
> On Wed, Jul 24, 2019 at 11:43 PM <[email protected]
<mailto:[email protected]>> wrote:
>>
>> From: Mingli Yu <[email protected]
<mailto:[email protected]>>
>>
>> Since cri-o of meta-virtualization depends on
>> libselinux which comes from selinux, add missing
>> layer depends back.
>
> This is already covered in the README. Since cri-o is optional, I > didn't want it to be a hard depends.

Not matter cri-o is optional or not, but first the cri-o recipe indeed
exists in meta-virtualization layer until now as ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
<http://cri-o_git.bb> and second
there is below logic in

considering that I wrote the recipe .. I know this.

./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
<http://cri-o_git.bb> and clearly
it depends on libselinux.
DEPENDS = " \
glib-2.0 \
btrfs-tools \
gpgme \
ostree \
libdevmapper \
libseccomp \
libselinux \
"

So we should add the layer depends selinux(libselinux in selinux layer)
for meta-virtualization layer, otherwise there comes below error when do
yocto compliance check:
ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
<http://cri-o_git.bb>
DEPENDS on or otherwise requires it)

Quoted 8 lines

My point is that I disagree with that compliance check. Unless I'm building the recipe, I don't have that dependency, I want a way to express that.

That being said, I did merge the patch so the layer will be in compliance while I look into options for not always requiring that dependency.

I will send V2 patch which not hard the dependency as you said crio-u is optional, please ignore this patch.

Thanks,

Quoted 72 lines

Bruce

    Bruce

        ERROR: Required build target 'meta-world-pkgdata' has no buildable
        providers.

        Missing or unbuildable dependency chain was: ['meta-world-pkgdata',
        'cri-o', 'libselinux'
        ]

        Thanks,

         >
         > Required for cri-o:
         > URI: git://github.com/advancedtelematic/meta-updater
        <http://github.com/advancedtelematic/meta-updater>
         > URI: git://git.yoctoproject.org/meta-selinux
        <http://git.yoctoproject.org/meta-selinux>
         > URI: git://git.yoctoproject.org/meta-security
        <http://git.yoctoproject.org/meta-security>
         > branch: master
         > revision: HEAD
         > prio: default
         >
         >
         > I haven't seen a way to do a conditional depends .. has
        anyone else ?
         >
         > Bruce
         >
         >>
         >> Signed-off-by: Mingli Yu <[email protected]
        <mailto:[email protected]>>
         >> ---
         >>   conf/layer.conf | 1 +
         >>   1 file changed, 1 insertion(+)
         >>
         >> diff --git a/conf/layer.conf b/conf/layer.conf
         >> index be1f222..23efcb8 100644
         >> --- a/conf/layer.conf
         >> +++ b/conf/layer.conf
         >> @@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \
         >>       networking-layer \
         >>       filesystems-layer \
         >>       meta-python \
         >> +    selinux \
         >>   "
         >>
         >>   # webserver: naigos requires apache2
         >> --
         >> 2.7.4
         >>
         >
         >



    --
    - Thou shalt not follow the NULL pointer, for chaos and madness
    await thee at its end
    - "Use the force Harry" - Gandalf, Star Trek II

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

#6 lore raw

PATCH 1/1 cri-o: skip it when depends not found

From: Mingli Yu <[email protected]>

cri-o depends on ostree, libselinux and libseccomp and we should check if the layer which provides these recipes exist or not before go on.

---
 recipes-containers/cri-o/cri-o_git.bb | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
recipes-containers/cri-o/cri-o_git.bb +22 -0
index c27aef7..b0c0ce4 100644
@@ -42,6 +42,28 @@ RDEPENDS_${PN} = " \
     cni \
     "
 
+python __anonymous() {
+    msg = ""
+    # ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
+    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
+    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']
+    if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-security should be present as it provides 'libseccomp'"
+        raise bb.parse.SkipRecipe(msg)
+    # ERROR: Nothing PROVIDES 'ostree' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
+    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
+    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'ostree']
+    elif 'cube' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-cube should be present as it provides 'ostree'"
+        raise bb.parse.SkipRecipe(msg)
+    # ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
+    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
+    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux']
+    elif 'selinux' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-selinux should be present as it provides 'libselinux'"
+        raise bb.parse.SkipRecipe(msg)
+}
+
 PACKAGES =+ "${PN}-config"
 
 RDEPENDS_${PN} += " virtual/containerd virtual/runc"
Signature · 1 line
2.7.4
author
#7 lore raw

Re: [PATCH] cri-o: skip it when depends not found

Ping.

Thanks,

Quoted 45 lines · On 2019年07月26日 17:10, [email protected] wrote:

From: Mingli Yu <[email protected]>

cri-o depends on ostree, libselinux and libseccomp and we should check if the layer which provides these recipes exist or not before go on.

---
  recipes-containers/cri-o/cri-o_git.bb | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)
recipes-containers/cri-o/cri-o_git.bb +22 -0
index c27aef7..b0c0ce4 100644
@@ -42,6 +42,28 @@ RDEPENDS_${PN} = " \
      cni \
      "
 
+python __anonymous() {
+    msg = ""
+    # ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
+    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
+    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']
+    if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-security should be present as it provides 'libseccomp'"
+        raise bb.parse.SkipRecipe(msg)
+    # ERROR: Nothing PROVIDES 'ostree' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
+    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
+    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'ostree']
+    elif 'cube' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-cube should be present as it provides 'ostree'"
+        raise bb.parse.SkipRecipe(msg)
+    # ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
+    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
+    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux']
+    elif 'selinux' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-selinux should be present as it provides 'libselinux'"
+        raise bb.parse.SkipRecipe(msg)
+}
+
  PACKAGES =+ "${PN}-config"
 
  RDEPENDS_${PN} += " virtual/containerd virtual/runc"
#8 lore raw

Re: [PATCH] cri-o: skip it when depends not found

Quoted 3 lines · Mingli

Ping.

I'm currently out of the office and won't be back until Aug 7th, so I'm not getting to any reviews/merges as fast as I normally do.

The approach that this takes is interesting. I personally don't have a problem with it, but I suppose things don't scale as well if everyone did depends like this on a per-recipe basis.

I'm going to stage the patch and test it locally, while I wait to see if anyone else has any objections to the approach

Bruce

Quoted 65 lines

Thanks,

Quoted 6 lines · On 2019年07月26日 17:10, [email protected] wrote:

From: Mingli Yu <[email protected]>

cri-o depends on ostree, libselinux and libseccomp and we should check if the layer which provides these recipes exist or not before go on.

Review

Quoted 6 lines
---
  recipes-containers/cri-o/cri-o_git.bb | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)
(quoted diff) +0 -0

b/recipes-containers/cri-o/cri-o_git.bb

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 47

Quoted 10 lines

index c27aef7..b0c0ce4 100644

recipes-containers/cri-o/cri-o_git.bb +3 -0
@@ -42,6 +42,28 @@ RDEPENDS_${PN} = " \
      cni \
      "
 
+python __anonymous() {
+    msg = ""
+    # ERROR: Nothing PROVIDES 'libseccomp' (but

/buildarea/layers/meta-virtualization/recipes-containers/cri-o/ cri-o_git.bb DEPENDS on or otherwise requires it).

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 48

Quoted 1 line
recipes-containers/cri-o/cri-o_git.bb +1 -0
+    # ERROR: Required build target 'meta-world-pkgdata' has no

buildable providers.

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 49

Quoted 1 line
recipes-containers/cri-o/cri-o_git.bb +1 -0
+    # Missing or unbuildable dependency chain was:

['meta-world-pkgdata', 'cri-o', 'libseccomp']

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 51

Quoted 2 lines
recipes-containers/cri-o/cri-o_git.bb +2 -0
+    if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-security should be present as it

provides 'libseccomp'"

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 53

Quoted 2 lines
recipes-containers/cri-o/cri-o_git.bb +2 -0
+        raise bb.parse.SkipRecipe(msg)
+    # ERROR: Nothing PROVIDES 'ostree' (but

/buildarea/layers/meta-virtualization/recipes-containers/cri-o/ cri-o_git.bb DEPENDS on or otherwise requires it).

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 54

Quoted 1 line
recipes-containers/cri-o/cri-o_git.bb +1 -0
+    # ERROR: Required build target 'meta-world-pkgdata' has no

buildable providers.

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 55

Quoted 1 line
recipes-containers/cri-o/cri-o_git.bb +1 -0
+    # Missing or unbuildable dependency chain was:

['meta-world-pkgdata', 'cri-o', 'ostree']

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 57

Quoted 2 lines
recipes-containers/cri-o/cri-o_git.bb +2 -0
+    elif 'cube' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-cube should be present as it provides

'ostree'"

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 59

Quoted 2 lines
recipes-containers/cri-o/cri-o_git.bb +2 -0
+        raise bb.parse.SkipRecipe(msg)
+    # ERROR: Nothing PROVIDES 'libselinux' (but

/buildarea/layers/meta-virtualization/recipes-containers/cri-o/ cri-o_git.bb DEPENDS on or otherwise requires it).

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 60

Quoted 1 line
recipes-containers/cri-o/cri-o_git.bb +1 -0
+    # ERROR: Required build target 'meta-world-pkgdata' has no

buildable providers.

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 61

Quoted 1 line
recipes-containers/cri-o/cri-o_git.bb +1 -0
+    # Missing or unbuildable dependency chain was:

['meta-world-pkgdata', 'cri-o', 'libselinux']

recipes-containers/cri-o/cri-o_git.bb RDEPENDS_${PN} = " \ · line 63

Quoted 2 lines
recipes-containers/cri-o/cri-o_git.bb +2 -0
+    elif 'selinux' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-selinux should be present as it provides

'libselinux'"

Quoted 7 lines
recipes-containers/cri-o/cri-o_git.bb +3 -0
+        raise bb.parse.SkipRecipe(msg)
+}
+
  PACKAGES =+ "${PN}-config"
 
  RDEPENDS_${PN} += " virtual/containerd virtual/runc"
Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
#9 lore raw
In reply to Bruce Ashfield
Quoted 41 lines · Bruce Ashfield

On Thu, Jul 25, 2019 at 10:31 PM Bruce Ashfield <[email protected] <mailto:[email protected]>> wrote:

    On Thu, Jul 25, 2019 at 9:57 PM Yu, Mingli <[email protected]
    <mailto:[email protected]>> wrote:



        On 2019年07月26日 02:28, Bruce Ashfield wrote:
        > On Wed, Jul 24, 2019 at 11:43 PM <[email protected]
        <mailto:[email protected]>> wrote:
        >>
        >> From: Mingli Yu <[email protected]
        <mailto:[email protected]>>
        >>
        >> Since cri-o of meta-virtualization depends on
        >> libselinux which comes from selinux, add missing
        >> layer depends back.
        >
        > This is already covered in the README. Since cri-o is optional, I
        > didn't want it to be a hard depends.

        Not matter cri-o is optional or not, but first the cri-o recipe indeed
        exists in meta-virtualization layer until now as
        ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
        <http://cri-o_git.bb> and second
        there is below logic in


    considering that I wrote the recipe .. I know this.

     

        ./meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
        <http://cri-o_git.bb> and clearly
        it depends on libselinux.
        DEPENDS = " \
Quoted 8 lines
             glib-2.0 \
             btrfs-tools \
             gpgme \
             ostree \
             libdevmapper \
             libseccomp \
             libselinux \
             "

Why does cri-o (any version) require libselinux? (libseccomp I can see).

Is this something that changed upstream to make it mandatory? If so, any way to reverse it? selinux is horribly heavy weight for a lot of things.

Quoted 9 lines

So we should add the layer depends selinux(libselinux in selinux layer) for meta-virtualization layer, otherwise there comes below error when do yocto compliance check:
ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
<http://cri-o_git.bb>
DEPENDS on or otherwise requires it)

Quoted 6 lines

My point is that I disagree with that compliance check. Unless I'm building the recipe, I don't have that dependency, I want a way to express that.

That being said, I did merge the patch so the layer will be in compliance while I look into options for not always requiring that dependency.

The way to do this is make the recipe based on a dynamic dependency.

IMHO the -best- way to do this, if possible, is to split the libselinux dependency out. Make it buildable with it. But either way the setup is similar.

conf/layer.conf:

BBFILES_DYNAMIC += "selinux:${LAYERDIR}/dynamic-layers/selinux/recipes*/*/*.bb \

selinux:${LAYERDIR}/dynamic-layers/selinux/recipes*/*/*.bbappend"

LAYERRECOMMENDS_<collection> = " \
          selinux \
          "

The above says that selinux is recommended for use with this (layerindex can read this and process it.) The BBFILES_DYNAMIC says to only bring in that path if 'selinux' collection is available.

Then move the recipe (or break out the selinux part in a bbappend) into:

dynamic-layers/selinux/recipes-containers/cri-o/...

--Mark

Quoted 74 lines

Bruce

    Bruce

     

        ERROR: Required build target 'meta-world-pkgdata' has no buildable
        providers.

        Missing or unbuildable dependency chain was: ['meta-world-pkgdata',
        'cri-o', 'libselinux'
        ]

        Thanks,

        >
        > Required for cri-o:
        > URI: git://github.com/advancedtelematic/meta-updater
        <http://github.com/advancedtelematic/meta-updater>
        > URI: git://git.yoctoproject.org/meta-selinux
        <http://git.yoctoproject.org/meta-selinux>
        > URI: git://git.yoctoproject.org/meta-security
        <http://git.yoctoproject.org/meta-security>
        > branch: master
        > revision: HEAD
        > prio: default
        >
        >
        > I haven't seen a way to do a conditional depends .. has anyone else ?
        >
        > Bruce
        >
        >>
        >> Signed-off-by: Mingli Yu <[email protected]
        <mailto:[email protected]>>
        >> ---
        >>   conf/layer.conf | 1 +
        >>   1 file changed, 1 insertion(+)
        >>
        >> diff --git a/conf/layer.conf b/conf/layer.conf
        >> index be1f222..23efcb8 100644
        >> --- a/conf/layer.conf
        >> +++ b/conf/layer.conf
        >> @@ -21,6 +21,7 @@ LAYERDEPENDS_virtualization-layer = " \
        >>       networking-layer \
        >>       filesystems-layer \
        >>       meta-python \
        >> +    selinux \
        >>   "
        >>
        >>   # webserver: naigos requires apache2
        >> --
        >> 2.7.4
        >>
        >
        >



    -- 
    - Thou shalt not follow the NULL pointer, for chaos and madness await thee
    at its end
    - "Use the force Harry" - Gandalf, Star Trek II
Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at
its end
- "Use the force Harry" - Gandalf, Star Trek II