Skip to contentSkip to conversation

clk: imx8mq: Mark AHB clock as critical

PATCH Superseded Abel Vesa 2 participants 4 messages Jul 29, 2019

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Abel Vesa

author
#0 lore raw

PATCH v2 1/1 clk: imx8mq: Mark AHB clock as critical

Keep the AHB clock always on since there is no driver to control it and all the other clocks that use it as parent rely on it being always enabled.

---

Changes since v1:
* added comment in code why this clock is critical
* added T-b by Daniel

This needs to go in ASAP to fix the boot hang.

 drivers/clk/imx/clk-imx8mq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/clk/imx/clk-imx8mq.c +2 -1
index 4328c22..04302f2 100644
@@ -406,7 +406,8 @@ static int imx8mq_clocks_probe(struct platform_device *pdev)
 	clks[IMX8MQ_CLK_NOC_APB] = imx8m_clk_composite_critical("noc_apb", imx8mq_noc_apb_sels, base + 0x8d80);
 
 	/* AHB */
-	clks[IMX8MQ_CLK_AHB] = imx8m_clk_composite("ahb", imx8mq_ahb_sels, base + 0x9000);
+	/* AHB clock is used by the AHB bus therefore marked as critical */
+	clks[IMX8MQ_CLK_AHB] = imx8m_clk_composite_critical("ahb", imx8mq_ahb_sels, base + 0x9000);
 	clks[IMX8MQ_CLK_AUDIO_AHB] = imx8m_clk_composite("audio_ahb", imx8mq_audio_ahb_sels, base + 0x9100);
 
 	/* IPG */
Signature · 1 line
2.7.4
reviewer
#1 lore raw

Hi Abel,

Quoted 6 lines · Abel Vesa

Keep the AHB clock always on since there is no driver to control it and all the other clocks that use it as parent rely on it being always enabled.

Quoted 7 lines

---

Changes since v1:
* added comment in code why this clock is critical
* added T-b by Daniel

This needs to go in ASAP to fix the boot hang.

Which boot hang exactly? Are you referring to the TMU clock hang?

On the TMU clock hang, the issue was that the qoriq_thermal needs to enable the TMU clock.

Please always provide a detailed description in the commit log.

Also, if this fixes a hang it should contain a Fixes tag.

author
#2 lore raw

Hi Fabio,

Quoted 17 lines · Fabio Estevam

Hi Abel,

Quoted 6 lines · Abel Vesa

Keep the AHB clock always on since there is no driver to control it and all the other clocks that use it as parent rely on it being always enabled.

Quoted 7 lines

---

Changes since v1:
* added comment in code why this clock is critical
* added T-b by Daniel

This needs to go in ASAP to fix the boot hang.

Quoted 8 lines

Which boot hang exactly? Are you referring to the TMU clock hang?

On the TMU clock hang, the issue was that the qoriq_thermal needs to enable the TMU clock.

Please always provide a detailed description in the commit log.

Also, if this fixes a hang it should contain a Fixes tag.

Please have a the explanation here:

https://lkml.org/lkml/2019/7/28/306

reviewer
#3 lore raw

Hi Abel,

Quoted 3 lines · Abel Vesa

Please have a the explanation here:

https://lkml.org/lkml/2019/7/28/306

I read that and it is still not clear for me: which hang exactly are you referring to in your comment below the --- line?

Reading the commit log it is not clear if the patch fixes a real bug or if it is just an improvement.

Please make this clear in the commit log.