Skip to contentSkip to conversation

arm64: mm: print hexadecimal EC value in mem_abort_decode()

PATCH Superseded Miles Chen 2 participants 5 messages Aug 7, 2019 – Aug 8, 2019

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Miles Chen

author
#0 lore raw

PATCH v2 1/1 arm64: mm: print hexadecimal EC value in mem_abort_decode()

This change prints the hexadecimal EC value in mem_abort_decode(), which makes it easier to lookup the corresponding EC in the ARM Architecture Reference Manual.

The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem faults") prints useful information when memory abort occurs. It would be easier to lookup "0x25" instead of "DABT" in the document. Then we can check the corresponding ISS.

For example:
Current info Document
EC Exception class
"CP15 MCR/MRC" 0x3 "MCR or MRC access to CP15a..."
"ASIMD" 0x7 "Access to SIMD or floating-point..."
"DABT (current EL)" 0x25 "Data Abort taken without..."
...

Before:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
Exception class = DABT (current EL), IL = 32 bits SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

After:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
EC = 0x25: DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

Change since v1:
print "EC" instead of "Exception class"
print EC in fixwidth

Cc Mark Rutland <[email protected]>
Cc Anshuman Khandual <[email protected]>
Cc James Morse <[email protected]>
---
 arch/arm64/mm/fault.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/mm/fault.c +2 -2
index cfd65b63f36f..ad4980a27edb 100644
@@ -86,8 +86,8 @@ static void mem_abort_decode(unsigned int esr)
 	pr_alert("Mem abort info:\n");
 
 	pr_alert("  ESR = 0x%08x\n", esr);
-	pr_alert("  Exception class = %s, IL = %u bits\n",
-		 esr_get_class_string(esr),
+	pr_alert("  EC = 0x%02lx: %s, IL = %u bits\n",
+		 ESR_ELx_EC(esr), esr_get_class_string(esr),
 		 (esr & ESR_ELx_IL) ? 32 : 16);
 	pr_alert("  SET = %lu, FnV = %lu\n",
 		 (esr & ESR_ELx_SET_MASK) >> ESR_ELx_SET_SHIFT,
Signature · 1 line
2.18.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 39 lines · Miles Chen

This change prints the hexadecimal EC value in mem_abort_decode(), which makes it easier to lookup the corresponding EC in the ARM Architecture Reference Manual.

The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem faults") prints useful information when memory abort occurs. It would be easier to lookup "0x25" instead of "DABT" in the document. Then we can check the corresponding ISS.

For example:
Current info Document
EC Exception class
"CP15 MCR/MRC" 0x3 "MCR or MRC access to CP15a..."
"ASIMD" 0x7 "Access to SIMD or floating-point..."
"DABT (current EL)" 0x25 "Data Abort taken without..."
...

Before:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
Exception class = DABT (current EL), IL = 32 bits SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

After:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
EC = 0x25: DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

Quoted 8 lines

Change since v1:
print "EC" instead of "Exception class"
print EC in fixwidth

Cc Mark Rutland <[email protected]>
Cc Anshuman Khandual <[email protected]>
Cc James Morse <[email protected]>

This version implements the suggestion, hence it should have also contained acked-by tag from Mark from earlier version.

author
#2 lore raw
Quoted 45 lines · Anshuman Khandual
Quoted 43 lines · Miles Chen

This change prints the hexadecimal EC value in mem_abort_decode(), which makes it easier to lookup the corresponding EC in the ARM Architecture Reference Manual.

The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem faults") prints useful information when memory abort occurs. It would be easier to lookup "0x25" instead of "DABT" in the document. Then we can check the corresponding ISS.

For example:
Current info Document
EC Exception class
"CP15 MCR/MRC" 0x3 "MCR or MRC access to CP15a..."
"ASIMD" 0x7 "Access to SIMD or floating-point..."
"DABT (current EL)" 0x25 "Data Abort taken without..."
...

Before:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
Exception class = DABT (current EL), IL = 32 bits SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

After:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
EC = 0x25: DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

Change since v1:
print "EC" instead of "Exception class"
print EC in fixwidth

Quoted 8 lines
Quoted 4 lines
Cc Mark Rutland <[email protected]>
Cc Anshuman Khandual <[email protected]>
Cc James Morse <[email protected]>

This version implements the suggestion, hence it should have also contained acked-by tag from Mark from earlier version.

No problem. Sorry for not including the tag.
I was not sure if I should add the acked-by tag from Mark in patch v2.

Quoted 1 line

If I send patch v3, I should include acked-by tag from Mark and Reviewed-by tag from you, right?

Miles

#3 lore raw
Quoted 51 lines · Miles Chen
Quoted 50 lines · Anshuman Khandual
Quoted 47 lines · Miles Chen

This change prints the hexadecimal EC value in mem_abort_decode(), which makes it easier to lookup the corresponding EC in the ARM Architecture Reference Manual.

The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem faults") prints useful information when memory abort occurs. It would be easier to lookup "0x25" instead of "DABT" in the document. Then we can check the corresponding ISS.

For example:
Current info Document
EC Exception class
"CP15 MCR/MRC" 0x3 "MCR or MRC access to CP15a..."
"ASIMD" 0x7 "Access to SIMD or floating-point..."
"DABT (current EL)" 0x25 "Data Abort taken without..."
...

Before:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
Exception class = DABT (current EL), IL = 32 bits SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

After:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
EC = 0x25: DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

Change since v1:
print "EC" instead of "Exception class"
print EC in fixwidth

Cc Mark Rutland <[email protected]>
Cc Anshuman Khandual <[email protected]>
Cc James Morse <[email protected]>
Quoted 6 lines
Quoted 3 lines

This version implements the suggestion, hence it should have also contained acked-by tag from Mark from earlier version.

No problem. Sorry for not including the tag.
I was not sure if I should add the acked-by tag from Mark in patch v2.

Yeah because V2 has now implemented the suggestion as required for getting the tag per Mark in V1.

Quoted 5 lines
Quoted 2 lines

If I send patch v3, I should include acked-by tag from Mark and Reviewed-by tag from you, right?

Right.

author
#4 lore raw
Quoted 57 lines · Anshuman Khandual
Quoted 55 lines · Miles Chen
Quoted 53 lines · Anshuman Khandual
Quoted 39 lines · Miles Chen

This change prints the hexadecimal EC value in mem_abort_decode(), which makes it easier to lookup the corresponding EC in the ARM Architecture Reference Manual.

The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem faults") prints useful information when memory abort occurs. It would be easier to lookup "0x25" instead of "DABT" in the document. Then we can check the corresponding ISS.

For example:
Current info Document
EC Exception class
"CP15 MCR/MRC" 0x3 "MCR or MRC access to CP15a..."
"ASIMD" 0x7 "Access to SIMD or floating-point..."
"DABT (current EL)" 0x25 "Data Abort taken without..."
...

Before:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
Exception class = DABT (current EL), IL = 32 bits SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

After:

Unable to handle kernel paging request at virtual address 000000000000c000

Mem abort info:
ESR = 0x96000046
EC = 0x25: DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x00000046
CM = 0, WnR = 1

Quoted 8 lines

Change since v1:
print "EC" instead of "Exception class"
print EC in fixwidth

Cc Mark Rutland <[email protected]>
Cc Anshuman Khandual <[email protected]>
Cc James Morse <[email protected]>

This version implements the suggestion, hence it should have also contained acked-by tag from Mark from earlier version.

Quoted 6 lines
Quoted 2 lines

No problem. Sorry for not including the tag.
I was not sure if I should add the acked-by tag from Mark in patch v2.

Yeah because V2 has now implemented the suggestion as required for getting the tag per Mark in V1.

Understood. thanks for the explanation

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

If I send patch v3, I should include acked-by tag from Mark and Reviewed-by tag from you, right?

Right.