drm/amd/powerplay: remove redundancy debug log about smu unsupported features
Subsystems (2)
PATCH 1/2 drm/amd/powerplay: remove redundancy debug log about smu unsupported features
remove redundancy debug log about smu unsupported features
--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +0 -1
@@ -215,7 +215,6 @@ static int arcturus_get_smu_feature_index(struct smu_context *smc, uint32_t inde mapping = arcturus_feature_mask_map[index];if (!(mapping.valid_mapping)) { -pr_warn ("Unsupported SMU feature: %d\n" , index);return -EINVAL ; }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1565598138-13844-1-git-send-email-Jack.Gui-5C7GfCeVMHo@public.gmane.org
PATCH 2/2 drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus
add arcturus_is_dpm_running function
--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +21 -0
@@ -51,6 +51,15 @@#define SMU_FEATURES_HIGH_MASK 0xFFFFFFFF00000000#define SMU_FEATURES_HIGH_SHIFT 32 +#define SMC_DPM_FEATURE ( \ + FEATURE_DPM_PREFETCHER_MASK | \ + FEATURE_DPM_GFXCLK_MASK | \ + FEATURE_DPM_UCLK_MASK | \ + FEATURE_DPM_SOCCLK_MASK | \ + FEATURE_DPM_MP0CLK_MASK | \ + FEATURE_DPM_FCLK_MASK | \ + FEATURE_DPM_XGMI_MASK) +/* possible frequency drift (1Mhz) */ #define EPSILON 1
@@ -1873,6 +1882,17 @@ static void arcturus_dump_pptable(struct smu_context *smu) } +static bool arcturus_is_dpm_running (struct smu_context *smu) +{ +int ret =0 ; +uint32_t feature_mask[2 ]; +unsigned long feature_enabled; + ret =smu_feature_get_enabled_mask (smu, feature_mask,2 ); + feature_enabled = (unsigned long )((uint64_t )feature_mask[0 ] | + ((uint64_t )feature_mask[1 ] <<32 )); +return !!(feature_enabled &SMC_DPM_FEATURE ); +} +static const struct pptable_funcs arcturus_ppt_funcs = {/* translate smu index into arcturus specific index */ .get_smu_msg_index = arcturus_get_smu_msg_index,
@@ -1910,6 +1930,7 @@ static const struct pptable_funcs arcturus_ppt_funcs = {/* debug (internal used) */ .dump_pptable = arcturus_dump_pptable, .get_power_limit = arcturus_get_power_limit, + .is_dpm_running = arcturus_is_dpm_running, };void arcturus_set_ppt_funcs (struct smu_context *smu)
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1565598138-13844-2-git-send-email-Jack.Gui-5C7GfCeVMHo@public.gmane.org
Kevin Wang
Reviewed-byRe: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus
Quoted 46 lines · Chengming Gui
add
arcturus_is_dpm_runningfunctionSigned-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +20
-0@@ -51,6 +51,15 @@#define SMU_FEATURES_HIGH_MASK 0xFFFFFFFF00000000#define SMU_FEATURES_HIGH_SHIFT 32 +#define SMC_DPM_FEATURE ( \ + FEATURE_DPM_PREFETCHER_MASK | \ + FEATURE_DPM_GFXCLK_MASK | \ + FEATURE_DPM_UCLK_MASK | \ + FEATURE_DPM_SOCCLK_MASK | \ + FEATURE_DPM_MP0CLK_MASK | \ + FEATURE_DPM_FCLK_MASK | \ + FEATURE_DPM_XGMI_MASK) +/* possible frequency drift (1Mhz) */ #define EPSILON 1@@ -1873,6 +1882,17 @@ static void arcturus_dump_pptable(struct smu_context *smu) } +static bool arcturus_is_dpm_running (struct smu_context *smu) +{ +int ret =0 ; +uint32_t feature_mask[2 ]; +unsigned long feature_enabled; + ret =smu_feature_get_enabled_mask (smu, feature_mask,2 ); + feature_enabled = (unsigned long )((uint64_t )feature_mask[0 ] | + ((uint64_t )feature_mask[1 ] <<32 )); +return !!(feature_enabled &SMC_DPM_FEATURE ); +} +static const struct pptable_funcs arcturus_ppt_funcs = {/* translate smu index into arcturus specific index */ .get_smu_msg_index = arcturus_get_smu_msg_index,
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c static const struct pptable_funcs arcturus_ppt_funcs = { · line 1936
Quoted 7 lines
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +1
-0@@ -1910,6 +1930,7 @@ static const struct pptable_funcs arcturus_ppt_funcs = {/* debug (internal used) */ .dump_pptable = arcturus_dump_pptable, .get_power_limit = arcturus_get_power_limit, + .is_dpm_running = arcturus_is_dpm_running, };void arcturus_set_ppt_funcs (struct smu_context *smu)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus
In reply to a message not in the archivePlease set FEATURE_DPM_PREFETCHER_MASK | FEATURE_DPM_GFXCLK_MASK only. For now, only these two are enabled on arcturus.
With that fixed, the patch is reviewed-by: Evan Quan <[email protected]>
Quoted 66 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Chengming Gui
Sent: Monday, August 12, 2019 4:22 PM
To: [email protected]
Cc: Gui, Jack <[email protected]>
Subject: [PATCH 2/2] drm/amd/powerplay: addarcturus_is_dpm_runningfunction for arcturusadd
arcturus_is_dpm_runningfunctionSigned-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +20
-1@@ -51,6 +51,15 @@#define SMU_FEATURES_HIGH_MASK 0xFFFFFFFF00000000#define SMU_FEATURES_HIGH_SHIFT 32 +#define SMC_DPM_FEATURE ( \ + FEATURE_DPM_PREFETCHER_MASK | \ + FEATURE_DPM_GFXCLK_MASK | \ + FEATURE_DPM_UCLK_MASK | \ + FEATURE_DPM_SOCCLK_MASK | \ + FEATURE_DPM_MP0CLK_MASK | \ + FEATURE_DPM_FCLK_MASK | \ + FEATURE_DPM_XGMI_MASK) +/* possible frequency drift (1Mhz) */ #define EPSILON 1@@ -1873,6 +1882,17 @@ static void arcturus_dump_pptable(struct smu_context *smu) } +static bool arcturus_is_dpm_running (struct smu_context *smu) { +int ret =0 ; +uint32_t feature_mask[2 ]; +unsigned long feature_enabled; + ret =smu_feature_get_enabled_mask (smu, feature_mask,2 ); + feature_enabled = (unsigned long )((uint64_t )feature_mask[0 ] | + ((uint64_t )feature_mask[1 ] <<32 )); +return !!(feature_enabled &SMC_DPM_FEATURE ); } +static const struct pptable_funcs arcturus_ppt_funcs = {/* translate smu index into arcturus specific index */ .get_smu_msg_index = arcturus_get_smu_msg_index, @@ -1910,6 +1930,7 @@ static const struct pptable_funcs arcturus_ppt_funcs = {/* debug (internal used) */ .dump_pptable = arcturus_dump_pptable, .get_power_limit = arcturus_get_power_limit, + .is_dpm_running = arcturus_is_dpm_running, };void arcturus_set_ppt_funcs (struct smu_context *smu) --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): MN2PR12MB33441DEDEEB00F8F321F72BBE4D30-rweVpJHSKToDMgCC8P//[email protected]
RE: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus
Hi Evan,
All supported feature can be set there,
Anyone of these features is running, we can judge dpm is running.
BR,
Jack Gui
-----Original Message-----
From: Quan, Evan <[email protected]>
Sent: Monday, August 12, 2019 5:39 PM
To: Gui, Jack <[email protected]>; [email protected]
Cc: Gui, Jack <[email protected]>
Subject: RE: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus
Please set FEATURE_DPM_PREFETCHER_MASK | FEATURE_DPM_GFXCLK_MASK only. For now, only these two are enabled on arcturus.
With that fixed, the patch is reviewed-by: Evan Quan <[email protected]>
Quoted 66 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Chengming Gui
Sent: Monday, August 12, 2019 4:22 PM
To: [email protected]
Cc: Gui, Jack <[email protected]>
Subject: [PATCH 2/2] drm/amd/powerplay: addarcturus_is_dpm_runningfunction for arcturusadd
arcturus_is_dpm_runningfunctionSigned-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +20
-1@@ -51,6 +51,15 @@#define SMU_FEATURES_HIGH_MASK 0xFFFFFFFF00000000#define SMU_FEATURES_HIGH_SHIFT 32 +#define SMC_DPM_FEATURE ( \ + FEATURE_DPM_PREFETCHER_MASK | \ + FEATURE_DPM_GFXCLK_MASK | \ + FEATURE_DPM_UCLK_MASK | \ + FEATURE_DPM_SOCCLK_MASK | \ + FEATURE_DPM_MP0CLK_MASK | \ + FEATURE_DPM_FCLK_MASK | \ + FEATURE_DPM_XGMI_MASK) +/* possible frequency drift (1Mhz) */ #define EPSILON 1@@ -1873,6 +1882,17 @@ static void arcturus_dump_pptable(struct smu_context *smu) } +static bool arcturus_is_dpm_running (struct smu_context *smu) { +int ret =0 ; +uint32_t feature_mask[2 ]; +unsigned long feature_enabled; + ret =smu_feature_get_enabled_mask (smu, feature_mask,2 ); + feature_enabled = (unsigned long )((uint64_t )feature_mask[0 ] | + ((uint64_t )feature_mask[1 ] <<32 )); +return !!(feature_enabled &SMC_DPM_FEATURE ); } +static const struct pptable_funcs arcturus_ppt_funcs = {/* translate smu index into arcturus specific index */ .get_smu_msg_index = arcturus_get_smu_msg_index, @@ -1910,6 +1930,7 @@ static const struct pptable_funcs arcturus_ppt_funcs = {/* debug (internal used) */ .dump_pptable = arcturus_dump_pptable, .get_power_limit = arcturus_get_power_limit, + .is_dpm_running = arcturus_is_dpm_running, };void arcturus_set_ppt_funcs (struct smu_context *smu) --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): MN2PR12MB35820DB4E84513D7F47606088BD30-rweVpJHSKTr2mYjuiDFEwwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
RE: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus
OK, I see. That will be fine.
Regards,
Evan
Quoted 90 lines
-----Original Message-----
From: Gui, Jack <[email protected]>
Sent: Monday, August 12, 2019 5:51 PM
To: Quan, Evan <[email protected]>; [email protected]
Subject: RE: [PATCH 2/2] drm/amd/powerplay: addarcturus_is_dpm_runningfunction for arcturusHi Evan,
All supported feature can be set there, Anyone of these features is running, we can judge dpm is running.
BR,
Jack Gui-----Original Message-----
From: Quan, Evan <[email protected]>
Sent: Monday, August 12, 2019 5:39 PM
To: Gui, Jack <[email protected]>; [email protected]
Cc: Gui, Jack <[email protected]>
Subject: RE: [PATCH 2/2] drm/amd/powerplay: addarcturus_is_dpm_runningfunction for arcturusPlease set
FEATURE_DPM_PREFETCHER_MASK|FEATURE_DPM_GFXCLK_MASKonly. For now, only these two are enabled on arcturus.With that fixed, the patch is reviewed-by: Evan Quan <[email protected]>
Quoted 62 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Chengming Gui
Sent: Monday, August 12, 2019 4:22 PM
To: [email protected]
Cc: Gui, Jack <[email protected]>
Subject: [PATCH 2/2] drm/amd/powerplay: addarcturus_is_dpm_runningfunction for arcturusadd
arcturus_is_dpm_runningfunctionSigned-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +20
-0@@ -51,6 +51,15 @@#define SMU_FEATURES_HIGH_MASK 0xFFFFFFFF00000000#define SMU_FEATURES_HIGH_SHIFT 32 +#define SMC_DPM_FEATURE ( \ + FEATURE_DPM_PREFETCHER_MASK | \ + FEATURE_DPM_GFXCLK_MASK | \ + FEATURE_DPM_UCLK_MASK | \ + FEATURE_DPM_SOCCLK_MASK | \ + FEATURE_DPM_MP0CLK_MASK | \ + FEATURE_DPM_FCLK_MASK | \ + FEATURE_DPM_XGMI_MASK) +/* possible frequency drift (1Mhz) */ #define EPSILON 1@@ -1873,6 +1882,17 @@ static void arcturus_dump_pptable(struct smu_context *smu) } +static bool arcturus_is_dpm_running (struct smu_context *smu) { +int ret =0 ; +uint32_t feature_mask[2 ]; +unsigned long feature_enabled; + ret =smu_feature_get_enabled_mask (smu, feature_mask,2 ); + feature_enabled = (unsigned long )((uint64_t )feature_mask[0 ] | + ((uint64_t )feature_mask[1 ] <<32 )); +return !!(feature_enabled &SMC_DPM_FEATURE ); } +static const struct pptable_funcs arcturus_ppt_funcs = {/* translate smu index into arcturus specific index */ .get_smu_msg_index = arcturus_get_smu_msg_index, @@ -1910,6 +1930,7 @@ static const struct pptable_funcs arcturus_ppt_funcs = {/* debug (internal used) */ .dump_pptable = arcturus_dump_pptable, .get_power_limit = arcturus_get_power_limit, + .is_dpm_running = arcturus_is_dpm_running, };
Quoted 8 lines
Quoted 8 lines
void
arcturus_set_ppt_funcs(struct smu_context *smu)
--
2.7.4_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus
In reply to a message not in the archiveif any DPM feature is enabled, then DPM is running, return true.
if all DPM feature is disabled, the DPM is not running, return false.
so the macro of "SMC_DPM_FEATURE" should be include all dpm feature, whether is enabled or supported. i think the @Gui, Jack<mailto:[email protected]>'s patch is right.
Best Regards,
Kevin
________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Quan, Evan <[email protected]>
Sent: Monday, August 12, 2019 5:38 PM
To: Gui, Jack <[email protected]>; [email protected] <[email protected]>
Cc: Gui, Jack <[email protected]>
Subject: RE: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus
Please set FEATURE_DPM_PREFETCHER_MASK | FEATURE_DPM_GFXCLK_MASK only. For now, only these two are enabled on arcturus.
With that fixed, the patch is reviewed-by: Evan Quan <[email protected]>
Quoted 66 lines
-----Original Message-----
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> On Behalf Of Chengming Gui
Sent: Monday, August 12, 2019 4:22 PM
To: [email protected]
Cc: Gui, Jack <[email protected]>
Subject: [PATCH 2/2] drm/amd/powerplay: addarcturus_is_dpm_running
function for arcturusadd
arcturus_is_dpm_runningfunctionSigned-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +20
-1@@ -51,6 +51,15 @@#define SMU_FEATURES_HIGH_MASK 0xFFFFFFFF00000000#define SMU_FEATURES_HIGH_SHIFT 32 +#define SMC_DPM_FEATURE ( \ + FEATURE_DPM_PREFETCHER_MASK | \ + FEATURE_DPM_GFXCLK_MASK | \ + FEATURE_DPM_UCLK_MASK | \ + FEATURE_DPM_SOCCLK_MASK | \ + FEATURE_DPM_MP0CLK_MASK | \ + FEATURE_DPM_FCLK_MASK | \ + FEATURE_DPM_XGMI_MASK) +/* possible frequency drift (1Mhz) */ #define EPSILON 1@@ -1873,6 +1882,17 @@ static void arcturus_dump_pptable(struct smu_context *smu) } +static bool arcturus_is_dpm_running (struct smu_context *smu) { +int ret =0 ; +uint32_t feature_mask[2 ]; +unsigned long feature_enabled; + ret =smu_feature_get_enabled_mask (smu, feature_mask,2 ); + feature_enabled = (unsigned long )((uint64_t )feature_mask[0 ] | + ((uint64_t )feature_mask[1 ] <<32 )); +return !!(feature_enabled &SMC_DPM_FEATURE ); } +static const struct pptable_funcs arcturus_ppt_funcs = {/* translate smu index into arcturus specific index */ .get_smu_msg_index = arcturus_get_smu_msg_index, @@ -1910,6 +1930,7 @@ static const struct pptable_funcs arcturus_ppt_funcs = {/* debug (internal used) */ .dump_pptable = arcturus_dump_pptable, .get_power_limit = arcturus_get_power_limit, + .is_dpm_running = arcturus_is_dpm_running, };void arcturus_set_ppt_funcs (struct smu_context *smu) --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Kevin Wang
Reviewed-byQuoted 12 lines · Chengming Gui
remove redundancy debug log about smu unsupported features
Signed-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +0
-0
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c static int arcturus_get_smu_feature_index(struct smu_context *smc, uint32_t inde · line 220
Quoted 7 lines
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +0
-1@@ -215,7 +215,6 @@ static int arcturus_get_smu_feature_index(struct smu_context *smc, uint32_t inde mapping = arcturus_feature_mask_map[index];if (!(mapping.valid_mapping)) { -pr_warn ("Unsupported SMU feature: %d\n" , index);return -EINVAL ; }
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quan, Evan
Reviewed-by Evan QuanQuoted 33 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Chengming Gui
Sent: Monday, August 12, 2019 4:22 PM
To: [email protected]
Cc: Gui, Jack <[email protected]>
Subject: [PATCH 1/2] drm/amd/powerplay: remove redundancy debug log about smu unsupported featuresremove redundancy debug log about smu unsupported features
Signed-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +0
-0@@ -215,7 +215,6 @@ static int arcturus_get_smu_feature_index(struct
smu_context*smc,uint32_tindedrivers/gpu/drm/amd/powerplay/arcturus_ppt.c +0
-2mapping = arcturus_feature_mask_map[index];if (!(mapping.valid_mapping)) { -pr_warn ("Unsupported SMU feature: %d\n" , index);return -EINVAL ; } --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx