Skip to contentSkip to conversation

spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

PATCH Superseded Ye Li 4 participants 33 messages Aug 14, 2019 – Oct 23, 2019 SPI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Ye Li

author
#0 lore raw

PATCH 1/6 spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when DDR_EN is set. Otherwise, the TX DDR delay logic won't be enabled.

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

---
 drivers/spi/fsl_qspi.c | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)
drivers/spi/fsl_qspi.c +16 -14
index 41abe19..8845986 100644
@@ -399,7 +399,7 @@ static inline void qspi_ahb_read(struct fsl_qspi_priv *priv, u8 *rxbuf, int len)
 
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 
 	rx_addr = (void *)(uintptr_t)(priv->cur_amba_base + priv->sf_addr);
 	/* Read out the data directly from the AHB buffer. */
@@ -429,6 +429,14 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv *priv)
 	reg |= BIT(29);
 
 	qspi_write32(priv->flags, &regs->mcr, reg);
+
+	/* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc
+	 * These two bits are reserved on other platforms
+	 */
+	reg = qspi_read32(priv->flags, &regs->flshcr);
+	reg &= ~(BIT(17));
+	reg |= BIT(16);
+	qspi_write32(priv->flags, &regs->flshcr, reg);
 }
 
 /*
@@ -482,7 +490,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -527,7 +535,7 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -573,7 +581,7 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	to_or_from = priv->sf_addr + priv->cur_amba_base;
@@ -625,7 +633,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	status_reg = 0;
@@ -700,7 +708,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv *priv, void *rxbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -737,7 +745,7 @@ static void qspi_op_erase(struct fsl_qspi_priv *priv)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	to_or_from = priv->sf_addr + priv->cur_amba_base;
@@ -900,15 +908,9 @@ static int fsl_qspi_probe(struct udevice *bus)
 		return ret;
 	}
 
-	mcr_val = qspi_read32(priv->flags, &priv->regs->mcr);
-
-	/* Set endianness to LE for i.mx */
-	if (IS_ENABLED(CONFIG_MX6) || IS_ENABLED(CONFIG_MX7))
-		mcr_val = QSPI_MCR_END_CFD_LE;
-
 	qspi_write32(priv->flags, &priv->regs->mcr,
 		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_MDIS_MASK |
-		     (mcr_val & QSPI_MCR_END_CFD_MASK));
+		     QSPI_MCR_END_CFD_LE);
 
 	qspi_cfg_smpr(priv, ~(QSPI_SMPR_FSDLY_MASK | QSPI_SMPR_DDRSMP_MASK |
 		QSPI_SMPR_FSPHS_MASK | QSPI_SMPR_HSENA_MASK), 0);
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/6 spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Please ignore the patch set. I will send out V2 to remove 2 patches.

Quoted 115 lines

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when DDR_EN is set. Otherwise, the TX DDR delay logic won't be enabled.

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

---
 drivers/spi/fsl_qspi.c | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)
drivers/spi/fsl_qspi.c +16 -14
index 41abe19..8845986 100644
@@ -399,7 +399,7 @@ static inline void qspi_ahb_read(struct fsl_qspi_priv *priv, u8 *rxbuf, int len)
 
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 
 	rx_addr = (void *)(uintptr_t)(priv->cur_amba_base + priv->sf_addr);
 	/* Read out the data directly from the AHB buffer. */
@@ -429,6 +429,14 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv *priv)
 	reg |= BIT(29);
 
 	qspi_write32(priv->flags, &regs->mcr, reg);
+
+	/* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc
+	 * These two bits are reserved on other platforms
+	 */
+	reg = qspi_read32(priv->flags, &regs->flshcr);
+	reg &= ~(BIT(17));
+	reg |= BIT(16);
+	qspi_write32(priv->flags, &regs->flshcr, reg);
 }
 
 /*
@@ -482,7 +490,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -527,7 +535,7 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -573,7 +581,7 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	to_or_from = priv->sf_addr + priv->cur_amba_base;
@@ -625,7 +633,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	status_reg = 0;
@@ -700,7 +708,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv *priv, void *rxbuf, u32 len)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -737,7 +745,7 @@ static void qspi_op_erase(struct fsl_qspi_priv *priv)
 	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
 	qspi_write32(priv->flags, &regs->mcr,
 		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
 	to_or_from = priv->sf_addr + priv->cur_amba_base;
@@ -900,15 +908,9 @@ static int fsl_qspi_probe(struct udevice *bus)
 		return ret;
 	}
 
-	mcr_val = qspi_read32(priv->flags, &priv->regs->mcr);
-
-	/* Set endianness to LE for i.mx */
-	if (IS_ENABLED(CONFIG_MX6) || IS_ENABLED(CONFIG_MX7))
-		mcr_val = QSPI_MCR_END_CFD_LE;
-
 	qspi_write32(priv->flags, &priv->regs->mcr,
 		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_MDIS_MASK |
-		     (mcr_val & QSPI_MCR_END_CFD_MASK));
+		     QSPI_MCR_END_CFD_LE);
 
 	qspi_cfg_smpr(priv, ~(QSPI_SMPR_FSDLY_MASK | QSPI_SMPR_DDRSMP_MASK |
 		QSPI_SMPR_FSPHS_MASK | QSPI_SMPR_HSENA_MASK), 0);
author
#2 lore raw

PATCH 2/6 spi: fsl_qspi: Fix erase issue to adapt spi-mem

In reply to Ye Li

After switched to spi-mem, the data format passed by xfer is changed for erase. The address of erase is moved to data phase in SPI_XFER_END. Update the driver to fix the erase issue

---
 drivers/spi/fsl_qspi.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
drivers/spi/fsl_qspi.c +13 -4
index 8845986..13cf0e9 100644
@@ -785,6 +785,19 @@ int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int bitlen,
 		}
 
 		if (flags == SPI_XFER_END) {
+			if ((priv->cur_seqid == QSPI_CMD_SE) ||
+				(priv->cur_seqid == QSPI_CMD_BE_4K)) {
+				int i;
+				txbuf = *(u8 *)dout;
+				for (i = 1; i < bytes; i++) {
+					txbuf <<= 8;
+					txbuf |= *(((u8 *)dout) + i);
+				}
+
+				priv->sf_addr = txbuf;
+				qspi_op_erase(priv);
+				return 0;
+			}
 			priv->sf_addr = wr_sfaddr;
 			qspi_op_write(priv, (u8 *)dout, bytes);
 			return 0;
@@ -793,10 +806,6 @@ int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int bitlen,
 		if (priv->cur_seqid == QSPI_CMD_FAST_READ ||
 		    priv->cur_seqid == QSPI_CMD_RDAR) {
 			priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
-		} else if ((priv->cur_seqid == QSPI_CMD_SE) ||
-			   (priv->cur_seqid == QSPI_CMD_BE_4K)) {
-			priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
-			qspi_op_erase(priv);
 		} else if (priv->cur_seqid == QSPI_CMD_PP ||
 			   priv->cur_seqid == QSPI_CMD_WRAR) {
 			wr_sfaddr = swab32(txbuf) & OFFSET_BITS_MASK;
Signature · 1 line
2.7.4
#3 lore raw

PATCH 2/6 spi: fsl_qspi: Fix erase issue to adapt spi-mem

Quoted 11 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Ye Li
Sent: Wednesday, August 14, 2019 3:39 PM
To: jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: [EXT] [U-Boot] [PATCH 2/6] spi: fsl_qspi: Fix erase issue to adapt spi- mem

Quoted 5 lines

Caution: EXT Email

After switched to spi-mem, the data format passed by xfer is changed for erase. The address of erase is moved to data phase in SPI_XFER_END. Update the driver to fix the erase issue

This does not seems true. Which u-boot version are you referring?
With new SPI-MEM frame work, sequence ID is now of 4-byte addressing is size is >16MB, a fsl_qspi.c patch was posted upstream but it was asked to move to spi-mem.
http://patchwork.ozlabs.org/patch/1091524/

Quoted 32 lines
---
 drivers/spi/fsl_qspi.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
drivers/spi/fsl_qspi.c index renamed from drivers/spi/fsl_qspi.c +0 -0

8845986..13cf0e9 100644

drivers/spi/fsl_qspi.c +13 -0
@@ -785,6 +785,19 @@ int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int
 bitlen,
                }
 
                if (flags == SPI_XFER_END) {
+                       if ((priv->cur_seqid == QSPI_CMD_SE) ||
+                               (priv->cur_seqid == QSPI_CMD_BE_4K)) {
+                               int i;
+                               txbuf = *(u8 *)dout;
+                               for (i = 1; i < bytes; i++) {
+                                       txbuf <<= 8;
+                                       txbuf |= *(((u8 *)dout) + i);
+                               }
+
+                               priv->sf_addr = txbuf;
+                               qspi_op_erase(priv);
+                               return 0;
+                       }
                        priv->sf_addr = wr_sfaddr;
                        qspi_op_write(priv, (u8 *)dout, bytes);
                        return 0;

drivers/spi/fsl_qspi.c int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int · line 800

Quoted 8 lines
drivers/spi/fsl_qspi.c +0 -4
@@ -793,10 +806,6 @@ int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int
 bitlen,
                if (priv->cur_seqid == QSPI_CMD_FAST_READ ||
                    priv->cur_seqid == QSPI_CMD_RDAR) {
                        priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
-               } else if ((priv->cur_seqid == QSPI_CMD_SE) ||
-                          (priv->cur_seqid == QSPI_CMD_BE_4K)) {
-                       priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
-                       qspi_op_erase(priv);

I update this on internal repo and it works:
driver/spi/fsl_qspi : update op_erase wrt 24/32 bits address

drivers/spi/fsl_qspi.c +3 -1
index 300d020486..7aaab8301e 100644
@@ -818,8 +818,10 @@ int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int bitlen,
                } else if (priv->cur_seqid == QSPI_CMD_FAST_READ_4B) {
                        priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
                } else if ((priv->cur_seqid == QSPI_CMD_SE) ||
-                          priv->cur_seqid == QSPI_CMD_SE_4B ||
                           priv->cur_seqid == QSPI_CMD_BE_4K) {
+                       priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK24;
+                       qspi_op_erase(priv);
+               } else if (priv->cur_seqid == QSPI_CMD_SE_4B) {
                        priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
                        qspi_op_erase(priv);
                } else if (priv->cur_seqid == QSPI_CMD_PP ||
Quoted 15 lines
drivers/spi/fsl_qspi.c +0 -0
                } else if (priv->cur_seqid == QSPI_CMD_PP ||
                           priv->cur_seqid == QSPI_CMD_WRAR) {
                        wr_sfaddr = swab32(txbuf) & OFFSET_BITS_MASK;

--
2.7.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
enx.de%2Flistinfo%2Fu- boot&amp;data=02%7C01%7CAshish.Kumar%40nxp.com%7C360e07152fea4 278ec9008d7209fbc7a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% 7C637013742744957457&amp;sdata=FRanhGdnBuIBIF433L8PQeqTvFDrktwv %2BQjKPROFwMw%3D&amp;reserved=0

author
#4 lore raw

PATCH 2/6 spi: fsl_qspi: Fix erase issue to adapt spi-mem

Hi Ashish,

Quoted 11 lines
Quoted 11 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Ye Li
Sent: Wednesday, August 14, 2019 3:39 PM
To: jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: [EXT] [U-Boot] [PATCH 2/6] spi: fsl_qspi: Fix erase issue to adapt spi- mem

Quoted 9 lines
Quoted 5 lines

Caution: EXT Email

After switched to spi-mem, the data format passed by xfer is changed for erase. The address of erase is moved to data phase in SPI_XFER_END. Update the driver to fix the erase issue

This does not seems true. Which u-boot version are you referring?
With new SPI-MEM frame work, sequence ID is now of 4-byte addressing is size is >16MB, a fsl_qspi.c patch was posted upstream but it was asked to move to spi-mem.
http://patchwork.ozlabs.org/patch/1091524/

I have sent out v2. Patch2 and 6 are removed from v2. They have been fixed in spi-nor-core.

Best regards,
Ye Li

Quoted 78 lines
Quoted 32 lines
---
 drivers/spi/fsl_qspi.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
drivers/spi/fsl_qspi.c index renamed from drivers/spi/fsl_qspi.c +0 -0

8845986..13cf0e9 100644

drivers/spi/fsl_qspi.c +13 -0
@@ -785,6 +785,19 @@ int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int
 bitlen,
                }
 
                if (flags == SPI_XFER_END) {
+                       if ((priv->cur_seqid == QSPI_CMD_SE) ||
+                               (priv->cur_seqid == QSPI_CMD_BE_4K)) {
+                               int i;
+                               txbuf = *(u8 *)dout;
+                               for (i = 1; i < bytes; i++) {
+                                       txbuf <<= 8;
+                                       txbuf |= *(((u8 *)dout) + i);
+                               }
+
+                               priv->sf_addr = txbuf;
+                               qspi_op_erase(priv);
+                               return 0;
+                       }
                        priv->sf_addr = wr_sfaddr;
                        qspi_op_write(priv, (u8 *)dout, bytes);
                        return 0;

drivers/spi/fsl_qspi.c int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int · line 800

Quoted 8 lines
drivers/spi/fsl_qspi.c +0 -4
@@ -793,10 +806,6 @@ int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int
 bitlen,
                if (priv->cur_seqid == QSPI_CMD_FAST_READ ||
                    priv->cur_seqid == QSPI_CMD_RDAR) {
                        priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
-               } else if ((priv->cur_seqid == QSPI_CMD_SE) ||
-                          (priv->cur_seqid == QSPI_CMD_BE_4K)) {
-                       priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
-                       qspi_op_erase(priv);

I update this on internal repo and it works:
driver/spi/fsl_qspi : update op_erase wrt 24/32 bits address

drivers/spi/fsl_qspi.c +3 -1
index 300d020486..7aaab8301e 100644
@@ -818,8 +818,10 @@ int qspi_xfer(struct fsl_qspi_priv *priv, unsigned int bitlen,
                } else if (priv->cur_seqid == QSPI_CMD_FAST_READ_4B) {
                        priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
                } else if ((priv->cur_seqid == QSPI_CMD_SE) ||
-                          priv->cur_seqid == QSPI_CMD_SE_4B ||
                           priv->cur_seqid == QSPI_CMD_BE_4K) {
+                       priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK24;
+                       qspi_op_erase(priv);
+               } else if (priv->cur_seqid == QSPI_CMD_SE_4B) {
                        priv->sf_addr = swab32(txbuf) & OFFSET_BITS_MASK;
                        qspi_op_erase(priv);
                } else if (priv->cur_seqid == QSPI_CMD_PP ||
Quoted 16 lines
drivers/spi/fsl_qspi.c +0 -0
                } else if (priv->cur_seqid == QSPI_CMD_PP ||
                           priv->cur_seqid == QSPI_CMD_WRAR) {
                        wr_sfaddr = swab32(txbuf) & OFFSET_BITS_MASK;

--
2.7.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
enx.de%2Flistinfo%2Fu- boot&amp;data=02%7C01%7CAshish.Kumar%40nxp.com%7C360e07152fea4 278ec9008d7209fbc7a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% 7C637013742744957457&amp;sdata=FRanhGdnBuIBIF433L8PQeqTvFDrktwv %2BQjKPROFwMw%3D&amp;reserved=0

author
#5 lore raw

PATCH 3/6 spi: fsl_qspi: Update write data size for page program LUT

In reply to Ye Li

The write data size can be overwritten by writing to the IDATSZ field of IPCR register. Since the driver always updates the IDATSZ in page program operation. Set the LUT data size to 0 to align the codes with iMX.

---
 drivers/spi/fsl_qspi.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/spi/fsl_qspi.c +1 -11
index 13cf0e9..21c2bf5 100644
@@ -273,19 +273,9 @@ static void qspi_set_lut(struct fsl_qspi_priv *priv)
 			     INSTR0(LUT_CMD) | OPRND1(ADDR32BIT) |
 			     PAD1(LUT_PAD1) | INSTR1(LUT_ADDR));
 #endif
-#if defined(CONFIG_MX6SX) || defined(CONFIG_MX6UL) || \
-	defined(CONFIG_MX6ULL) || defined(CONFIG_MX7D)
-	/*
-	 * To MX6SX, OPRND0(TX_BUFFER_SIZE) can not work correctly.
-	 * So, Use IDATSZ in IPCR to determine the size and here set 0.
-	 */
+	/* Use IDATSZ in IPCR to determine the size and here set 0. */
 	qspi_write32(priv->flags, &regs->lut[lut_base + 1], OPRND0(0) |
 		     PAD0(LUT_PAD1) | INSTR0(LUT_WRITE));
-#else
-	qspi_write32(priv->flags, &regs->lut[lut_base + 1],
-		     OPRND0(TX_BUFFER_SIZE) |
-		     PAD0(LUT_PAD1) | INSTR0(LUT_WRITE));
-#endif
 	qspi_write32(priv->flags, &regs->lut[lut_base + 2], 0);
 	qspi_write32(priv->flags, &regs->lut[lut_base + 3], 0);
 
Signature · 1 line
2.7.4
author
#6 lore raw

PATCH 4/6 spi: fsl_qspi: Update to use driver data

In reply to Ye Li

Add the driver data for each compatible string. So we can remove the SOC config and use driver data instead.

---
 drivers/spi/fsl_qspi.c | 113 ++++++++++++++++++++++++++++++++++---------------
 1 file changed, 79 insertions(+), 34 deletions(-)
drivers/spi/fsl_qspi.c +79 -34
index 21c2bf5..8950412 100644
@@ -19,14 +19,6 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#define RX_BUFFER_SIZE		0x80
-#if defined(CONFIG_MX6SX) || defined(CONFIG_MX6UL) || \
-	defined(CONFIG_MX6ULL) || defined(CONFIG_MX7D)
-#define TX_BUFFER_SIZE		0x200
-#else
-#define TX_BUFFER_SIZE		0x40
-#endif
-
 #define OFFSET_BITS_MASK	GENMASK(23, 0)
 
 #define FLASH_STATUS_WEL	0x02
@@ -85,6 +77,23 @@ DECLARE_GLOBAL_DATA_PTR;
 /* QSPI max chipselect signals number */
 #define FSL_QSPI_MAX_CHIPSELECT_NUM     4
 
+/* Controller needs driver to swap endian */
+#define QUADSPI_QUIRK_SWAP_ENDIAN	BIT(0)
+
+enum fsl_qspi_devtype {
+	FSL_QUADSPI_VYBRID,
+	FSL_QUADSPI_IMX6SX,
+	FSL_QUADSPI_IMX6UL_7D,
+};
+
+struct fsl_qspi_devtype_data {
+	enum fsl_qspi_devtype devtype;
+	u32 rxfifo;
+	u32 txfifo;
+	u32 ahb_buf_size;
+	u32 driver_data;
+};
+
 /**
  * struct fsl_qspi_platdata - platform data for Freescale QSPI
  *
@@ -133,8 +142,32 @@ struct fsl_qspi_priv {
 	u32 flash_num;
 	u32 num_chipselect;
 	struct fsl_qspi_regs *regs;
+	struct fsl_qspi_devtype_data *devtype_data;
 };
 
+static const struct fsl_qspi_devtype_data vybrid_data = {
+	.devtype = FSL_QUADSPI_VYBRID,
+	.rxfifo = 128,
+	.txfifo = 64,
+	.ahb_buf_size = 1024,
+	.driver_data = QUADSPI_QUIRK_SWAP_ENDIAN,
+};
+
+static const struct fsl_qspi_devtype_data imx6sx_data = {
+	.devtype = FSL_QUADSPI_IMX6SX,
+	.rxfifo = 128,
+	.txfifo = 512,
+	.ahb_buf_size = 1024,
+	.driver_data = 0,
+};
+
+static const struct fsl_qspi_devtype_data imx6ul_7d_data = {
+	.devtype = FSL_QUADSPI_IMX6UL_7D,
+	.rxfifo = 128,
+	.txfifo = 512,
+	.ahb_buf_size = 1024,
+	.driver_data = 0,
+};
 
 static u32 qspi_read32(u32 flags, u32 *addr)
 {
@@ -162,13 +195,12 @@ static inline int is_controller_busy(const struct fsl_qspi_priv *priv)
 
 /* QSPI support swapping the flash read/write data
  * in hardware for LS102xA, but not for VF610 */
-static inline u32 qspi_endian_xchg(u32 data)
+static inline u32 qspi_endian_xchg(struct fsl_qspi_priv *priv, u32 data)
 {
-#ifdef CONFIG_VF610
-	return swab32(data);
-#else
-	return data;
-#endif
+	if (priv->devtype_data->driver_data & QUADSPI_QUIRK_SWAP_ENDIAN)
+		return swab32(data);
+	else
+		return data;
 }
 
 static void qspi_set_lut(struct fsl_qspi_priv *priv)
@@ -210,7 +242,7 @@ static void qspi_set_lut(struct fsl_qspi_priv *priv)
 #endif
 	qspi_write32(priv->flags, &regs->lut[lut_base + 1],
 		     OPRND0(8) | PAD0(LUT_PAD1) | INSTR0(LUT_DUMMY) |
-		     OPRND1(RX_BUFFER_SIZE) | PAD1(LUT_PAD1) |
+		     OPRND1(priv->devtype_data->rxfifo) | PAD1(LUT_PAD1) |
 		     INSTR1(LUT_READ));
 	qspi_write32(priv->flags, &regs->lut[lut_base + 2], 0);
 	qspi_write32(priv->flags, &regs->lut[lut_base + 3], 0);
@@ -417,7 +449,6 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv *priv)
 	reg |= QSPI_MCR_DDR_EN_MASK;
 	/* Enable bit 29 for imx6sx */
 	reg |= BIT(29);
-
 	qspi_write32(priv->flags, &regs->mcr, reg);
 
 	/* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc
@@ -451,7 +482,7 @@ static void qspi_init_ahb_read(struct fsl_qspi_priv *priv)
 	qspi_write32(priv->flags, &regs->buf1cr, QSPI_BUFXCR_INVALID_MSTRID);
 	qspi_write32(priv->flags, &regs->buf2cr, QSPI_BUFXCR_INVALID_MSTRID);
 	qspi_write32(priv->flags, &regs->buf3cr, QSPI_BUF3CR_ALLMST_MASK |
-		     (0x80 << QSPI_BUF3CR_ADATSZ_SHIFT));
+		     ((priv->devtype_data->ahb_buf_size >> 3) << QSPI_BUF3CR_ADATSZ_SHIFT));
 
 	/* We only use the buffer3 */
 	qspi_write32(priv->flags, &regs->buf0ind, 0);
@@ -503,7 +534,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)
 		reg = qspi_read32(priv->flags, &regs->rbsr);
 		if (reg & QSPI_RBSR_RDBFL_MASK) {
 			data = qspi_read32(priv->flags, &regs->rbdr[0]);
-			data = qspi_endian_xchg(data);
+			data = qspi_endian_xchg(priv, data);
 			memcpy(rxbuf, &data, len);
 			qspi_write32(priv->flags, &regs->mcr,
 				     qspi_read32(priv->flags, &regs->mcr) |
@@ -536,13 +567,13 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
 		;
 
 	i = 0;
-	while ((RX_BUFFER_SIZE >= len) && (len > 0)) {
+	while ((priv->devtype_data->rxfifo >= len) && (len > 0)) {
 		WATCHDOG_RESET();
 
 		rbsr_reg = qspi_read32(priv->flags, &regs->rbsr);
 		if (rbsr_reg & QSPI_RBSR_RDBFL_MASK) {
 			data = qspi_read32(priv->flags, &regs->rbdr[i]);
-			data = qspi_endian_xchg(data);
+			data = qspi_endian_xchg(priv, data);
 			size = (len < 4) ? len : 4;
 			memcpy(rxbuf, &data, size);
 			len -= size;
@@ -581,8 +612,8 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
 
 		qspi_write32(priv->flags, &regs->sfar, to_or_from);
 
-		size = (len > RX_BUFFER_SIZE) ?
-			RX_BUFFER_SIZE : len;
+		size = (len > priv->devtype_data->rxfifo) ?
+			priv->devtype_data->rxfifo : len;
 
 		qspi_write32(priv->flags, &regs->ipcr,
 			     (seqid << QSPI_IPCR_SEQID_SHIFT) |
@@ -594,9 +625,9 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
 		len -= size;
 
 		i = 0;
-		while ((RX_BUFFER_SIZE >= size) && (size > 0)) {
+		while ((priv->devtype_data->rxfifo >= size) && (size > 0)) {
 			data = qspi_read32(priv->flags, &regs->rbdr[i]);
-			data = qspi_endian_xchg(data);
+			data = qspi_endian_xchg(priv, data);
 			if (size < 4)
 				memcpy(rxbuf, &data, size);
 			else
@@ -643,7 +674,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf, u32 len)
 		reg = qspi_read32(priv->flags, &regs->rbsr);
 		if (reg & QSPI_RBSR_RDBFL_MASK) {
 			status_reg = qspi_read32(priv->flags, &regs->rbdr[0]);
-			status_reg = qspi_endian_xchg(status_reg);
+			status_reg = qspi_endian_xchg(priv, status_reg);
 		}
 		qspi_write32(priv->flags, &regs->mcr,
 			     qspi_read32(priv->flags, &regs->mcr) |
@@ -665,8 +696,8 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf, u32 len)
 
 	qspi_write32(priv->flags, &regs->sfar, to_or_from);
 
-	tx_size = (len > TX_BUFFER_SIZE) ?
-		TX_BUFFER_SIZE : len;
+	tx_size = (len > priv->devtype_data->txfifo) ?
+		priv->devtype_data->txfifo : len;
 
 	size = tx_size / 16;
 	/*
@@ -677,7 +708,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf, u32 len)
 		size++;
 	for (i = 0; i < size * 4; i++) {
 		memcpy(&data, txbuf, 4);
-		data = qspi_endian_xchg(data);
+		data = qspi_endian_xchg(priv, data);
 		qspi_write32(priv->flags, &regs->tbdr, data);
 		txbuf += 4;
 	}
@@ -714,7 +745,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv *priv, void *rxbuf, u32 len)
 		reg = qspi_read32(priv->flags, &regs->rbsr);
 		if (reg & QSPI_RBSR_RDBFL_MASK) {
 			data = qspi_read32(priv->flags, &regs->rbdr[0]);
-			data = qspi_endian_xchg(data);
+			data = qspi_endian_xchg(priv, data);
 			memcpy(rxbuf, &data, len);
 			qspi_write32(priv->flags, &regs->mcr,
 				     qspi_read32(priv->flags, &regs->mcr) |
@@ -866,8 +897,9 @@ void qspi_cfg_smpr(struct fsl_qspi_priv *priv, u32 clear_bits, u32 set_bits)
 static int fsl_qspi_child_pre_probe(struct udevice *dev)
 {
 	struct spi_slave *slave = dev_get_parent_priv(dev);
+	struct fsl_qspi_priv *priv = dev_get_priv(dev_get_parent(dev));
 
-	slave->max_write_size = TX_BUFFER_SIZE;
+	slave->max_write_size = priv->devtype_data->txfifo;
 
 	return 0;
 }
@@ -899,6 +931,19 @@ static int fsl_qspi_probe(struct udevice *bus)
 	priv->flash_num = plat->flash_num;
 	priv->num_chipselect = plat->num_chipselect;
 
+	priv->devtype_data = (struct fsl_qspi_devtype_data *)dev_get_driver_data(bus);
+	if (!priv->devtype_data) {
+		printf("ERROR : No devtype_data found\n");
+		return -ENODEV;
+	}
+
+	debug("devtype=%d, txfifo=%d, rxfifo=%d, ahb=%d, data=0x%x\n",
+		priv->devtype_data->devtype,
+		priv->devtype_data->txfifo,
+		priv->devtype_data->rxfifo,
+		priv->devtype_data->ahb_buf_size,
+		priv->devtype_data->driver_data);
+
 	/* make sure controller is not busy anywhere */
 	ret = is_controller_busy(priv);
 
@@ -1105,10 +1150,10 @@ static const struct dm_spi_ops fsl_qspi_ops = {
 };
 
 static const struct udevice_id fsl_qspi_ids[] = {
-	{ .compatible = "fsl,vf610-qspi" },
-	{ .compatible = "fsl,imx6sx-qspi" },
-	{ .compatible = "fsl,imx6ul-qspi" },
-	{ .compatible = "fsl,imx7d-qspi" },
+	{ .compatible = "fsl,vf610-qspi", .data = (ulong)&vybrid_data },
+	{ .compatible = "fsl,imx6sx-qspi", .data = (ulong)&imx6sx_data },
+	{ .compatible = "fsl,imx6ul-qspi", .data = (ulong)&imx6ul_7d_data },
+	{ .compatible = "fsl,imx7d-qspi", .data = (ulong)&imx6ul_7d_data },
 	{ }
 };
 
Signature · 1 line
2.7.4
author
#7 lore raw

PATCH 5/6 spi: fsl_qspi: Add support for QSPI on iMX7ULP

In reply to Ye Li

Add the compatible string and driver data for iMX7ULP platform

---
 drivers/spi/fsl_qspi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/spi/fsl_qspi.c +10 -0
index 8950412..f3cf8e6 100644
@@ -84,6 +84,7 @@ enum fsl_qspi_devtype {
 	FSL_QUADSPI_VYBRID,
 	FSL_QUADSPI_IMX6SX,
 	FSL_QUADSPI_IMX6UL_7D,
+	FSL_QUADSPI_IMX7ULP,
 };
 
 struct fsl_qspi_devtype_data {
@@ -169,6 +170,14 @@ static const struct fsl_qspi_devtype_data imx6ul_7d_data = {
 	.driver_data = 0,
 };
 
+static const struct fsl_qspi_devtype_data imx7ulp_data = {
+	.devtype = FSL_QUADSPI_IMX7ULP,
+	.rxfifo = 64,
+	.txfifo = 64,
+	.ahb_buf_size = 128,
+	.driver_data = 0,
+};
+
 static u32 qspi_read32(u32 flags, u32 *addr)
 {
 	return flags & QSPI_FLAG_REGMAP_ENDIAN_BIG ?
@@ -1154,6 +1163,7 @@ static const struct udevice_id fsl_qspi_ids[] = {
 	{ .compatible = "fsl,imx6sx-qspi", .data = (ulong)&imx6sx_data },
 	{ .compatible = "fsl,imx6ul-qspi", .data = (ulong)&imx6ul_7d_data },
 	{ .compatible = "fsl,imx7d-qspi", .data = (ulong)&imx6ul_7d_data },
+	{ .compatible = "fsl,imx7ulp-qspi", .data = (ulong)&imx7ulp_data },
 	{ }
 };
 
Signature · 1 line
2.7.4
author
#8 lore raw

PATCH 6/6 spi: fsl_qspi: Fix flash write issue with small TX FIFO

In reply to Ye Li

The page write sequence in spi-mem is changed with orignal spi-flash. When the max_write_size is set by driver, the orignal sequence is
1. WREN
2. write max_write_size data to flash
3. wait for WIP clean
4. back to #1 if having data remained in a page.

The new sequence is:
1. WREN
2. write (max_write_size - command length) data to flash
3. back to #2 if having data remained in a page
4. wait for WIP clean

If TX FIFO (max_write_size) is small (for example iMX7ULP only has 64 bytes TX FIFO, while other iMX SOCs have 512 bytes), the driver has to check the WIP in step 3. Otherwise the WIP may set due to previous write is not completed by flash device, then cause current write failed.

---
 drivers/spi/fsl_qspi.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
drivers/spi/fsl_qspi.c +22 -0
index f3cf8e6..450155e 100644
@@ -22,6 +22,7 @@ DECLARE_GLOBAL_DATA_PTR;
 #define OFFSET_BITS_MASK	GENMASK(23, 0)
 
 #define FLASH_STATUS_WEL	0x02
+#define FLASH_STATUS_WIP	0x01
 
 /* SEQID */
 #define SEQID_WREN		1
@@ -666,6 +667,27 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf, u32 len)
 		     mcr_reg);
 	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
+	if (priv->devtype_data->txfifo <= 256) {
+		status_reg = 0;
+		do {
+			WATCHDOG_RESET();
+
+			qspi_write32(priv->flags, &regs->ipcr,
+				     (SEQID_RDSR << QSPI_IPCR_SEQID_SHIFT) | 1);
+			while (qspi_read32(priv->flags, &regs->sr) & QSPI_SR_BUSY_MASK)
+				;
+
+			reg = qspi_read32(priv->flags, &regs->rbsr);
+			if (reg & QSPI_RBSR_RDBFL_MASK) {
+				status_reg = qspi_read32(priv->flags, &regs->rbdr[0]);
+				status_reg = qspi_endian_xchg(priv, status_reg);
+			}
+			qspi_write32(priv->flags, &regs->mcr,
+				     qspi_read32(priv->flags, &regs->mcr) |
+				     QSPI_MCR_CLR_RXF_MASK);
+		} while ((status_reg & FLASH_STATUS_WIP) == FLASH_STATUS_WIP);
+	}
+
 	status_reg = 0;
 	while ((status_reg & FLASH_STATUS_WEL) != FLASH_STATUS_WEL) {
 		WATCHDOG_RESET();
Signature · 1 line
2.7.4
#9 lore raw

PATCH 1/6 spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

In reply to Ye Li

Hi Ye,

Quoted 4 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when DDR_EN is set. Otherwise, the TX DDR delay logic won't be enabled.

This is actually an issue I have experienced myself. But in our case this behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

Quoted 5 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

The best way to fix all of these things (also the ones in the other patches) would be to fix them in Linux and port the driver from Linux to U-Boot. Actually I've already done most of the porting [2], but didn't have the time to finish it recently. It probably needs some rebasing and testing.

Could you port your fixes to the Linux driver and submit them to linux-mtd?

Thanks
Frieder

[1] https://community.nxp.com/thread/507260
[2] https://github.com/fschrempf/u-boot/commits/fsl_qspi_spimem_port

Quoted 106 lines
---
  drivers/spi/fsl_qspi.c | 30 ++++++++++++++++--------------
  1 file changed, 16 insertions(+), 14 deletions(-)
drivers/spi/fsl_qspi.c +16 -14
index 41abe19..8845986 100644
@@ -399,7 +399,7 @@ static inline void qspi_ahb_read(struct fsl_qspi_priv *priv, u8 *rxbuf, int len)
 
  	qspi_write32(priv->flags, &regs->mcr,
  		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
 
  	rx_addr = (void *)(uintptr_t)(priv->cur_amba_base + priv->sf_addr);
  	/* Read out the data directly from the AHB buffer. */
@@ -429,6 +429,14 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv *priv)
  	reg |= BIT(29);
 
  	qspi_write32(priv->flags, &regs->mcr, reg);
+
+	/* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc
+	 * These two bits are reserved on other platforms
+	 */
+	reg = qspi_read32(priv->flags, &regs->flshcr);
+	reg &= ~(BIT(17));
+	reg |= BIT(16);
+	qspi_write32(priv->flags, &regs->flshcr, reg);
  }
 
  /*
@@ -482,7 +490,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)
  	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
  	qspi_write32(priv->flags, &regs->mcr,
  		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
  	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
  	qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -527,7 +535,7 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
  	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
  	qspi_write32(priv->flags, &regs->mcr,
  		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
  	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
  	qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -573,7 +581,7 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
  	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
  	qspi_write32(priv->flags, &regs->mcr,
  		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
  	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
  	to_or_from = priv->sf_addr + priv->cur_amba_base;
@@ -625,7 +633,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf, u32 len)
  	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
  	qspi_write32(priv->flags, &regs->mcr,
  		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
  	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
  	status_reg = 0;
@@ -700,7 +708,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv *priv, void *rxbuf, u32 len)
  	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
  	qspi_write32(priv->flags, &regs->mcr,
  		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
  	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
  	qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -737,7 +745,7 @@ static void qspi_op_erase(struct fsl_qspi_priv *priv)
  	mcr_reg = qspi_read32(priv->flags, &regs->mcr);
  	qspi_write32(priv->flags, &regs->mcr,
  		     QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+		     mcr_reg);
  	qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
  	to_or_from = priv->sf_addr + priv->cur_amba_base;
@@ -900,15 +908,9 @@ static int fsl_qspi_probe(struct udevice *bus)
  		return ret;
  	}
 
-	mcr_val = qspi_read32(priv->flags, &priv->regs->mcr);
-
-	/* Set endianness to LE for i.mx */
-	if (IS_ENABLED(CONFIG_MX6) || IS_ENABLED(CONFIG_MX7))
-		mcr_val = QSPI_MCR_END_CFD_LE;
-
  	qspi_write32(priv->flags, &priv->regs->mcr,
  		     QSPI_MCR_RESERVED_MASK | QSPI_MCR_MDIS_MASK |
-		     (mcr_val & QSPI_MCR_END_CFD_MASK));
+		     QSPI_MCR_END_CFD_LE);
 
  	qspi_cfg_smpr(priv, ~(QSPI_SMPR_FSDLY_MASK | QSPI_SMPR_DDRSMP_MASK |
  		QSPI_SMPR_FSPHS_MASK | QSPI_SMPR_HSENA_MASK), 0);
#10 lore raw
Quoted 27 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Schrempf Frieder
Sent: Wednesday, August 14, 2019 5:07 PM
To: Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Hi Ye,

Quoted 4 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when DDR_EN is set. Otherwise, the TX DDR delay logic won't be enabled.

This is actually an issue I have experienced myself. But in our case this behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

Quoted 1 line
Quoted 8 lines
Quoted 4 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

The best way to fix all of these things (also the ones in the other patches) would be to fix them in Linux and port the driver from Linux to U- Boot. Actually I've already done most of the porting [2],

Hello Frieder,

I had tested your porting and it was not functional on u-boot.
I found that only erase, read up to TX/RX buf size is working or something like that.
Also ip and AHB mode cannot be used at time in code. Previously only IP mode was used in u-boot,
Since endianness across different QSPI-IP(ls1012, ls1043, ls1021 big endian), (ls1088,ls2088 little endian) is not consistent on various silicon's. I am not sure if Yogesh who worked with you on Linux porting gave you this information about endianness inconsistency.

Please suggest way forward. How to correct this issue?

Regards
Ashish

Quoted 143 lines

time to finish it recently. It probably needs some rebasing and testing.

Could you port your fixes to the Linux driver and submit them to linux-mtd?

Thanks
Frieder

[1]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcomm
unity.nxp.com%2Fthread%2F507260&amp;data=02%7C01%7CAshish.Kumar %40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3bc2b4c 6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata=Za7LB 6RyXAHszPfiEMLDb%2FvVNSTQJwxHFtiapmNi3Co%3D&amp;reserved=0
[2]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
.com%2Ffschrempf%2Fu- boot%2Fcommits%2Ffsl_qspi_spimem_port&amp;data=02%7C01%7CAshish. Kumar%40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3 bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata =kYDjrs2a9DdL8QLFPORfHsMSWvgUxhSTgNC3WLziu7Y%3D&amp;reserved=0

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv

Quoted 36 lines
---
  drivers/spi/fsl_qspi.c | 30 ++++++++++++++++--------------
  1 file changed, 16 insertions(+), 14 deletions(-)
drivers/spi/fsl_qspi.c index renamed from drivers/spi/fsl_qspi.c +0 -0

41abe19..8845986 100644

drivers/spi/fsl_qspi.c +1 -1
@@ -399,7 +399,7 @@ static inline void qspi_ahb_read(struct
 fsl_qspi_priv *priv, u8 *rxbuf, int len)
 
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
 
      rx_addr = (void *)(uintptr_t)(priv->cur_amba_base + priv->sf_addr);
      /* Read out the data directly from the AHB buffer. */ @@ -429,6
+429,14 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv *priv)
      reg |= BIT(29);

      qspi_write32(priv->flags, &regs->mcr, reg);
drivers/spi/fsl_qspi.c +8 -0
+
+     /* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc
+      * These two bits are reserved on other platforms
+      */
+     reg = qspi_read32(priv->flags, &regs->flshcr);
+     reg &= ~(BIT(17));
+     reg |= BIT(16);
+     qspi_write32(priv->flags, &regs->flshcr, reg);
  }
 
  /*
@@ -482,7 +490,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv

*priv, u8 *rxbuf, u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)

Quoted 9 lines
drivers/spi/fsl_qspi.c +1 -2
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base); @@
-527,7 +535,7 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)

Quoted 9 lines
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -2
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base); @@
-573,7 +581,7 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)

Quoted 9 lines
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +2 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -625,7
+633,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf,

u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdsr(struct fsl_qspi_priv *priv,

Quoted 9 lines
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      status_reg = 0;
@@ -700,7 +708,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv *priv,

void *rxbuf, u32 len)

Quoted 23 lines
drivers/spi/fsl_qspi.c +3 -5
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base); @@
-737,7 +745,7 @@ static void qspi_op_erase(struct fsl_qspi_priv *priv)
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -900,15
+908,9 @@ static int fsl_qspi_probe(struct udevice *bus)
              return ret;
      }
 
-     mcr_val = qspi_read32(priv->flags, &priv->regs->mcr);
-

drivers/spi/fsl_qspi.c static void qspi_op_rdsr(struct fsl_qspi_priv *priv,

Quoted 10 lines
drivers/spi/fsl_qspi.c +1 -5
-     /* Set endianness to LE for i.mx */
-     if (IS_ENABLED(CONFIG_MX6) || IS_ENABLED(CONFIG_MX7))
-             mcr_val = QSPI_MCR_END_CFD_LE;
-
      qspi_write32(priv->flags, &priv->regs->mcr,
                   QSPI_MCR_RESERVED_MASK | QSPI_MCR_MDIS_MASK |
-                  (mcr_val & QSPI_MCR_END_CFD_MASK));
+                  QSPI_MCR_END_CFD_LE);
 
      qspi_cfg_smpr(priv, ~(QSPI_SMPR_FSDLY_MASK |

QSPI_SMPR_DDRSMP_MASK |

Quoted 2 lines
              QSPI_SMPR_FSPHS_MASK | QSPI_SMPR_HSENA_MASK), 0);

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
enx.de%2Flistinfo%2Fu- boot&amp;data=02%7C01%7CAshish.Kumar%40nxp.com%7C8882d56622954 68a45b008d720abd98c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 %7C637013794778063281&amp;sdata=l1Pb4yEQABBx5ave4Lb7jGSVRJ1TG68 KMkl7WpSSwRc%3D&amp;reserved=0

#11 lore raw

Hi Ashish,

Quoted 35 lines · Ashish Kumar
Quoted 27 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Schrempf Frieder
Sent: Wednesday, August 14, 2019 5:07 PM
To: Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Hi Ye,

Quoted 4 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when DDR_EN is set. Otherwise, the TX DDR delay logic won't be enabled.

This is actually an issue I have experienced myself. But in our case this behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

Quoted 1 line
Quoted 8 lines
Quoted 4 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

The best way to fix all of these things (also the ones in the other patches) would be to fix them in Linux and port the driver from Linux to U- Boot. Actually I've already done most of the porting [2],

Quoted 6 lines

Hello Frieder,

I had tested your porting and it was not functional on u-boot.
I found that only erase, read up to TX/RX buf size is working or something like that.
Also ip and AHB mode cannot be used at time in code. Previously only IP mode was used in u-boot,
Since endianness across different QSPI-IP(ls1012, ls1043, ls1021 big endian), (ls1088,ls2088 little endian) is not consistent on various silicon's. I am not sure if Yogesh who worked with you on Linux porting gave you this information about endianness inconsistency.

Ok, thanks for your feedback. The endianness for the different SoCs can be handled by the device data.

Quoted 148 lines

Please suggest way forward. How to correct this issue?

Regards
Ashish

Quoted 143 lines

time to finish it recently. It probably needs some rebasing and testing.

Could you port your fixes to the Linux driver and submit them to linux-mtd?

Thanks
Frieder

[1]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcomm
unity.nxp.com%2Fthread%2F507260&amp;data=02%7C01%7CAshish.Kumar %40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3bc2b4c 6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata=Za7LB 6RyXAHszPfiEMLDb%2FvVNSTQJwxHFtiapmNi3Co%3D&amp;reserved=0
[2]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
.com%2Ffschrempf%2Fu- boot%2Fcommits%2Ffsl_qspi_spimem_port&amp;data=02%7C01%7CAshish. Kumar%40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3 bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata =kYDjrs2a9DdL8QLFPORfHsMSWvgUxhSTgNC3WLziu7Y%3D&amp;reserved=0

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv

Quoted 36 lines
---
   drivers/spi/fsl_qspi.c | 30 ++++++++++++++++--------------
   1 file changed, 16 insertions(+), 14 deletions(-)
drivers/spi/fsl_qspi.c index renamed from drivers/spi/fsl_qspi.c +0 -0

41abe19..8845986 100644

drivers/spi/fsl_qspi.c +1 -1
@@ -399,7 +399,7 @@ static inline void qspi_ahb_read(struct
 fsl_qspi_priv *priv, u8 *rxbuf, int len)
 
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
 
       rx_addr = (void *)(uintptr_t)(priv->cur_amba_base + priv->sf_addr);
       /* Read out the data directly from the AHB buffer. */ @@ -429,6
+429,14 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv *priv)
       reg |= BIT(29);

       qspi_write32(priv->flags, &regs->mcr, reg);
drivers/spi/fsl_qspi.c +8 -0
+
+     /* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc
+      * These two bits are reserved on other platforms
+      */
+     reg = qspi_read32(priv->flags, &regs->flshcr);
+     reg &= ~(BIT(17));
+     reg |= BIT(16);
+     qspi_write32(priv->flags, &regs->flshcr, reg);
   }
 
   /*
@@ -482,7 +490,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv

*priv, u8 *rxbuf, u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)

Quoted 9 lines
drivers/spi/fsl_qspi.c +1 -2
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base); @@
-527,7 +535,7 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)

Quoted 9 lines
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -2
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base); @@
-573,7 +581,7 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)

Quoted 9 lines
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +2 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
       to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -625,7
+633,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf,

u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdsr(struct fsl_qspi_priv *priv,

Quoted 9 lines
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
       status_reg = 0;
@@ -700,7 +708,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv *priv,

void *rxbuf, u32 len)

Quoted 23 lines
drivers/spi/fsl_qspi.c +3 -5
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base); @@
-737,7 +745,7 @@ static void qspi_op_erase(struct fsl_qspi_priv *priv)
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
       to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -900,15
+908,9 @@ static int fsl_qspi_probe(struct udevice *bus)
               return ret;
       }
 
-     mcr_val = qspi_read32(priv->flags, &priv->regs->mcr);
-

drivers/spi/fsl_qspi.c static void qspi_op_rdsr(struct fsl_qspi_priv *priv,

Quoted 10 lines
drivers/spi/fsl_qspi.c +1 -5
-     /* Set endianness to LE for i.mx */
-     if (IS_ENABLED(CONFIG_MX6) || IS_ENABLED(CONFIG_MX7))
-             mcr_val = QSPI_MCR_END_CFD_LE;
-
       qspi_write32(priv->flags, &priv->regs->mcr,
                    QSPI_MCR_RESERVED_MASK | QSPI_MCR_MDIS_MASK |
-                  (mcr_val & QSPI_MCR_END_CFD_MASK));
+                  QSPI_MCR_END_CFD_LE);
 
       qspi_cfg_smpr(priv, ~(QSPI_SMPR_FSDLY_MASK |

QSPI_SMPR_DDRSMP_MASK |

Quoted 2 lines
               QSPI_SMPR_FSPHS_MASK | QSPI_SMPR_HSENA_MASK), 0);

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
enx.de%2Flistinfo%2Fu- boot&amp;data=02%7C01%7CAshish.Kumar%40nxp.com%7C8882d56622954 68a45b008d720abd98c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 %7C637013794778063281&amp;sdata=l1Pb4yEQABBx5ave4Lb7jGSVRJ1TG68 KMkl7WpSSwRc%3D&amp;reserved=0

#12 lore raw

Sorry, I hit the "Send" button too early ;)

Quoted 54 lines · Frieder Schrempf

Hi Ashish,

Quoted 41 lines · Ashish Kumar
Quoted 35 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Schrempf Frieder
Sent: Wednesday, August 14, 2019 5:07 PM
To: Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for
latest iMX platforms

Caution: EXT Email

Hi Ye,

Quoted 4 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when DDR_EN is set. Otherwise, the TX DDR delay logic won't be enabled.

This is actually an issue I have experienced myself. But in our case this
behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

Quoted 5 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

Quoted 4 lines

The best way to fix all of these things (also the ones in the other patches) would be to fix them in Linux and port the driver from Linux to U-
Boot. Actually I've already done most of the porting [2],

Hello Frieder,

Quoted 9 lines

I had tested your porting and it was not functional on u-boot. I found that only erase, read up to TX/RX buf size is working or something like that.
Also ip and AHB mode cannot be used at time in code. Previously only IP mode was used in u-boot,
Since endianness across different QSPI-IP(ls1012, ls1043, ls1021 big endian), (ls1088,ls2088 little endian) is not consistent on various silicon's. I am not sure if Yogesh who worked with you on Linux porting gave you this information about endianness inconsistency.

Quoted 2 lines

Ok, thanks for your feedback. The endianness for the different SoCs can be handled by the device data.

Does this work correctly in Linux, or does the Linux driver need fixes?

Quoted 2 lines
Quoted 2 lines

Please suggest way forward. How to correct this issue?

The first thigh would be to make sure the Linux driver works for all platforms and then do the porting to U-Boot. I will be out of office for 10 days. After that I can try to work on this, but I need support and testing for other platforms. I only have i.MX6UL/ULL.

Thanks,
Frieder

Quoted 153 lines
Quoted 153 lines

Regards
Ashish

Quoted 150 lines

time to finish it recently. It probably needs some rebasing and testing.

Could you port your fixes to the Linux driver and submit them to linux-mtd?

Thanks
Frieder

[1]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcomm
unity.nxp.com%2Fthread%2F507260&amp;data=02%7C01%7CAshish.Kumar %40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3bc2b4c 6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata=Za7LB 6RyXAHszPfiEMLDb%2FvVNSTQJwxHFtiapmNi3Co%3D&amp;reserved=0
[2]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
.com%2Ffschrempf%2Fu- boot%2Fcommits%2Ffsl_qspi_spimem_port&amp;data=02%7C01%7CAshish. Kumar%40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3 bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata =kYDjrs2a9DdL8QLFPORfHsMSWvgUxhSTgNC3WLziu7Y%3D&amp;reserved=0

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv

Quoted 37 lines

---
   drivers/spi/fsl_qspi.c | 30 ++++++++++++++++--------------

   1 file changed, 16 insertions(+), 14 deletions(-)
drivers/spi/fsl_qspi.c index renamed from drivers/spi/fsl_qspi.c +0 -0

41abe19..8845986 100644

drivers/spi/fsl_qspi.c +0 -0
@@ -399,7 +399,7 @@ static inline void qspi_ahb_read(struct
 fsl_qspi_priv *priv, u8 *rxbuf, int len)
 
        qspi_write32(priv->flags, &regs->mcr,

                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK | -                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE); +                  mcr_reg);

       rx_addr = (void *)(uintptr_t)(priv->cur_amba_base + priv->sf_addr);
       /* Read out the data directly from the AHB buffer. */ @@ -429,6 +429,14 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv *priv) reg |= BIT(29);

       qspi_write32(priv->flags, &regs->mcr, reg);
+
+     /* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc +      * These two bits are reserved on other platforms
+      */
+     reg = qspi_read32(priv->flags, &regs->flshcr);
+     reg &= ~(BIT(17));
+     reg |= BIT(16);
+     qspi_write32(priv->flags, &regs->flshcr, reg);
   }

   /*

drivers/spi/fsl_qspi.c +0 -0
@@ -482,7 +490,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv

*priv, u8 *rxbuf, u32 len)

Quoted 10 lines
drivers/spi/fsl_qspi.c +0 -0
        mcr_reg = qspi_read32(priv->flags, &regs->mcr);
        qspi_write32(priv->flags, &regs->mcr,

                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK | -                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE); +                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);

       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base); @@ -527,7 +535,7 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

Quoted 10 lines

       mcr_reg = qspi_read32(priv->flags, &regs->mcr); qspi_write32(priv->flags, &regs->mcr, QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK | -                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE); +                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);

       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base); @@ -573,7 +581,7 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

Quoted 10 lines

       mcr_reg = qspi_read32(priv->flags, &regs->mcr); qspi_write32(priv->flags, &regs->mcr, QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK | -                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE); +                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);

       to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -625,7 +633,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf,

u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdsr(struct fsl_qspi_priv · line 708

Quoted 10 lines

       mcr_reg = qspi_read32(priv->flags, &regs->mcr); qspi_write32(priv->flags, &regs->mcr, QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK | -                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE); +                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);

       status_reg = 0;

drivers/spi/fsl_qspi.c +0 -0
@@ -700,7 +708,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv 
 *priv,

void *rxbuf, u32 len)

Quoted 32 lines
drivers/spi/fsl_qspi.c +0 -0
        mcr_reg = qspi_read32(priv->flags, &regs->mcr);
        qspi_write32(priv->flags, &regs->mcr,

                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK | -                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE); +                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);

       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base); @@ -737,7 +745,7 @@ static void qspi_op_erase(struct fsl_qspi_priv *priv) mcr_reg = qspi_read32(priv->flags, &regs->mcr); qspi_write32(priv->flags, &regs->mcr, QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK | -                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE); +                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);

       to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -900,15 +908,9 @@ static int fsl_qspi_probe(struct udevice *bus) return ret;
       }

-     mcr_val = qspi_read32(priv->flags, &priv->regs->mcr);

drivers/spi/fsl_qspi.c +0 -5
-
-     /* Set endianness to LE for i.mx */
-     if (IS_ENABLED(CONFIG_MX6) || IS_ENABLED(CONFIG_MX7))
-             mcr_val = QSPI_MCR_END_CFD_LE;
-

       qspi_write32(priv->flags, &priv->regs->mcr, QSPI_MCR_RESERVED_MASK | QSPI_MCR_MDIS_MASK | -                  (mcr_val & QSPI_MCR_END_CFD_MASK)); +                  QSPI_MCR_END_CFD_LE);

Quoted 1 line

       qspi_cfg_smpr(priv, ~(QSPI_SMPR_FSDLY_MASK |

QSPI_SMPR_DDRSMP_MASK |

Quoted 2 lines

               QSPI_SMPR_FSPHS_MASK | QSPI_SMPR_HSENA_MASK), 0);

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d

enx.de%2Flistinfo%2Fu- boot&amp;data=02%7C01%7CAshish.Kumar%40nxp.com%7C8882d56622954 68a45b008d720abd98c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 %7C637013794778063281&amp;sdata=l1Pb4yEQABBx5ave4Lb7jGSVRJ1TG68 KMkl7WpSSwRc%3D&amp;reserved=0

#13 lore raw
Quoted 76 lines

-----Original Message-----
From: Schrempf Frieder <[email protected]>
Sent: Wednesday, August 14, 2019 5:41 PM
To: Ashish Kumar <[email protected]>; Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Sorry, I hit the "Send" button too early ;)

Quoted 23 lines · Frieder Schrempf

Hi Ashish,

Quoted 20 lines · Ashish Kumar
Quoted 20 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Schrempf Frieder
Sent: Wednesday, August 14, 2019 5:07 PM
To: Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Hi Ye,

Quoted 3 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when DDR_EN

is set.

Quoted 29 lines
Quoted 19 lines
Quoted 13 lines
Quoted 1 line

Otherwise, the TX DDR delay logic won't be enabled.

This is actually an issue I have experienced myself. But in our case this behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

Quoted 5 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

Quoted 4 lines

The best way to fix all of these things (also the ones in the other patches) would be to fix them in Linux and port the driver from Linux to U- Boot. Actually I've already done most of the porting [2],

Hello Frieder,

Quoted 9 lines

I had tested your porting and it was not functional on u-boot. I found that only erase, read up to TX/RX buf size is working or something like that.
Also ip and AHB mode cannot be used at time in code. Previously only IP mode was used in u-boot, Since endianness across different QSPI-IP(ls1012, ls1043, ls1021 big endian), (ls1088,ls2088 little endian) is not consistent on various silicon's. I am not sure if Yogesh who worked with you on Linux porting gave you this information about endianness inconsistency.

Quoted 2 lines

Ok, thanks for your feedback. The endianness for the different SoCs can be handled by the device data.

Does this work correctly in Linux, or does the Linux driver need fixes?

Quoted 1 line
Quoted 6 lines
Quoted 1 line
Quoted 1 line

Please suggest way forward. How to correct this issue?

The first thigh would be to make sure the Linux driver works for all platforms and then do the porting to U-Boot. I will be out of office for
10 days. After that I can try to work on this, but I need support and testing for other platforms. I only have i.MX6UL/ULL.

Hi Frieder,
Surely, I can help with all LS platforms. In the mean while I will try to debug it further on u-boot.
But I believe we can focus on u-boot straight away by disabling AHB for now. Since AHB is taken care with help of another file ./arch/arm/cpu/armv8/fsl-layerscape/soc.c function qspi_ahb_init(), Which is facilitated via md command.

Regards
Ashish

Quoted 178 lines

Thanks,
Frieder

Quoted 8 lines
Quoted 8 lines

Regards
Ashish

Quoted 5 lines

time to finish it recently. It probably needs some rebasing and testing.

Could you port your fixes to the Linux driver and submit them to linux-mtd?

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Thanks
Frieder

[1]
https://comm

unity.nxp.com%2Fthread%2F507260&amp;data=02%7C01%7CAshish.Kumar

Quoted 1 line
Quoted 1 line
Quoted 1 line

%40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3bc2b4c

Quoted 1 line
Quoted 1 line
Quoted 1 line

6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata=Za7LB

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

6RyXAHszPfiEMLDb%2FvVNSTQJwxHFtiapmNi3Co%3D&amp;reserved=0
[2]
https://github
.com%2Ffschrempf%2Fu-

boot%2Fcommits%2Ffsl_qspi_spimem_port&amp;data=02%7C01%7CAshish.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Kumar%40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3

Quoted 1 line
Quoted 1 line
Quoted 1 line

bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata

Quoted 1 line
Quoted 1 line
Quoted 1 line

=kYDjrs2a9DdL8QLFPORfHsMSWvgUxhSTgNC3WLziu7Y%3D&amp;reserved=0

Quoted 130 lines
Quoted 130 lines
Quoted 130 lines

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv

Quoted 40 lines
---
   drivers/spi/fsl_qspi.c | 30 ++++++++++++++++--------------
   1 file changed, 16 insertions(+), 14 deletions(-)
drivers/spi/fsl_qspi.c index renamed from drivers/spi/fsl_qspi.c +0 -0

41abe19..8845986 100644

drivers/spi/fsl_qspi.c +1 -1
@@ -399,7 +399,7 @@ static inline void qspi_ahb_read(struct
 fsl_qspi_priv *priv, u8 *rxbuf, int len)
 
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
 
       rx_addr = (void *)(uintptr_t)(priv->cur_amba_base +
priv->sf_addr);
       /* Read out the data directly from the AHB buffer. */ @@

-429,6
+429,14 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv

drivers/spi/fsl_qspi.c +9 -0
+*priv)
       reg |= BIT(29);
 
       qspi_write32(priv->flags, &regs->mcr, reg);
+
+     /* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc
+      * These two bits are reserved on other platforms
+      */
+     reg = qspi_read32(priv->flags, &regs->flshcr);
+     reg &= ~(BIT(17));
+     reg |= BIT(16);
+     qspi_write32(priv->flags, &regs->flshcr, reg);
   }
 
   /*
@@ -482,7 +490,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv

*priv, u8 *rxbuf, u32 len)

Quoted 9 lines
drivers/spi/fsl_qspi.c +1 -1
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,
 QSPI_RBCT_RXBRD_USEIPS);
 
       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
Quoted 3 lines

@@
-527,7 +535,7 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

Quoted 8 lines
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,

QSPI_RBCT_RXBRD_USEIPS);

Quoted 4 lines
       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);

@@
-573,7 +581,7 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

Quoted 11 lines
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,

QSPI_RBCT_RXBRD_USEIPS);

       to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -625,7

+633,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf,

u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdsr(struct fsl_qspi_priv · line 708

Quoted 11 lines
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,

QSPI_RBCT_RXBRD_USEIPS);

       status_reg = 0;
drivers/spi/fsl_qspi.c +0 -0
@@ -700,7 +708,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv
 *priv,

void *rxbuf, u32 len)

Quoted 26 lines
drivers/spi/fsl_qspi.c +1 -1
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,
 QSPI_RBCT_RXBRD_USEIPS);
       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@
-737,7 +745,7 @@ static void qspi_op_erase(struct fsl_qspi_priv *priv)
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,

QSPI_RBCT_RXBRD_USEIPS);

       to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -900,15
+908,9 @@ static int fsl_qspi_probe(struct udevice *bus)
               return ret;
       }
drivers/spi/fsl_qspi.c +0 -2
-     mcr_val = qspi_read32(priv->flags, &priv->regs->mcr);
-

drivers/spi/fsl_qspi.c static int fsl_qspi_probe(struct udevice *bus)

Quoted 10 lines
drivers/spi/fsl_qspi.c +1 -5
-     /* Set endianness to LE for i.mx */
-     if (IS_ENABLED(CONFIG_MX6) || IS_ENABLED(CONFIG_MX7))
-             mcr_val = QSPI_MCR_END_CFD_LE;
-
       qspi_write32(priv->flags, &priv->regs->mcr,
                    QSPI_MCR_RESERVED_MASK | QSPI_MCR_MDIS_MASK |
-                  (mcr_val & QSPI_MCR_END_CFD_MASK));
+                  QSPI_MCR_END_CFD_LE);
 
       qspi_cfg_smpr(priv, ~(QSPI_SMPR_FSDLY_MASK |

QSPI_SMPR_DDRSMP_MASK |

Quoted 2 lines
               QSPI_SMPR_FSPHS_MASK | QSPI_SMPR_HSENA_MASK), 0);
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.d

enx.de%2Flistinfo%2Fu-

boot&amp;data=02%7C01%7CAshish.Kumar%40nxp.com%7C8882d56622954

Quoted 1 line
Quoted 1 line
Quoted 1 line

68a45b008d720abd98c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0

Quoted 1 line
Quoted 1 line
Quoted 1 line

%7C637013794778063281&amp;sdata=l1Pb4yEQABBx5ave4Lb7jGSVRJ1TG68

Quoted 1 line
Quoted 1 line
Quoted 1 line

KMkl7WpSSwRc%3D&amp;reserved=0

#14 lore raw
In reply to Schrempf Frieder
Quoted 77 lines

-----Original Message-----
From: Schrempf Frieder <[email protected]>
Sent: Wednesday, August 14, 2019 5:41 PM
To: Ashish Kumar <[email protected]>; Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Sorry, I hit the "Send" button too early ;)

Quoted 11 lines · Frieder Schrempf

Hi Ashish,

Quoted 8 lines · Ashish Kumar
Quoted 8 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Schrempf Frieder
Sent: Wednesday, August 14, 2019 5:07 PM
To: Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de;

dl-

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

uboot-imx <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Caution: EXT Email

Hi Ye,

Quoted 3 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when

DDR_EN is set.

Quoted 29 lines
Quoted 19 lines
Quoted 13 lines
Quoted 1 line

Otherwise, the TX DDR delay logic won't be enabled.

This is actually an issue I have experienced myself. But in our case this behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

Quoted 5 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

Quoted 4 lines

The best way to fix all of these things (also the ones in the other patches) would be to fix them in Linux and port the driver from Linux to U- Boot. Actually I've already done most of the porting [2],

Hello Frieder,

Quoted 9 lines

I had tested your porting and it was not functional on u-boot. I found that only erase, read up to TX/RX buf size is working or something like that.
Also ip and AHB mode cannot be used at time in code. Previously only IP mode was used in u-boot, Since endianness across different QSPI-IP(ls1012, ls1043, ls1021 big endian), (ls1088,ls2088 little endian) is not consistent on various silicon's. I am not sure if Yogesh who worked with you on Linux porting gave you this information about endianness inconsistency.

Quoted 2 lines

Ok, thanks for your feedback. The endianness for the different SoCs can be handled by the device data.

Does this work correctly in Linux, or does the Linux driver need fixes?

Quoted 1 line
Quoted 6 lines
Quoted 1 line
Quoted 1 line

Please suggest way forward. How to correct this issue?

The first thigh would be to make sure the Linux driver works for all platforms and then do the porting to U-Boot. I will be out of office for
10 days. After that I can try to work on this, but I need support and testing for other platforms. I only have i.MX6UL/ULL.

Hi Frieder,

I have found some break though after porting to 2019.10 and few modification in driver code, I will update in a weeks' time. Please do not invest time on this. If I need some help I will update.

Regards
Ashish

Quoted 179 lines

Thanks,
Frieder

Quoted 8 lines
Quoted 8 lines

Regards
Ashish

Quoted 5 lines

time to finish it recently. It probably needs some rebasing and testing.

Could you port your fixes to the Linux driver and submit them to linux-mtd?

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Thanks
Frieder

[1]
https://comm

unity.nxp.com%2Fthread%2F507260&amp;data=02%7C01%7CAshish.Kumar

Quoted 1 line
Quoted 1 line
Quoted 1 line

%40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3bc2b4c

Quoted 1 line
Quoted 1 line
Quoted 1 line

6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata=Za7LB

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

6RyXAHszPfiEMLDb%2FvVNSTQJwxHFtiapmNi3Co%3D&amp;reserved=0
[2]
https://github
.com%2Ffschrempf%2Fu-

boot%2Fcommits%2Ffsl_qspi_spimem_port&amp;data=02%7C01%7CAshish.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Kumar%40nxp.com%7C8882d5662295468a45b008d720abd98c%7C686ea1d3

Quoted 1 line
Quoted 1 line
Quoted 1 line

bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637013794778063281&amp;sdata

Quoted 1 line
Quoted 1 line
Quoted 1 line

=kYDjrs2a9DdL8QLFPORfHsMSWvgUxhSTgNC3WLziu7Y%3D&amp;reserved= 0

Quoted 130 lines
Quoted 130 lines
Quoted 130 lines

drivers/spi/fsl_qspi.c static void qspi_op_rdbank(struct fsl_qspi_priv

Quoted 40 lines
---
   drivers/spi/fsl_qspi.c | 30 ++++++++++++++++--------------
   1 file changed, 16 insertions(+), 14 deletions(-)
drivers/spi/fsl_qspi.c index renamed from drivers/spi/fsl_qspi.c +0 -0

41abe19..8845986 100644

drivers/spi/fsl_qspi.c +1 -1
@@ -399,7 +399,7 @@ static inline void qspi_ahb_read(struct
 fsl_qspi_priv *priv, u8 *rxbuf, int len)
 
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
 
       rx_addr = (void *)(uintptr_t)(priv->cur_amba_base +
priv->sf_addr);
       /* Read out the data directly from the AHB buffer. */ @@

-429,6
+429,14 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv

drivers/spi/fsl_qspi.c +9 -0
+*priv)
       reg |= BIT(29);
 
       qspi_write32(priv->flags, &regs->mcr, reg);
+
+     /* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc
+      * These two bits are reserved on other platforms
+      */
+     reg = qspi_read32(priv->flags, &regs->flshcr);
+     reg &= ~(BIT(17));
+     reg |= BIT(16);
+     qspi_write32(priv->flags, &regs->flshcr, reg);
   }
 
   /*
@@ -482,7 +490,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv

*priv, u8 *rxbuf, u32 len)

Quoted 9 lines
drivers/spi/fsl_qspi.c +1 -1
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,
 QSPI_RBCT_RXBRD_USEIPS);
 
       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
Quoted 3 lines

@@
-527,7 +535,7 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

Quoted 8 lines
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,

QSPI_RBCT_RXBRD_USEIPS);

Quoted 4 lines
       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);

@@
-573,7 +581,7 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32

*rxbuf, u32 len)

Quoted 11 lines
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,

QSPI_RBCT_RXBRD_USEIPS);

       to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -625,7

+633,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf,

u32 len)

drivers/spi/fsl_qspi.c static void qspi_op_rdsr(struct fsl_qspi_priv · line 708

Quoted 11 lines
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,

QSPI_RBCT_RXBRD_USEIPS);

       status_reg = 0;
drivers/spi/fsl_qspi.c +0 -0
@@ -700,7 +708,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv
 *priv,

void *rxbuf, u32 len)

Quoted 26 lines
drivers/spi/fsl_qspi.c +1 -1
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,
 QSPI_RBCT_RXBRD_USEIPS);
       qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@
-737,7 +745,7 @@ static void qspi_op_erase(struct fsl_qspi_priv *priv)
       mcr_reg = qspi_read32(priv->flags, &regs->mcr);
       qspi_write32(priv->flags, &regs->mcr,
                    QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
drivers/spi/fsl_qspi.c +1 -1
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
       qspi_write32(priv->flags, &regs->rbct,

QSPI_RBCT_RXBRD_USEIPS);

       to_or_from = priv->sf_addr + priv->cur_amba_base; @@ -900,15
+908,9 @@ static int fsl_qspi_probe(struct udevice *bus)
               return ret;
       }
drivers/spi/fsl_qspi.c +0 -2
-     mcr_val = qspi_read32(priv->flags, &priv->regs->mcr);
-

drivers/spi/fsl_qspi.c static int fsl_qspi_probe(struct udevice *bus)

Quoted 10 lines
drivers/spi/fsl_qspi.c +1 -5
-     /* Set endianness to LE for i.mx */
-     if (IS_ENABLED(CONFIG_MX6) || IS_ENABLED(CONFIG_MX7))
-             mcr_val = QSPI_MCR_END_CFD_LE;
-
       qspi_write32(priv->flags, &priv->regs->mcr,
                    QSPI_MCR_RESERVED_MASK | QSPI_MCR_MDIS_MASK |
-                  (mcr_val & QSPI_MCR_END_CFD_MASK));
+                  QSPI_MCR_END_CFD_LE);
 
       qspi_cfg_smpr(priv, ~(QSPI_SMPR_FSDLY_MASK |

QSPI_SMPR_DDRSMP_MASK |

Quoted 2 lines
               QSPI_SMPR_FSPHS_MASK | QSPI_SMPR_HSENA_MASK), 0);
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.d

enx.de%2Flistinfo%2Fu-

boot&amp;data=02%7C01%7CAshish.Kumar%40nxp.com%7C8882d56622954

Quoted 1 line
Quoted 1 line
Quoted 1 line

68a45b008d720abd98c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0

Quoted 1 line
Quoted 1 line
Quoted 1 line

%7C637013794778063281&amp;sdata=l1Pb4yEQABBx5ave4Lb7jGSVRJ1TG68

Quoted 1 line
Quoted 1 line
Quoted 1 line

KMkl7WpSSwRc%3D&amp;reserved=0

#15 lore raw

Hi Ashish,

Quoted 84 lines · Ashish Kumar
Quoted 77 lines

-----Original Message-----
From: Schrempf Frieder <[email protected]>
Sent: Wednesday, August 14, 2019 5:41 PM
To: Ashish Kumar <[email protected]>; Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Sorry, I hit the "Send" button too early ;)

Quoted 11 lines · Frieder Schrempf

Hi Ashish,

Quoted 8 lines · Ashish Kumar
Quoted 8 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Schrempf Frieder
Sent: Wednesday, August 14, 2019 5:07 PM
To: Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de;

dl-

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

uboot-imx <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Caution: EXT Email

Hi Ye,

Quoted 3 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when

DDR_EN is set.

Quoted 29 lines
Quoted 19 lines
Quoted 13 lines
Quoted 1 line

Otherwise, the TX DDR delay logic won't be enabled.

This is actually an issue I have experienced myself. But in our case this behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

Quoted 5 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

Quoted 4 lines

The best way to fix all of these things (also the ones in the other patches) would be to fix them in Linux and port the driver from Linux to U- Boot. Actually I've already done most of the porting [2],

Hello Frieder,

Quoted 9 lines

I had tested your porting and it was not functional on u-boot. I found that only erase, read up to TX/RX buf size is working or something like that.
Also ip and AHB mode cannot be used at time in code. Previously only IP mode was used in u-boot, Since endianness across different QSPI-IP(ls1012, ls1043, ls1021 big endian), (ls1088,ls2088 little endian) is not consistent on various silicon's. I am not sure if Yogesh who worked with you on Linux porting gave you this information about endianness inconsistency.

Quoted 2 lines

Ok, thanks for your feedback. The endianness for the different SoCs can be handled by the device data.

Does this work correctly in Linux, or does the Linux driver need fixes?

Quoted 1 line
Quoted 6 lines
Quoted 1 line
Quoted 1 line

Please suggest way forward. How to correct this issue?

The first thigh would be to make sure the Linux driver works for all platforms and then do the porting to U-Boot. I will be out of office for
10 days. After that I can try to work on this, but I need support and testing for other platforms. I only have i.MX6UL/ULL.

Quoted 4 lines

Hi Frieder,

I have found some break though after porting to 2019.10 and few modification in driver code, I will update in a weeks' time. Please do not invest time on this. If I need some help I will update.

Thanks for your work. Do you already have some news? Can you share your results?

Thanks,
Frieder

#16 lore raw

Hi Ashish,
Hi Frieder,

Quoted 87 lines · Schrempf Frieder

Hi Ashish,

Quoted 84 lines · Ashish Kumar
Quoted 83 lines

-----Original Message-----
From: Schrempf Frieder <[email protected]>
Sent: Wednesday, August 14, 2019 5:41 PM
To: Ashish Kumar <[email protected]>; Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Sorry, I hit the "Send" button too early ;)

Quoted 11 lines · Frieder Schrempf

Hi Ashish,

Quoted 8 lines · Ashish Kumar
Quoted 8 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Schrempf Frieder
Sent: Wednesday, August 14, 2019 5:07 PM
To: Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de;

dl-

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

uboot-imx <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Caution: EXT Email

Hi Ye,

Quoted 3 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when

DDR_EN is set.

Quoted 29 lines
Quoted 19 lines
Quoted 13 lines
Quoted 1 line

Otherwise, the TX DDR delay logic won't be enabled.

This is actually an issue I have experienced myself. But in our case this behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

Quoted 5 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

Quoted 4 lines

The best way to fix all of these things (also the ones in the other patches) would be to fix them in Linux and port the driver from Linux to U- Boot. Actually I've already done most of the porting [2],

Hello Frieder,

Quoted 9 lines

I had tested your porting and it was not functional on u-boot. I found that only erase, read up to TX/RX buf size is working or something like that.
Also ip and AHB mode cannot be used at time in code. Previously only IP mode was used in u-boot, Since endianness across different QSPI-IP(ls1012, ls1043, ls1021 big endian), (ls1088,ls2088 little endian) is not consistent on various silicon's. I am not sure if Yogesh who worked with you on Linux porting gave you this information about endianness inconsistency.

Quoted 2 lines

Ok, thanks for your feedback. The endianness for the different SoCs can be handled by the device data.

Does this work correctly in Linux, or does the Linux driver need fixes?

Quoted 2 lines
Quoted 2 lines

Please suggest way forward. How to correct this issue?

The first thigh would be to make sure the Linux driver works for all platforms and then do the porting to U-Boot. I will be out of office for
10 days. After that I can try to work on this, but I need support and testing for other platforms. I only have i.MX6UL/ULL.

Quoted 7 lines
Quoted 4 lines

Hi Frieder,

I have found some break though after porting to 2019.10 and few modification in driver code, I will update in a weeks' time. Please do not invest time on this. If I need some help I will update.

Thanks for your work. Do you already have some news? Can you share your results?

I'm most likely currently running in similar issues on tests with the i.MX6ULL EVK. QSPI does not work reliably. So before digging deeper into the QSPI driver, I wanted to check on the status of any updates in the driver. Is there anything available that I could use for testing already?

Thanks,
Stefan

#17 lore raw
Quoted 118 lines

-----Original Message-----
From: Stefan Roese <[email protected]>
Sent: Wednesday, September 11, 2019 11:17 AM
To: Schrempf Frieder <[email protected]>; Ashish Kumar <[email protected]>; Ye Li <[email protected]>;
jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Hi Ashish,
Hi Frieder,

Quoted 11 lines · Schrempf Frieder

Hi Ashish,

Quoted 8 lines · Ashish Kumar
Quoted 8 lines

-----Original Message-----
From: Schrempf Frieder <[email protected]>
Sent: Wednesday, August 14, 2019 5:41 PM
To: Ashish Kumar <[email protected]>; Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de;

dl-

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

uboot-imx <[email protected]>
Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Sorry, I hit the "Send" button too early ;)

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines · Frieder Schrempf
Quoted 7 lines

Hi Ashish,

Quoted 4 lines · Ashish Kumar
Quoted 4 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of

Schrempf

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Frieder
Sent: Wednesday, August 14, 2019 5:07 PM
To: Ye Li <[email protected]>; jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-

boot at lists.denx.de;

Quoted 58 lines
Quoted 58 lines
Quoted 57 lines

dl-

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

uboot-imx <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Caution: EXT Email

Hi Ye,

Quoted 3 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when

DDR_EN is set.

Quoted 30 lines
Quoted 20 lines
Quoted 13 lines
Quoted 1 line

Otherwise, the TX DDR delay logic won't be enabled.

This is actually an issue I have experienced myself. But in our case this behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

Quoted 5 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

Quoted 5 lines

The best way to fix all of these things (also the ones in the other
patches) would be to fix them in Linux and port the driver from Linux to U- Boot. Actually I've already done most of the porting [2],

Hello Frieder,

Quoted 9 lines

I had tested your porting and it was not functional on u-boot. I found that only erase, read up to TX/RX buf size is working or something like that.
Also ip and AHB mode cannot be used at time in code. Previously only IP mode was used in u-boot, Since endianness across different QSPI-IP(ls1012, ls1043, ls1021 big endian), (ls1088,ls2088 little endian) is not consistent on various silicon's. I am not sure if Yogesh who worked with you on Linux porting gave you this information about endianness inconsistency.

Quoted 2 lines

Ok, thanks for your feedback. The endianness for the different SoCs can be handled by the device data.

Does this work correctly in Linux, or does the Linux driver need fixes?

Quoted 2 lines
Quoted 2 lines

Please suggest way forward. How to correct this issue?

The first thigh would be to make sure the Linux driver works for all platforms and then do the porting to U-Boot. I will be out of office for
10 days. After that I can try to work on this, but I need support and testing for other platforms. I only have i.MX6UL/ULL.

Quoted 3 lines
Quoted 3 lines

Hi Frieder,

I have found some break though after porting to 2019.10 and few

modification in driver code, I will update in a weeks' time. Please do not invest time on this.

Quoted 2 lines
Quoted 1 line

If I need some help I will update.

Quoted 7 lines
Quoted 2 lines

Thanks for your work. Do you already have some news? Can you share your results?

I'm most likely currently running in similar issues on tests with the i.MX6ULL EVK. QSPI does not work reliably. So before digging deeper into the QSPI driver, I wanted to check on the status of any updates in the driver. Is there anything available that I could use for testing already?

Hi Stefan, Frieder,

The spi-mem version is still under debug, I could make it working for ls1088rdb, ls1046rdb, but it is failing for
ls1012ardb and ls2088ardb and untested for i.mx and other Layerscape silicon/boards . It is derived from work done by Frieder earlier. This version can be found here:
https://github.com/erashish007/u-boot-spi-mem/tree/spi-mem-port

There is completely working version of fsl_qspi.c based on old xfer method, which was not accepted in upstream, considering it is recommended to migrate to spi-mem frame. This version is located here:
https://github.com/erashish007/u-boot-spi-mem/tree/xfer_wrking

Regards
Ashish

I have push the working version of these on github.

Quoted 3 lines

Thanks,
Stefan

#18 lore raw

Hi Ashish,

On 12.09.19 07:03, Ashish Kumar wrote:

<snip>

Quoted 22 lines
Quoted 15 lines
Quoted 11 lines
Quoted 11 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line

Please suggest way forward. How to correct this issue?

The first thigh would be to make sure the Linux driver works for all platforms and then do the porting to U-Boot. I will be out of office for
10 days. After that I can try to work on this, but I need support and testing for other platforms. I only have i.MX6UL/ULL.

Hi Frieder,

I have found some break though after porting to 2019.10 and few

modification in driver code, I will update in a weeks' time. Please do not invest time on this.

Quoted 2 lines
Quoted 1 line

If I need some help I will update.

Quoted 7 lines
Quoted 2 lines

Thanks for your work. Do you already have some news? Can you share your results?

I'm most likely currently running in similar issues on tests with the i.MX6ULL EVK. QSPI does not work reliably. So before digging deeper into the QSPI driver, I wanted to check on the status of any updates in the driver. Is there anything available that I could use for testing already?

Quoted 8 lines

Hi Stefan, Frieder,

The spi-mem version is still under debug, I could make it working for ls1088rdb, ls1046rdb, but it is failing for ls1012ardb and ls2088ardb and untested for i.mx and other Layerscape silicon/boards . It is derived from work done by Frieder earlier. This version can be found here:
https://github.com/erashish007/u-boot-spi-mem/tree/spi-mem-port

Many thanks. I did some tests with this version and it seems to work fine in general on the i.MX6ULL EVK. My first tests show that reading and writing has no issues. So this is very promising. The only thing I noticed is, that when using SPI for environment via CONFIG_ENV_IS_IN_SPI_FLASH, the board hangs upon bootup while trying to read the env. Since you already added some debug print's to the env code, I suspect that you also did run into this problem.

I'll try to help with this driver version. At least I can debug this env issue and can always do some test on my mx6ull platform for you once you have any updates here. Just let me know.

Quoted 5 lines

There is completely working version of fsl_qspi.c based on old xfer method, which was not accepted in upstream,
considering it is recommended to migrate to spi-mem frame. This version is located here:
https://github.com/erashish007/u-boot-spi-mem/tree/xfer_wrking

This one does not work for me on the i.MX6ULL EVK. "sf read" command returns almost immediately and the data is not read as it seems. I did not dig into this deeper though.

Thanks,
Stefan

#19 lore raw
Quoted 71 lines

-----Original Message-----
From: Stefan Roese <[email protected]>
Sent: Thursday, September 12, 2019 6:06 PM
To: Ashish Kumar <[email protected]>; Schrempf Frieder <[email protected]>; Ye Li <[email protected]>;
jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Hi Ashish,

On 12.09.19 07:03, Ashish Kumar wrote:

<snip>

Quoted 15 lines
Quoted 15 lines
Quoted 11 lines
Quoted 11 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line

Please suggest way forward. How to correct this issue?

The first thigh would be to make sure the Linux driver works for all platforms and then do the porting to U-Boot. I will be out of office for
10 days. After that I can try to work on this, but I need support and testing for other platforms. I only have i.MX6UL/ULL.

Hi Frieder,

I have found some break though after porting to 2019.10 and few

modification in driver code, I will update in a weeks' time. Please do not invest time on this.

Quoted 2 lines
Quoted 1 line

If I need some help I will update.

Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

Thanks for your work. Do you already have some news? Can you share your results?

I'm most likely currently running in similar issues on tests with the i.MX6ULL EVK. QSPI does not work reliably. So before digging deeper into the QSPI driver, I wanted to check on the status of any updates in the driver. Is there anything available that I could use for testing

already?

Quoted 9 lines

Hi Stefan, Frieder,

The spi-mem version is still under debug, I could make it working for ls1088rdb, ls1046rdb, but it is failing for ls1012ardb and ls2088ardb and untested for i.mx and other Layerscape silicon/boards . It is derived from work done by Frieder earlier.
This version can be found here:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2Ferashish007%2Fu-boot-spi-mem%2Ftree%2Fspi-mem-

port&amp;data=0

Quoted 1 line

2%7C01%7Cashish.kumar%40nxp.com%7C2697e09d52b94dc737ce08d737cd3 34c%7C6

Quoted 1 line

86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637039226779815773&amp ;sdata

Quoted 1 line

=NqcR9VBELvvXhcCay850Fj%2BEZuOjkJzf15IXdBR4l2A%3D&amp;reserved=0

Many thanks. I did some tests with this version and it seems to work fine in general on the i.MX6ULL EVK. My first tests show that reading and writing has no issues. So this is very promising. The only thing I noticed is, that when using SPI for environment via CONFIG_ENV_IS_IN_SPI_FLASH, the board hangs upon bootup while trying to read the env. Since you already added some debug print's to the env code, I suspect that you also did run into this problem.

Quoted 3 lines

I'll try to help with this driver version. At least I can debug this env issue and can always do some test on my mx6ull platform for you once you have any updates here. Just let me know.

Hi Stefan,

Yes, I was also debugging the same, what confuses me is that it works on Ls1046, ls1088, but fails on ls2088, ls1012.

Regards
Ashish

Quoted 21 lines
Quoted 6 lines

There is completely working version of fsl_qspi.c based on old xfer method, which was not accepted in upstream, considering it is recommended to migrate to spi-mem frame. This version is located here:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2Ferashish007%2Fu-boot-spi-

mem%2Ftree%2Fxfer_wrking&amp;data=02

Quoted 1 line

%7C01%7Cashish.kumar%40nxp.com%7C2697e09d52b94dc737ce08d737cd33 4c%7C68

Quoted 1 line

6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637039226779815773&amp; sdata=

Quoted 1 line

qpksEv36Zjb6jXKsnWN5iVtAoG9UEQFMIi4uu1OgiJ8%3D&amp;reserved=0

This one does not work for me on the i.MX6ULL EVK. "sf read" command returns almost immediately and the data is not read as it seems. I did not dig into this deeper though.

Thanks,
Stefan

#20 lore raw
In reply to Stefan Roese

Hi Ashish,

On 12.09.19 14:36, Stefan Roese wrote:

<snip>

Quoted 15 lines
Quoted 6 lines

The spi-mem version is still under debug, I could make it working for ls1088rdb, ls1046rdb, but it is failing for ls1012ardb and ls2088ardb and untested for i.mx and other Layerscape silicon/boards . It is derived from work done by Frieder earlier. This version can be found here:
https://github.com/erashish007/u-boot-spi-mem/tree/spi-mem-port

Many thanks. I did some tests with this version and it seems to work fine in general on the i.MX6ULL EVK. My first tests show that reading and writing has no issues. So this is very promising. The only thing I noticed is, that when using SPI for environment via CONFIG_ENV_IS_IN_SPI_FLASH, the board hangs upon bootup while trying to read the env. Since you already added some debug print's to the env code, I suspect that you also did run into this problem.

Quoted 3 lines

I'll try to help with this driver version. At least I can debug this env issue and can always do some test on my mx6ull platform for you once you have any updates here. Just let me know.

Okay, this one with the env in SPI NOR is fixed. Its a problem with your PR debug printf macro. Please change it this way:

-#define PR(fmt, ...) \
- fprintf(stderr, "DEBUG: %s:%d:%s(): " fmt" \n", \
+#define PR(fmt, ...) \
+ printf("DEBUG: %s:%d:%s(): " fmt" \n", \

With this change, I can successfully boot with SPI NOR environment on my board. I will do some further tests with your driver next week and will get back to you with the results. Please keep me in the loop, if you have updates on the driver.

Thanks,
Stefan

#21 lore raw

Hi Ashish,

Quoted 31 lines · Stefan Roese

On 12.09.19 14:36, Stefan Roese wrote:

<snip>

Quoted 15 lines
Quoted 6 lines

The spi-mem version is still under debug, I could make it working for ls1088rdb, ls1046rdb, but it is failing for ls1012ardb and ls2088ardb and untested for i.mx and other Layerscape silicon/boards . It is derived from work done by Frieder earlier. This version can be found here:
https://github.com/erashish007/u-boot-spi-mem/tree/spi-mem-port

Many thanks. I did some tests with this version and it seems to work fine in general on the i.MX6ULL EVK. My first tests show that reading and writing has no issues. So this is very promising. The only thing I noticed is, that when using SPI for environment via CONFIG_ENV_IS_IN_SPI_FLASH, the board hangs upon bootup while trying to read the env. Since you already added some debug print's to the env code, I suspect that you also did run into this problem.

Quoted 3 lines

I'll try to help with this driver version. At least I can debug this env issue and can always do some test on my mx6ull platform for you once you have any updates here. Just let me know.

Okay, this one with the env in SPI NOR is fixed. Its a problem with your PR debug printf macro. Please change it this way:

(quoted diff) +2 -2
-#define PR(fmt, ...) \
-        fprintf(stderr, "DEBUG: %s:%d:%s(): " fmt" \n", \
+#define PR(fmt, ...)                                    \
+        printf("DEBUG: %s:%d:%s(): " fmt" \n", \
Quoted 4 lines

With this change, I can successfully boot with SPI NOR environment on my board. I will do some further tests with your driver next week and will get back to you with the results. Please keep me in the loop, if you have updates on the driver.

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

Thanks,
Stefan

#22 lore raw

Hi Stefan,

Quoted 53 lines · Stefan Roese

Hi Ashish,

Quoted 31 lines · Stefan Roese

On 12.09.19 14:36, Stefan Roese wrote:

<snip>

Quoted 15 lines
Quoted 6 lines

The spi-mem version is still under debug, I could make it working for ls1088rdb, ls1046rdb, but it is failing for ls1012ardb and ls2088ardb and untested for i.mx and other Layerscape silicon/boards . It is derived from work done by Frieder earlier. This version can be found here:
https://github.com/erashish007/u-boot-spi-mem/tree/spi-mem-port

Many thanks. I did some tests with this version and it seems to work fine in general on the i.MX6ULL EVK. My first tests show that reading and writing has no issues. So this is very promising. The only thing I noticed is, that when using SPI for environment via CONFIG_ENV_IS_IN_SPI_FLASH, the board hangs upon bootup while trying to read the env. Since you already added some debug print's to the env code, I suspect that you also did run into this problem.

Quoted 3 lines

I'll try to help with this driver version. At least I can debug this env issue and can always do some test on my mx6ull platform for you once you have any updates here. Just let me know.

Okay, this one with the env in SPI NOR is fixed. Its a problem with your PR debug printf macro. Please change it this way:

(quoted diff) +2 -2
-#define PR(fmt, ...) \
-        fprintf(stderr, "DEBUG: %s:%d:%s(): " fmt" \n", \
+#define PR(fmt, ...)                                    \
+        printf("DEBUG: %s:%d:%s(): " fmt" \n", \
Quoted 4 lines

With this change, I can successfully boot with SPI NOR environment on my board. I will do some further tests with your driver next week and will get back to you with the results. Please keep me in the loop, if you have updates on the driver.

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

Quoted 7 lines

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

I have a strong suspicion of what goes wrong in your case. We experienced exactly the same issue recently on i.MX6ULL. For some reasons (I guess differences in BootROM) this does not happen on i.MX6UL.

The problem is, that the BootROM sets the TDH bits in the QuadSPI_FLSHCR register to '01' in case it uses the DDR mode. Afterwards when U-Boot or Linux try to access the flash in SDR mode, they fail as the TDH bits are still set. Resetting them to '00' solves the problem.

Unfortunately the TDH bits are not documented in the manual of the i.MX6UL/ULL, but they can be found in the manual of the i.MX7.

For the QSPI driver, this means it needs a fix to set/reset the TDH bits according to the mode that is used (DDR/SDR).

For more details please also look here:
https://community.nxp.com/thread/507260

Thanks,
Frieder

#23 lore raw

Hi Frieder,

On 18.09.19 09:08, Schrempf Frieder wrote:

<snip>

Quoted 31 lines
Quoted 14 lines

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

Quoted 7 lines

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

I have a strong suspicion of what goes wrong in your case. We experienced exactly the same issue recently on i.MX6ULL. For some reasons (I guess differences in BootROM) this does not happen on i.MX6UL.

The problem is, that the BootROM sets the TDH bits in the QuadSPI_FLSHCR register to '01' in case it uses the DDR mode. Afterwards when U-Boot or Linux try to access the flash in SDR mode, they fail as the TDH bits are still set. Resetting them to '00' solves the problem.

Quoted 8 lines

Unfortunately the TDH bits are not documented in the manual of the i.MX6UL/ULL, but they can be found in the manual of the i.MX7.

For the QSPI driver, this means it needs a fix to set/reset the TDH bits according to the mode that is used (DDR/SDR).

For more details please also look here:
https://community.nxp.com/thread/507260

Perfect. With these bits set to 00 again, booting from QSPI now works on the EVK. Many thanks for this hint! :)

BTW: When receiving your mail I was just comparing the registers settings and wondering about this difference in bit 16 as well. ;)

Thanks,
Stefan

#24 lore raw

Hi Frieder,
Hi Ashish,
Hi Ye Li,
Hi Fabio,

Quoted 40 lines · Stefan Roese

Hi Frieder,

On 18.09.19 09:08, Schrempf Frieder wrote:

<snip>

Quoted 34 lines
Quoted 14 lines

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

Quoted 7 lines

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

I have a strong suspicion of what goes wrong in your case. We experienced exactly the same issue recently on i.MX6ULL. For some reasons (I guess differences in BootROM) this does not happen on i.MX6UL.

The problem is, that the BootROM sets the TDH bits in the QuadSPI_FLSHCR register to '01' in case it uses the DDR mode. Afterwards when U-Boot or Linux try to access the flash in SDR mode, they fail as the TDH bits are still set. Resetting them to '00' solves the problem.

Unfortunately the TDH bits are not documented in the manual of the i.MX6UL/ULL, but they can be found in the manual of the i.MX7.

Quoted 8 lines
Quoted 5 lines

For the QSPI driver, this means it needs a fix to set/reset the TDH bits according to the mode that is used (DDR/SDR).

For more details please also look here:
https://community.nxp.com/thread/507260

Perfect. With these bits set to 00 again, booting from QSPI now works on the EVK. Many thanks for this hint! :)

I'm coming back to this issue, as we now have the new NXP patches integrated into mainline. Including this one:

7949576664ac "spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms"

I've now re-tested current mainline on the i.MX6ULL Eval Kit and QSPI does not work reliably. This is with CONFIG_SYS_FSL_QSPI_AHB enabled and disabled. How is QSPI supposed to work on i.MX6ULL/ULZ? Is any one of you running this current mainline driver successfully on one any i-MX6ULL/ULZ based board? If yes, what is your configuration here?

BTW: Using the "spi-mem" driver version from Ashish with the fix suggested by Frieder to clear the DDR bit in TDH (reset to 00) still works without any problems.

Thanks,
Stefan

[1] https://github.com/erashish007/u-boot-spi-mem/tree/spi-mem-port

#25 lore raw

Hi Stefan,

Quoted 59 lines · Stefan Roese

Hi Frieder,
Hi Ashish,
Hi Ye Li,
Hi Fabio,

Quoted 41 lines · Stefan Roese

Hi Frieder,

On 18.09.19 09:08, Schrempf Frieder wrote:

<snip>

Quoted 35 lines
Quoted 14 lines

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

Quoted 7 lines

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

I have a strong suspicion of what goes wrong in your case. We experienced exactly the same issue recently on i.MX6ULL. For some reasons (I guess differences in BootROM) this does not happen on i.MX6UL.

The problem is, that the BootROM sets the TDH bits in the QuadSPI_FLSHCR register to '01' in case it uses the DDR mode. Afterwards when U-Boot or Linux try to access the flash in SDR mode, they fail as the TDH bits are still set. Resetting them to '00' solves the problem.

Unfortunately the TDH bits are not documented in the manual of the i.MX6UL/ULL, but they can be found in the manual of the i.MX7.

Quoted 8 lines
Quoted 5 lines

For the QSPI driver, this means it needs a fix to set/reset the TDH bits according to the mode that is used (DDR/SDR).

For more details please also look here:
https://community.nxp.com/thread/507260

Perfect. With these bits set to 00 again, booting from QSPI now works on the EVK. Many thanks for this hint! :)

I'm coming back to this issue, as we now have the new NXP patches integrated into mainline. Including this one:

Quoted 6 lines

7949576664ac "spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms" > I've now re-tested current mainline on the i.MX6ULL Eval Kit and QSPI does not work reliably. This is with CONFIG_SYS_FSL_QSPI_AHB enabled and disabled. How is QSPI supposed to work on i.MX6ULL/ULZ? Is any one of you running this current mainline driver successfully on one any i-MX6ULL/ULZ based board? If yes, what is your configuration here?

I don't have any experience with the current mainline SPI NOR driver.

Quoted 4 lines

BTW: Using the "spi-mem" driver version from Ashish with the fix suggested by Frieder to clear the DDR bit in TDH (reset to 00) still works without any problems.

There is some cleanup work that needs to be done (e.g. [1]). After that I will send an official patch for the spi-mem driver. Then Ashish and you can comment with your test results and change requests.

I have also sent a fix for the TDH bit for the Linux driver [2]. This is also applicable to the new U-Boot driver.

Regards,
Frieder

[1]: https://github.com/fschrempf/u-boot/commits/spi_flash_kconfig_cleanup
[2]: https://patchwork.kernel.org/patch/11176905/

#26 lore raw
Quoted 74 lines · Frieder Schrempf

Hi Stefan,

Quoted 63 lines · Stefan Roese

Hi Frieder,
Hi Ashish,
Hi Ye Li,
Hi Fabio,

Quoted 48 lines · Stefan Roese

Hi Frieder,

On 18.09.19 09:08, Schrempf Frieder wrote:

<snip>

Quoted 42 lines
Quoted 14 lines

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

Quoted 7 lines

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

I have a strong suspicion of what goes wrong in your case. We experienced exactly the same issue recently on i.MX6ULL. For some reasons (I guess differences in BootROM) this does not happen on i.MX6UL.

The problem is, that the BootROM sets the TDH bits in the QuadSPI_FLSHCR
register to '01' in case it uses the DDR mode. Afterwards when U-Boot or
Linux try to access the flash in SDR mode, they fail as the TDH bits are
still set. Resetting them to '00' solves the problem.

Unfortunately the TDH bits are not documented in the manual of the i.MX6UL/ULL, but they can be found in the manual of the i.MX7.

For the QSPI driver, this means it needs a fix to set/reset the TDH bits
according to the mode that is used (DDR/SDR).

Quoted 5 lines
Quoted 2 lines

For more details please also look here:
https://community.nxp.com/thread/507260

Perfect. With these bits set to 00 again, booting from QSPI now works on the EVK. Many thanks for this hint! :)

I'm coming back to this issue, as we now have the new NXP patches integrated into mainline. Including this one:

Quoted 7 lines

7949576664ac "spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms" >
I've now re-tested current mainline on the i.MX6ULL Eval Kit and QSPI does not work reliably. This is with CONFIG_SYS_FSL_QSPI_AHB enabled and disabled. How is QSPI supposed to work on i.MX6ULL/ULZ? Is any one of you running this current mainline driver successfully on one any i-MX6ULL/ULZ based board? If yes, what is your configuration here?

Quoted 1 line

I don't have any experience with the current mainline SPI NOR driver.

I had a look and the current mainline driver has 7949576664ac "spi:
fsl_qspi: Fix DDR mode setting for latest iMX platforms", but it still does not reset the TDH bits during init, in case the BootROM has left them set, which is the case when booting from QSPI on i.MX6ULL. Initially for detection the driver does not use DDR, so TDH must be cleared.

I have an older U-Boot 2017.03 that uses a backported version of the current mainline QSPI driver without DM. And it seems to work fine on i.MX6ULL with a 64MB SPI NOR, except for the issue described above.

Quoted 17 lines
Quoted 4 lines

BTW: Using the "spi-mem" driver version from Ashish with the fix suggested by Frieder to clear the DDR bit in TDH (reset to 00) still works without any problems.

There is some cleanup work that needs to be done (e.g. [1]). After that I will send an official patch for the spi-mem driver. Then Ashish and you can comment with your test results and change requests.

I have also sent a fix for the TDH bit for the Linux driver [2]. This is also applicable to the new U-Boot driver.

Regards,
Frieder

[1]: https://github.com/fschrempf/u-boot/commits/spi_flash_kconfig_cleanup
[2]: https://patchwork.kernel.org/patch/11176905/

#27 lore raw

Hi Frieder,

Quoted 75 lines · Schrempf Frieder
Quoted 74 lines · Frieder Schrempf

Hi Stefan,

Quoted 70 lines · Stefan Roese

Hi Frieder,
Hi Ashish,
Hi Ye Li,
Hi Fabio,

Quoted 48 lines · Stefan Roese

Hi Frieder,

On 18.09.19 09:08, Schrempf Frieder wrote:

<snip>

Quoted 42 lines
Quoted 14 lines

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

Quoted 7 lines

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

I have a strong suspicion of what goes wrong in your case. We experienced exactly the same issue recently on i.MX6ULL. For some reasons (I guess differences in BootROM) this does not happen on i.MX6UL.

The problem is, that the BootROM sets the TDH bits in the QuadSPI_FLSHCR
register to '01' in case it uses the DDR mode. Afterwards when U-Boot or
Linux try to access the flash in SDR mode, they fail as the TDH bits are
still set. Resetting them to '00' solves the problem.

Unfortunately the TDH bits are not documented in the manual of the i.MX6UL/ULL, but they can be found in the manual of the i.MX7.

For the QSPI driver, this means it needs a fix to set/reset the TDH bits
according to the mode that is used (DDR/SDR).

Quoted 5 lines
Quoted 2 lines

For more details please also look here:
https://community.nxp.com/thread/507260

Perfect. With these bits set to 00 again, booting from QSPI now works on the EVK. Many thanks for this hint! :)

I'm coming back to this issue, as we now have the new NXP patches integrated into mainline. Including this one:

7949576664ac "spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms" >
I've now re-tested current mainline on the i.MX6ULL Eval Kit and QSPI does not work reliably. This is with CONFIG_SYS_FSL_QSPI_AHB enabled and disabled. How is QSPI supposed to work on i.MX6ULL/ULZ? Is any one of you running this current mainline driver successfully on one any i-MX6ULL/ULZ based board? If yes, what is your configuration here?

Quoted 7 lines
Quoted 1 line

I don't have any experience with the current mainline SPI NOR driver.

I had a look and the current mainline driver has 7949576664ac "spi:
fsl_qspi: Fix DDR mode setting for latest iMX platforms", but it still does not reset the TDH bits during init, in case the BootROM has left them set, which is the case when booting from QSPI on i.MX6ULL. Initially for detection the driver does not use DDR, so TDH must be cleared.

I've already "played" with those DDR bits (TDH) in this register - without success so far.

Let's concentrate on the spi-mem driver instead.

Thanks,
Stefan

#28 lore raw
In reply to Schrempf Frieder

Hi Frieder,

Quoted 72 lines · Schrempf Frieder

Hi Stefan,

Quoted 59 lines · Stefan Roese

Hi Frieder,
Hi Ashish,
Hi Ye Li,
Hi Fabio,

Quoted 41 lines · Stefan Roese

Hi Frieder,

On 18.09.19 09:08, Schrempf Frieder wrote:

<snip>

Quoted 35 lines
Quoted 14 lines

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

Quoted 7 lines

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

I have a strong suspicion of what goes wrong in your case. We experienced exactly the same issue recently on i.MX6ULL. For some reasons (I guess differences in BootROM) this does not happen on i.MX6UL.

The problem is, that the BootROM sets the TDH bits in the QuadSPI_FLSHCR register to '01' in case it uses the DDR mode. Afterwards when U-Boot or Linux try to access the flash in SDR mode, they fail as the TDH bits are still set. Resetting them to '00' solves the problem.

Unfortunately the TDH bits are not documented in the manual of the i.MX6UL/ULL, but they can be found in the manual of the i.MX7.

Quoted 8 lines
Quoted 5 lines

For the QSPI driver, this means it needs a fix to set/reset the TDH bits according to the mode that is used (DDR/SDR).

For more details please also look here:
https://community.nxp.com/thread/507260

Perfect. With these bits set to 00 again, booting from QSPI now works on the EVK. Many thanks for this hint! :)

I'm coming back to this issue, as we now have the new NXP patches integrated into mainline. Including this one:

Quoted 6 lines

7949576664ac "spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms" > I've now re-tested current mainline on the i.MX6ULL Eval Kit and QSPI does not work reliably. This is with CONFIG_SYS_FSL_QSPI_AHB enabled and disabled. How is QSPI supposed to work on i.MX6ULL/ULZ? Is any one of you running this current mainline driver successfully on one any i-MX6ULL/ULZ based board? If yes, what is your configuration here?

I don't have any experience with the current mainline SPI NOR driver.

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

BTW: Using the "spi-mem" driver version from Ashish with the fix suggested by Frieder to clear the DDR bit in TDH (reset to 00) still works without any problems.

There is some cleanup work that needs to be done (e.g. [1]). After that I will send an official patch for the spi-mem driver. Then Ashish and you can comment with your test results and change requests.

Sounds like a good plan. Please keep me on Cc on any of these patches, so that I don't forget to review and test them. Thanks in advance.

Quoted 2 lines

I have also sent a fix for the TDH bit for the Linux driver [2]. This is also applicable to the new U-Boot driver.

Thanks.

Quoted 6 lines

Regards,
Frieder

[1]: https://github.com/fschrempf/u-boot/commits/spi_flash_kconfig_cleanup
[2]: https://patchwork.kernel.org/patch/11176905/

Thanks,
Stefan

#29 lore raw
Quoted 109 lines

-----Original Message-----
From: Stefan Roese <[email protected]>
Sent: Tuesday, October 22, 2019 9:12 PM
To: Schrempf Frieder <[email protected]>; Ashish Kumar <[email protected]>; Ye Li <[email protected]>;
jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Hi Frieder,

Quoted 47 lines · Schrempf Frieder

Hi Stefan,

Quoted 44 lines · Stefan Roese

Hi Frieder,
Hi Ashish,
Hi Ye Li,
Hi Fabio,

Quoted 38 lines · Stefan Roese

Hi Frieder,

On 18.09.19 09:08, Schrempf Frieder wrote:

<snip>

Quoted 32 lines
Quoted 15 lines

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR
flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

Quoted 7 lines

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

I have a strong suspicion of what goes wrong in your case. We experienced exactly the same issue recently on i.MX6ULL. For some reasons (I guess differences in BootROM) this does not happen on i.MX6UL.

The problem is, that the BootROM sets the TDH bits in the QuadSPI_FLSHCR register to '01' in case it uses the DDR mode. Afterwards when U-Boot or Linux try to access the flash in SDR mode, they fail as the TDH bits are still set. Resetting them to '00' solves

the problem.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

Unfortunately the TDH bits are not documented in the manual of the i.MX6UL/ULL, but they can be found in the manual of the i.MX7.

For the QSPI driver, this means it needs a fix to set/reset the TDH bits according to the mode that is used (DDR/SDR).

For more details please also look here:

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fc

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

ommunity.nxp.com%2Fthread%2F507260&amp;data=02%7C01%7Cashish.ku mar%

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

40nxp.com%7Cc03ee11b869c47c9a7d308d757065561%7C686ea1d3bc2b4c6fa 92c

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

d99c5c301635%7C0%7C0%7C637073557020848801&amp;sdata=ZvRU8vVPq0ll gIF

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

56nVugHjTQhM0E1GJ8PPl6P46vrg%3D&amp;reserved=0

Perfect. With these bits set to 00 again, booting from QSPI now works on the EVK. Many thanks for this hint! :)

Quoted 7 lines
Quoted 7 lines

I'm coming back to this issue, as we now have the new NXP patches integrated into mainline. Including this one:

7949576664ac "spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms" > I've now re-tested current mainline on the i.MX6ULL Eval Kit and QSPI does not work reliably. This is with CONFIG_SYS_FSL_QSPI_AHB enabled and disabled. How is QSPI

supposed to

Quoted 2 lines
Quoted 2 lines

work on i.MX6ULL/ULZ? Is any one of you running this current mainline driver successfully on one any i-MX6ULL/ULZ based board? If yes, what is

your configuration here?

Quoted 8 lines

I don't have any experience with the current mainline SPI NOR driver.

Quoted 4 lines

BTW: Using the "spi-mem" driver version from Ashish with the fix suggested by Frieder to clear the DDR bit in TDH (reset to 00) still works without any problems.

Quoted 6 lines
Quoted 3 lines

There is some cleanup work that needs to be done (e.g. [1]). After that I will send an official patch for the spi-mem driver. Then Ashish and you can comment with your test results and change requests.

Sounds like a good plan. Please keep me on Cc on any of these patches, so that I don't forget to review and test them. Thanks in advance.

Hi Frieder,

I see one issue with current SPI-MEM driver getting ported in u-boot, that is: access via md command is not working, in order words direct access to flash memory is no more possible, which was previously possible. Such access is helpful to access memory directly and make user experience similar to parallel NOR.

To fix this I had tried these possible changes in driver, change this to q->devtype_data->ahb_buf_size to flash size rather than AHB buffer size.

In function

fsl_qspi_default_setup() {
	/*
	 * In HW there can be a maximum of four chips on two buses with
	 * two chip selects on each bus. We use four chip selects in SW
	 * to differentiate between the four chips.
	 * We use ahb_buf_size for each chip and set SFA1AD, SFA2AD, SFB1AD,
	 * SFB2AD accordingly.
	 */
	qspi_writel(q, q->devtype_data->ahb_buf_size + addr_offset,
		    base + QUADSPI_SFA1AD);
	qspi_writel(q, q->devtype_data->ahb_buf_size * 2 + addr_offset,
		    base + QUADSPI_SFA2AD);
	qspi_writel(q, q->devtype_data->ahb_buf_size * 3 + addr_offset,
		    base + QUADSPI_SFB1AD);
	qspi_writel(q, q->devtype_data->ahb_buf_size * 4 + addr_offset, 	
		    base + QUADSPI_SFB2AD);	
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
In function fsl_qspi_exec_op() {
		qspi_writel(q, QUADSPI_RBCT_WMRK_MASK |
			    QUADSPI_RBCT_RXBRD_USEIPS, base + QUADSPI_RBCT);

		if (op->data.nbytes && op->data.dir == SPI_MEM_DATA_OUT)
			fsl_qspi_fill_txfifo(q, op);

		err = fsl_qspi_do_op(q, op);

added this line : spi_writel(q, op->data.nbytes | QUADSPI_IPCR_SEQID(0), base + QUADSPI_IPCR);

And set seq_id to 0, Which was initially set by BootROM, after this md works correctly but, sf read is only able to read max data size of rxfifo.

Could you please suggest what other thing I am missing to get access via md command.

I will post the delta changes via mail or github[1] tomorrow morning.

[1]: https://github.com/erashish007/u-boot-spi-mem/blob/a516f41f17acb1ff9be6d34f54644605c666128c/drivers/spi/fsl_qspi.c
Regards
Ashish

Quoted 38 lines
Quoted 2 lines

I have also sent a fix for the TDH bit for the Linux driver [2]. This is also applicable to the new U-Boot driver.

Thanks.

Quoted 6 lines

Regards,
Frieder

[1]:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.com%2Ffschrempf%2Fu-

boot%2Fcommits%2Fspi_flash_kconfig_cleanup&amp;

Quoted 1 line

data=02%7C01%7Cashish.kumar%40nxp.com%7Cc03ee11b869c47c9a7d308d7 570655

Quoted 1 line

61%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370735570208488 01&amp

Quoted 1 line

;sdata=VvxGQquY5n9fysZueDsbj0f3Jc%2Bo6b0TelevDt0M7cI%3D&amp;rese rved=0

Quoted 2 lines

[2]:

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc

Quoted 1 line

hwork.kernel.org%2Fpatch%2F11176905%2F&amp;data=02%7C01%7Cashish. kumar

Quoted 1 line

%40nxp.com%7Cc03ee11b869c47c9a7d308d757065561%7C686ea1d3bc2b4c6f a92cd9

Quoted 1 line

9c5c301635%7C0%7C0%7C637073557020848801&amp;sdata=KSz2A%2B0ssK% 2B7OR6M

Quoted 2 lines

zQtyZdNAX7C4yU%2Fhl5xDLYWSenU%3D&amp;reserved=0

Thanks,
Stefan

#30 lore raw

Hi Ashish,

Quoted 113 lines · Ashish Kumar
Quoted 113 lines

-----Original Message-----
From: Stefan Roese <[email protected]>
Sent: Tuesday, October 22, 2019 9:12 PM
To: Schrempf Frieder <[email protected]>; Ashish Kumar <[email protected]>; Ye Li <[email protected]>;
jagan at amarulasolutions.com
Cc: Fabio Estevam <[email protected]>; u-boot at lists.denx.de; dl- uboot-imx <[email protected]>
Subject: Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

Caution: EXT Email

Hi Frieder,

Quoted 47 lines · Schrempf Frieder

Hi Stefan,

Quoted 44 lines · Stefan Roese

Hi Frieder,
Hi Ashish,
Hi Ye Li,
Hi Fabio,

Quoted 38 lines · Stefan Roese

Hi Frieder,

On 18.09.19 09:08, Schrempf Frieder wrote:

<snip>

Quoted 32 lines
Quoted 15 lines

One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR
flash:

=> sf probe
unrecognized JEDEC id bytes: ff, ff, ff

Do you have any idea what might explain this difference. I would have expected that when booting via QSPI it would be "easier" for the driver, as the BootROM already initializes the QSPI interface. Which is not the case in the boot via serial download (imx_usb) mode. Here everyhting (pinmux, clocks, etc) need to be configured.

Quoted 7 lines

My feeling is that something is configured "incorrectly" by the BootROM in this case which is not re-configured as the QSPI driver needs it to be currently.

Do you have any ideas on what might be the problem here? Is there something that I can do to help test this? Would it help if I would send the debug logging of the driver?

I have a strong suspicion of what goes wrong in your case. We experienced exactly the same issue recently on i.MX6ULL. For some reasons (I guess differences in BootROM) this does not happen on i.MX6UL.

The problem is, that the BootROM sets the TDH bits in the QuadSPI_FLSHCR register to '01' in case it uses the DDR mode. Afterwards when U-Boot or Linux try to access the flash in SDR mode, they fail as the TDH bits are still set. Resetting them to '00' solves

the problem.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

Unfortunately the TDH bits are not documented in the manual of the i.MX6UL/ULL, but they can be found in the manual of the i.MX7.

For the QSPI driver, this means it needs a fix to set/reset the TDH bits according to the mode that is used (DDR/SDR).

For more details please also look here:

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fc

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

ommunity.nxp.com%2Fthread%2F507260&amp;data=02%7C01%7Cashish.ku mar%

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

40nxp.com%7Cc03ee11b869c47c9a7d308d757065561%7C686ea1d3bc2b4c6fa 92c

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

d99c5c301635%7C0%7C0%7C637073557020848801&amp;sdata=ZvRU8vVPq0ll gIF

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

56nVugHjTQhM0E1GJ8PPl6P46vrg%3D&amp;reserved=0

Perfect. With these bits set to 00 again, booting from QSPI now works on the EVK. Many thanks for this hint! :)

Quoted 7 lines
Quoted 7 lines

I'm coming back to this issue, as we now have the new NXP patches integrated into mainline. Including this one:

7949576664ac "spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms" > I've now re-tested current mainline on the i.MX6ULL Eval Kit and QSPI does not work reliably. This is with CONFIG_SYS_FSL_QSPI_AHB enabled and disabled. How is QSPI

supposed to

Quoted 2 lines
Quoted 2 lines

work on i.MX6ULL/ULZ? Is any one of you running this current mainline driver successfully on one any i-MX6ULL/ULZ based board? If yes, what is

your configuration here?

Quoted 11 lines

I don't have any experience with the current mainline SPI NOR driver.

Quoted 4 lines

BTW: Using the "spi-mem" driver version from Ashish with the fix suggested by Frieder to clear the DDR bit in TDH (reset to 00) still works without any problems.

There is some cleanup work that needs to be done (e.g. [1]). After that I will send an official patch for the spi-mem driver. Then Ashish and you can comment with your test results and change requests.

Quoted 6 lines
Quoted 2 lines

Sounds like a good plan. Please keep me on Cc on any of these patches, so that I don't forget to review and test them. Thanks in advance.

Hi Frieder,

I see one issue with current SPI-MEM driver getting ported in u-boot, that is: access via md command is not working, in order words direct access to flash memory is no more possible, which was previously possible. Such access is helpful to access memory directly and make user experience similar to parallel NOR.

Yes, direct memory-mapped access to the whole flash is not possible with this driver. Though I don't see any good reason why someone wants to do this, when there's a SPI NOR and MTD layer to abstract the flash and handle access to it. You can still use sf and/or mtd commands to read/write data between flash and RAM.

Quoted 2 lines

To fix this I had tried these possible changes in driver, change this to q->devtype_data->ahb_buf_size to flash size rather than AHB buffer size.

This is not a good idea. The driver is not designed to do this. In the upstream Linux SPI MEM layer, we have a implementation for a direct mapping API, that allows the SPI MEM layer to create memory mappings for SPI NOR devices. If needed this could be ported to U-Boot, but IMHO it should be avoided.

Quoted 29 lines

In function

fsl_qspi_default_setup() {
	/*
	 * In HW there can be a maximum of four chips on two buses with
	 * two chip selects on each bus. We use four chip selects in SW
	 * to differentiate between the four chips.
	 * We use ahb_buf_size for each chip and set SFA1AD, SFA2AD, SFB1AD,
	 * SFB2AD accordingly.
	 */
	qspi_writel(q, q->devtype_data->ahb_buf_size + addr_offset,
		    base + QUADSPI_SFA1AD);
	qspi_writel(q, q->devtype_data->ahb_buf_size * 2 + addr_offset,
		    base + QUADSPI_SFA2AD);
	qspi_writel(q, q->devtype_data->ahb_buf_size * 3 + addr_offset,
		    base + QUADSPI_SFB1AD);
	qspi_writel(q, q->devtype_data->ahb_buf_size * 4 + addr_offset, 	
		    base + QUADSPI_SFB2AD);	
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
In function fsl_qspi_exec_op() {
		qspi_writel(q, QUADSPI_RBCT_WMRK_MASK |
			    QUADSPI_RBCT_RXBRD_USEIPS, base + QUADSPI_RBCT);

		if (op->data.nbytes && op->data.dir == SPI_MEM_DATA_OUT)
			fsl_qspi_fill_txfifo(q, op);

		err = fsl_qspi_do_op(q, op);
Quoted 5 lines

added this line : spi_writel(q, op->data.nbytes | QUADSPI_IPCR_SEQID(0), base + QUADSPI_IPCR);

And set seq_id to 0, Which was initially set by BootROM, after this md works correctly but, sf read is only able to read max data size of rxfifo.

Could you please suggest what other thing I am missing to get access via md command.

Sorry no, because as already mentioned, this driver and the SPI MEM layer is not supposed to work like this. At least not without the direct mapping API ([1]).

Regards,
Frieder

[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=aa167f3fed0c37e0e4c707d4331d827661f46644

#31 lore raw

On 23.10.19 12:34, Schrempf Frieder wrote:

<snip>

Quoted 13 lines
Quoted 13 lines
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines

BTW: Using the "spi-mem" driver version from Ashish with the fix suggested by Frieder to clear the DDR bit in TDH (reset to 00) still works without any problems.

There is some cleanup work that needs to be done (e.g. [1]). After that I will send an official patch for the spi-mem driver. Then Ashish and you can comment with your test results and change requests.

Sounds like a good plan. Please keep me on Cc on any of these patches, so that I don't forget to review and test them. Thanks in advance.

Hi Frieder,

Quoted 7 lines
Quoted 1 line

I see one issue with current SPI-MEM driver getting ported in u-boot, that is: access via md command is not working, in order words direct access to flash memory is no more possible, which was previously possible. Such access is helpful to access memory directly and make user experience similar to parallel NOR.

Yes, direct memory-mapped access to the whole flash is not possible with this driver. Though I don't see any good reason why someone wants to do this, when there's a SPI NOR and MTD layer to abstract the flash and handle access to it. You can still use sf and/or mtd commands to read/write data between flash and RAM.

I agree with Frieder that we don't need this direct memory access via "md/mm/etc" in U-Boot. Access via the "normal" sf and/or mtd commands should be enough for SPI NOR.

Thanks,
Stefan

author
#32 lore raw
In reply to Schrempf Frieder

Hi Frieder,

Quoted 10 lines

Caution: EXT Email

Hi Ye,

Quoted 4 lines · Ye Li

On latest iMX platforms like iMX7D/iMX6UL/iMX8MQ, the QSPI controller is updated to have TDH field in FLSHCR register. According to reference manual, this TDH must be set to 1 when DDR_EN is set. Otherwise, the TX DDR delay logic won't be enabled.

Quoted 4 lines

This is actually an issue I have experienced myself. But in our case this behavior only happened on i.MX6ULL not on i.MX6UL. Either the QSPI controller hardware or the BootROM code changed when moving from UL to ULL. For details see: [1].

iMX6ULL has same QSPI controller revision with 6UL. I just checked their ROM codes, the TDH will be set if the DDR mode is enabled in QSPI configuration parameters. It won't be cleared by ROM.

Have you compared other registers like LUT and MCR DDR_EN? Is the MCR DDR_EN set When the TDH is cleared?

Quoted 7 lines
Quoted 6 lines

Another issue in DDR mode is the MCR register will be overwritten in every read/write/erase operation. This causes DDR_EN been cleared while TDH=1, then no clk2x output for TX data shift and all operations will fail.

Quoted 7 lines

The best way to fix all of these things (also the ones in the other patches) would be to fix them in Linux and port the driver from Linux to U-Boot. Actually I've already done most of the porting [2], but didn't have the time to finish it recently. It probably needs some rebasing and testing.

Could you port your fixes to the Linux driver and submit them to linux-mtd?

Our downstream kernel has fixed the issue, it is similar as this u-boot fix. TDH must be set along with DDR_EN. I'm not this kernel driver owner, I will check with him about the upstream of this fix.

Best regards,
Ye Li

Quoted 114 lines

Thanks
Frieder

[1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcommunity.nxp.com%2Fthread%2F507260&amp;data=02%7C01%7Cye.li%40nxp.com%7Cc0caf3432e8e4a136b5208d720abd020%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637013794616656270&amp;sdata=hcyPpSlxU59NVtsHQdnGksMcu%2BQ8DzOJJJ2lnUGd7uQ%3D&amp;reserved=0
[2] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffschrempf%2Fu-boot%2Fcommits%2Ffsl_qspi_spimem_port&amp;data=02%7C01%7Cye.li%40nxp.com%7Cc0caf3432e8e4a136b5208d720abd020%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637013794616656270&amp;sdata=eqj4L2daAfOMA6oGbmPCPWHuy%2B6NbizQihJ0QeAcIxY%3D&amp;reserved=0

Quoted 106 lines
---
  drivers/spi/fsl_qspi.c | 30 ++++++++++++++++--------------
  1 file changed, 16 insertions(+), 14 deletions(-)
drivers/spi/fsl_qspi.c +16 -14
index 41abe19..8845986 100644
@@ -399,7 +399,7 @@ static inline void qspi_ahb_read(struct fsl_qspi_priv *priv, u8 *rxbuf, int len)
 
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
 
      rx_addr = (void *)(uintptr_t)(priv->cur_amba_base + priv->sf_addr);
      /* Read out the data directly from the AHB buffer. */
@@ -429,6 +429,14 @@ static void qspi_enable_ddr_mode(struct fsl_qspi_priv *priv)
      reg |= BIT(29);
 
      qspi_write32(priv->flags, &regs->mcr, reg);
+
+     /* Enable the TDH to 1 for some platforms like imx6ul, imx7d, etc
+      * These two bits are reserved on other platforms
+      */
+     reg = qspi_read32(priv->flags, &regs->flshcr);
+     reg &= ~(BIT(17));
+     reg |= BIT(16);
+     qspi_write32(priv->flags, &regs->flshcr, reg);
  }
 
  /*
@@ -482,7 +490,7 @@ static void qspi_op_rdbank(struct fsl_qspi_priv *priv, u8 *rxbuf, u32 len)
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -527,7 +535,7 @@ static void qspi_op_rdid(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -573,7 +581,7 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32 *rxbuf, u32 len)
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      to_or_from = priv->sf_addr + priv->cur_amba_base;
@@ -625,7 +633,7 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 *txbuf, u32 len)
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      status_reg = 0;
@@ -700,7 +708,7 @@ static void qspi_op_rdsr(struct fsl_qspi_priv *priv, void *rxbuf, u32 len)
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      qspi_write32(priv->flags, &regs->sfar, priv->cur_amba_base);
@@ -737,7 +745,7 @@ static void qspi_op_erase(struct fsl_qspi_priv *priv)
      mcr_reg = qspi_read32(priv->flags, &regs->mcr);
      qspi_write32(priv->flags, &regs->mcr,
                   QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK |
-                  QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE);
+                  mcr_reg);
      qspi_write32(priv->flags, &regs->rbct, QSPI_RBCT_RXBRD_USEIPS);
 
      to_or_from = priv->sf_addr + priv->cur_amba_base;
@@ -900,15 +908,9 @@ static int fsl_qspi_probe(struct udevice *bus)
              return ret;
      }
 
-     mcr_val = qspi_read32(priv->flags, &priv->regs->mcr);
-
-     /* Set endianness to LE for i.mx */
-     if (IS_ENABLED(CONFIG_MX6) || IS_ENABLED(CONFIG_MX7))
-             mcr_val = QSPI_MCR_END_CFD_LE;
-
      qspi_write32(priv->flags, &priv->regs->mcr,
                   QSPI_MCR_RESERVED_MASK | QSPI_MCR_MDIS_MASK |
-                  (mcr_val & QSPI_MCR_END_CFD_MASK));
+                  QSPI_MCR_END_CFD_LE);
 
      qspi_cfg_smpr(priv, ~(QSPI_SMPR_FSDLY_MASK | QSPI_SMPR_DDRSMP_MASK |
              QSPI_SMPR_FSPHS_MASK | QSPI_SMPR_HSENA_MASK), 0);